From 03d003b625deec05306070c5e445f88f68731be6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=BCnter?= Date: Wed, 25 Oct 2017 20:18:24 +0000 Subject: [PATCH] Extract validation into separat method --- src/zabapgit_popups.prog.abap | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/zabapgit_popups.prog.abap b/src/zabapgit_popups.prog.abap index 98b2a54d6..893c71ed0 100644 --- a/src/zabapgit_popups.prog.abap +++ b/src/zabapgit_popups.prog.abap @@ -127,7 +127,12 @@ CLASS lcl_popups DEFINITION FINAL. EXPORTING ev_url TYPE abaptxt255-line ev_package TYPE tdevc-devclass - ev_branch TYPE textl-line. + ev_branch TYPE textl-line, + + validate + IMPORTING + iv_package TYPE tdevc-devclass + iv_url TYPE abaptxt255-line. ENDCLASS. @@ -597,10 +602,8 @@ CLASS lcl_popups IMPLEMENTATION. lv_finished = abap_true. TRY. - - " validate - lcl_url=>name( |{ lv_url }| ). - lcl_app=>repo_srv( )->validate_package( lv_package ). + validate( iv_url = lv_url + iv_package = lv_package ). CATCH zcx_abapgit_exception INTO lx_error. MESSAGE lx_error->text TYPE 'S' DISPLAY LIKE 'E'. @@ -1036,4 +1039,9 @@ CLASS lcl_popups IMPLEMENTATION. ENDMETHOD. + + METHOD validate. + + ENDMETHOD. + ENDCLASS.