SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactor: Calling batch input (#5252)

Browse Source 
* Refactor: Calling batch input

Standardizes calling batch input API and handling errors.

* Fix indent

* Add new window

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2022-01-10 09:27:17 +01:00 committed by GitHub
parent a655480d77
commit 074ae5a69b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
24 changed files with 121 additions and 295 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/objects/core/zcl_abapgit_gui_jumper.clas.abap
View File

@ -179,4 +179,42 @@ CLASS zcl_abapgit_gui_jumper IMPLEMENTATION.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_gui_jumper~jump_batch_input.
DATA lv_msg TYPE c LENGTH 80.
IF iv_new_window = abap_true.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = iv_tcode
mode_val = 'E'
TABLES
using_tab = it_bdcdata
EXCEPTIONS
system_failure = 1 MESSAGE lv_msg
communication_failure = 2 MESSAGE lv_msg
resource_failure = 3
OTHERS = 4.
ELSE.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
EXPORTING
tcode = iv_tcode
mode_val = 'E'
TABLES
using_tab = it_bdcdata
EXCEPTIONS
OTHERS = 4.
ENDIF.
CASE sy-subrc.
WHEN 1 OR 2.
zcx_abapgit_exception=>raise( |Batch input error for transaction { iv_tcode }: { lv_msg }| ).
WHEN 3 OR 4.
zcx_abapgit_exception=>raise( |Batch input error for transaction { iv_tcode }| ).
ENDCASE.
ENDMETHOD.
ENDCLASS.

19
src/objects/zcl_abapgit_object_chdo.clas.abap
View File

@ -339,22 +339,9 @@ CLASS zcl_abapgit_object_chdo IMPLEMENTATION.
ls_bdcdata-fval = '=DISP'.
APPEND ls_bdcdata TO lt_bdcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SCDO'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
system_failure = 1
communication_failure = 2
resource_failure = 3
OTHERS = 4.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |ERROR: Jump { mv_object }| ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SCDO'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

17
src/objects/zcl_abapgit_object_cus1.clas.abap
View File

@ -177,19 +177,10 @@ CLASS zcl_abapgit_object_cus1 IMPLEMENTATION.
<ls_bdc_data>-fnam = 'BDC_OKCODE'.
<ls_bdc_data>-fval = '=ACT_DISP'.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
EXPORTING
tcode = 'S_CUS_ACTIVITY'
mode_val = 'E'
TABLES
using_tab = lt_bdc_data
EXCEPTIONS
call_transaction_denied = 1
tcode_invalid = 2
OTHERS = 3.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error from JUMP CUS1: { sy-subrc }| ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'S_CUS_ACTIVITY'
it_bdcdata = lt_bdc_data ).
ENDMETHOD.

18
src/objects/zcl_abapgit_object_dial.clas.abap
View File

@ -20,7 +20,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECT_DIAL IMPLEMENTATION.
CLASS zcl_abapgit_object_dial IMPLEMENTATION.
METHOD zif_abapgit_object~changed_by.
@ -76,18 +76,10 @@ CLASS ZCL_ABAPGIT_OBJECT_DIAL IMPLEMENTATION.
ls_bcdata-fval = '=BACK'.
APPEND ls_bcdata TO lt_bcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
EXPORTING
tcode = 'SE35'
mode_val = 'E'
TABLES
using_tab = lt_bcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, SE35' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SE35'
it_bdcdata = lt_bcdata
iv_new_window = abap_false ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_doct.clas.abap
View File

@ -140,19 +140,9 @@ CLASS zcl_abapgit_object_doct IMPLEMENTATION.
ls_bcdata-fval = '=SHOW'.
APPEND ls_bcdata TO lt_bcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SE61'
mode_val = 'E'
TABLES
using_tab = lt_bcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, DOCT' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SE61'
it_bdcdata = lt_bcdata ).
ENDMETHOD.

13
src/objects/zcl_abapgit_object_form.clas.abap
View File

@ -383,16 +383,9 @@ CLASS zcl_abapgit_object_form IMPLEMENTATION.
<ls_bdcdata>-fnam = 'RSSCF-TDFORM'.
<ls_bdcdata>-fval = ms_item-obj_name.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SE71'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
OTHERS = 1
##fm_subrc_ok. "#EC CI_SUBRC
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SE71'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

18
src/objects/zcl_abapgit_object_idoc.clas.abap
View File

@ -28,7 +28,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECT_IDOC IMPLEMENTATION.
CLASS zcl_abapgit_object_idoc IMPLEMENTATION.
METHOD clear_idoc_segement_field.
@ -213,19 +213,9 @@ CLASS ZCL_ABAPGIT_OBJECT_IDOC IMPLEMENTATION.
<ls_bdcdata>-fnam = 'BDC_OKCODE'.
<ls_bdcdata>-fval = '=DISP'.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'WE30'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'WE30'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_iext.clas.abap
View File

@ -168,19 +168,9 @@ CLASS zcl_abapgit_object_iext IMPLEMENTATION.
<ls_bdcdata>-fnam = 'BDC_OKCODE'.
<ls_bdcdata>-fval = '=DISP'.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'WE30'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'WE30'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

18
src/objects/zcl_abapgit_object_iwmo.clas.abap
View File

@ -111,21 +111,9 @@ CLASS zcl_abapgit_object_iwmo IMPLEMENTATION.
<ls_bdcdata>-fnam = 'GS_MODEL_SCREEN_100-VERSION'.
<ls_bdcdata>-fval = lv_version.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = '/IWBEP/REG_MODEL'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
call_transaction_denied = 1
tcode_invalid = 2
OTHERS = 3.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error from ABAP4_CALL_TRANSACTION. Subrc={ sy-subrc }| ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = '/IWBEP/REG_MODEL'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

18
src/objects/zcl_abapgit_object_iwsv.clas.abap
View File

@ -111,21 +111,9 @@ CLASS zcl_abapgit_object_iwsv IMPLEMENTATION.
<ls_bdcdata>-fnam = 'GS_SCREEN_100-VERSION'.
<ls_bdcdata>-fval = lv_version.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = '/IWBEP/REG_SERVICE'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
call_transaction_denied = 1
tcode_invalid = 2
OTHERS = 3.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error from ABAP4_CALL_TRANSACTION. Subrc={ sy-subrc }| ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = '/IWBEP/REG_SERVICE'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_nrob.clas.abap
View File

@ -248,19 +248,9 @@ CLASS zcl_abapgit_object_nrob IMPLEMENTATION.
ls_bcdata-fval = '=DISP'.
APPEND ls_bcdata TO lt_bcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SNRO'
mode_val = 'E'
TABLES
using_tab = lt_bcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, NROB' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SNRO'
it_bdcdata = lt_bcdata ).
ENDMETHOD.

18
src/objects/zcl_abapgit_object_pers.clas.abap
View File

@ -194,21 +194,9 @@ CLASS zcl_abapgit_object_pers IMPLEMENTATION.
ls_bcdata-fval = '=PERSDISPLAY'.
APPEND ls_bcdata TO lt_bcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'PERSREG'
mode_val = 'E'
TABLES
using_tab = lt_bcdata
EXCEPTIONS
call_transaction_denied = 1
tcode_invalid = 2
OTHERS = 3.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |error from ABAP4_CALL_TRANSACTION, PERSREG. SUBRC= { sy-subrc }| ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'PERSREG'
it_bdcdata = lt_bcdata ).
ENDMETHOD.

19
src/objects/zcl_abapgit_object_shi3.clas.abap
View File

@ -158,22 +158,9 @@ CLASS zcl_abapgit_object_shi3 IMPLEMENTATION.
<ls_bdcdata>-fnam = 'BMENUNAME-ID'.
<ls_bdcdata>-fval = ms_item-obj_name.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SE43'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
system_failure = 1
communication_failure = 2
resource_failure = 3
OTHERS = 4.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, SHI3' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SE43'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_shma.clas.abap
View File

@ -246,19 +246,9 @@ CLASS zcl_abapgit_object_shma IMPLEMENTATION.
ls_bcdata-fval = '=SHOW'.
APPEND ls_bcdata TO lt_bcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SHMA'
mode_val = 'E'
TABLES
using_tab = lt_bcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, SHMA' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SHMA'
it_bdcdata = lt_bcdata ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_sicf.clas.abap
View File

@ -552,19 +552,9 @@ CLASS zcl_abapgit_object_sicf IMPLEMENTATION.
ls_bcdata-fval = '=ONLI'.
APPEND ls_bcdata TO lt_bcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SICF'
mode_val = 'E'
TABLES
using_tab = lt_bcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, SICF' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SICF'
it_bdcdata = lt_bcdata ).
ENDMETHOD.

13
src/objects/zcl_abapgit_object_ssfo.clas.abap
View File

@ -386,16 +386,9 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION.
<ls_bdcdata>-fnam = 'BDC_OKCODE'.
<ls_bdcdata>-fval = '=DISPLAY'.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SMARTFORMS'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
OTHERS = 1
##fm_subrc_ok. "#EC CI_SUBRC
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SMARTFORMS'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_ssst.clas.abap
View File

@ -200,19 +200,9 @@ CLASS zcl_abapgit_object_ssst IMPLEMENTATION.
ls_bcdata-fval = '=DISPLAY'.
APPEND ls_bcdata TO lt_bcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SMARTSTYLES'
mode_val = 'E'
TABLES
using_tab = lt_bcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, SSST' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SMARTSTYLES'
it_bdcdata = lt_bcdata ).
ENDMETHOD.

18
src/objects/zcl_abapgit_object_styl.clas.abap
View File

@ -17,7 +17,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECT_STYL IMPLEMENTATION.
CLASS zcl_abapgit_object_styl IMPLEMENTATION.
METHOD zif_abapgit_object~changed_by.
@ -159,19 +159,9 @@ CLASS ZCL_ABAPGIT_OBJECT_STYL IMPLEMENTATION.
ls_bcdata-fval = '=SHOW'.
APPEND ls_bcdata TO lt_bcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SE72'
mode_val = 'E'
TABLES
using_tab = lt_bcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, STYL' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SE72'
it_bdcdata = lt_bcdata ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_tran.clas.abap
View File

@ -834,19 +834,9 @@ CLASS zcl_abapgit_object_tran IMPLEMENTATION.
<ls_bdcdata>-fnam = 'TSTC-TCODE'.
<ls_bdcdata>-fval = ms_item-obj_name.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SE93'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
system_failure = 1
communication_failure = 2
resource_failure = 3
OTHERS = 4
##fm_subrc_ok. "#EC CI_SUBRC
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SE93'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

18
src/objects/zcl_abapgit_object_udmo.clas.abap
View File

@ -96,7 +96,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECT_UDMO IMPLEMENTATION.
CLASS zcl_abapgit_object_udmo IMPLEMENTATION.
METHOD access_free.
@ -734,19 +734,9 @@ CLASS ZCL_ABAPGIT_OBJECT_UDMO IMPLEMENTATION.
<ls_bdcdata>-fnam = 'RSUD3-OBJ_KEY'.
<ls_bdcdata>-fval = ms_item-obj_name.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SD11'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
system_failure = 1
communication_failure = 2
resource_failure = 3
OTHERS = 4
##fm_subrc_ok. "#EC CI_SUBRC
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SD11'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_ueno.clas.abap
View File

@ -614,19 +614,9 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
<ls_bdcdata>-fnam = 'RSUD3-OBJ_KEY'.
<ls_bdcdata>-fval = ms_item-obj_name.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SD11'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
system_failure = 1
communication_failure = 2
resource_failure = 3
OTHERS = 4
##fm_subrc_ok. "#EC CI_SUBRC
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SD11'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_vcls.clas.abap
View File

@ -246,19 +246,9 @@ CLASS zcl_abapgit_object_vcls IMPLEMENTATION.
ls_bcdata-fval = '=CLSH'.
APPEND ls_bcdata TO lt_bcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SE54'
mode_val = 'E'
TABLES
using_tab = lt_bcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, SE35' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SE54'
it_bdcdata = lt_bcdata ).
ENDMETHOD.

16
src/objects/zcl_abapgit_object_w3xx_super.clas.abap
View File

@ -417,19 +417,9 @@ CLASS zcl_abapgit_object_w3xx_super IMPLEMENTATION.
ls_bdcdata-fval = '=ONLI'.
APPEND ls_bdcdata TO lt_bdcdata.
CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
STARTING NEW TASK 'GIT'
EXPORTING
tcode = 'SMW0'
mode_val = 'E'
TABLES
using_tab = lt_bdcdata
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from ABAP4_CALL_TRANSACTION, SE35' ).
ENDIF.
zcl_abapgit_ui_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'SMW0'
it_bdcdata = lt_bdcdata ).
ENDMETHOD.

11
src/ui/zif_abapgit_gui_jumper.intf.abap
View File

@ -1,6 +1,9 @@
INTERFACE zif_abapgit_gui_jumper
PUBLIC.
TYPES:
ty_bdcdata_tt TYPE STANDARD TABLE OF bdcdata WITH DEFAULT KEY.
METHODS jump
IMPORTING
!is_item TYPE zif_abapgit_definitions=>ty_item
@ -23,4 +26,12 @@ INTERFACE zif_abapgit_gui_jumper
RAISING
zcx_abapgit_exception.
METHODS jump_batch_input
IMPORTING
!iv_tcode TYPE sy-tcode
!it_bdcdata TYPE ty_bdcdata_tt
!iv_new_window TYPE abap_bool DEFAULT abap_true
RAISING
zcx_abapgit_exception.
ENDINTERFACE.