From 07c87edd03beb035035606c4bc8ab4c25bd024f9 Mon Sep 17 00:00:00 2001
From: g-back <27279305+g-back@users.noreply.github.com>
Date: Wed, 11 Mar 2020 11:42:15 +0100
Subject: [PATCH] PINF: Exporting to Returning Parameter (#3252)

* change exporting to returning parameter

* enable prefer_returning_to_exporting
---
 abaplint.json                                       |  2 +-
 src/objects/zcl_abapgit_object_pinf.clas.abap       | 12 ++++++------
 .../zcl_abapgit_object_pinf.clas.locals_def.abap    | 13 +++++++------
 .../zcl_abapgit_object_pinf.clas.locals_imp.abap    |  6 +++---
 4 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/abaplint.json b/abaplint.json
index 4904725cb..90d0c3f87 100644
--- a/abaplint.json
+++ b/abaplint.json
@@ -63,7 +63,7 @@
     "check_comments": false,
     "fully_type_constants": true,
     "keep_single_parameter_on_one_line": true,
-    "prefer_returning_to_exporting": false,
+    "prefer_returning_to_exporting": true,
     "selection_screen_naming": true,
     "sicf_consistency": true,
     "sql_escape_host_variables": true,
diff --git a/src/objects/zcl_abapgit_object_pinf.clas.abap b/src/objects/zcl_abapgit_object_pinf.clas.abap
index 50ae4183c..1a7604f3d 100644
--- a/src/objects/zcl_abapgit_object_pinf.clas.abap
+++ b/src/objects/zcl_abapgit_object_pinf.clas.abap
@@ -55,7 +55,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_OBJECT_PINF IMPLEMENTATION.
+CLASS zcl_abapgit_object_pinf IMPLEMENTATION.
 
 
   METHOD create_facade.
@@ -108,7 +108,7 @@ CLASS ZCL_ABAPGIT_OBJECT_PINF IMPLEMENTATION.
 
     ii_interface->set_elements_changeable( abap_true ).
 
-    ii_interface->get_elements( IMPORTING et_elements = lt_elements ).
+    lt_elements = ii_interface->get_elements( ).
 
     LOOP AT lt_elements ASSIGNING <li_element>.
       <li_element>->delete( ).
@@ -141,7 +141,7 @@ CLASS ZCL_ABAPGIT_OBJECT_PINF IMPLEMENTATION.
           lv_changeable TYPE abap_bool.
 
 
-    ii_interface->get_changeable( IMPORTING ev_changeable = lv_changeable ).
+    lv_changeable = ii_interface->get_changeable( ).
     IF lv_changeable = abap_false.
 * at creation the object is already in change mode
       ii_interface->set_changeable( abap_true ).
@@ -183,7 +183,7 @@ CLASS ZCL_ABAPGIT_OBJECT_PINF IMPLEMENTATION.
 
     ii_interface->set_elements_changeable( abap_true ).
 
-    ii_interface->get_elements( IMPORTING et_elements = lt_existing ).
+    lt_existing = ii_interface->get_elements( ).
 
     LOOP AT is_pinf-elements ASSIGNING <ls_element>.
 
@@ -345,7 +345,7 @@ CLASS ZCL_ABAPGIT_OBJECT_PINF IMPLEMENTATION.
 
     li_interface = load( |{ ms_item-obj_name }| ).
 
-    li_interface->get_all_attributes( IMPORTING es_package_interface_data = ls_pinf-attributes ).
+    ls_pinf-attributes = li_interface->get_all_attributes( ).
 
     CLEAR: ls_pinf-attributes-pack_name,
            ls_pinf-attributes-author,
@@ -365,7 +365,7 @@ CLASS ZCL_ABAPGIT_OBJECT_PINF IMPLEMENTATION.
       CLEAR <lg_any>.
     ENDIF.
 
-    li_interface->get_elements( IMPORTING et_elements = lt_elements ).
+    lt_elements = li_interface->get_elements( ).
 
     LOOP AT lt_elements ASSIGNING <li_element>.
       APPEND INITIAL LINE TO ls_pinf-elements ASSIGNING <ls_element>.
diff --git a/src/objects/zcl_abapgit_object_pinf.clas.locals_def.abap b/src/objects/zcl_abapgit_object_pinf.clas.locals_def.abap
index 90b27f31a..eb2ddd037 100644
--- a/src/objects/zcl_abapgit_object_pinf.clas.locals_def.abap
+++ b/src/objects/zcl_abapgit_object_pinf.clas.locals_def.abap
@@ -1,9 +1,10 @@
 INTERFACE lif_package_interface_facade.
+  TYPES ty_tpak_package_interf_elem_tt TYPE STANDARD TABLE OF tpak_package_interf_elem_ref WITH DEFAULT KEY.
 
   METHODS:
     get_elements
-      EXPORTING
-        et_elements              TYPE tpak_package_interf_elem_list
+      RETURNING
+        VALUE(rt_elements) TYPE ty_tpak_package_interf_elem_tt
       RAISING
         zcx_abapgit_exception,
 
@@ -18,8 +19,8 @@ INTERFACE lif_package_interface_facade.
         zcx_abapgit_exception,
 
     get_all_attributes
-      EXPORTING
-        es_package_interface_data TYPE scompidtln
+      RETURNING
+        VALUE(rs_package_interface_data) TYPE scompidtln
       RAISING
         zcx_abapgit_exception,
 
@@ -57,8 +58,8 @@ INTERFACE lif_package_interface_facade.
         zcx_abapgit_exception,
 
     get_changeable
-      EXPORTING
-        VALUE(ev_changeable) TYPE flag
+      RETURNING
+        VALUE(rv_changeable) TYPE flag
       RAISING
         zcx_abapgit_exception.
 
diff --git a/src/objects/zcl_abapgit_object_pinf.clas.locals_imp.abap b/src/objects/zcl_abapgit_object_pinf.clas.locals_imp.abap
index 0b96e8bfa..3336b2988 100644
--- a/src/objects/zcl_abapgit_object_pinf.clas.locals_imp.abap
+++ b/src/objects/zcl_abapgit_object_pinf.clas.locals_imp.abap
@@ -10,7 +10,7 @@ CLASS lcl_package_interface_facade IMPLEMENTATION.
 
     mi_interface->get_elements(
       IMPORTING
-        e_elements     = et_elements
+        e_elements     = rt_elements
       EXCEPTIONS
         object_invalid = 1
         intern_err     = 2
@@ -67,7 +67,7 @@ CLASS lcl_package_interface_facade IMPLEMENTATION.
 
     mi_interface->get_all_attributes(
       IMPORTING
-        e_package_interface_data = es_package_interface_data
+        e_package_interface_data = rs_package_interface_data
       EXCEPTIONS
         object_invalid           = 1
         OTHERS                   = 2 ).
@@ -200,7 +200,7 @@ CLASS lcl_package_interface_facade IMPLEMENTATION.
 
     mi_interface->get_changeable(
       IMPORTING
-        e_changeable   = ev_changeable
+        e_changeable   = rv_changeable
       EXCEPTIONS
         object_invalid = 1
         OTHERS         = 2 ).