From 09791d068567cb5848f474aa5d64855443438c29 Mon Sep 17 00:00:00 2001 From: Johannes Konings Date: Mon, 6 Aug 2018 12:54:43 +0200 Subject: [PATCH] Unit test ZCL_ABAPGIT_BRANCH_OVERVIEW for author regex (#1767) * changed assert to exception * unit test for author regex added * Umlauts removed --- src/zcl_abapgit_branch_overview.clas.abap | 6 ++- ...pgit_branch_overview.clas.testclasses.abap | 47 ++++++++++++++++++- 2 files changed, 50 insertions(+), 3 deletions(-) diff --git a/src/zcl_abapgit_branch_overview.clas.abap b/src/zcl_abapgit_branch_overview.clas.abap index 6792c5523..5d405c6d9 100644 --- a/src/zcl_abapgit_branch_overview.clas.abap +++ b/src/zcl_abapgit_branch_overview.clas.abap @@ -58,7 +58,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_BRANCH_OVERVIEW IMPLEMENTATION. +CLASS zcl_abapgit_branch_overview IMPLEMENTATION. METHOD constructor. @@ -325,7 +325,9 @@ CLASS ZCL_ABAPGIT_BRANCH_OVERVIEW IMPLEMENTATION. ls_commit-author ls_commit-email ls_commit-time ##NO_TEXT. - ASSERT sy-subrc = 0. + IF sy-subrc <> 0. + zcx_abapgit_exception=>raise( 'Error author regex' ). + ENDIF. APPEND ls_commit TO rt_commits. ENDLOOP. diff --git a/src/zcl_abapgit_branch_overview.clas.testclasses.abap b/src/zcl_abapgit_branch_overview.clas.testclasses.abap index 4844bfa4f..d062e190f 100644 --- a/src/zcl_abapgit_branch_overview.clas.testclasses.abap +++ b/src/zcl_abapgit_branch_overview.clas.testclasses.abap @@ -10,7 +10,8 @@ CLASS ltcl_test DEFINITION FOR TESTING PRIVATE SECTION. METHODS: - parse_commits FOR TESTING RAISING zcx_abapgit_exception. + parse_commits FOR TESTING RAISING zcx_abapgit_exception, + check_author_regex FOR TESTING RAISING zcx_abapgit_exception. ENDCLASS. @@ -54,4 +55,48 @@ CLASS ltcl_test IMPLEMENTATION. ENDMETHOD. + METHOD check_author_regex. + + + DATA: lt_objects TYPE zif_abapgit_definitions=>ty_objects_tt, + lt_commits TYPE zcl_abapgit_branch_overview=>ty_commits, + ls_object LIKE LINE OF lt_objects, + ls_git_pack_commit TYPE zcl_abapgit_git_pack=>ty_commit. + + ls_object-type = zif_abapgit_definitions=>gc_type-commit. + ls_git_pack_commit-tree = 'dummy'. + ls_git_pack_commit-author = 'Lastname, Firstname 1532611350 +0000'. + ls_git_pack_commit-committer = 'dummy'. + ls_object-data = zcl_abapgit_git_pack=>encode_commit( is_commit = ls_git_pack_commit ). + APPEND ls_object TO lt_objects. + + ls_object-type = zif_abapgit_definitions=>gc_type-commit. + ls_git_pack_commit-tree = 'dummy'. + ls_git_pack_commit-author = 'Soeren Mueller 1532611350 +0000'. + ls_git_pack_commit-committer = 'dummy'. + ls_object-data = zcl_abapgit_git_pack=>encode_commit( is_commit = ls_git_pack_commit ). + APPEND ls_object TO lt_objects. + + ls_object-type = zif_abapgit_definitions=>gc_type-commit. + ls_git_pack_commit-tree = 'dummy'. + ls_git_pack_commit-author = 'S#ren M#ller 1532611350 +0000'. + ls_git_pack_commit-committer = 'dummy'. + ls_object-data = zcl_abapgit_git_pack=>encode_commit( is_commit = ls_git_pack_commit ). + APPEND ls_object TO lt_objects. + + ls_object-type = zif_abapgit_definitions=>gc_type-commit. + ls_git_pack_commit-tree = 'dummy'. + ls_git_pack_commit-author = 'Dr. Werner Mueller 1532611350 +0000'. + ls_git_pack_commit-committer = 'dummy'. + ls_object-data = zcl_abapgit_git_pack=>encode_commit( is_commit = ls_git_pack_commit ). + APPEND ls_object TO lt_objects. + + lt_commits = zcl_abapgit_branch_overview=>parse_commits( lt_objects ). + + cl_abap_unit_assert=>assert_equals( + act = lines( lt_commits ) + exp = 4 ). + + ENDMETHOD. + ENDCLASS.