SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 11:46:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Unit test ZCL_ABAPGIT_BRANCH_OVERVIEW for author regex (#1767)

Browse Source 
* changed assert to exception

* unit test for author regex added

* Umlauts removed
This commit is contained in:
Johannes Konings 2018-08-06 12:54:43 +02:00 committed by Lars Hvam
parent e26f90260b
commit 09791d0685
2 changed files with 50 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/zcl_abapgit_branch_overview.clas.abap
View File

@ -58,7 +58,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_BRANCH_OVERVIEW IMPLEMENTATION. CLASS zcl_abapgit_branch_overview IMPLEMENTATION.
METHOD constructor. METHOD constructor.
@ -325,7 +325,9 @@ CLASS ZCL_ABAPGIT_BRANCH_OVERVIEW IMPLEMENTATION.
ls_commit-author ls_commit-author
ls_commit-email ls_commit-email
ls_commit-time ##NO_TEXT. ls_commit-time ##NO_TEXT.
ASSERT sy-subrc = 0. IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error author regex' ).
ENDIF.
APPEND ls_commit TO rt_commits. APPEND ls_commit TO rt_commits.
ENDLOOP. ENDLOOP.

47
src/zcl_abapgit_branch_overview.clas.testclasses.abap
View File

@ -10,7 +10,8 @@ CLASS ltcl_test DEFINITION FOR TESTING
PRIVATE SECTION. PRIVATE SECTION.
METHODS: METHODS:
parse_commits FOR TESTING RAISING zcx_abapgit_exception. parse_commits FOR TESTING RAISING zcx_abapgit_exception,
check_author_regex FOR TESTING RAISING zcx_abapgit_exception.
ENDCLASS. ENDCLASS.
@ -54,4 +55,48 @@ CLASS ltcl_test IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD check_author_regex.
DATA: lt_objects TYPE zif_abapgit_definitions=>ty_objects_tt,
lt_commits TYPE zcl_abapgit_branch_overview=>ty_commits,
ls_object LIKE LINE OF lt_objects,
ls_git_pack_commit TYPE zcl_abapgit_git_pack=>ty_commit.
ls_object-type = zif_abapgit_definitions=>gc_type-commit.
ls_git_pack_commit-tree = 'dummy'.
ls_git_pack_commit-author = 'Lastname, Firstname <mail@mail.com> 1532611350 +0000'.
ls_git_pack_commit-committer = 'dummy'.
ls_object-data = zcl_abapgit_git_pack=>encode_commit( is_commit = ls_git_pack_commit ).
APPEND ls_object TO lt_objects.
ls_object-type = zif_abapgit_definitions=>gc_type-commit.
ls_git_pack_commit-tree = 'dummy'.
ls_git_pack_commit-author = 'Soeren Mueller <mail@mail.com> 1532611350 +0000'.
ls_git_pack_commit-committer = 'dummy'.
ls_object-data = zcl_abapgit_git_pack=>encode_commit( is_commit = ls_git_pack_commit ).
APPEND ls_object TO lt_objects.
ls_object-type = zif_abapgit_definitions=>gc_type-commit.
ls_git_pack_commit-tree = 'dummy'.
ls_git_pack_commit-author = 'S#ren M#ller <mail@mail.com> 1532611350 +0000'.
ls_git_pack_commit-committer = 'dummy'.
ls_object-data = zcl_abapgit_git_pack=>encode_commit( is_commit = ls_git_pack_commit ).
APPEND ls_object TO lt_objects.
ls_object-type = zif_abapgit_definitions=>gc_type-commit.
ls_git_pack_commit-tree = 'dummy'.
ls_git_pack_commit-author = 'Dr. Werner Mueller <mail@mail.com> 1532611350 +0000'.
ls_git_pack_commit-committer = 'dummy'.
ls_object-data = zcl_abapgit_git_pack=>encode_commit( is_commit = ls_git_pack_commit ).
APPEND ls_object TO lt_objects.
lt_commits = zcl_abapgit_branch_overview=>parse_commits( lt_objects ).
cl_abap_unit_assert=>assert_equals(
act = lines( lt_commits )
exp = 4 ).
ENDMETHOD.
ENDCLASS. ENDCLASS.