SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

refactor user record class (#6520)

Browse Source
This commit is contained in:
Lars Hvam 2023-09-30 19:15:42 +02:00 committed by GitHub
parent 90d1e1a02f
commit 0ab304420b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 38 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

82
src/utils/zcl_abapgit_user_record.clas.abap
View File

@ -15,10 +15,10 @@ CLASS zcl_abapgit_user_record DEFINITION
!iv_user TYPE sy-uname.
METHODS get_name
RETURNING
VALUE(rv_name) TYPE zif_abapgit_git_definitions=>ty_git_user-name.
VALUE(rv_name) TYPE string.
METHODS get_email
RETURNING
VALUE(rv_email) TYPE zif_abapgit_git_definitions=>ty_git_user-email.
VALUE(rv_email) TYPE string.
CLASS-METHODS get_title
IMPORTING
iv_username TYPE sy-uname
@ -32,25 +32,19 @@ CLASS zcl_abapgit_user_record DEFINITION
o_user TYPE REF TO zcl_abapgit_user_record,
END OF ty_user.
TYPES:
ty_smtp TYPE STANDARD TABLE OF bapiadsmtp WITH DEFAULT KEY.
CLASS-DATA gt_user TYPE HASHED TABLE OF ty_user WITH UNIQUE KEY user.
TYPES:
ty_dev_clients TYPE SORTED TABLE OF sy-mandt WITH UNIQUE KEY table_line.
CLASS-DATA:
gt_user TYPE HASHED TABLE OF ty_user
WITH UNIQUE KEY user.
DATA:
ms_user TYPE zif_abapgit_git_definitions=>ty_git_user.
DATA: BEGIN OF ms_user,
name TYPE string,
email TYPE string,
END OF ms_user .
METHODS check_user_exists
IMPORTING
VALUE(iv_user) TYPE sy-uname
iv_user TYPE sy-uname
EXPORTING
VALUE(es_address) TYPE bapiaddr3
VALUE(et_smtp) TYPE ty_smtp
ev_fullname TYPE string
ev_email TYPE string
RAISING
zcx_abapgit_exception.
@ -86,52 +80,49 @@ CLASS zcl_abapgit_user_record IMPLEMENTATION.
METHOD check_user_exists.
DATA lt_return TYPE STANDARD TABLE OF bapiret2 WITH DEFAULT KEY.
DATA ls_address TYPE bapiaddr3.
DATA lt_smtp TYPE TABLE OF bapiadsmtp.
DATA ls_smtp LIKE LINE OF lt_smtp.
CALL FUNCTION 'BAPI_USER_GET_DETAIL'
EXPORTING
username = iv_user
IMPORTING
address = es_address
address = ls_address
TABLES
return = lt_return
addsmtp = et_smtp.
addsmtp = lt_smtp.
LOOP AT lt_return TRANSPORTING NO FIELDS WHERE type CA 'EA'.
zcx_abapgit_exception=>raise( |User: { iv_user } not found| ).
ENDLOOP.
ev_fullname = ls_address-fullname.
" Choose the first email from SU01
SORT lt_smtp BY consnumber ASCENDING.
LOOP AT lt_smtp INTO ls_smtp.
ev_email = ls_smtp-e_mail.
EXIT.
ENDLOOP.
ENDMETHOD.
METHOD constructor.
DATA:
ls_address TYPE bapiaddr3,
lt_smtp TYPE TABLE OF bapiadsmtp,
ls_smtp TYPE bapiadsmtp,
ls_user TYPE ty_user,
lo_exception TYPE REF TO zcx_abapgit_exception.
DATA ls_user TYPE ty_user.
"Get user details
" Get user details
TRY.
check_user_exists(
EXPORTING
iv_user = iv_user
IMPORTING
es_address = ls_address
et_smtp = lt_smtp ).
" Choose the first email from SU01
SORT lt_smtp BY consnumber ASCENDING.
LOOP AT lt_smtp INTO ls_smtp.
ms_user-email = ls_smtp-e_mail.
EXIT.
ENDLOOP.
" Attempt to use the full name from SU01
ms_user-name = ls_address-fullname.
CATCH zcx_abapgit_exception INTO lo_exception.
"Could not find user,try to get from other clients
ev_fullname = ms_user-name
ev_email = ms_user-email ).
CATCH zcx_abapgit_exception.
" Could not find user, try to get from other clients
get_user_dtls_from_other_clnt( iv_user ).
ENDTRY.
@ -154,7 +145,7 @@ CLASS zcl_abapgit_user_record IMPLEMENTATION.
METHOD get_instance.
FIELD-SYMBOLS: <ls_user> TYPE ty_user.
FIELD-SYMBOLS <ls_user> TYPE ty_user.
READ TABLE gt_user ASSIGNING <ls_user> WITH TABLE KEY user = iv_user.
IF sy-subrc = 0.
@ -178,18 +169,17 @@ CLASS zcl_abapgit_user_record IMPLEMENTATION.
METHOD get_user_dtls_from_other_clnt.
CONSTANTS lc_cc_category TYPE string VALUE 'C'.
TYPES ty_dev_clients TYPE SORTED TABLE OF sy-mandt WITH UNIQUE KEY table_line.
DATA lt_dev_clients TYPE ty_dev_clients.
FIELD-SYMBOLS <lv_dev_client> LIKE LINE OF lt_dev_clients.
FIELD-SYMBOLS: <lv_dev_client> LIKE LINE OF lt_dev_clients.
" Could not find the user Try other development clients
" Could not find the user, try other development clients
SELECT mandt FROM t000 INTO TABLE lt_dev_clients
WHERE cccategory = lc_cc_category AND mandt <> sy-mandt
ORDER BY PRIMARY KEY.
LOOP AT lt_dev_clients ASSIGNING <lv_dev_client>.
SELECT SINGLE p~name_text a~smtp_addr INTO (ms_user-name,ms_user-email)
SELECT SINGLE p~name_text a~smtp_addr INTO (ms_user-name, ms_user-email)
FROM usr21 AS u
INNER JOIN adrp AS p ON p~persnumber = u~persnumber
AND p~client = u~mandt