SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

remove DEFINED from zcl_abapgit_gui_page_repo_over (#3185)

Browse Source 
Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Alexander Tsybulsky 2020-01-30 09:03:19 +02:00 committed by GitHub
parent dc96e3b3ef
commit 0c3cdf639e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 53 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

94
src/ui/zcl_abapgit_gui_page_repo_over.clas.abap
View File

@ -41,7 +41,8 @@ CLASS zcl_abapgit_gui_page_repo_over DEFINITION
mv_order_by TYPE string, mv_order_by TYPE string,
mv_order_descending TYPE abap_bool, mv_order_descending TYPE abap_bool,
mv_filter TYPE string, mv_filter TYPE string,
mv_time_zone TYPE timezone. mv_time_zone TYPE timezone,
mt_col_spec TYPE zif_abapgit_definitions=>tty_col_spec.
METHODS: METHODS:
render_text_input render_text_input
@ -86,13 +87,17 @@ CLASS zcl_abapgit_gui_page_repo_over DEFINITION
io_html TYPE REF TO zcl_abapgit_html, io_html TYPE REF TO zcl_abapgit_html,
apply_order_by apply_order_by
CHANGING ct_overview TYPE tty_overview. CHANGING ct_overview TYPE tty_overview,
_add_col
IMPORTING
iv_descriptor TYPE string.
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION. CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_OVER IMPLEMENTATION.
METHOD apply_filter. METHOD apply_filter.
@ -114,6 +119,25 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD apply_order_by.
DATA:
lt_sort TYPE abap_sortorder_tab,
ls_sort LIKE LINE OF lt_sort.
IF mv_order_by IS NOT INITIAL.
ls_sort-name = mv_order_by.
ls_sort-descending = mv_order_descending.
ls_sort-astext = abap_true.
INSERT ls_sort INTO TABLE lt_sort.
SORT ct_overview BY (lt_sort).
ENDIF.
ENDMETHOD.
METHOD constructor. METHOD constructor.
super->constructor( ). super->constructor( ).
@ -319,35 +343,25 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
METHOD render_table_header. METHOD render_table_header.
DATA lt_col_spec TYPE zif_abapgit_definitions=>tty_col_spec. CLEAR mt_col_spec.
FIELD-SYMBOLS <ls_col> LIKE LINE OF lt_col_spec. " technical name /display name /css class /add timezone
_add_col( 'FAVORITE / /wmin / ' ).
DEFINE _add_col. _add_col( 'TYPE / /wmin / ' ).
APPEND INITIAL LINE TO lt_col_spec ASSIGNING <ls_col>. _add_col( 'NAME /Name / / ' ).
<ls_col>-tech_name = &1. _add_col( 'URL /Url / / ' ).
<ls_col>-display_name = &2. _add_col( 'PACKAGE /Package / / ' ).
<ls_col>-css_class = &3. _add_col( 'BRANCH /Branch / / ' ).
<ls_col>-add_tz = &4. _add_col( 'DESERIALIZED_BY /Deserialized by /ro-detail / ' ).
END-OF-DEFINITION. _add_col( 'DESERIALIZED_AT /Deserialized at /ro-detail /X' ).
_add_col( 'CREATED_BY /Created by /ro-detail / ' ).
" technical name display name css class add timezone _add_col( 'CREATED_AT /Created at /ro-detail /X' ).
_add_col 'FAVORITE' '' 'wmin' ''. _add_col( 'KEY /Key /ro-detail / ' ).
_add_col 'TYPE' '' 'wmin' ''.
_add_col 'NAME' 'Name' '' ''.
_add_col 'URL' 'Url' '' ''.
_add_col 'PACKAGE' 'Package' '' ''.
_add_col 'BRANCH' 'Branch' '' ''.
_add_col 'DESERIALIZED_BY' 'Deserialized by' 'ro-detail' ''.
_add_col 'DESERIALIZED_AT' 'Deserialized at' 'ro-detail' 'X'.
_add_col 'CREATED_BY' 'Created by' 'ro-detail' ''.
_add_col 'CREATED_AT' 'Created at' 'ro-detail' 'X'.
_add_col 'KEY' 'Key' 'ro-detail' ''.
io_html->add( |<thead>| ). io_html->add( |<thead>| ).
io_html->add( |<tr>| ). io_html->add( |<tr>| ).
io_html->add( zcl_abapgit_gui_chunk_lib=>render_order_by_header_cells( io_html->add( zcl_abapgit_gui_chunk_lib=>render_order_by_header_cells(
it_col_spec = lt_col_spec it_col_spec = mt_col_spec
iv_order_by = mv_order_by iv_order_by = mv_order_by
iv_order_descending = mv_order_descending ) ). iv_order_descending = mv_order_descending ) ).
@ -436,22 +450,20 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD apply_order_by.
DATA: METHOD _add_col.
lt_sort TYPE abap_sortorder_tab,
ls_sort LIKE LINE OF lt_sort.
IF mv_order_by IS NOT INITIAL. FIELD-SYMBOLS <ls_col> LIKE LINE OF mt_col_spec.
APPEND INITIAL LINE TO mt_col_spec ASSIGNING <ls_col>.
ls_sort-name = mv_order_by. SPLIT iv_descriptor AT '/' INTO
ls_sort-descending = mv_order_descending. <ls_col>-tech_name
ls_sort-astext = abap_true. <ls_col>-display_name
INSERT ls_sort INTO TABLE lt_sort. <ls_col>-css_class
SORT ct_overview BY (lt_sort). <ls_col>-add_tz.
CONDENSE <ls_col>-tech_name.
ENDIF. CONDENSE <ls_col>-display_name.
CONDENSE <ls_col>-css_class.
CONDENSE <ls_col>-add_tz.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.