SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 20:32:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix for #2896 (#2906)

Browse Source 
> Error message for missing development object
> Reopen "Object to File"-PopUp when object was not found
> Spelling correction for error message
This commit is contained in:
CASAG-MariusRaht 2019-09-10 07:02:12 +02:00 committed by Lars Hvam
parent 739b14ab6a
commit 0e27d90212
2 changed files with 18 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/ui/zcl_abapgit_popups.clas.abap
View File

@ -93,7 +93,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION. CLASS zcl_abapgit_popups IMPLEMENTATION.
METHOD add_field. METHOD add_field.
@ -613,20 +613,15 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
iv_fieldtext = 'Name' iv_fieldtext = 'Name'
CHANGING ct_fields = lt_fields ). CHANGING ct_fields = lt_fields ).
TRY. _popup_2_get_values( EXPORTING iv_popup_title = 'Object' "#EC NOTEXT
iv_no_value_check = abap_true
IMPORTING ev_value_1 = lv_object_type
ev_value_2 = lv_object_name
CHANGING ct_fields = lt_fields ).
_popup_2_get_values( EXPORTING iv_popup_title = 'Object' "#EC NOTEXT rs_tadir = zcl_abapgit_factory=>get_tadir( )->read_single(
iv_no_value_check = abap_true iv_object = to_upper( lv_object_type )
IMPORTING ev_value_1 = lv_object_type iv_obj_name = to_upper( lv_object_name ) ).
ev_value_2 = lv_object_name
CHANGING ct_fields = lt_fields ).
rs_tadir = zcl_abapgit_factory=>get_tadir( )->read_single(
iv_object = to_upper( lv_object_type )
iv_obj_name = to_upper( lv_object_name ) ).
CATCH zcx_abapgit_cancel.
ENDTRY.
ENDMETHOD. ENDMETHOD.
@ -1212,7 +1207,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
EXCEPTIONS EXCEPTIONS
OTHERS = 1 ##NO_TEXT. OTHERS = 1 ##NO_TEXT.
IF sy-subrc <> 0. IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from POPUP_GET_VALUES' ). zcx_abapgit_exception=>raise( 'Error from POPUP_GET_VALUES' ).
ENDIF. ENDIF.
IF lv_answer = c_answer_cancel. IF lv_answer = c_answer_cancel.

13
src/zcl_abapgit_zip.clas.abap
View File

@ -70,7 +70,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_ZIP IMPLEMENTATION. CLASS zcl_abapgit_zip IMPLEMENTATION.
METHOD encode_files. METHOD encode_files.
@ -132,11 +132,14 @@ CLASS ZCL_ABAPGIT_ZIP IMPLEMENTATION.
FIELD-SYMBOLS: <ls_file> LIKE LINE OF ls_files_item-files. FIELD-SYMBOLS: <ls_file> LIKE LINE OF ls_files_item-files.
WHILE ls_tadir IS INITIAL.
ls_tadir = zcl_abapgit_ui_factory=>get_popups( )->popup_object( ). ls_tadir = zcl_abapgit_ui_factory=>get_popups( )->popup_object( ).
IF ls_tadir IS INITIAL. IF ls_tadir IS INITIAL.
RAISE EXCEPTION TYPE zcx_abapgit_cancel. MESSAGE |Object couldn't be found| TYPE 'S' DISPLAY LIKE 'E'.
ENDIF. ENDIF.
ENDWHILE.
ls_files_item-item-obj_type = ls_tadir-object. ls_files_item-item-obj_type = ls_tadir-object.
ls_files_item-item-obj_name = ls_tadir-obj_name. ls_files_item-item-obj_name = ls_tadir-obj_name.