From 0e504d5eeb9e50aca5efc1ecb890883adc14d32b Mon Sep 17 00:00:00 2001
From: Christian Guenter <christianguenter@googlemail.com>
Date: Wed, 19 Apr 2017 20:12:13 +0000
Subject: [PATCH] fixed change detection

The CHANGED* and CREATED* fields are now cleared properly
---
 src/zabapgit_object_samc.prog.abap | 34 +++++++++++++++++++++++++++---
 src/zabapgit_object_sapc.prog.abap | 32 ++++++++++++++++++++++++++--
 2 files changed, 61 insertions(+), 5 deletions(-)

diff --git a/src/zabapgit_object_samc.prog.abap b/src/zabapgit_object_samc.prog.abap
index c8f8a85fa..beb06fba4 100644
--- a/src/zabapgit_object_samc.prog.abap
+++ b/src/zabapgit_object_samc.prog.abap
@@ -81,7 +81,6 @@ CLASS lcl_object_samc IMPLEMENTATION.
 
   METHOD lif_object~get_metadata.
     rs_metadata = get_metadata( ).
-    rs_metadata-ddic = abap_true.
     rs_metadata-delete_tadir = abap_true.
   ENDMETHOD.                    "lif_object~get_metadata.
 
@@ -109,9 +108,11 @@ CLASS lcl_object_samc IMPLEMENTATION.
 
   METHOD lif_object~serialize.
 
-    DATA: lr_data TYPE REF TO data.
+    DATA: lr_data   TYPE REF TO data.
 
-    FIELD-SYMBOLS: <ls_data>    TYPE any.
+    FIELD-SYMBOLS: <ls_data>   TYPE any,
+                   <ls_header> TYPE any,
+                   <field>     TYPE any.
 
     TRY.
         CREATE DATA lr_data TYPE ('AMC_APPLICATION_COMPLETE').
@@ -125,6 +126,33 @@ CLASS lcl_object_samc IMPLEMENTATION.
       IMPORTING
         p_data = <ls_data> ).
 
+    ASSIGN COMPONENT 'HEADER' OF STRUCTURE <ls_data> TO <ls_header>.
+    ASSERT sy-subrc = 0.
+
+    ASSIGN COMPONENT 'CHANGED_ON' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CHANGED_BY' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CHANGED_AT' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CHANGED_CLNT' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CREATED_ON' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CREATED_BY' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CREATED_AT' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CREATED_CLNT' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
     io_xml->add( iv_name = 'SAMC'
                  ig_data = <ls_data> ).
 
diff --git a/src/zabapgit_object_sapc.prog.abap b/src/zabapgit_object_sapc.prog.abap
index 8082f99ef..3eb838879 100644
--- a/src/zabapgit_object_sapc.prog.abap
+++ b/src/zabapgit_object_sapc.prog.abap
@@ -81,7 +81,6 @@ CLASS lcl_object_sapc IMPLEMENTATION.
 
   METHOD lif_object~get_metadata.
     rs_metadata = get_metadata( ).
-    rs_metadata-ddic = abap_true.
     rs_metadata-delete_tadir = abap_true.
   ENDMETHOD.                    "lif_object~get_metadata.
 
@@ -111,7 +110,9 @@ CLASS lcl_object_sapc IMPLEMENTATION.
 
     DATA: lr_data TYPE REF TO data.
 
-    FIELD-SYMBOLS: <ls_data>    TYPE any.
+    FIELD-SYMBOLS: <ls_data>   TYPE any,
+                   <ls_header> TYPE any,
+                   <field>     TYPE any.
 
     TRY.
         CREATE DATA lr_data TYPE ('APC_APPLICATION_COMPLETE').
@@ -125,6 +126,33 @@ CLASS lcl_object_sapc IMPLEMENTATION.
       IMPORTING
         p_data = <ls_data> ).
 
+    ASSIGN COMPONENT 'HEADER' OF STRUCTURE <ls_data> TO <ls_header>.
+    ASSERT sy-subrc = 0.
+
+    ASSIGN COMPONENT 'CHANGED_ON' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CHANGED_BY' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CHANGED_AT' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CHANGED_CLNT' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CREATED_ON' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CREATED_BY' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CREATED_AT' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
+    ASSIGN COMPONENT 'CREATED_CLNT' OF STRUCTURE <ls_header> TO <field>.
+    ASSERT sy-subrc = 0. CLEAR <field>.
+
     io_xml->add( iv_name = 'SAPC'
                  ig_data = <ls_data> ).