SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Unsupported object count in repo statistics (#4601)

Browse Source 
* Add unsupported object count in repo statistics

* lint fix: Keep single parameter on one line

* Fix indentation

* Undo changes to TADIR and DEFINITIONS

Undo changes to ZCL_ABAPGIT_TADIR and ZIF_ABAPGIT_DEFINITIONS

* Refactor code

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
yellappam 2021-03-10 00:13:10 +13:00 committed by GitHub
parent f6fe626cbb
commit 0f2020b5c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 61 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/repo/zcl_abapgit_repo.clas.abap
View File

@ -141,6 +141,11 @@ CLASS zcl_abapgit_repo DEFINITION
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS reset_status . METHODS reset_status .
METHODS get_unsupported_objects_local
RETURNING
VALUE(rt_objects) TYPE zif_abapgit_definitions=>ty_items_tt
RAISING
zcx_abapgit_exception .
PROTECTED SECTION. PROTECTED SECTION.
DATA mt_local TYPE zif_abapgit_definitions=>ty_files_item_tt . DATA mt_local TYPE zif_abapgit_definitions=>ty_files_item_tt .
@ -212,7 +217,7 @@ ENDCLASS.
CLASS zcl_abapgit_repo IMPLEMENTATION. CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
METHOD bind_listener. METHOD bind_listener.
@ -553,6 +558,33 @@ CLASS zcl_abapgit_repo IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD get_unsupported_objects_local.
DATA: lt_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt,
lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt.
FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF lt_tadir,
<ls_object> LIKE LINE OF rt_objects.
lt_tadir = zcl_abapgit_factory=>get_tadir( )->read(
iv_package = ms_data-package
iv_ignore_subpackages = ms_data-local_settings-ignore_subpackages
iv_only_local_objects = ms_data-local_settings-only_local_objects
io_dot = get_dot_abapgit( ) ).
lt_supported_types = zcl_abapgit_objects=>supported_list( ).
LOOP AT lt_tadir ASSIGNING <ls_tadir>.
READ TABLE lt_supported_types WITH KEY table_line = <ls_tadir>-object TRANSPORTING NO FIELDS.
IF sy-subrc <> 0.
APPEND INITIAL LINE TO rt_objects ASSIGNING <ls_object>.
MOVE-CORRESPONDING <ls_tadir> TO <ls_object>.
<ls_object>-obj_type = <ls_tadir>-object.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD is_offline. METHOD is_offline.
rv_offline = ms_data-offline. rv_offline = ms_data-offline.
ENDMETHOD. ENDMETHOD.

39
src/ui/zcl_abapgit_gui_page_sett_info.clas.abap
View File

@ -84,7 +84,7 @@ ENDCLASS.
CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION. CLASS ZCL_ABAPGIT_GUI_PAGE_SETT_INFO IMPLEMENTATION.
METHOD constructor. METHOD constructor.
@ -309,15 +309,18 @@ CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION.
METHOD read_stats. METHOD read_stats.
DATA: DATA:
lt_local TYPE zif_abapgit_definitions=>ty_files_item_tt, lt_local TYPE zif_abapgit_definitions=>ty_files_item_tt,
lt_remote TYPE zif_abapgit_definitions=>ty_files_tt, lt_remote TYPE zif_abapgit_definitions=>ty_files_tt,
ls_item TYPE zif_abapgit_definitions=>ty_item, ls_item TYPE zif_abapgit_definitions=>ty_item,
lt_local_items TYPE STANDARD TABLE OF zif_abapgit_definitions=>ty_item WITH DEFAULT KEY, lt_local_items TYPE STANDARD TABLE OF zif_abapgit_definitions=>ty_item WITH DEFAULT KEY,
lt_remote_items TYPE STANDARD TABLE OF zif_abapgit_definitions=>ty_item WITH DEFAULT KEY, lt_remote_items TYPE STANDARD TABLE OF zif_abapgit_definitions=>ty_item WITH DEFAULT KEY,
lt_results TYPE zif_abapgit_definitions=>ty_results_tt, lt_results TYPE zif_abapgit_definitions=>ty_results_tt,
lv_ignored TYPE abap_bool, lt_unsupported_local TYPE zif_abapgit_definitions=>ty_items_tt,
lv_state TYPE c LENGTH 1, lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt,
ls_stats TYPE ty_stats. lv_unsupported_remote TYPE i,
lv_ignored TYPE abap_bool,
lv_state TYPE c LENGTH 1,
ls_stats TYPE ty_stats.
FIELD-SYMBOLS: FIELD-SYMBOLS:
<ls_local> LIKE LINE OF lt_local, <ls_local> LIKE LINE OF lt_local,
@ -404,7 +407,6 @@ CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION.
io_dot = mo_repo->get_dot_abapgit( ) io_dot = mo_repo->get_dot_abapgit( )
IMPORTING IMPORTING
es_item = ls_item ). es_item = ls_item ).
COLLECT ls_item INTO lt_remote_items. COLLECT ls_item INTO lt_remote_items.
CATCH zcx_abapgit_exception ##NO_HANDLER. CATCH zcx_abapgit_exception ##NO_HANDLER.
ENDTRY. ENDTRY.
@ -426,6 +428,21 @@ CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION.
APPEND ls_stats TO mt_stats. APPEND ls_stats TO mt_stats.
CLEAR ls_stats.
lt_supported_types = zcl_abapgit_objects=>supported_list( ).
ls_stats-measure = 'Number of Unsupported Objects'.
lt_unsupported_local = mo_repo->get_unsupported_objects_local( ).
ls_stats-local = lines( lt_unsupported_local ).
LOOP AT lt_remote_items INTO ls_item.
READ TABLE lt_supported_types WITH KEY table_line = ls_item-obj_type TRANSPORTING NO FIELDS.
IF sy-subrc <> 0.
lv_unsupported_remote = lv_unsupported_remote + 1.
ENDIF.
ENDLOOP.
ls_stats-remote = lv_unsupported_remote.
APPEND ls_stats TO mt_stats.
ENDMETHOD. ENDMETHOD.