remove unused variables and methods

src/zabapgit_2fa.prog.abap

@@ -446,20 +446,22 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION.
   ENDMETHOD.
 
   METHOD parse_repo_from_url.
-    CONSTANTS: lc_search_regex TYPE string VALUE 'https?:\/\/(www\.)?github.com\/(.*)$'.
+* method not used?
-    DATA: lo_regex   TYPE REF TO cl_abap_regex,
+    ASSERT 0 = 1.
-          lo_matcher TYPE REF TO cl_abap_matcher.
+*    CONSTANTS: lc_search_regex TYPE string VALUE 'https?:\/\/(www\.)?github.com\/(.*)$'.
-
+*    DATA: lo_regex   TYPE REF TO cl_abap_regex,
-    CREATE OBJECT lo_regex
+*          lo_matcher TYPE REF TO cl_abap_matcher.
-      EXPORTING
+*
-        pattern = lc_search_regex.
+*    CREATE OBJECT lo_regex
-
+*      EXPORTING
-    lo_matcher = lo_regex->create_matcher( text = iv_url ).
+*        pattern = lc_search_regex.
-    IF lo_matcher->match( ) = abap_true.
+*
-      rv_repo_name = lo_matcher->get_submatch( 1 ).
+*    lo_matcher = lo_regex->create_matcher( text = iv_url ).
-    ELSE.
+*    IF lo_matcher->match( ) = abap_true.
-      rv_repo_name = '???' ##NO_TEXT.
+*      rv_repo_name = lo_matcher->get_submatch( 1 ).
-    ENDIF.
+*    ELSE.
+*      rv_repo_name = '???' ##NO_TEXT.
+*    ENDIF.
   ENDMETHOD.
 
   METHOD get_service_id_from_url.
@@ -467,9 +469,8 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION.
   ENDMETHOD.
 
   METHOD is_2fa_required.
-    DATA: li_client       TYPE REF TO if_http_client,
+    DATA: li_client   TYPE REF TO if_http_client,
-          lv_header_value TYPE string,
+          lo_settings TYPE REF TO lcl_settings.
-          lo_settings     TYPE REF TO lcl_settings.
 
     lo_settings = lcl_app=>settings( )->read( ).
 
@@ -693,7 +694,7 @@ CLASS lcl_2fa_authenticator_registry DEFINITION
     CLASS-METHODS:
       popup_token
         RETURNING VALUE(rv_token) TYPE string
-        RAISING lcx_exception.
+        RAISING   lcx_exception.
 ENDCLASS.
 
 CLASS lcl_2fa_authenticator_registry IMPLEMENTATION.

src/zabapgit_object_clas.prog.abap

@@ -202,8 +202,6 @@ CLASS lcl_object_clas IMPLEMENTATION.
 
     DATA: ls_vseoclass    TYPE vseoclass,
           lt_tpool        TYPE textpool_table,
-          lv_object       TYPE dokhl-object,
-          lv_state        TYPE dokhl-dokstate,
           lt_descriptions TYPE ty_seocompotx_tt,
           ls_clskey       TYPE seoclskey,
           lt_sotr         TYPE ty_sotr_tt,
@@ -274,8 +272,7 @@ CLASS lcl_object_clas IMPLEMENTATION.
 
   METHOD deserialize_sotr.
     "OTR stands for Online Text Repository
-    DATA: lt_sotr    TYPE ty_sotr_tt,
+    DATA: lt_sotr    TYPE ty_sotr_tt.
-          lt_objects TYPE sotr_objects.
 
     io_xml->read( EXPORTING iv_name = 'SOTR'
                   CHANGING cg_data = lt_sotr ).

src/zabapgit_object_ddls.prog.abap

@@ -92,7 +92,6 @@ CLASS lcl_object_ddls IMPLEMENTATION.
   METHOD lif_object~serialize.
 
     DATA: li_ddl    TYPE REF TO object,
-          lv_source TYPE string,
           lr_data   TYPE REF TO data.
 
     FIELD-SYMBOLS: <ls_data>  TYPE any,

src/zabapgit_object_enho.prog.abap

@@ -690,7 +690,6 @@ CLASS lcl_object_enho_interface IMPLEMENTATION.
   METHOD lif_object_enho~deserialize.
 
     DATA: lo_enh_intf  TYPE REF TO cl_enh_tool_intf,
-          lt_source    TYPE rswsourcet,
           li_tool      TYPE REF TO if_enh_tool,
           lv_shorttext TYPE string,
           lv_class     TYPE seoclsname,

src/zabapgit_object_intf.prog.abap

@@ -143,13 +143,9 @@ CLASS lcl_object_intf IMPLEMENTATION.
 
   METHOD serialize_xml.
     DATA:
-      lt_tpool        TYPE textpool_table,
-      lv_object       TYPE dokhl-object,
-      lv_state        TYPE dokhl-dokstate,
       lt_descriptions TYPE ty_seocompotx_tt,
       ls_vseointerf   TYPE vseointerf,
       ls_clskey       TYPE seoclskey,
-      lt_sotr         TYPE ty_sotr_tt,
       lt_lines        TYPE tlinetab.
 
 

src/zabapgit_object_sfpf.prog.abap

@@ -112,8 +112,7 @@ CLASS lcl_object_sfpf IMPLEMENTATION.
 
   METHOD form_to_xstring.
 
-    DATA: lv_xstr    TYPE xstring,
+    DATA: li_fp_form TYPE REF TO if_fp_form,
-          li_fp_form TYPE REF TO if_fp_form,
           li_wb_form TYPE REF TO if_fp_wb_form.
 
 
@@ -130,8 +129,6 @@ CLASS lcl_object_sfpf IMPLEMENTATION.
   METHOD fix_oref.
 
     DATA: li_iterator TYPE REF TO if_ixml_node_iterator,
-          lv_name     TYPE string,
-          lv_value    TYPE string,
           lv_new      TYPE n LENGTH 3,
           lv_old      TYPE string,
           lt_map      TYPE STANDARD TABLE OF string WITH DEFAULT KEY,

src/zabapgit_object_sfpi.prog.abap

@@ -108,8 +108,7 @@ CLASS lcl_object_sfpi IMPLEMENTATION.
 
   METHOD interface_to_xstring.
 
-    DATA: lv_xstr         TYPE xstring,
+    DATA: li_fp_interface TYPE REF TO if_fp_interface,
-          li_fp_interface TYPE REF TO if_fp_interface,
           li_wb_interface TYPE REF TO if_fp_wb_interface.
 
 

src/zabapgit_object_splo.prog.abap

@@ -76,8 +76,7 @@ CLASS lcl_object_splo IMPLEMENTATION.
 
   METHOD lif_object~deserialize.
 
-    DATA: lv_obj_name TYPE e071-obj_name,
+    DATA: ls_tsp1t    TYPE tsp1t,
-          ls_tsp1t    TYPE tsp1t,
           ls_tsp1d    TYPE tsp1d,
           ls_tsp0p    TYPE tsp0p.
 
@@ -93,17 +92,8 @@ CLASS lcl_object_splo IMPLEMENTATION.
     MODIFY tsp1d FROM ls_tsp1d.                           "#EC CI_SUBRC
     MODIFY tsp0p FROM ls_tsp0p.                           "#EC CI_SUBRC
 
-    lv_obj_name = ms_item-obj_name.
-
     tadir_insert( iv_package ).
 
-*    CALL FUNCTION 'TR_TADIR_POPUP_ENTRY_E071'
-*      EXPORTING
-*        wi_e071_pgmid     = 'R3TR'
-*        wi_e071_object    = ms_item-obj_type
-*        wi_e071_obj_name  = lv_obj_name
-*        wi_tadir_devclass = iv_package.
-
   ENDMETHOD.                    "lif_object~deserialize
 
   METHOD lif_object~delete.

src/zabapgit_objects.prog.abap

@@ -1733,8 +1733,6 @@ CLASS lcl_objects DEFINITION FINAL.
 
   PRIVATE SECTION.
 
-    CLASS-DATA: mv_langs_installed TYPE scplangs.
-
     CLASS-METHODS check_duplicates
       IMPORTING it_files TYPE ty_files_tt
       RAISING   lcx_exception.

src/zabapgit_page_diff.prog.abap

@@ -595,8 +595,6 @@ CLASS lcl_gui_page_diff IMPLEMENTATION.
 
   METHOD render_line_unified.
 
-    DATA lv_line TYPE string.
-
     FIELD-SYMBOLS <diff_line> LIKE LINE OF mt_delayed_lines.
 
     CREATE OBJECT ro_html.

src/zabapgit_tadir.prog.abap

@@ -129,8 +129,6 @@ CLASS lcl_tadir IMPLEMENTATION.
     DATA: lv_index    TYPE i,
           lt_tadir    TYPE ty_tadir_tt,
           lt_tdevc    TYPE STANDARD TABLE OF tdevc,
-          lv_len      TYPE i,
-          lv_message  TYPE string,
           lv_path     TYPE string.
 
     FIELD-SYMBOLS: <ls_tdevc> LIKE LINE OF lt_tdevc,

src/zabapgit_transport.prog.abap

@@ -66,10 +66,7 @@ CLASS lcl_transport IMPLEMENTATION.
   ENDMETHOD.
 
   METHOD to_tadir.
-    DATA: lt_requests TYPE trwbo_requests,
+    DATA: lt_requests TYPE trwbo_requests.
-          lt_tadir    TYPE scts_tadir,
-          lv_package  TYPE devclass,
-          lt_trkorr   TYPE trwbo_request_headers.
 
 
     IF lines( it_transport_headers ) = 0.
@@ -288,17 +285,11 @@ CLASS lcl_transport_to_branch IMPLEMENTATION.
 
   METHOD create.
     DATA:
-      ls_transport_object TYPE LINE OF scts_tadir,
-      lt_items            TYPE ty_files_item_tt,
-      ls_local_file       TYPE LINE OF ty_files_item_tt,
-      ls_remote_file      TYPE LINE OF ty_files_tt,
-      ls_item             TYPE string,
       lv_branch_name      TYPE string,
       ls_comment          TYPE ty_comment,
       lo_stage            TYPE REF TO lcl_stage,
       ls_stage_objects    TYPE ty_stage_files,
-      lt_object_statuses  TYPE ty_results_tt,
+      lt_object_statuses  TYPE ty_results_tt.
-      ls_object_status    TYPE LINE OF ty_results_tt.
 
     lv_branch_name = lcl_git_branch_list=>complete_heads_branch_name(
         lcl_git_branch_list=>normalize_branch_name( is_transport_to_branch-branch_name ) ).

src/zabapgit_unit_test.prog.abap

@@ -1247,9 +1247,7 @@ CLASS ltcl_html DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT FINAL.
       style1  FOR TESTING RAISING lcx_exception.
 
     METHODS:
-      setup,
+      setup.
-      last_line
-        RETURNING VALUE(rv_line) TYPE string.
 
 ENDCLASS. "ltcl_html
 
@@ -1331,15 +1329,6 @@ CLASS ltcl_html IMPLEMENTATION.
 
   ENDMETHOD.
 
-  METHOD last_line.
-
-    DATA: lt_strings TYPE STANDARD TABLE OF string WITH DEFAULT KEY.
-
-    SPLIT mo_html->render( ) AT gc_newline INTO TABLE lt_strings.
-    READ TABLE lt_strings INDEX lines( lt_strings ) INTO rv_line.
-
-  ENDMETHOD.
-
   METHOD style1.
 
     DATA lv_exp TYPE string.

src/zabapgit_unit_test_transport.prog.abap

@@ -164,7 +164,6 @@ CLASS ltcl_transport_objects IMPLEMENTATION.
   ENDMETHOD.
 
   METHOD object_not_in_local_files.
-    DATA ls_local_file TYPE ty_file_item.
 
     given_the_transport_object(
       iv_obj_name   = 'CL_FOO'

src/zabapgit_view_repo.prog.abap

@@ -264,17 +264,13 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION.
           lo_tb_branch   TYPE REF TO lcl_html_toolbar,
           lv_key         TYPE lcl_persistence_db=>ty_value,
           lv_wp_opt      LIKE gc_html_opt-crossout,
-          lv_pull_opt    LIKE gc_html_opt-crossout,
+          lv_pull_opt    LIKE gc_html_opt-crossout.
-          lo_repo_online TYPE REF TO lcl_repo_online.
 
     CREATE OBJECT ro_toolbar.
     CREATE OBJECT lo_tb_branch.
     CREATE OBJECT lo_tb_advanced.
 
     lv_key = mo_repo->get_key( ).
-    IF mo_repo->is_offline( ) = abap_false.
-      lo_repo_online ?= mo_repo.
-    ENDIF.
 
     IF mo_repo->is_write_protected( ) = abap_true.
       lv_wp_opt   = gc_html_opt-crossout.

src/zabapgit_zip.prog.abap

@@ -69,40 +69,42 @@ ENDCLASS.                    "lcl_zip DEFINITION
 CLASS lcl_zip IMPLEMENTATION.
 
   METHOD get_message.
+* method not in use?
+    ASSERT 0 = 1.
 
-    DATA: lv_returncode TYPE c,
+*    DATA: lv_returncode TYPE c,
-          lt_fields     TYPE TABLE OF sval.
+*          lt_fields     TYPE TABLE OF sval.
-
+*
-    FIELD-SYMBOLS: <ls_field> LIKE LINE OF lt_fields.
+*    FIELD-SYMBOLS: <ls_field> LIKE LINE OF lt_fields.
-
+*
-
+*
-    APPEND INITIAL LINE TO lt_fields ASSIGNING <ls_field>.
+*    APPEND INITIAL LINE TO lt_fields ASSIGNING <ls_field>.
-    <ls_field>-tabname   = 'ABAPTXT255'.
+*    <ls_field>-tabname   = 'ABAPTXT255'.
-    <ls_field>-fieldname = 'LINE'.
+*    <ls_field>-fieldname = 'LINE'.
-    <ls_field>-fieldtext = 'Commit message'.                "#EC NOTEXT
+*    <ls_field>-fieldtext = 'Commit message'.                "#EC NOTEXT
-    <ls_field>-field_obl = abap_true.
+*    <ls_field>-field_obl = abap_true.
-
+*
-    CALL FUNCTION 'POPUP_GET_VALUES'
+*    CALL FUNCTION 'POPUP_GET_VALUES'
-      EXPORTING
+*      EXPORTING
-        no_value_check  = abap_true
+*        no_value_check  = abap_true
-        popup_title     = 'Enter commit message'            "#EC NOTEXT
+*        popup_title     = 'Enter commit message'            "#EC NOTEXT
-      IMPORTING
+*      IMPORTING
-        returncode      = lv_returncode
+*        returncode      = lv_returncode
-      TABLES
+*      TABLES
-        fields          = lt_fields
+*        fields          = lt_fields
-      EXCEPTIONS
+*      EXCEPTIONS
-        error_in_fields = 1
+*        error_in_fields = 1
-        OTHERS          = 2.
+*        OTHERS          = 2.
-    IF sy-subrc <> 0.
+*    IF sy-subrc <> 0.
-      lcx_exception=>raise( 'Error from POPUP_GET_VALUES' ).
+*      lcx_exception=>raise( 'Error from POPUP_GET_VALUES' ).
-    ENDIF.
+*    ENDIF.
-    IF lv_returncode = 'A'.
+*    IF lv_returncode = 'A'.
-      lcx_exception=>raise( 'cancelled' ).
+*      lcx_exception=>raise( 'cancelled' ).
-    ENDIF.
+*    ENDIF.
-
+*
-    READ TABLE lt_fields INDEX 1 ASSIGNING <ls_field>.
+*    READ TABLE lt_fields INDEX 1 ASSIGNING <ls_field>.
-    ASSERT sy-subrc = 0.
+*    ASSERT sy-subrc = 0.
-    rv_message = <ls_field>-value.
+*    rv_message = <ls_field>-value.
 
   ENDMETHOD.                    "get_message
 
@@ -395,9 +397,8 @@ CLASS lcl_zip IMPLEMENTATION.
 
   METHOD export.
 
-    DATA: lo_log   TYPE REF TO lcl_log,
+    DATA: lo_log TYPE REF TO lcl_log,
-          lv_index TYPE i,
+          lt_zip TYPE ty_files_item_tt.
-          lt_zip   TYPE ty_files_item_tt.
 
     FIELD-SYMBOLS: <ls_zip> LIKE LINE OF lt_zip.