SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

remove unused variables (#3721)

Browse Source 
* remove unused

* remove fstate

* remove

* false

* AVAS, delete method insert_links

* fstate

* sotr

* WAPA

* ssfo

* ddls mock
This commit is contained in:
Lars Hvam 2020-08-11 18:11:39 +02:00 committed by GitHub
parent 32ec5430a7
commit 17b6411cdb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 12 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/objects/zcl_abapgit_object_avas.clas.abap
View File

@ -26,9 +26,6 @@ CLASS zcl_abapgit_object_avas DEFINITION
!is_avas TYPE ty_avas !is_avas TYPE ty_avas
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS insert_links
IMPORTING
!is_avas TYPE ty_avas .
METHODS instantiate METHODS instantiate
RETURNING RETURNING
VALUE(ro_avas) TYPE REF TO cl_cls_attr_value_assignment VALUE(ro_avas) TYPE REF TO cl_cls_attr_value_assignment
@ -74,14 +71,6 @@ CLASS ZCL_ABAPGIT_OBJECT_AVAS IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD insert_links.
* todo, how does links work?
RETURN.
ENDMETHOD.
METHOD instantiate. METHOD instantiate.
DATA: lv_id TYPE guid_32, DATA: lv_id TYPE guid_32,
@ -162,7 +151,7 @@ CLASS ZCL_ABAPGIT_OBJECT_AVAS IMPLEMENTATION.
tadir_insert( iv_package ). tadir_insert( iv_package ).
insert_assignments( ls_avas ). insert_assignments( ls_avas ).
insert_links( ls_avas ). * todo, how does links work?
* corr_insert? * corr_insert?

3
src/objects/zcl_abapgit_object_ssfo.clas.abap
View File

@ -410,8 +410,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION.
li_iterator TYPE REF TO if_ixml_node_iterator, li_iterator TYPE REF TO if_ixml_node_iterator,
lv_formname TYPE tdsfname, lv_formname TYPE tdsfname,
li_ixml TYPE REF TO if_ixml, li_ixml TYPE REF TO if_ixml,
li_xml_doc TYPE REF TO if_ixml_document, li_xml_doc TYPE REF TO if_ixml_document.
lv_within_code_section TYPE abap_bool.
li_ixml = cl_ixml=>create( ). li_ixml = cl_ixml=>create( ).
li_xml_doc = li_ixml->create_document( ). li_xml_doc = li_ixml->create_document( ).

4
src/objects/zcl_abapgit_object_wapa.clas.abap
View File

@ -596,9 +596,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WAPA IMPLEMENTATION.
lt_navgraph TYPE o2applgrap_table, lt_navgraph TYPE o2applgrap_table,
lt_pages TYPE o2pagelist, lt_pages TYPE o2pagelist,
lt_pages_info TYPE ty_pages_tt, lt_pages_info TYPE ty_pages_tt,
lo_bsp TYPE REF TO cl_o2_api_application, lo_bsp TYPE REF TO cl_o2_api_application.
lt_sotr TYPE zif_abapgit_definitions=>ty_sotr_tt,
lt_sotr_use TYPE zif_abapgit_definitions=>ty_sotr_use_tt.
FIELD-SYMBOLS: <ls_page> LIKE LINE OF lt_pages. FIELD-SYMBOLS: <ls_page> LIKE LINE OF lt_pages.

5
src/objects/zcl_abapgit_objects.clas.testclasses.abap
View File

@ -368,6 +368,11 @@ CLASS ltcl_object_ddls_mock IMPLEMENTATION.
ms_item = is_item. ms_item = is_item.
* dummy use of variable
IF iv_language = 'E'.
RETURN.
ENDIF.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_object~is_locked. METHOD zif_abapgit_object~is_locked.

6
src/objects/zcl_abapgit_sotr_handler.clas.abap
View File

@ -130,8 +130,7 @@ CLASS ZCL_ABAPGIT_SOTR_HANDLER IMPLEMENTATION.
METHOD get_sotr_4_concept. METHOD get_sotr_4_concept.
DATA: ls_header TYPE sotr_head, DATA: ls_header TYPE sotr_head,
lt_entries TYPE sotr_text_tt, lt_entries TYPE sotr_text_tt.
lv_obj_name TYPE trobj_name.
FIELD-SYMBOLS: <ls_entry> LIKE LINE OF lt_entries. FIELD-SYMBOLS: <ls_entry> LIKE LINE OF lt_entries.
@ -200,9 +199,6 @@ CLASS ZCL_ABAPGIT_SOTR_HANDLER IMPLEMENTATION.
METHOD read_sotr. METHOD read_sotr.
DATA:
lv_concept TYPE sotr_head-concept.
FIELD-SYMBOLS <ls_sotr_use> TYPE sotr_use. FIELD-SYMBOLS <ls_sotr_use> TYPE sotr_use.
" Known SOTR usage... " Known SOTR usage...

3
src/ui/zcl_abapgit_gui_chunk_lib.clas.abap
View File

@ -565,11 +565,10 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
METHOD render_order_by_header_cells. METHOD render_order_by_header_cells.
DATA: DATA:
lt_colspec TYPE zif_abapgit_definitions=>tty_col_spec,
lv_tmp TYPE string, lv_tmp TYPE string,
lv_disp_name TYPE string. lv_disp_name TYPE string.
FIELD-SYMBOLS <ls_col> LIKE LINE OF lt_colspec. FIELD-SYMBOLS <ls_col> LIKE LINE OF it_col_spec.
CREATE OBJECT ro_html. CREATE OBJECT ro_html.

1
src/ui/zcl_abapgit_gui_page_debuginfo.clas.abap
View File

@ -138,7 +138,6 @@ CLASS zcl_abapgit_gui_page_debuginfo IMPLEMENTATION.
lv_class TYPE seoclsname, lv_class TYPE seoclsname,
li_object TYPE REF TO zif_abapgit_object, li_object TYPE REF TO zif_abapgit_object,
ls_item TYPE zif_abapgit_definitions=>ty_item, ls_item TYPE zif_abapgit_definitions=>ty_item,
lv_language TYPE spras,
ls_metadata TYPE zif_abapgit_definitions=>ty_metadata, ls_metadata TYPE zif_abapgit_definitions=>ty_metadata,
lv_step TYPE zif_abapgit_definitions=>ty_deserialization_step, lv_step TYPE zif_abapgit_definitions=>ty_deserialization_step,
lt_steps TYPE zif_abapgit_definitions=>ty_deserialization_step_tt. lt_steps TYPE zif_abapgit_definitions=>ty_deserialization_step_tt.

7
src/ui/zcl_abapgit_gui_page_patch.clas.abap
View File

@ -68,7 +68,6 @@ CLASS zcl_abapgit_gui_page_patch DEFINITION
io_html TYPE REF TO zcl_abapgit_html io_html TYPE REF TO zcl_abapgit_html
iv_filename TYPE string iv_filename TYPE string
is_diff_line TYPE zif_abapgit_definitions=>ty_diff is_diff_line TYPE zif_abapgit_definitions=>ty_diff
iv_fstate TYPE char1
iv_index TYPE sy-tabix iv_index TYPE sy-tabix
RAISING RAISING
zcx_abapgit_exception, zcx_abapgit_exception,
@ -166,7 +165,6 @@ CLASS zcl_abapgit_gui_page_patch DEFINITION
is_patch_line_possible is_patch_line_possible
IMPORTING IMPORTING
is_diff_line TYPE zif_abapgit_definitions=>ty_diff is_diff_line TYPE zif_abapgit_definitions=>ty_diff
iv_fstate TYPE char1
RETURNING RETURNING
VALUE(rv_is_patch_line_possible) TYPE abap_bool. VALUE(rv_is_patch_line_possible) TYPE abap_bool.
@ -617,7 +615,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_PATCH IMPLEMENTATION.
render_patch( io_html = io_html render_patch( io_html = io_html
iv_filename = iv_filename iv_filename = iv_filename
is_diff_line = is_diff_line is_diff_line = is_diff_line
iv_fstate = iv_fstate
iv_index = iv_index ). iv_index = iv_index ).
super->render_line_split_row( super->render_line_split_row(
@ -646,9 +643,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_PATCH IMPLEMENTATION.
lv_patched = get_diff_object( iv_filename )->is_line_patched( iv_index ). lv_patched = get_diff_object( iv_filename )->is_line_patched( iv_index ).
lv_is_patch_possible = is_patch_line_possible( lv_is_patch_possible = is_patch_line_possible( is_diff_line ).
is_diff_line = is_diff_line
iv_fstate = iv_fstate ).
IF lv_is_patch_possible = abap_true. IF lv_is_patch_possible = abap_true.

4
src/ui/zcl_abapgit_gui_page_patch.clas.testclasses.abap
View File

@ -198,9 +198,7 @@ CLASS ltcl_is_patch_line_possible IMPLEMENTATION.
METHOD when_is_patch_line_possible. METHOD when_is_patch_line_possible.
mv_is_patch_line_possible = zcl_abapgit_gui_page_patch=>is_patch_line_possible( mv_is_patch_line_possible = zcl_abapgit_gui_page_patch=>is_patch_line_possible( ms_diff_line ).
is_diff_line = ms_diff_line
iv_fstate = mv_fstate ).
ENDMETHOD. ENDMETHOD.

2
src/ui/zcl_abapgit_gui_page_tutorial.clas.abap
View File

@ -64,8 +64,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TUTORIAL IMPLEMENTATION.
METHOD zif_abapgit_gui_renderable~render. METHOD zif_abapgit_gui_renderable~render.
DATA: lv_devclass TYPE tadir-devclass.
CREATE OBJECT ri_html TYPE zcl_abapgit_html. CREATE OBJECT ri_html TYPE zcl_abapgit_html.
ri_html->add( '<div class="tutorial">' ). ri_html->add( '<div class="tutorial">' ).