From 17ba24e72a6e87f95de87853d9dbe39a12ae2469 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Thu, 23 Feb 2023 07:38:56 +0100 Subject: [PATCH] refactor TDEVCT SELECT to SAP package class (#6081) --- ...cl_abapgit_dependencies.clas.testclasses.abap | 4 ++++ ...zcl_abapgit_file_status.clas.testclasses.abap | 4 ++++ ...cl_abapgit_folder_logic.clas.testclasses.abap | 16 ++++++++++++++++ src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap | 3 +-- ..._abapgit_services_basis.clas.testclasses.abap | 4 ++++ src/zcl_abapgit_sap_package.clas.abap | 8 ++++++++ src/zif_abapgit_sap_package.intf.abap | 5 +++++ 7 files changed, 42 insertions(+), 2 deletions(-) diff --git a/src/objects/core/zcl_abapgit_dependencies.clas.testclasses.abap b/src/objects/core/zcl_abapgit_dependencies.clas.testclasses.abap index 2fafc0449..f4261e1a1 100644 --- a/src/objects/core/zcl_abapgit_dependencies.clas.testclasses.abap +++ b/src/objects/core/zcl_abapgit_dependencies.clas.testclasses.abap @@ -30,6 +30,10 @@ CLASS ltcl_sap_package IMPLEMENTATION. ENDMETHOD. + METHOD zif_abapgit_sap_package~read_description. + RETURN. + ENDMETHOD. + METHOD zif_abapgit_sap_package~list_subpackages. IF mv_package = 'Z_MAIN'. diff --git a/src/objects/core/zcl_abapgit_file_status.clas.testclasses.abap b/src/objects/core/zcl_abapgit_file_status.clas.testclasses.abap index 82a54a730..5f1e4b7a2 100644 --- a/src/objects/core/zcl_abapgit_file_status.clas.testclasses.abap +++ b/src/objects/core/zcl_abapgit_file_status.clas.testclasses.abap @@ -65,6 +65,10 @@ ENDCLASS. CLASS ltcl_run_checks IMPLEMENTATION. + METHOD zif_abapgit_sap_package~read_description. + RETURN. + ENDMETHOD. + METHOD zif_abapgit_sap_package~list_subpackages. RETURN. ENDMETHOD. diff --git a/src/objects/core/zcl_abapgit_folder_logic.clas.testclasses.abap b/src/objects/core/zcl_abapgit_folder_logic.clas.testclasses.abap index 8c802cb84..5aab62455 100644 --- a/src/objects/core/zcl_abapgit_folder_logic.clas.testclasses.abap +++ b/src/objects/core/zcl_abapgit_folder_logic.clas.testclasses.abap @@ -68,6 +68,10 @@ CLASS ltcl_folder_logic_package IMPLEMENTATION. INSERT lv_devclass INTO TABLE rt_list. ENDMETHOD. + METHOD zif_abapgit_sap_package~read_description. + RETURN. + ENDMETHOD. + METHOD zif_abapgit_sap_package~list_superpackages. RETURN. ENDMETHOD. @@ -155,6 +159,10 @@ CLASS ltcl_folder_logic IMPLEMENTATION. RETURN. ENDMETHOD. + METHOD zif_abapgit_sap_package~read_description. + RETURN. + ENDMETHOD. + METHOD zif_abapgit_sap_package~read_parent. rv_parentcl = c_top. ENDMETHOD. @@ -357,6 +365,10 @@ CLASS ltcl_folder_logic_namespaces IMPLEMENTATION. INSERT lv_devclass INTO TABLE rt_list. ENDMETHOD. + METHOD zif_abapgit_sap_package~read_description. + RETURN. + ENDMETHOD. + METHOD zif_abapgit_sap_package~list_superpackages. RETURN. ENDMETHOD. @@ -484,6 +496,10 @@ ENDCLASS. CLASS ltcl_folder_logic_no_parent IMPLEMENTATION. + METHOD zif_abapgit_sap_package~read_description. + RETURN. + ENDMETHOD. + METHOD zif_abapgit_sap_package~list_subpackages. RETURN. ENDMETHOD. diff --git a/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap index a35010bca..7726d06e4 100644 --- a/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap @@ -871,8 +871,7 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. ENDIF. IF iv_suppress_title = abap_false. - SELECT SINGLE ctext FROM tdevct INTO lv_title - WHERE devclass = iv_package AND spras = sy-langu ##SUBRC_OK. + lv_title = zcl_abapgit_factory=>get_sap_package( iv_package )->read_description( ). ENDIF. lv_obj_name = iv_package. diff --git a/src/ui/routing/zcl_abapgit_services_basis.clas.testclasses.abap b/src/ui/routing/zcl_abapgit_services_basis.clas.testclasses.abap index 7bce0696a..ea6e48548 100644 --- a/src/ui/routing/zcl_abapgit_services_basis.clas.testclasses.abap +++ b/src/ui/routing/zcl_abapgit_services_basis.clas.testclasses.abap @@ -274,6 +274,10 @@ CLASS ltcl_sap_package_mock IMPLEMENTATION. ENDMETHOD. + METHOD zif_abapgit_sap_package~read_description. + + ENDMETHOD. + METHOD zif_abapgit_sap_package~are_changes_recorded_in_tr_req. ENDMETHOD. diff --git a/src/zcl_abapgit_sap_package.clas.abap b/src/zcl_abapgit_sap_package.clas.abap index cd3a98ef3..9e7cabbf6 100644 --- a/src/zcl_abapgit_sap_package.clas.abap +++ b/src/zcl_abapgit_sap_package.clas.abap @@ -382,6 +382,14 @@ CLASS zcl_abapgit_sap_package IMPLEMENTATION. ENDMETHOD. + METHOD zif_abapgit_sap_package~read_description. + + SELECT SINGLE ctext FROM tdevct INTO rv_description + WHERE devclass = mv_package AND spras = sy-langu ##SUBRC_OK. + + ENDMETHOD. + + METHOD zif_abapgit_sap_package~read_parent. SELECT SINGLE parentcl FROM tdevc INTO rv_parentcl diff --git a/src/zif_abapgit_sap_package.intf.abap b/src/zif_abapgit_sap_package.intf.abap index 79c7d4ab2..f94568178 100644 --- a/src/zif_abapgit_sap_package.intf.abap +++ b/src/zif_abapgit_sap_package.intf.abap @@ -26,6 +26,11 @@ INTERFACE zif_abapgit_sap_package VALUE(rv_parentcl) TYPE tdevc-parentcl RAISING zcx_abapgit_exception . + METHODS read_description + RETURNING + VALUE(rv_description) TYPE string + RAISING + zcx_abapgit_exception . METHODS create_child IMPORTING !iv_child TYPE devclass