SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-03 05:18:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

UI: Message box improvements (#5616)

Browse Source 
- Align width of message box to width of abapGit div (instead of full window width)
- Don't render "Message (00/001)" for generic messages

Closes #5614
This commit is contained in:
Marc Bernard 2022-06-08 07:54:29 +02:00 committed by GitHub
parent 3131fc6cf8
commit 188996e417
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ui/zabapgit_css_common.w3mi.data.css
View File

@ -900,12 +900,12 @@ div.info-panel div.info-list td { padding-right: 1em }
div.message-panel { div.message-panel {
z-index: 99; z-index: 99;
box-shadow: 2px 2px 4px 0px hsla(0, 0%, 0%, .1); box-shadow: 2px 2px 4px 0px hsla(0, 0%, 0%, .1);
padding: 12px; padding: 0.5em 1em;
margin-left: -48%;
position: fixed; position: fixed;
bottom: 12px; bottom: 12px;
width: 94%; width: 95%;
left: 50%; margin: 0 auto;
max-width: 1248px;
border: 1px solid; border: 1px solid;
border-radius: 5px; border-radius: 5px;

24
src/ui/zcl_abapgit_gui_chunk_lib.clas.abap
View File

@ -198,7 +198,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
METHOD advanced_submenu. METHOD advanced_submenu.
@ -267,6 +267,11 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
AND msgnr = iv_msgno AND msgnr = iv_msgno
AND sprsl = sy-langu. AND sprsl = sy-langu.
" Don't return any generic messages like `&1 &2 &3 &4`
IF rv_text CO ' 0123456789&'.
CLEAR rv_text.
ENDIF.
ENDMETHOD. ENDMETHOD.
@ -472,15 +477,16 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
iv_msgid = ix_error->if_t100_message~t100key-msgid iv_msgid = ix_error->if_t100_message~t100key-msgid
iv_msgno = ix_error->if_t100_message~t100key-msgno ). iv_msgno = ix_error->if_t100_message~t100key-msgno ).
lv_text = |Message ({ ix_error->if_t100_message~t100key-msgid }/{ ix_error->if_t100_message~t100key-msgno })|. IF lv_title IS NOT INITIAL.
lv_text = |Message ({ ix_error->if_t100_message~t100key-msgid }/{ ix_error->if_t100_message~t100key-msgno })|.
ri_html->add_a(
iv_txt = lv_text
iv_typ = zif_abapgit_html=>c_action_type-sapevent
iv_act = zif_abapgit_definitions=>c_action-goto_message
iv_title = lv_title
iv_id = `a_goto_message` ).
ri_html->add_a(
iv_txt = lv_text
iv_typ = zif_abapgit_html=>c_action_type-sapevent
iv_act = zif_abapgit_definitions=>c_action-goto_message
iv_title = lv_title
iv_id = `a_goto_message` ).
ENDIF.
ENDIF. ENDIF.
ix_error->get_source_position( IMPORTING program_name = lv_program_name ). ix_error->get_source_position( IMPORTING program_name = lv_program_name ).