From 8b0b6999fc16f7ded7159ce2a3923db41ea56448 Mon Sep 17 00:00:00 2001 From: larshp Date: Tue, 17 Jan 2017 16:15:36 +0100 Subject: [PATCH 1/7] Background mode: fix commit text, close #540 --- src/zabapgit_background.prog.abap | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/zabapgit_background.prog.abap b/src/zabapgit_background.prog.abap index 01d643c7c..21fce22bf 100644 --- a/src/zabapgit_background.prog.abap +++ b/src/zabapgit_background.prog.abap @@ -97,6 +97,9 @@ CLASS lcl_background IMPLEMENTATION. APPEND lv_str TO lt_objects. ENDLOOP. + SORT lt_objects AS TEXT. + DELETE ADJACENT DUPLICATES FROM lt_objects. + IF lines( lt_objects ) = 1. rv_comment = |BG: { lv_str }|. ELSE. From 68c51626a3d33e88c8f38a240791a9fbad68aca2 Mon Sep 17 00:00:00 2001 From: larshp Date: Tue, 17 Jan 2017 16:05:23 +0000 Subject: [PATCH 2/7] edit xml - fix dump, close #539 --- src/zabapgit_html_action_utils.prog.abap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/zabapgit_html_action_utils.prog.abap b/src/zabapgit_html_action_utils.prog.abap index 8fd1ed7bb..df57ea389 100644 --- a/src/zabapgit_html_action_utils.prog.abap +++ b/src/zabapgit_html_action_utils.prog.abap @@ -271,8 +271,8 @@ CLASS lcl_html_action_utils IMPLEMENTATION. get_field( EXPORTING name = 'XMLDATA' it = lt_fields CHANGING cv = rs_content-data_str ). IF rs_content-data_str(1) <> '<' AND rs_content-data_str+1(1) = '<'. " Hmmm ??? rs_content-data_str = rs_content-data_str+1. - ELSE. - CLEAR rs_content-data_str. +* ELSE. +* CLEAR rs_content-data_str. ENDIF. ENDMETHOD. "dbcontent_decode From e9c6b5a3d6f3ba1af10378f89856eb8a36335b63 Mon Sep 17 00:00:00 2001 From: larshp Date: Wed, 18 Jan 2017 15:24:57 +0000 Subject: [PATCH 3/7] Only show first 500 objects in list #537 Render only the first 500 objects, as it takes a lot of time to render the html if there are _many_ objects --- src/zabapgit_view_repo.prog.abap | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/zabapgit_view_repo.prog.abap b/src/zabapgit_view_repo.prog.abap index 3de6e6655..5c9cd9b74 100644 --- a/src/zabapgit_view_repo.prog.abap +++ b/src/zabapgit_view_repo.prog.abap @@ -110,6 +110,7 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION. lx_error TYPE REF TO lcx_exception, lv_lstate TYPE char1, lv_rstate TYPE char1, + lv_max TYPE abap_bool, lo_log TYPE REF TO lcl_log. FIELD-SYMBOLS LIKE LINE OF lt_repo_items. @@ -159,11 +160,20 @@ CLASS lcl_gui_view_repo_content IMPLEMENTATION. ro_html->add( render_empty_package( ) ). ELSE. LOOP AT lt_repo_items ASSIGNING . + IF sy-tabix > 500. + lv_max = abap_true. + EXIT. " current loop + ENDIF. ro_html->add( render_item( ) ). ENDLOOP. ENDIF. ro_html->add( '' ). + + IF lv_max = abap_true. + ro_html->add( 'Only first 500 objects shown in list' ). + ENDIF. + ro_html->add( '' ). CATCH lcx_exception INTO lx_error. From b2f3bbf881cc3b46693cd4254d788f088f6a3c03 Mon Sep 17 00:00:00 2001 From: Christian Tapia Sabogal Date: Thu, 19 Jan 2017 00:56:41 -0500 Subject: [PATCH 4/7] Unnecessary "no description" error deleted. --- src/zabapgit_object_susc.prog.abap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/zabapgit_object_susc.prog.abap b/src/zabapgit_object_susc.prog.abap index 5830bc7b4..aa0a07580 100644 --- a/src/zabapgit_object_susc.prog.abap +++ b/src/zabapgit_object_susc.prog.abap @@ -62,7 +62,7 @@ CLASS lcl_object_susc IMPLEMENTATION. WHERE oclss = ms_item-obj_name AND langu = mv_language. IF sy-subrc <> 0. - lcx_exception=>raise( 'TOBCT no english description' ). +* lcx_exception=>raise( 'TOBCT no english description' ). ENDIF. io_xml->add( iv_name = 'TOBC' @@ -127,4 +127,4 @@ CLASS lcl_object_susc IMPLEMENTATION. CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. ENDMETHOD. -ENDCLASS. "lcl_object_susc IMPLEMENTATION \ No newline at end of file +ENDCLASS. "lcl_object_susc IMPLEMENTATION From 7fce8790518710ad20fd22e8a62873361e7dd189 Mon Sep 17 00:00:00 2001 From: Christian Tapia Sabogal Date: Thu, 19 Jan 2017 00:58:24 -0500 Subject: [PATCH 5/7] Unnecessary "no description" error deleted. --- src/zabapgit_object_susc.prog.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/zabapgit_object_susc.prog.abap b/src/zabapgit_object_susc.prog.abap index aa0a07580..21f68b0f5 100644 --- a/src/zabapgit_object_susc.prog.abap +++ b/src/zabapgit_object_susc.prog.abap @@ -62,7 +62,7 @@ CLASS lcl_object_susc IMPLEMENTATION. WHERE oclss = ms_item-obj_name AND langu = mv_language. IF sy-subrc <> 0. -* lcx_exception=>raise( 'TOBCT no english description' ). +* lcx_exception=>raise( 'TOBCT no english description' ). ENDIF. io_xml->add( iv_name = 'TOBC' From cb288beafdc2eefb380a3d28a66193db6071c0f3 Mon Sep 17 00:00:00 2001 From: Christian Tapia Sabogal Date: Thu, 19 Jan 2017 01:53:40 -0500 Subject: [PATCH 6/7] Unnecessary "no description" error deleted #545 --- src/zabapgit_object_susc.prog.abap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/zabapgit_object_susc.prog.abap b/src/zabapgit_object_susc.prog.abap index 21f68b0f5..e0a5be805 100644 --- a/src/zabapgit_object_susc.prog.abap +++ b/src/zabapgit_object_susc.prog.abap @@ -61,9 +61,9 @@ CLASS lcl_object_susc IMPLEMENTATION. SELECT SINGLE * FROM tobct INTO ls_tobct WHERE oclss = ms_item-obj_name AND langu = mv_language. - IF sy-subrc <> 0. +* IF sy-subrc <> 0. * lcx_exception=>raise( 'TOBCT no english description' ). - ENDIF. +* ENDIF. io_xml->add( iv_name = 'TOBC' ig_data = ls_tobc ). From 10b3e3192fda53149dcbb1d10645dcf7ac0e7375 Mon Sep 17 00:00:00 2001 From: larshp Date: Thu, 19 Jan 2017 08:13:59 +0100 Subject: [PATCH 7/7] fix newline should really fix https://github.com/larshp/abapGit/issues/42 sometime soon --- src/zabapgit_object_susc.prog.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/zabapgit_object_susc.prog.abap b/src/zabapgit_object_susc.prog.abap index e0a5be805..615cb27a6 100644 --- a/src/zabapgit_object_susc.prog.abap +++ b/src/zabapgit_object_susc.prog.abap @@ -127,4 +127,4 @@ CLASS lcl_object_susc IMPLEMENTATION. CREATE OBJECT ro_comparison_result TYPE lcl_null_comparison_result. ENDMETHOD. -ENDCLASS. "lcl_object_susc IMPLEMENTATION +ENDCLASS. "lcl_object_susc IMPLEMENTATION \ No newline at end of file