From 1a94c9a0f068947faa4925f70dac52edbefd8f8d Mon Sep 17 00:00:00 2001
From: yellappam <yellappa5237@gmail.com>
Date: Thu, 4 Mar 2021 20:49:44 +1300
Subject: [PATCH] TYPE: Serialize active version (#4593)

* TYPE: Serialize active version

When a new type-pools is created, SAP creates active version by default. SY-SUBRC is always set to 0 for the first function module call as there is always an active version hence, second function will never be called. Remove the second call.

* Multiple changes

Check existence of the object using TADIR entry
If the active object doesn't exist, show proper message

* Existence check using PROGDIR

* Replace SELECT..ENDSELECT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
---
 src/objects/zcl_abapgit_object_type.clas.abap | 49 ++++++-------------
 1 file changed, 16 insertions(+), 33 deletions(-)

diff --git a/src/objects/zcl_abapgit_object_type.clas.abap b/src/objects/zcl_abapgit_object_type.clas.abap
index 7e86658d4..910819e2a 100644
--- a/src/objects/zcl_abapgit_object_type.clas.abap
+++ b/src/objects/zcl_abapgit_object_type.clas.abap
@@ -11,7 +11,7 @@ CLASS zcl_abapgit_object_type DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
     METHODS read
       EXPORTING ev_ddtext TYPE ddtypet-ddtext
                 et_source TYPE abaptxt255_tab
-      RAISING   zcx_abapgit_not_found.
+      RAISING   zcx_abapgit_exception.
 
     METHODS create
       IMPORTING iv_ddtext   TYPE ddtypet-ddtext
@@ -23,7 +23,7 @@ ENDCLASS.
 
 
 
-CLASS zcl_abapgit_object_type IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
 
 
   METHOD create.
@@ -92,23 +92,7 @@ CLASS zcl_abapgit_object_type IMPLEMENTATION.
         reps_not_exist    = 2
         OTHERS            = 3.
     IF sy-subrc <> 0.
-      " Inactive version
-      CALL FUNCTION 'TYPD_GET_OBJECT'
-        EXPORTING
-          typdname          = lv_typdname
-          r3state           = 'I'
-        TABLES
-          psmodisrc         = lt_psmodisrc
-          psmodilog         = lt_psmodilog
-          psource           = et_source
-          ptrdir            = lt_ptrdir
-        EXCEPTIONS
-          version_not_found = 1
-          reps_not_exist    = 2
-          OTHERS            = 3.
-    ENDIF.
-    IF sy-subrc <> 0.
-      RAISE EXCEPTION TYPE zcx_abapgit_not_found.
+      zcx_abapgit_exception=>raise( |No active version found for { ms_item-obj_type } { ms_item-obj_name }| ).
     ENDIF.
 
   ENDMETHOD.
@@ -162,13 +146,17 @@ CLASS zcl_abapgit_object_type IMPLEMENTATION.
 
   METHOD zif_abapgit_object~exists.
 
-    TRY.
-        read( ).
-        rv_bool = abap_true.
-      CATCH zcx_abapgit_not_found
-            zcx_abapgit_exception.
-        rv_bool = abap_false.
-    ENDTRY.
+    DATA: lv_progname TYPE progname,
+          lv_state    TYPE r3state.
+
+    lv_progname = |%_C{ ms_item-obj_name }|.
+    SELECT SINGLE state
+      FROM progdir
+      INTO lv_state
+      WHERE name = lv_progname.
+    IF lv_state IS NOT INITIAL.
+      rv_bool = abap_true.
+    ENDIF.
 
   ENDMETHOD.
 
@@ -209,13 +197,8 @@ CLASS zcl_abapgit_object_type IMPLEMENTATION.
           lt_source TYPE abaptxt255_tab.
 
 
-    TRY.
-        read( IMPORTING
-                ev_ddtext = lv_ddtext
-                et_source = lt_source ).
-      CATCH zcx_abapgit_not_found.
-        RETURN.
-    ENDTRY.
+    read( IMPORTING ev_ddtext = lv_ddtext
+                    et_source = lt_source ).
 
     io_xml->add( iv_name = 'DDTEXT'
                  ig_data = lv_ddtext ).