SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove unnecessary exception (#5856)

Browse Source
This commit is contained in:
Marc Bernard 2022-11-06 10:57:16 -05:00 committed by GitHub
parent 754fe5b5a8
commit 1c236e042d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 39 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/repo/zcl_abapgit_repo_offline.clas.abap
View File

@ -12,7 +12,7 @@ CLASS zcl_abapgit_repo_offline DEFINITION
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS get_name METHODS zif_abapgit_repo~get_name
REDEFINITION . REDEFINITION .
METHODS has_remote_source METHODS has_remote_source
REDEFINITION . REDEFINITION .
@ -28,15 +28,6 @@ ENDCLASS.
CLASS zcl_abapgit_repo_offline IMPLEMENTATION. CLASS zcl_abapgit_repo_offline IMPLEMENTATION.
METHOD get_name.
rv_name = super->get_name( ).
IF rv_name IS INITIAL.
rv_name = ms_data-url.
ENDIF.
ENDMETHOD.
METHOD has_remote_source. METHOD has_remote_source.
rv_yes = boolc( lines( mt_remote ) > 0 ). rv_yes = boolc( lines( mt_remote ) > 0 ).
ENDMETHOD. ENDMETHOD.
@ -63,4 +54,13 @@ CLASS zcl_abapgit_repo_offline IMPLEMENTATION.
METHOD set_name. METHOD set_name.
set( iv_url = iv_url ). set( iv_url = iv_url ).
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_repo~get_name.
rv_name = super->get_name( ).
IF rv_name IS INITIAL.
rv_name = ms_data-url.
ENDIF.
ENDMETHOD.
ENDCLASS. ENDCLASS.

50
src/repo/zcl_abapgit_repo_online.clas.abap
View File

@ -33,9 +33,9 @@ CLASS zcl_abapgit_repo_online DEFINITION
METHODS get_files_remote METHODS zif_abapgit_repo~get_files_remote
REDEFINITION . REDEFINITION .
METHODS get_name METHODS zif_abapgit_repo~get_name
REDEFINITION . REDEFINITION .
METHODS has_remote_source METHODS has_remote_source
REDEFINITION . REDEFINITION .
@ -73,7 +73,8 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_REPO_ONLINE IMPLEMENTATION. CLASS zcl_abapgit_repo_online IMPLEMENTATION.
METHOD fetch_remote. METHOD fetch_remote.
@ -104,23 +105,6 @@ CLASS ZCL_ABAPGIT_REPO_ONLINE IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD get_files_remote.
fetch_remote( ).
rt_files = super->get_files_remote(
ii_obj_filter = ii_obj_filter
iv_ignore_files = iv_ignore_files ).
ENDMETHOD.
METHOD get_name.
rv_name = super->get_name( ).
IF rv_name IS INITIAL.
rv_name = zcl_abapgit_url=>name( ms_data-url ).
rv_name = cl_http_utility=>unescape_url( rv_name ).
ENDIF.
ENDMETHOD.
METHOD get_objects. METHOD get_objects.
fetch_remote( ). fetch_remote( ).
rt_objects = mt_objects. rt_objects = mt_objects.
@ -234,6 +218,11 @@ CLASS ZCL_ABAPGIT_REPO_ONLINE IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_repo_online~get_switched_origin.
rv_switched_origin = ms_data-switched_origin.
ENDMETHOD.
METHOD zif_abapgit_repo_online~get_url. METHOD zif_abapgit_repo_online~get_url.
rv_url = ms_data-url. rv_url = ms_data-url.
ENDMETHOD. ENDMETHOD.
@ -358,7 +347,24 @@ CLASS ZCL_ABAPGIT_REPO_ONLINE IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_repo_online~get_switched_origin.
rv_switched_origin = ms_data-switched_origin. METHOD zif_abapgit_repo~get_files_remote.
fetch_remote( ).
rt_files = super->get_files_remote(
ii_obj_filter = ii_obj_filter
iv_ignore_files = iv_ignore_files ).
ENDMETHOD.
METHOD zif_abapgit_repo~get_name.
rv_name = super->get_name( ).
IF rv_name IS INITIAL.
TRY.
rv_name = zcl_abapgit_url=>name( ms_data-url ).
rv_name = cl_http_utility=>unescape_url( rv_name ).
CATCH zcx_abapgit_exception.
rv_name = 'New online repo'. "unlikely fallback
ENDTRY.
ENDIF.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

4
src/repo/zif_abapgit_repo.intf.abap
View File

@ -8,9 +8,7 @@ INTERFACE zif_abapgit_repo
VALUE(rv_key) TYPE zif_abapgit_persistence=>ty_value . VALUE(rv_key) TYPE zif_abapgit_persistence=>ty_value .
METHODS get_name METHODS get_name
RETURNING RETURNING
VALUE(rv_name) TYPE string VALUE(rv_name) TYPE string.
RAISING
zcx_abapgit_exception .
METHODS is_offline METHODS is_offline
RETURNING RETURNING
VALUE(rv_offline) TYPE abap_bool . VALUE(rv_offline) TYPE abap_bool .