diff --git a/src/apack/zcl_abapgit_apack_migration.clas.abap b/src/apack/zcl_abapgit_apack_migration.clas.abap index 885b479af..e3ac8239e 100644 --- a/src/apack/zcl_abapgit_apack_migration.clas.abap +++ b/src/apack/zcl_abapgit_apack_migration.clas.abap @@ -178,7 +178,7 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE' EXPORTING diff --git a/src/cts/zcl_abapgit_cts_api.clas.abap b/src/cts/zcl_abapgit_cts_api.clas.abap index 0892d56f5..0ef490902 100644 --- a/src/cts/zcl_abapgit_cts_api.clas.abap +++ b/src/cts/zcl_abapgit_cts_api.clas.abap @@ -623,7 +623,7 @@ CLASS zcl_abapgit_cts_api IMPLEMENTATION. ev_object = ls_list-object ev_obj_name = ls_list-obj_name ). INSERT ls_list INTO TABLE rt_list. - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDCASE. ENDLOOP. diff --git a/src/data/zcl_abapgit_data_utils.clas.abap b/src/data/zcl_abapgit_data_utils.clas.abap index 91da50dd8..b205f93d4 100644 --- a/src/data/zcl_abapgit_data_utils.clas.abap +++ b/src/data/zcl_abapgit_data_utils.clas.abap @@ -49,7 +49,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_DATA_UTILS IMPLEMENTATION. +CLASS zcl_abapgit_data_utils IMPLEMENTATION. METHOD build_config_filename. @@ -196,7 +196,7 @@ CLASS ZCL_ABAPGIT_DATA_UTILS IMPLEMENTATION. db_not_exists = 3 no_permission = 4 no_change_allowed = 5 - table_is_gtt = 6 +* table_is_gtt = 6 " not in lower releases OTHERS = 7. IF sy-subrc <> 0. zcx_abapgit_exception=>raise( |Table { is_item-obj_name } cannot be displayed| ). diff --git a/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap b/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap index 6d731a02f..dadea98c5 100644 --- a/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap +++ b/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap @@ -50,7 +50,7 @@ CLASS zcl_abapgit_pr_enumerator IMPLEMENTATION. mv_repo_url = to_lower( iv_url ). TRY. mi_enum_provider = create_provider( mv_repo_url ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDMETHOD. diff --git a/src/inspect/zcl_abapgit_where_used_tools.clas.abap b/src/inspect/zcl_abapgit_where_used_tools.clas.abap index d99572336..14d13ef11 100644 --- a/src/inspect/zcl_abapgit_where_used_tools.clas.abap +++ b/src/inspect/zcl_abapgit_where_used_tools.clas.abap @@ -124,7 +124,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_WHERE_USED_TOOLS IMPLEMENTATION. +CLASS zcl_abapgit_where_used_tools IMPLEMENTATION. METHOD build_package_scope. @@ -311,7 +311,7 @@ CLASS ZCL_ABAPGIT_WHERE_USED_TOOLS IMPLEMENTATION. not_enough_input = 1 no_function_pool = 2 delimiter_wrong_position = 3 - OTHERS = 4. + OTHERS = 4 ##FM_SUBRC_OK. IF lv_area IS INITIAL. SELECT SINGLE master FROM d010inc INTO lv_program @@ -325,7 +325,7 @@ CLASS ZCL_ABAPGIT_WHERE_USED_TOOLS IMPLEMENTATION. not_enough_input = 1 no_function_pool = 2 delimiter_wrong_position = 3 - OTHERS = 4. + OTHERS = 4 ##FM_SUBRC_OK. ENDIF. IF lv_area IS NOT INITIAL. diff --git a/src/objects/core/zcl_abapgit_dependencies.clas.abap b/src/objects/core/zcl_abapgit_dependencies.clas.abap index 2d76f2320..3c6c3523a 100644 --- a/src/objects/core/zcl_abapgit_dependencies.clas.abap +++ b/src/objects/core/zcl_abapgit_dependencies.clas.abap @@ -61,7 +61,7 @@ CLASS zcl_abapgit_dependencies IMPLEMENTATION. INSERT ls_ddls_name INTO TABLE lt_ddls_name. PERFORM ('DDLS_GET_DEP') IN PROGRAM ('RADMASDL') - TABLES lt_ddls_name rt_dependency. + TABLES lt_ddls_name rt_dependency ##PERF_NO_FORM. ENDMETHOD. diff --git a/src/objects/core/zcl_abapgit_objects_activation.clas.abap b/src/objects/core/zcl_abapgit_objects_activation.clas.abap index 833f456b7..09d549be6 100644 --- a/src/objects/core/zcl_abapgit_objects_activation.clas.abap +++ b/src/objects/core/zcl_abapgit_objects_activation.clas.abap @@ -310,7 +310,7 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION. excecution_error = 1 cancelled = 2 insert_into_corr_error = 3 - OTHERS = 4 ##SUBRC_OK. + OTHERS = 4 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'RS_WORKING_OBJECTS_ACTIVATE' EXPORTING @@ -324,7 +324,7 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION. excecution_error = 1 cancelled = 2 insert_into_corr_error = 3 - OTHERS = 4 ##SUBRC_OK. + OTHERS = 4 ##FM_SUBRC_OK. ENDTRY. CASE sy-subrc. WHEN 1 OR 3 OR 4. diff --git a/src/objects/core/zcl_abapgit_serialize.clas.abap b/src/objects/core/zcl_abapgit_serialize.clas.abap index 21dae0a50..fc4ad0c95 100644 --- a/src/objects/core/zcl_abapgit_serialize.clas.abap +++ b/src/objects/core/zcl_abapgit_serialize.clas.abap @@ -432,7 +432,7 @@ CLASS zcl_abapgit_serialize IMPLEMENTATION. METHOD filter_unsupported_objects. DATA: ls_unsupported_count TYPE ty_unsupported_count, - lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt, + lt_supported_types TYPE zif_abapgit_objects=>ty_types_tt, lt_unsupported_count TYPE ty_unsupported_count_tt. FIELD-SYMBOLS: LIKE LINE OF ct_tadir, diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap index e4244297e..a6768c13e 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap @@ -66,7 +66,7 @@ CLASS zcl_abapgit_ecatt_helper IMPLEMENTATION. lv_text = lx_ecatt->get_text( ). zcx_abapgit_exception=>raise( lv_text ). " note, exception cx_ecatt_ui_attachment doesn't exist in 702 - CATCH cx_ecatt. + CATCH cx_ecatt ##NO_HANDLER. "will never be raised from download, when called with mv_generate_xml_no_download = 'X'. ENDTRY. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap index 03b6a0eeb..175e3544a 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap @@ -25,7 +25,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION. +CLASS zcl_abapgit_ecatt_sp_download IMPLEMENTATION. METHOD download. @@ -93,7 +93,7 @@ CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION. CALL METHOD lo_ecatt_sp->('GET_SP_ATTRIBUTES') IMPORTING e_sp_xml = lv_sp_xml. - CATCH cx_ecatt_apl. + CATCH cx_ecatt_apl ##NO_HANDLER. ENDTRY. CALL FUNCTION 'SDIXML_XML_TO_DOM' diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap index fab1f31f8..2874dfbf7 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap @@ -27,7 +27,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION. +CLASS zcl_abapgit_ecatt_sp_upload IMPLEMENTATION. METHOD get_ecatt_sp. @@ -129,7 +129,6 @@ CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION. ENDTRY. ASSIGN ecatt_object TO . - ASSERT sy-subrc = 0. lo_ecatt_sp = . @@ -162,13 +161,12 @@ CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION. CATCH cx_ecatt_apl INTO lx_ecatt. lv_exc_occ = 'X'. ENDTRY. -* Devesh,C5129871 18.07.2011 Releasing enqueue after uploading -*begin + " Releasing enqueue after uploading TRY. ecatt_object->close_object( im_suppress_events = 'X' ). - CATCH cx_ecatt_apl INTO lx_ecatt. + CATCH cx_ecatt_apl INTO lx_ecatt ##NO_HANDLER. ENDTRY. -*end + * get devclass from existing object TRY. cl_apl_ecatt_object=>get_tadir_entry( diff --git a/src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap b/src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap index 7eceedf0b..206100054 100644 --- a/src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap +++ b/src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap @@ -62,7 +62,7 @@ CLASS zcl_abapgit_object_enho_clif IMPLEMENTATION. TRY. io_clif->add_change_enha_type( type_line = ls_type_line ). CATCH cx_enh_mod_not_allowed - cx_enh_is_not_enhanceable. + cx_enh_is_not_enhanceable ##NO_HANDLER. " TODO ENDTRY. ENDLOOP. diff --git a/src/objects/oo/zcl_abapgit_oo_class.clas.abap b/src/objects/oo/zcl_abapgit_oo_class.clas.abap index 7d7091a3b..ad60369bb 100644 --- a/src/objects/oo/zcl_abapgit_oo_class.clas.abap +++ b/src/objects/oo/zcl_abapgit_oo_class.clas.abap @@ -611,7 +611,7 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE' EXPORTING @@ -628,7 +628,7 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. ENDTRY. IF sy-subrc <> 0. zcx_abapgit_exception=>raise_t100( ). @@ -998,5 +998,4 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION. zcx_abapgit_exception=>raise( |Class { ls_clskey-clsname } has syntax errors | ). ENDIF. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/oo/zcl_abapgit_oo_interface.clas.abap b/src/objects/oo/zcl_abapgit_oo_interface.clas.abap index a4852bee2..2715e70ac 100644 --- a/src/objects/oo/zcl_abapgit_oo_interface.clas.abap +++ b/src/objects/oo/zcl_abapgit_oo_interface.clas.abap @@ -212,7 +212,7 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE' EXPORTING @@ -229,7 +229,7 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. ENDTRY. IF sy-subrc <> 0. zcx_abapgit_exception=>raise_t100( ). @@ -368,5 +368,4 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION. zcx_abapgit_exception=>raise( |Interface { ls_intkey-clsname } has syntax errors | ). ENDIF. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/oo/zcl_abapgit_oo_serializer.clas.abap b/src/objects/oo/zcl_abapgit_oo_serializer.clas.abap index d90d1fc6f..bf55ef56a 100644 --- a/src/objects/oo/zcl_abapgit_oo_serializer.clas.abap +++ b/src/objects/oo/zcl_abapgit_oo_serializer.clas.abap @@ -151,7 +151,7 @@ CLASS zcl_abapgit_oo_serializer IMPLEMENTATION. lv_program = ls_include. TRY. lt_source = zcl_abapgit_factory=>get_sap_report( )->read_report( lv_program ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. * ignore if the report is not found, sometimes the CCDEF include does not exist ENDTRY. rt_source = lt_source. diff --git a/src/objects/sap/zcl_abapgit_sap_report.clas.abap b/src/objects/sap/zcl_abapgit_sap_report.clas.abap index 4f0bfaa2c..4f229d659 100644 --- a/src/objects/sap/zcl_abapgit_sap_report.clas.abap +++ b/src/objects/sap/zcl_abapgit_sap_report.clas.abap @@ -47,7 +47,7 @@ CLASS zcl_abapgit_sap_report IMPLEMENTATION. no_show_permission = 7 permission_failure = 8 request_language_denied = 9 - OTHERS = 10. + OTHERS = 10 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'RS_ACCESS_PERMISSION' EXPORTING @@ -67,7 +67,7 @@ CLASS zcl_abapgit_sap_report IMPLEMENTATION. no_show_permission = 7 permission_failure = 8 request_language_denied = 9 - OTHERS = 10. + OTHERS = 10 ##FM_SUBRC_OK. ENDTRY. IF sy-subrc <> 0. zcx_abapgit_exception=>raise_t100( ). diff --git a/src/objects/tabl/zcl_abapgit_object_tabl_ddl.clas.abap b/src/objects/tabl/zcl_abapgit_object_tabl_ddl.clas.abap index ca9222106..4e9740f3c 100644 --- a/src/objects/tabl/zcl_abapgit_object_tabl_ddl.clas.abap +++ b/src/objects/tabl/zcl_abapgit_object_tabl_ddl.clas.abap @@ -103,7 +103,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_OBJECT_TABL_DDL IMPLEMENTATION. +CLASS zcl_abapgit_object_tabl_ddl IMPLEMENTATION. METHOD deserialize. @@ -158,9 +158,9 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL_DDL IMPLEMENTATION. start TYPE i VALUE 0, colon TYPE i VALUE 1, type TYPE i VALUE 2, - aftertype TYPE i VALUE 2, - null TYPE i VALUE 2, - afternull TYPE i VALUE 2, + aftertype TYPE i VALUE 3, + null TYPE i VALUE 4, + afternull TYPE i VALUE 5, END OF lc_mode. DATA lv_field TYPE string. diff --git a/src/objects/zcl_abapgit_object_aifc.clas.abap b/src/objects/zcl_abapgit_object_aifc.clas.abap index e54a12d16..55dc58237 100644 --- a/src/objects/zcl_abapgit_object_aifc.clas.abap +++ b/src/objects/zcl_abapgit_object_aifc.clas.abap @@ -383,7 +383,7 @@ CLASS zcl_abapgit_object_aifc IMPLEMENTATION. packages = '' ). CATCH cx_abap_not_a_table INTO lx_abap_not_a_table. zcx_abapgit_exception=>raise_with_text( lx_abap_not_a_table ). - CATCH cx_abap_not_in_package. + CATCH cx_abap_not_in_package ##NO_HANDLER. "that's fine ENDTRY. diff --git a/src/objects/zcl_abapgit_object_auth.clas.abap b/src/objects/zcl_abapgit_object_auth.clas.abap index 4241eec8b..462cd5e2b 100644 --- a/src/objects/zcl_abapgit_object_auth.clas.abap +++ b/src/objects/zcl_abapgit_object_auth.clas.abap @@ -159,7 +159,7 @@ CLASS zcl_abapgit_object_auth IMPLEMENTATION. CALL FUNCTION 'SU20_MAINTAIN_SNGL' EXPORTING id_field = mv_fieldname - id_wbo_mode = abap_false. + id_wbo_mode = abap_false ##EXISTS. rv_exit = abap_true. ENDIF. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_cmpt.clas.abap b/src/objects/zcl_abapgit_object_cmpt.clas.abap index 3d0a0a710..a20b5cc56 100644 --- a/src/objects/zcl_abapgit_object_cmpt.clas.abap +++ b/src/objects/zcl_abapgit_object_cmpt.clas.abap @@ -38,6 +38,7 @@ CLASS zcl_abapgit_object_cmpt IMPLEMENTATION. r_ref_db_access = mo_cmp_db. CATCH cx_root. + zcx_abapgit_exception=>raise( 'CMPT not supported' ). ENDTRY. mv_name = ms_item-obj_name. diff --git a/src/objects/zcl_abapgit_object_doma.clas.abap b/src/objects/zcl_abapgit_object_doma.clas.abap index 8bc1f7280..79e6860a2 100644 --- a/src/objects/zcl_abapgit_object_doma.clas.abap +++ b/src/objects/zcl_abapgit_object_doma.clas.abap @@ -43,7 +43,7 @@ CLASS zcl_abapgit_object_doma DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje METHODS handle_dependencies IMPORTING - !iv_step TYPE zif_abapgit_definitions=>ty_deserialization_step + !iv_step TYPE zif_abapgit_objects=>ty_deserialization_step CHANGING !cv_exit TYPE dd01v-convexit !cv_done TYPE abap_bool. diff --git a/src/objects/zcl_abapgit_object_fugr.clas.abap b/src/objects/zcl_abapgit_object_fugr.clas.abap index 9dc0c1406..d4661d869 100644 --- a/src/objects/zcl_abapgit_object_fugr.clas.abap +++ b/src/objects/zcl_abapgit_object_fugr.clas.abap @@ -786,7 +786,8 @@ CLASS zcl_abapgit_object_fugr IMPLEMENTATION. CHANGING include = lv_include EXCEPTIONS - OTHERS = 1. + OTHERS = 1 ##FM_SUBRC_OK. + IF lv_function_group(1) = 'X'. " "EXIT"-function-module ls_tadir-object = 'FUGS'. ENDIF. diff --git a/src/objects/zcl_abapgit_object_iext.clas.abap b/src/objects/zcl_abapgit_object_iext.clas.abap index e0f681080..712bbf900 100644 --- a/src/objects/zcl_abapgit_object_iext.clas.abap +++ b/src/objects/zcl_abapgit_object_iext.clas.abap @@ -53,8 +53,9 @@ CLASS zcl_abapgit_object_iext IMPLEMENTATION. pe_attributes = ls_attributes EXCEPTIONS OTHERS = 1. - - rv_user = ls_attributes-plast. + IF sy-subrc = 0. + rv_user = ls_attributes-plast. + ENDIF. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iobj.clas.abap b/src/objects/zcl_abapgit_object_iobj.clas.abap index ae70908a1..ed1d4f4da 100644 --- a/src/objects/zcl_abapgit_object_iobj.clas.abap +++ b/src/objects/zcl_abapgit_object_iobj.clas.abap @@ -61,7 +61,7 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION. iobj_not_found = 1 illegal_input = 2 bct_comp_invalid = 3 - not_authorized = 4 +* not_authorized = 4 " not in lower releases OTHERS = 5. IF sy-subrc = 0. ASSIGN COMPONENT 'TSTPNM' OF STRUCTURE TO . @@ -200,36 +200,67 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION. ASSERT sy-subrc = 0. IF zif_abapgit_object~exists( ) = abap_false. - CALL FUNCTION 'BAPI_IOBJ_CREATE' - EXPORTING - details = - IMPORTING - return = ls_return - TABLES - compounds = - attributes = - navigationattributes = - atrnavinfoprovider = - hierarchycharacteristics = - elimination = - hanafieldsmapping = - xxlattributes = . + TRY. + CALL FUNCTION 'BAPI_IOBJ_CREATE' + EXPORTING + details = + IMPORTING + return = ls_return + TABLES + compounds = + attributes = + navigationattributes = + atrnavinfoprovider = + hierarchycharacteristics = + elimination = + hanafieldsmapping = + xxlattributes = ##ARG_OK. + CATCH cx_sy_dyn_call_param_not_found. + CALL FUNCTION 'BAPI_IOBJ_CREATE' + EXPORTING + details = + IMPORTING + return = ls_return + TABLES + compounds = + attributes = + navigationattributes = + atrnavinfoprovider = + hierarchycharacteristics = + elimination = . + ENDTRY. ELSE. - CALL FUNCTION 'BAPI_IOBJ_CHANGE' - EXPORTING - infoobject = - details = - IMPORTING - return = ls_return - TABLES - compounds = - attributes = - navigationattributes = - atrnavinfoprovider = - hierarchycharacteristics = - elimination = - hanafieldsmapping = - xxlattributes = . + TRY. + CALL FUNCTION 'BAPI_IOBJ_CHANGE' + EXPORTING + infoobject = + details = + IMPORTING + return = ls_return + TABLES + compounds = + attributes = + navigationattributes = + atrnavinfoprovider = + hierarchycharacteristics = + elimination = + hanafieldsmapping = + xxlattributes = ##ARG_OK. + CATCH cx_sy_dyn_call_param_not_found. + CALL FUNCTION 'BAPI_IOBJ_CHANGE' + EXPORTING + infoobject = + details = + IMPORTING + return = ls_return + TABLES + compounds = + attributes = + navigationattributes = + atrnavinfoprovider = + hierarchycharacteristics = + elimination = . + ENDTRY. ENDIF. IF ls_return-type = 'E'. @@ -409,21 +440,37 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION. lv_iobjnam = ms_item-obj_name. - CALL FUNCTION 'BAPI_IOBJ_GETDETAIL' - EXPORTING - infoobject = lv_iobjnam - IMPORTING - details = - return = ls_return - TABLES - compounds = - attributes = - navigationattributes = - atrnavinfoprovider = - hierarchycharacteristics = - elimination = - hanafieldsmapping = - xxlattributes = . + TRY. + CALL FUNCTION 'BAPI_IOBJ_GETDETAIL' + EXPORTING + infoobject = lv_iobjnam + IMPORTING + details = + return = ls_return + TABLES + compounds = + attributes = + navigationattributes = + atrnavinfoprovider = + hierarchycharacteristics = + elimination = + hanafieldsmapping = + xxlattributes = ##ARG_OK. + CATCH cx_sy_dyn_call_param_not_found. + CALL FUNCTION 'BAPI_IOBJ_GETDETAIL' + EXPORTING + infoobject = lv_iobjnam + IMPORTING + details = + return = ls_return + TABLES + compounds = + attributes = + navigationattributes = + atrnavinfoprovider = + hierarchycharacteristics = + elimination = . + ENDTRY. IF ls_return-type = 'E'. zcx_abapgit_exception=>raise( |Error getting details of InfoObject: { ls_return-message }| ). diff --git a/src/objects/zcl_abapgit_object_iwpr.clas.abap b/src/objects/zcl_abapgit_object_iwpr.clas.abap index 1701dc6ec..a0251fce3 100644 --- a/src/objects/zcl_abapgit_object_iwpr.clas.abap +++ b/src/objects/zcl_abapgit_object_iwpr.clas.abap @@ -124,7 +124,11 @@ CLASS zcl_abapgit_object_iwpr IMPLEMENTATION. METHOD zif_abapgit_object~jump. - SUBMIT /iwbep/r_sbui_service_builder + DATA lv_prog TYPE progname. + + lv_prog = '/IWBEP/R_SBUI_SERVICE_BUILDER'. + + SUBMIT (lv_prog) WITH i_prname = ms_item-obj_name AND RETURN. diff --git a/src/objects/zcl_abapgit_object_iwvb.clas.abap b/src/objects/zcl_abapgit_object_iwvb.clas.abap index 78b21145d..e2405e71a 100644 --- a/src/objects/zcl_abapgit_object_iwvb.clas.abap +++ b/src/objects/zcl_abapgit_object_iwvb.clas.abap @@ -131,7 +131,11 @@ CLASS zcl_abapgit_object_iwvb IMPLEMENTATION. METHOD zif_abapgit_object~jump. - SUBMIT /iwbep/r_dst_vocan_register + DATA lv_prog TYPE progname. + + lv_prog = '/IWBEP/R_DST_VOCAN_REGISTER'. + + SUBMIT (lv_prog) WITH ip_aname = ms_item-obj_name WITH ip_avers = ms_item-obj_name+32(4) AND RETURN. diff --git a/src/objects/zcl_abapgit_object_oa2p.clas.abap b/src/objects/zcl_abapgit_object_oa2p.clas.abap index 3a2d26068..d4cb699d0 100644 --- a/src/objects/zcl_abapgit_object_oa2p.clas.abap +++ b/src/objects/zcl_abapgit_object_oa2p.clas.abap @@ -90,7 +90,7 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION. "authority check AUTHORITY-CHECK OBJECT 'S_OA2C_ADM' - ID 'ACTVT' FIELD lc_actvt. + ID 'ACTVT' FIELD lc_actvt ##AUTH_OBJ_OK. IF sy-subrc <> 0. MESSAGE e463(01) WITH mv_profile INTO zcx_abapgit_exception=>null. zcx_abapgit_exception=>raise_t100( ). @@ -104,7 +104,7 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION. CALL METHOD lo_persist->('IF_WB_OBJECT_PERSIST~DELETE') EXPORTING p_object_key = lv_profile_key. " Object Key - CATCH cx_swb_object_does_not_exist. + CATCH cx_swb_object_does_not_exist ##NO_HANDLER. CATCH cx_swb_exception. zcx_abapgit_exception=>raise( |Error when deleting OAuth2 Profile { lv_profile_key }.| ). ENDTRY. diff --git a/src/objects/zcl_abapgit_object_otgr.clas.abap b/src/objects/zcl_abapgit_object_otgr.clas.abap index 73e22c19a..cd5108d74 100644 --- a/src/objects/zcl_abapgit_object_otgr.clas.abap +++ b/src/objects/zcl_abapgit_object_otgr.clas.abap @@ -137,7 +137,7 @@ CLASS zcl_abapgit_object_otgr IMPLEMENTATION. TRY. CREATE DATA lo_parents TYPE TABLE OF ('CLS_TYGR_PARENT'). ASSIGN lo_parents->* TO . - CATCH cx_sy_create_data_error. + CATCH cx_sy_create_data_error ##NO_HANDLER. ENDTRY. IF IS ASSIGNED. @@ -288,7 +288,7 @@ CLASS zcl_abapgit_object_otgr IMPLEMENTATION. TRY. CREATE DATA lo_parents TYPE TABLE OF ('CLS_TYGR_PARENT'). ASSIGN lo_parents->* TO . - CATCH cx_sy_create_data_error. + CATCH cx_sy_create_data_error ##NO_HANDLER. ENDTRY. TRY. diff --git a/src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap b/src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap index e8ccc60e4..d21fb9742 100644 --- a/src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap +++ b/src/objects/zcl_abapgit_object_pdts.clas.locals_imp.abap @@ -172,7 +172,7 @@ CLASS lcl_task_definition IMPLEMENTATION. IF sy-subrc <> 0. TRY. li_container->element_remove( name = lv_element ). - CATCH cx_swf_cnt_container. + CATCH cx_swf_cnt_container ##NO_HANDLER. "Shouldn't happen, doesn't matter if it does ENDTRY. ENDIF. diff --git a/src/objects/zcl_abapgit_object_pdxx_super.clas.abap b/src/objects/zcl_abapgit_object_pdxx_super.clas.abap index 004a4b501..3b066e968 100644 --- a/src/objects/zcl_abapgit_object_pdxx_super.clas.abap +++ b/src/objects/zcl_abapgit_object_pdxx_super.clas.abap @@ -77,7 +77,7 @@ CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION. enqueue_failed = 1 object_not_deleted = 2 object_not_found = 3 - OTHERS = 4. "#EC SUBRC_OK + OTHERS = 4 ##FM_SUBRC_OK. check_subrc_for( `RH_HRSOBJECT_DELETE` ). diff --git a/src/objects/zcl_abapgit_object_scp1.clas.abap b/src/objects/zcl_abapgit_object_scp1.clas.abap index 00bfe1355..b31918f1a 100644 --- a/src/objects/zcl_abapgit_object_scp1.clas.abap +++ b/src/objects/zcl_abapgit_object_scp1.clas.abap @@ -486,7 +486,8 @@ CLASS zcl_abapgit_object_scp1 IMPLEMENTATION. TABLES texts = ls_scp1-scprtext EXCEPTIONS - no_text_found = 1. + no_text_found = 1 + OTHERS = 2 ##FM_SUBRC_OK. IF ls_scp1-scprattr-type = 'TMP'. load_hier( CHANGING cs_scp1 = ls_scp1 ). diff --git a/src/objects/zcl_abapgit_object_sfpf.clas.abap b/src/objects/zcl_abapgit_object_sfpf.clas.abap index 29564ada8..908114251 100644 --- a/src/objects/zcl_abapgit_object_sfpf.clas.abap +++ b/src/objects/zcl_abapgit_object_sfpf.clas.abap @@ -134,7 +134,7 @@ CLASS zcl_abapgit_object_sfpf IMPLEMENTATION. TRY. rv_xstr = cl_fp_helper=>convert_form_to_xstring( li_fp_form ). - CATCH cx_fp_api INTO lx_fp_conv_err. + CATCH cx_fp_api INTO lx_fp_conv_err ##NO_HANDLER. " Pass - the exception is handled below! ENDTRY. diff --git a/src/objects/zcl_abapgit_object_shlp.clas.abap b/src/objects/zcl_abapgit_object_shlp.clas.abap index 02dd0c9b6..c4b800b8b 100644 --- a/src/objects/zcl_abapgit_object_shlp.clas.abap +++ b/src/objects/zcl_abapgit_object_shlp.clas.abap @@ -7,7 +7,7 @@ CLASS zcl_abapgit_object_shlp DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje METHODS handle_dependencies IMPORTING - !iv_step TYPE zif_abapgit_definitions=>ty_deserialization_step + !iv_step TYPE zif_abapgit_objects=>ty_deserialization_step CHANGING !cv_exit TYPE dd30v-selmexit !cv_done TYPE abap_bool. diff --git a/src/objects/zcl_abapgit_object_ueno.clas.abap b/src/objects/zcl_abapgit_object_ueno.clas.abap index 079ac07ac..d23a46759 100644 --- a/src/objects/zcl_abapgit_object_ueno.clas.abap +++ b/src/objects/zcl_abapgit_object_ueno.clas.abap @@ -569,7 +569,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION. header = ls_docu-header content = ls_docu-content itf = ls_docu-itf - pstatus = lv_error_status. + pstatus = lv_error_status ##ARG_OK. CHECK lv_error_status = 'S'. "Success diff --git a/src/objects/zcl_abapgit_object_wdca.clas.abap b/src/objects/zcl_abapgit_object_wdca.clas.abap index f5f8a1276..fd041d6fc 100644 --- a/src/objects/zcl_abapgit_object_wdca.clas.abap +++ b/src/objects/zcl_abapgit_object_wdca.clas.abap @@ -303,7 +303,7 @@ CLASS zcl_abapgit_object_wdca IMPLEMENTATION. WHERE config_id = ls_outline-config_id AND config_type = ls_outline-config_type AND config_var = ls_outline-config_var. - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. " File not found ENDTRY. diff --git a/src/objects/zcl_abapgit_object_xinx.clas.abap b/src/objects/zcl_abapgit_object_xinx.clas.abap index 305e7cef9..020901d8c 100644 --- a/src/objects/zcl_abapgit_object_xinx.clas.abap +++ b/src/objects/zcl_abapgit_object_xinx.clas.abap @@ -100,7 +100,7 @@ CLASS zcl_abapgit_object_xinx IMPLEMENTATION. suppress_transport = 'X' EXCEPTIONS no_docu_found = 1 - OTHERS = 2. + OTHERS = 2 ##FM_SUBRC_OK. ENDMETHOD. @@ -317,6 +317,9 @@ CLASS zcl_abapgit_object_xinx IMPLEMENTATION. EXCEPTIONS illegal_input = 1 OTHERS = 2. + IF sy-subrc <> 0. + zcx_abapgit_exception=>raise( 'Error reading index' ). + ENDIF. rv_bool = boolc( ls_dd12v IS NOT INITIAL ). diff --git a/src/objects/zcl_abapgit_objects.clas.abap b/src/objects/zcl_abapgit_objects.clas.abap index 218529719..3c82e136e 100644 --- a/src/objects/zcl_abapgit_objects.clas.abap +++ b/src/objects/zcl_abapgit_objects.clas.abap @@ -4,9 +4,6 @@ CLASS zcl_abapgit_objects DEFINITION PUBLIC SECTION. - TYPES: - ty_types_tt TYPE SORTED TABLE OF tadir-object WITH UNIQUE KEY table_line . - CLASS-METHODS serialize IMPORTING !is_item TYPE zif_abapgit_definitions=>ty_item @@ -71,7 +68,7 @@ CLASS zcl_abapgit_objects DEFINITION VALUE(rv_bool) TYPE abap_bool . CLASS-METHODS supported_list RETURNING - VALUE(rt_types) TYPE ty_types_tt . + VALUE(rt_types) TYPE zif_abapgit_objects=>ty_types_tt. CLASS-METHODS is_active IMPORTING !is_item TYPE zif_abapgit_definitions=>ty_item @@ -663,7 +660,7 @@ CLASS zcl_abapgit_objects IMPLEMENTATION. li_progress TYPE REF TO zif_abapgit_progress, lv_path TYPE string, lt_items TYPE zif_abapgit_definitions=>ty_items_tt, - lt_steps_id TYPE zif_abapgit_definitions=>ty_deserialization_step_tt, + lt_steps_id TYPE zif_abapgit_objects=>ty_deserialization_step_tt, lt_steps TYPE zif_abapgit_objects=>ty_step_data_tt, lx_exc TYPE REF TO zcx_abapgit_exception. DATA lo_folder_logic TYPE REF TO zcl_abapgit_folder_logic. @@ -672,7 +669,7 @@ CLASS zcl_abapgit_objects IMPLEMENTATION. DATA lo_abap_language_vers TYPE REF TO zcl_abapgit_abap_language_vers. FIELD-SYMBOLS: TYPE zif_abapgit_definitions=>ty_result, - TYPE LINE OF zif_abapgit_definitions=>ty_deserialization_step_tt, + TYPE LINE OF zif_abapgit_objects=>ty_deserialization_step_tt, TYPE LINE OF zif_abapgit_objects=>ty_step_data_tt, TYPE LINE OF zif_abapgit_objects=>ty_deserialization_tt. diff --git a/src/objects/zcl_abapgit_objects.clas.testclasses.abap b/src/objects/zcl_abapgit_objects.clas.testclasses.abap index ae2704279..5d29ba4e6 100644 --- a/src/objects/zcl_abapgit_objects.clas.testclasses.abap +++ b/src/objects/zcl_abapgit_objects.clas.testclasses.abap @@ -29,7 +29,7 @@ CLASS ltcl_object_types IMPLEMENTATION. DATA: ls_item TYPE zif_abapgit_definitions=>ty_item, lv_exists TYPE abap_bool, - lt_types TYPE zcl_abapgit_objects=>ty_types_tt. + lt_types TYPE zif_abapgit_objects=>ty_types_tt. FIELD-SYMBOLS: LIKE LINE OF lt_types. diff --git a/src/objects/zcl_abapgit_objects_program.clas.abap b/src/objects/zcl_abapgit_objects_program.clas.abap index fc75e7f71..f4266aae9 100644 --- a/src/objects/zcl_abapgit_objects_program.clas.abap +++ b/src/objects/zcl_abapgit_objects_program.clas.abap @@ -650,7 +650,7 @@ CLASS zcl_abapgit_objects_program IMPLEMENTATION. cancelled = 2 name_not_allowed = 3 permission_error = 4 - OTHERS = 5. + OTHERS = 5 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'RPY_PROGRAM_INSERT' EXPORTING @@ -667,7 +667,7 @@ CLASS zcl_abapgit_objects_program IMPLEMENTATION. cancelled = 2 name_not_allowed = 3 permission_error = 4 - OTHERS = 5. + OTHERS = 5 ##FM_SUBRC_OK. ENDTRY. IF sy-subrc = 3. diff --git a/src/objects/zcl_abapgit_objects_super.clas.abap b/src/objects/zcl_abapgit_objects_super.clas.abap index c6b6d0382..3ad0a10c5 100644 --- a/src/objects/zcl_abapgit_objects_super.clas.abap +++ b/src/objects/zcl_abapgit_objects_super.clas.abap @@ -191,7 +191,7 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION. object_not_specified = 3 permission_failure = 4 dialog_needed = 5 - OTHERS = 6. + OTHERS = 6 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. TRY. " try to force deletion for APPENDs @@ -207,7 +207,7 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION. object_not_specified = 3 permission_failure = 4 dialog_needed = 5 - OTHERS = 6. + OTHERS = 6 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. " no_ask_delete_append and aie_force_deletion not available in lower releases CALL FUNCTION 'RS_DD_DELETE_OBJ' @@ -221,7 +221,7 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION. object_not_specified = 3 permission_failure = 4 dialog_needed = 5 - OTHERS = 6. + OTHERS = 6 ##FM_SUBRC_OK. ENDTRY. ENDTRY. diff --git a/src/objects/zif_abapgit_object.intf.abap b/src/objects/zif_abapgit_object.intf.abap index b2a4b7121..24d938fbb 100644 --- a/src/objects/zif_abapgit_object.intf.abap +++ b/src/objects/zif_abapgit_object.intf.abap @@ -1,12 +1,11 @@ -INTERFACE zif_abapgit_object - PUBLIC . +INTERFACE zif_abapgit_object PUBLIC. CONSTANTS: BEGIN OF gc_step_id, - early TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `EARLY`, - abap TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `ABAP`, - ddic TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `DDIC`, - late TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `LATE`, + early TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'EARLY', + abap TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'ABAP', + ddic TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'DDIC', + late TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'LATE', END OF gc_step_id. METHODS serialize @@ -19,7 +18,7 @@ INTERFACE zif_abapgit_object IMPORTING !iv_package TYPE devclass !io_xml TYPE REF TO zif_abapgit_xml_input - !iv_step TYPE zif_abapgit_definitions=>ty_deserialization_step + !iv_step TYPE zif_abapgit_objects=>ty_deserialization_step !ii_log TYPE REF TO zif_abapgit_log !iv_transport TYPE trkorr RAISING @@ -78,7 +77,7 @@ INTERFACE zif_abapgit_object METHODS get_deserialize_steps RETURNING - VALUE(rt_steps) TYPE zif_abapgit_definitions=>ty_deserialization_step_tt . + VALUE(rt_steps) TYPE zif_abapgit_objects=>ty_deserialization_step_tt. METHODS get_deserialize_order IMPORTING diff --git a/src/objects/zif_abapgit_objects.intf.abap b/src/objects/zif_abapgit_objects.intf.abap index 8709cb6dd..e20f4bd19 100644 --- a/src/objects/zif_abapgit_objects.intf.abap +++ b/src/objects/zif_abapgit_objects.intf.abap @@ -1,5 +1,4 @@ -INTERFACE zif_abapgit_objects - PUBLIC. +INTERFACE zif_abapgit_objects PUBLIC. TYPES: BEGIN OF ty_serialization, @@ -15,9 +14,15 @@ INTERFACE zif_abapgit_objects END OF ty_deserialization . TYPES: ty_deserialization_tt TYPE STANDARD TABLE OF ty_deserialization WITH DEFAULT KEY . + TYPES: + ty_types_tt TYPE SORTED TABLE OF tadir-object WITH UNIQUE KEY table_line. + TYPES: + ty_deserialization_step TYPE string. + TYPES: + ty_deserialization_step_tt TYPE STANDARD TABLE OF ty_deserialization_step WITH DEFAULT KEY. TYPES: BEGIN OF ty_step_data, - step_id TYPE zif_abapgit_definitions=>ty_deserialization_step, + step_id TYPE ty_deserialization_step, order TYPE i, descr TYPE string, syntax_check TYPE abap_bool, diff --git a/src/persist/zcl_abapgit_persist_migrate.clas.abap b/src/persist/zcl_abapgit_persist_migrate.clas.abap index 77ef0989d..c2f0a53ef 100644 --- a/src/persist/zcl_abapgit_persist_migrate.clas.abap +++ b/src/persist/zcl_abapgit_persist_migrate.clas.abap @@ -53,7 +53,7 @@ CLASS zcl_abapgit_persist_migrate IMPLEMENTATION. TRY. lcl_cua_interface=>new( )->put_own_cua( ls_cua ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDMETHOD. @@ -70,7 +70,7 @@ CLASS zcl_abapgit_persist_migrate IMPLEMENTATION. TRY. ls_own_cua = lcl_cua_interface=>new( )->get_own_cua( ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. IF ls_own_cua IS INITIAL. diff --git a/src/repo/utils/zcl_abapgit_repo_labels.clas.abap b/src/repo/utils/zcl_abapgit_repo_labels.clas.abap index f76a21936..5793913ec 100644 --- a/src/repo/utils/zcl_abapgit_repo_labels.clas.abap +++ b/src/repo/utils/zcl_abapgit_repo_labels.clas.abap @@ -136,7 +136,7 @@ CLASS zcl_abapgit_repo_labels IMPLEMENTATION. TRY. validate_one_label_color( ). APPEND TO lt_normalized. - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDLOOP. @@ -225,7 +225,7 @@ CLASS zcl_abapgit_repo_labels IMPLEMENTATION. ro_map->set( iv_key = -label iv_val = -color ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDLOOP. diff --git a/src/repo/zcl_abapgit_repo.clas.abap b/src/repo/zcl_abapgit_repo.clas.abap index b24ecf3d4..b74622984 100644 --- a/src/repo/zcl_abapgit_repo.clas.abap +++ b/src/repo/zcl_abapgit_repo.clas.abap @@ -192,7 +192,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION. +CLASS zcl_abapgit_repo IMPLEMENTATION. METHOD bind_listener. @@ -402,7 +402,7 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION. METHOD get_unsupported_objects_local. DATA: lt_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt, - lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt. + lt_supported_types TYPE zif_abapgit_objects=>ty_types_tt. FIELD-SYMBOLS: LIKE LINE OF lt_tadir, LIKE LINE OF rt_objects. diff --git a/src/ui/core/zcl_abapgit_gui.clas.abap b/src/ui/core/zcl_abapgit_gui.clas.abap index ef5e6f477..9c9b5bfe2 100644 --- a/src/ui/core/zcl_abapgit_gui.clas.abap +++ b/src/ui/core/zcl_abapgit_gui.clas.abap @@ -115,7 +115,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI IMPLEMENTATION. +CLASS zcl_abapgit_gui IMPLEMENTATION. METHOD back. @@ -373,7 +373,7 @@ CLASS ZCL_ABAPGIT_GUI IMPLEMENTATION. li_modal ?= ii_page. rv_yes = li_modal->is_modal( ). ENDIF. - CATCH cx_sy_move_cast_error. + CATCH cx_sy_move_cast_error ##NO_HANDLER. ENDTRY. ENDMETHOD. diff --git a/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap index fe330fbeb..85babc732 100644 --- a/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap @@ -243,7 +243,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. +CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. METHOD class_constructor. @@ -261,7 +261,7 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. timezone = gv_time_zone EXCEPTIONS customizing_missing = 1 - OTHERS = 2. + OTHERS = 2 ##FM_SUBRC_OK. ENDTRY. ENDMETHOD. diff --git a/src/ui/lib/zcl_abapgit_gui_page_hoc.clas.abap b/src/ui/lib/zcl_abapgit_gui_page_hoc.clas.abap index 2a8ae8e53..ff2d8b1c9 100644 --- a/src/ui/lib/zcl_abapgit_gui_page_hoc.clas.abap +++ b/src/ui/lib/zcl_abapgit_gui_page_hoc.clas.abap @@ -54,7 +54,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_HOC IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_hoc IMPLEMENTATION. METHOD constructor. @@ -96,14 +96,14 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_HOC IMPLEMENTATION. IF ls_control-page_menu_provider IS NOT BOUND. " try component itself TRY. ls_control-page_menu_provider ?= ii_child_component. - CATCH cx_sy_move_cast_error. + CATCH cx_sy_move_cast_error ##NO_HANDLER. ENDTRY. ENDIF. IF ls_control-page_title_provider IS NOT BOUND. " try component itself TRY. ls_control-page_title_provider ?= ii_child_component. - CATCH cx_sy_move_cast_error. + CATCH cx_sy_move_cast_error ##NO_HANDLER. ENDTRY. ENDIF. @@ -132,7 +132,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_HOC IMPLEMENTATION. TRY. li_modal ?= mi_child. rv_is_modal = li_modal->is_modal( ). - CATCH cx_sy_move_cast_error. + CATCH cx_sy_move_cast_error ##NO_HANDLER. ENDTRY. ENDMETHOD. @@ -141,7 +141,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_HOC IMPLEMENTATION. METHOD detect_title_provider. TRY. ri_ref ?= mi_child. - CATCH cx_sy_move_cast_error. + CATCH cx_sy_move_cast_error ##NO_HANDLER. ENDTRY. ENDMETHOD. diff --git a/src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap b/src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap index 4a18a629b..822f53c53 100644 --- a/src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap +++ b/src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap @@ -127,7 +127,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_codi_base IMPLEMENTATION. METHOD apply_filter_kind. @@ -256,7 +256,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION. ENDIF. ENDCASE. - CATCH cx_root. + CATCH cx_root ##NO_HANDLER. " leave empty, fallback to default, defined elsewhere ENDTRY. @@ -340,7 +340,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION. RETURN. ENDIF. - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. TRY. diff --git a/src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap b/src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap index 3125d605c..690b144cc 100644 --- a/src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap +++ b/src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap @@ -422,7 +422,7 @@ CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION. DATA: ls_stats TYPE ty_stats, ls_item TYPE zif_abapgit_definitions=>ty_item, - lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt. + lt_supported_types TYPE zif_abapgit_objects=>ty_types_tt. ls_stats-measure = 'Number of Objects'. diff --git a/src/ui/pages/sett/zcl_abapgit_gui_page_sett_pers.clas.abap b/src/ui/pages/sett/zcl_abapgit_gui_page_sett_pers.clas.abap index 7e1209753..71f423278 100644 --- a/src/ui/pages/sett/zcl_abapgit_gui_page_sett_pers.clas.abap +++ b/src/ui/pages/sett/zcl_abapgit_gui_page_sett_pers.clas.abap @@ -317,7 +317,7 @@ CLASS zcl_abapgit_gui_page_sett_pers IMPLEMENTATION. lo_colors->set( iv_key = lv_l iv_val = lv_l ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDLOOP. diff --git a/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap index 9fc930243..c2b561118 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap @@ -298,15 +298,15 @@ CLASS zcl_abapgit_gui_page_debuginfo IMPLEMENTATION. DATA: lv_list TYPE string, li_html TYPE REF TO zif_abapgit_html, - lt_types TYPE zcl_abapgit_objects=>ty_types_tt, + lt_types TYPE zif_abapgit_objects=>ty_types_tt, lv_type LIKE LINE OF lt_types, lt_obj TYPE STANDARD TABLE OF ko100 WITH DEFAULT KEY, lv_class TYPE seoclsname, li_object TYPE REF TO zif_abapgit_object, ls_item TYPE zif_abapgit_definitions=>ty_item, ls_metadata TYPE zif_abapgit_definitions=>ty_metadata, - lv_step TYPE zif_abapgit_definitions=>ty_deserialization_step, - lt_steps TYPE zif_abapgit_definitions=>ty_deserialization_step_tt. + lv_step TYPE zif_abapgit_objects=>ty_deserialization_step, + lt_steps TYPE zif_abapgit_objects=>ty_deserialization_step_tt. FIELD-SYMBOLS: TYPE ko100. diff --git a/src/ui/pages/zcl_abapgit_gui_page_stage.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_stage.clas.abap index 79c55fd92..9f4dba922 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_stage.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_stage.clas.abap @@ -137,7 +137,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION. METHOD check_selected. @@ -281,7 +281,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION. es_item = ls_item ). ls_changed_by-item = ls_item. INSERT ls_changed_by INTO TABLE lt_changed_by_remote. - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDLOOP. @@ -348,7 +348,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION. rt_transports = li_cts_api->get_transports_for_list( lt_items ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDMETHOD. diff --git a/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap b/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap index 7e6d5e8c3..232395a02 100644 --- a/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap +++ b/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap @@ -22,6 +22,7 @@ CLASS zcl_abapgit_popup_branch_list DEFINITION !iv_default_branch TYPE string OPTIONAL !iv_show_new_option TYPE abap_bool DEFAULT abap_false. + PROTECTED SECTION. PRIVATE SECTION. DATA mv_repo_url TYPE string. @@ -41,15 +42,6 @@ ENDCLASS. CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. - METHOD create. - CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_branch_list - EXPORTING - iv_url = iv_url - iv_default_branch = iv_default_branch - iv_show_new_option = iv_show_new_option. - ENDMETHOD. - - METHOD constructor. mv_repo_url = iv_url. mv_default_branch = zif_abapgit_git_definitions=>c_git_branch-heads_prefix && iv_default_branch. @@ -57,14 +49,12 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_html_popup~create_picklist. - - CREATE OBJECT ro_picklist + METHOD create. + CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_branch_list EXPORTING - iv_title = 'Choose Branch' - it_list = fetch_branch_list( ) - ii_item_renderer = me. - + iv_url = iv_url + iv_default_branch = iv_default_branch + iv_show_new_option = iv_show_new_option. ENDMETHOD. @@ -109,7 +99,6 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. FIELD-SYMBOLS TYPE zif_abapgit_git_definitions=>ty_git_branch. ASSIGN iv_item TO . - ASSERT sy-subrc = 0. " TODO render mv_default_branch properly, needs respecting support from the picklist components @@ -120,4 +109,15 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. ri_html = zcl_abapgit_html=>create( |{ -display_name }{ lv_head_marker }| ). ENDMETHOD. + + + METHOD zif_abapgit_html_popup~create_picklist. + + CREATE OBJECT ro_picklist + EXPORTING + iv_title = 'Choose Branch' + it_list = fetch_branch_list( ) + ii_item_renderer = me. + + ENDMETHOD. ENDCLASS. diff --git a/src/ui/popups/zcl_abapgit_popup_code_insp.clas.abap b/src/ui/popups/zcl_abapgit_popup_code_insp.clas.abap index 4e39b9984..09b14720c 100644 --- a/src/ui/popups/zcl_abapgit_popup_code_insp.clas.abap +++ b/src/ui/popups/zcl_abapgit_popup_code_insp.clas.abap @@ -24,7 +24,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_POPUP_CODE_INSP IMPLEMENTATION. +CLASS zcl_abapgit_popup_code_insp IMPLEMENTATION. METHOD create. @@ -44,7 +44,6 @@ CLASS ZCL_ABAPGIT_POPUP_CODE_INSP IMPLEMENTATION. FIELD-SYMBOLS TYPE LINE OF zif_abapgit_code_inspector=>ty_variants. ASSIGN iv_item TO . - ASSERT sy-subrc = 0. ri_html = zcl_abapgit_html=>create( |{ -name } - { -description }| ). diff --git a/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap b/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap index e6ed9f72b..327550038 100644 --- a/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap +++ b/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap @@ -67,7 +67,6 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION. FIELD-SYMBOLS TYPE zif_abapgit_pr_enum_provider=>ty_pull_request. ASSIGN iv_item TO . - ASSERT sy-subrc = 0. ri_html = zcl_abapgit_html=>create( |{ -number } - { -title } @{ -user }| ). diff --git a/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap b/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap index 85ecdb296..fb99de911 100644 --- a/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap +++ b/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap @@ -18,6 +18,7 @@ CLASS zcl_abapgit_popup_tag_list DEFINITION IMPORTING iv_url TYPE string. + PROTECTED SECTION. PRIVATE SECTION. DATA mv_repo_url TYPE string. @@ -34,26 +35,15 @@ ENDCLASS. CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION. - METHOD create. - CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_tag_list - EXPORTING - iv_url = iv_url. - ENDMETHOD. - - METHOD constructor. mv_repo_url = iv_url. ENDMETHOD. - METHOD zif_abapgit_html_popup~create_picklist. - - CREATE OBJECT ro_picklist + METHOD create. + CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_tag_list EXPORTING - iv_title = 'Choose Tag' - it_list = fetch_tag_list( ) - ii_item_renderer = me. - + iv_url = iv_url. ENDMETHOD. @@ -80,9 +70,19 @@ CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION. FIELD-SYMBOLS TYPE zif_abapgit_git_definitions=>ty_git_branch. ASSIGN iv_item TO . - ASSERT sy-subrc = 0. ri_html = zcl_abapgit_html=>create( |{ -display_name }| ). ENDMETHOD. + + + METHOD zif_abapgit_html_popup~create_picklist. + + CREATE OBJECT ro_picklist + EXPORTING + iv_title = 'Choose Tag' + it_list = fetch_tag_list( ) + ii_item_renderer = me. + + ENDMETHOD. ENDCLASS. diff --git a/src/ui/zcl_abapgit_popups.clas.locals_imp.abap b/src/ui/zcl_abapgit_popups.clas.locals_imp.abap index 5facf3f92..1bbfcc52a 100644 --- a/src/ui/zcl_abapgit_popups.clas.locals_imp.abap +++ b/src/ui/zcl_abapgit_popups.clas.locals_imp.abap @@ -248,7 +248,7 @@ CLASS lcl_object_decision_list IMPLEMENTATION. TRY. lo_columns->get_column( |{ c_fieldname_obj_type }| ). lv_object_list = abap_true. - CATCH cx_salv_not_found. + CATCH cx_salv_not_found ##NO_HANDLER. ENDTRY. setup_columns( diff --git a/src/zabapgit_forms.prog.abap b/src/zabapgit_forms.prog.abap index 5b1b241af..b966f61f7 100644 --- a/src/zabapgit_forms.prog.abap +++ b/src/zabapgit_forms.prog.abap @@ -81,18 +81,18 @@ CLASS lcl_startup IMPLEMENTATION. " - open a specific repo by package name provided by ADT " These overrule the last shown repo - GET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_repo_key FIELD lv_repo_key. - GET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_package FIELD lv_package. + GET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_repo_key FIELD lv_repo_key ##EXISTS. + GET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_package FIELD lv_package ##EXISTS. lv_package_adt = get_package_from_adt( ). IF lv_repo_key IS NOT INITIAL. - SET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_repo_key FIELD ''. + SET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_repo_key FIELD '' ##EXISTS. zcl_abapgit_persistence_user=>get_instance( )->set_repo_show( lv_repo_key ). ELSEIF lv_package IS NOT INITIAL. - SET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_package FIELD ''. + SET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_package FIELD '' ##EXISTS. set_start_repo_from_package( lv_package ). ELSEIF lv_package_adt IS NOT INITIAL. @@ -198,7 +198,7 @@ CLASS lcl_startup IMPLEMENTATION. ENDIF. - CATCH cx_root. + CATCH cx_root ##NO_HANDLER. " Some problems with dynamic ADT access. " Let's ignore it for now and fail silently ENDTRY. diff --git a/src/zabapgit_password_dialog.prog.abap b/src/zabapgit_password_dialog.prog.abap index 85224b8d8..79562e80f 100644 --- a/src/zabapgit_password_dialog.prog.abap +++ b/src/zabapgit_password_dialog.prog.abap @@ -181,7 +181,7 @@ FORM password_popup pv_repo_url TYPE string CHANGING cv_user TYPE string - cv_pass TYPE string. + cv_pass TYPE string ##CALLED. lcl_password_dialog=>popup( EXPORTING diff --git a/src/zif_abapgit_definitions.intf.abap b/src/zif_abapgit_definitions.intf.abap index c205a0200..db0ca4e89 100644 --- a/src/zif_abapgit_definitions.intf.abap +++ b/src/zif_abapgit_definitions.intf.abap @@ -268,11 +268,6 @@ INTERFACE zif_abapgit_definitions prerelase TYPE string, prerelase_patch TYPE i, END OF ty_version. - TYPES: - ty_deserialization_step TYPE string. - TYPES: - ty_deserialization_step_tt TYPE STANDARD TABLE OF ty_deserialization_step - WITH DEFAULT KEY . TYPES ty_sci_result TYPE c LENGTH 1. CONSTANTS: BEGIN OF c_sci_result,