SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Dialogs: Set autofocus on first form element (#4853)

Browse Source 
* Dialogs: Set autofocus on first form element

Improves usability. 

Closes #4816

* Autofocus for commit page

- Works in case JS is not an option

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2021-07-06 11:41:34 +02:00 committed by GitHub
parent 60a82331b5
commit 1d98688be5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ui/zcl_abapgit_gui_page_commit.clas.abap
View File

@ -58,6 +58,7 @@ CLASS zcl_abapgit_gui_page_commit DEFINITION
!iv_label TYPE string !iv_label TYPE string
!iv_value TYPE string OPTIONAL !iv_value TYPE string OPTIONAL
!iv_max_length TYPE string OPTIONAL !iv_max_length TYPE string OPTIONAL
!iv_autofocus TYPE abap_bool DEFAULT abap_false
RETURNING RETURNING
VALUE(ri_html) TYPE REF TO zif_abapgit_html . VALUE(ri_html) TYPE REF TO zif_abapgit_html .
METHODS get_comment_default METHODS get_comment_default
@ -283,7 +284,8 @@ CLASS zcl_abapgit_gui_page_commit IMPLEMENTATION.
ri_html->add( render_text_input( iv_name = 'comment' ri_html->add( render_text_input( iv_name = 'comment'
iv_label = 'Comment' iv_label = 'Comment'
iv_value = lv_comment iv_value = lv_comment
iv_max_length = lv_s_param ) ). iv_max_length = lv_s_param
iv_autofocus = abap_true ) ).
ri_html->add( '<div class="row">' ). ri_html->add( '<div class="row">' ).
ri_html->add( '<label for="c-body">Body</label>' ). ri_html->add( '<label for="c-body">Body</label>' ).
@ -408,6 +410,10 @@ CLASS zcl_abapgit_gui_page_commit IMPLEMENTATION.
lv_attrs = | maxlength="{ iv_max_length }"|. lv_attrs = | maxlength="{ iv_max_length }"|.
ENDIF. ENDIF.
IF iv_autofocus = abap_true.
lv_attrs = lv_attrs && ' autofocus'.
ENDIF.
ri_html->add( '<div class="row">' ). ri_html->add( '<div class="row">' ).
ri_html->add( |<label for="{ iv_name }">{ iv_label }</label>| ). ri_html->add( |<label for="{ iv_name }">{ iv_label }</label>| ).
ri_html->add( |<input id="{ iv_name }" name="{ iv_name }" type="text"{ lv_attrs }>| ). ri_html->add( |<input id="{ iv_name }" name="{ iv_name }" type="text"{ lv_attrs }>| ).

29
src/ui/zcl_abapgit_html_form.clas.abap
View File

@ -124,10 +124,10 @@ CLASS zcl_abapgit_html_form DEFINITION
readonly TYPE string, readonly TYPE string,
placeholder TYPE string, placeholder TYPE string,
required TYPE string, required TYPE string,
autofocus TYPE string,
END OF ty_attr . END OF ty_attr .
DATA: DATA mt_fields TYPE zif_abapgit_html_form=>ty_fields .
mt_fields TYPE zif_abapgit_html_form=>ty_fields.
DATA: DATA:
mt_commands TYPE STANDARD TABLE OF zif_abapgit_html_form=>ty_command . mt_commands TYPE STANDARD TABLE OF zif_abapgit_html_form=>ty_command .
DATA mv_form_id TYPE string . DATA mv_form_id TYPE string .
@ -138,7 +138,8 @@ CLASS zcl_abapgit_html_form DEFINITION
!ii_html TYPE REF TO zif_abapgit_html !ii_html TYPE REF TO zif_abapgit_html
!io_values TYPE REF TO zcl_abapgit_string_map !io_values TYPE REF TO zcl_abapgit_string_map
!io_validation_log TYPE REF TO zcl_abapgit_string_map !io_validation_log TYPE REF TO zcl_abapgit_string_map
!is_field TYPE zif_abapgit_html_form=>ty_field . !is_field TYPE zif_abapgit_html_form=>ty_field
!iv_autofocus TYPE abap_bool .
METHODS render_field_text METHODS render_field_text
IMPORTING IMPORTING
!ii_html TYPE REF TO zif_abapgit_html !ii_html TYPE REF TO zif_abapgit_html
@ -341,6 +342,7 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION.
DATA ls_form_action TYPE string. DATA ls_form_action TYPE string.
DATA lv_cur_group TYPE string. DATA lv_cur_group TYPE string.
DATA lv_url TYPE string. DATA lv_url TYPE string.
DATA lv_autofocus TYPE abap_bool.
IF mv_form_id IS NOT INITIAL. IF mv_form_id IS NOT INITIAL.
ls_form_id = | id="{ mv_form_id }"|. ls_form_id = | id="{ mv_form_id }"|.
@ -362,6 +364,7 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION.
EXIT. EXIT.
ENDLOOP. ENDLOOP.
lv_autofocus = abap_true.
LOOP AT mt_fields ASSIGNING <ls_field>. LOOP AT mt_fields ASSIGNING <ls_field>.
AT FIRST. AT FIRST.
IF <ls_field>-type <> zif_abapgit_html_form=>c_field_type-field_group. IF <ls_field>-type <> zif_abapgit_html_form=>c_field_type-field_group.
@ -390,7 +393,10 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION.
ii_html = ri_html ii_html = ri_html
io_values = io_values io_values = io_values
io_validation_log = io_validation_log io_validation_log = io_validation_log
is_field = <ls_field> ). is_field = <ls_field>
iv_autofocus = lv_autofocus ).
lv_autofocus = abap_false.
AT LAST. AT LAST.
ri_html->add( |</ul>| ). ri_html->add( |</ul>| ).
@ -498,6 +504,10 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION.
ls_attr-readonly = ' readonly'. ls_attr-readonly = ' readonly'.
ENDIF. ENDIF.
IF iv_autofocus = abap_true.
ls_attr-autofocus = ' autofocus'.
ENDIF.
" Prepare item class " Prepare item class
lv_item_class = is_field-item_class. lv_item_class = is_field-item_class.
IF ls_attr-error IS NOT INITIAL. IF ls_attr-error IS NOT INITIAL.
@ -580,7 +590,8 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION.
lv_checked = ' checked'. lv_checked = ' checked'.
ENDIF. ENDIF.
ii_html->add( |<input type="checkbox" name="{ is_field-name }" id="{ is_field-name }"{ lv_checked }>| ). ii_html->add( |<input type="checkbox" name="{ is_field-name }" id="{ is_field-name }"| &&
|{ lv_checked }{ is_attr-readonly }{ is_attr-autofocus }>| ).
ii_html->add( |<label for="{ is_field-name }"{ is_attr-hint }>{ is_field-label }</label>| ). ii_html->add( |<label for="{ is_field-name }"{ is_attr-hint }>{ is_field-label }</label>| ).
ENDMETHOD. ENDMETHOD.
@ -621,7 +632,7 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION.
lv_opt_id = |{ is_field-name }{ sy-tabix }|. lv_opt_id = |{ is_field-name }{ sy-tabix }|.
ii_html->add( |<input type="radio" name="{ is_field-name }" id="{ lv_opt_id }"| ii_html->add( |<input type="radio" name="{ is_field-name }" id="{ lv_opt_id }"|
&& | value="{ lv_opt_value }"{ lv_checked }>| ). && | value="{ lv_opt_value }"{ lv_checked }{ is_attr-autofocus }>| ).
ii_html->add( |<label for="{ lv_opt_id }">{ <ls_opt>-label }</label>| ). ii_html->add( |<label for="{ lv_opt_id }">{ <ls_opt>-label }</label>| ).
ENDLOOP. ENDLOOP.
@ -724,7 +735,8 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION.
ENDIF. ENDIF.
ii_html->add( |<input type="{ lv_type }" name="{ is_field-name }" id="{ is_field-name }"| ii_html->add( |<input type="{ lv_type }" name="{ is_field-name }" id="{ is_field-name }"|
&& | value="{ is_attr-value }" { is_field-dblclick }{ is_attr-placeholder }{ is_attr-readonly }>| ). && | value="{ is_attr-value }" { is_field-dblclick }{ is_attr-placeholder }|
&& |{ is_attr-readonly }{ is_attr-autofocus }>| ).
IF is_field-side_action IS NOT INITIAL. IF is_field-side_action IS NOT INITIAL.
ii_html->add( '</div>' ). ii_html->add( '</div>' ).
@ -750,7 +762,8 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION.
lv_rows = lines( zcl_abapgit_convert=>split_string( is_attr-value ) ). lv_rows = lines( zcl_abapgit_convert=>split_string( is_attr-value ) ).
" Avoid adding line-breaks inside textarea tag (except for the actual value) " Avoid adding line-breaks inside textarea tag (except for the actual value)
lv_html = |<textarea name="{ is_field-name }" id="{ is_field-name }" rows="{ lv_rows }"{ is_attr-readonly }>|. lv_html = |<textarea name="{ is_field-name }" id="{ is_field-name }" rows="{ lv_rows }"|
&& |{ is_attr-readonly }{ is_attr-autofocus }>|.
lv_html = lv_html && escape( val = is_attr-value lv_html = lv_html && escape( val = is_attr-value
format = cl_abap_format=>e_html_attr ). format = cl_abap_format=>e_html_attr ).
lv_html = lv_html && |</textarea>|. lv_html = lv_html && |</textarea>|.