diff --git a/src/git/zcl_abapgit_git_add_patch.clas.abap b/src/git/zcl_abapgit_git_add_patch.clas.abap index f340d1347..6bb0fdee2 100644 --- a/src/git/zcl_abapgit_git_add_patch.clas.abap +++ b/src/git/zcl_abapgit_git_add_patch.clas.abap @@ -12,7 +12,7 @@ CLASS zcl_abapgit_git_add_patch DEFINITION get_patch RETURNING - VALUE(rt_patch) TYPE stringtab + VALUE(rt_patch) TYPE string_table RAISING zcx_abapgit_exception, @@ -21,20 +21,18 @@ CLASS zcl_abapgit_git_add_patch DEFINITION VALUE(rv_patch_binary) TYPE xstring RAISING zcx_abapgit_exception. - PROTECTED SECTION. PRIVATE SECTION. DATA: mt_diff TYPE zif_abapgit_definitions=>ty_diffs_tt, - mt_patch TYPE stringtab. + mt_patch TYPE string_table. METHODS: calculate_patch RETURNING - VALUE(rt_patch) TYPE stringtab + VALUE(rt_patch) TYPE string_table RAISING zcx_abapgit_exception. - ENDCLASS. diff --git a/src/git/zcl_abapgit_git_add_patch.clas.testclasses.abap b/src/git/zcl_abapgit_git_add_patch.clas.testclasses.abap index 99bc687ea..c2b0563fa 100644 --- a/src/git/zcl_abapgit_git_add_patch.clas.testclasses.abap +++ b/src/git/zcl_abapgit_git_add_patch.clas.testclasses.abap @@ -46,7 +46,7 @@ CLASS ltcl_calculate_patch DEFINITION FINAL FOR TESTING DATA: mt_diff TYPE zif_abapgit_definitions=>ty_diffs_tt, - mt_patch TYPE stringtab, + mt_patch TYPE string_table, mx_error TYPE REF TO zcx_abapgit_exception. ENDCLASS. diff --git a/src/git/zcl_abapgit_git_branch_list.clas.abap b/src/git/zcl_abapgit_git_branch_list.clas.abap index 499fdfe55..933fffce5 100644 --- a/src/git/zcl_abapgit_git_branch_list.clas.abap +++ b/src/git/zcl_abapgit_git_branch_list.clas.abap @@ -37,8 +37,8 @@ CLASS zcl_abapgit_git_branch_list DEFINITION CLASS-METHODS get_type IMPORTING !iv_branch_name TYPE clike - !it_result TYPE stringtab OPTIONAL - !iv_current_row_index TYPE sytabix OPTIONAL + !it_result TYPE string_table OPTIONAL + !iv_current_row_index TYPE sy-tabix OPTIONAL RETURNING VALUE(rv_type) TYPE zif_abapgit_definitions=>ty_git_branch_type . CLASS-METHODS complete_heads_branch_name @@ -197,7 +197,7 @@ CLASS ZCL_ABAPGIT_GIT_BRANCH_LIST IMPLEMENTATION. DATA: lv_annotated_tag_with_suffix TYPE string. - FIELD-SYMBOLS: TYPE LINE OF stringtab. + FIELD-SYMBOLS: TYPE LINE OF string_table. rv_type = zif_abapgit_definitions=>c_git_branch_type-other. diff --git a/src/http/zcl_abapgit_2fa_github_auth.clas.abap b/src/http/zcl_abapgit_2fa_github_auth.clas.abap index dbe5bac13..146ea9e0f 100644 --- a/src/http/zcl_abapgit_2fa_github_auth.clas.abap +++ b/src/http/zcl_abapgit_2fa_github_auth.clas.abap @@ -41,7 +41,7 @@ CLASS zcl_abapgit_2fa_github_auth DEFINITION IMPORTING !ii_response TYPE REF TO if_http_response RETURNING - VALUE(rt_ids) TYPE stringtab . + VALUE(rt_ids) TYPE string_table . CLASS-METHODS set_del_token_request IMPORTING !ii_request TYPE REF TO if_http_request @@ -249,7 +249,8 @@ CLASS ZCL_ABAPGIT_2FA_GITHUB_AUTH IMPLEMENTATION. DATA: li_http_client TYPE REF TO if_http_client, lv_http_code TYPE i, lv_http_code_description TYPE string, - lt_tobedeleted_tokens TYPE stringtab. + lt_tobedeleted_tokens TYPE string_table. + FIELD-SYMBOLS: TYPE string. li_http_client = get_authenticated_client( iv_username = iv_username diff --git a/src/objects/zcl_abapgit_object_tabl_compar.clas.abap b/src/objects/zcl_abapgit_object_tabl_compar.clas.abap index 2eeaab360..70f87ab5a 100644 --- a/src/objects/zcl_abapgit_object_tabl_compar.clas.abap +++ b/src/objects/zcl_abapgit_object_tabl_compar.clas.abap @@ -64,7 +64,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL_COMPAR IMPLEMENTATION. METHOD get_where_used_recursive. - DATA: lt_findstrings TYPE stringtab, + DATA: lt_findstrings TYPE string_table, lt_founds TYPE STANDARD TABLE OF rsfindlst, lt_scope TYPE tty_seu_obj, lv_findstring LIKE LINE OF lt_findstrings. diff --git a/src/objects/zcl_abapgit_objects_generic.clas.abap b/src/objects/zcl_abapgit_objects_generic.clas.abap index 96a0180fb..7db18a499 100644 --- a/src/objects/zcl_abapgit_objects_generic.clas.abap +++ b/src/objects/zcl_abapgit_objects_generic.clas.abap @@ -32,8 +32,8 @@ CLASS zcl_abapgit_objects_generic DEFINITION TYPES: BEGIN OF ty_s_objkey, - num TYPE numc3, - value TYPE char128, + num TYPE n LENGTH 3, + value TYPE c LENGTH 128, END OF ty_s_objkey . TYPES: ty_t_objkey TYPE SORTED TABLE OF ty_s_objkey WITH UNIQUE KEY num . diff --git a/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap b/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap index dc8bdb8b6..46040a6c1 100644 --- a/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap +++ b/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap @@ -19,7 +19,7 @@ CLASS zcl_abapgit_syntax_highlighter DEFINITION TYPES: BEGIN OF ty_match, - token TYPE char1, " Type of matches + token TYPE c LENGTH 1, " Type of matches offset TYPE i, " Beginning position of the string that should be formatted length TYPE i, " Length of the string that should be formatted text_tag TYPE string, " Type of text tag @@ -29,7 +29,7 @@ CLASS zcl_abapgit_syntax_highlighter DEFINITION TYPES: BEGIN OF ty_rule, regex TYPE REF TO cl_abap_regex, - token TYPE char1, + token TYPE c LENGTH 1, style TYPE string, relevant_submatch TYPE i, END OF ty_rule . @@ -72,6 +72,7 @@ CLASS zcl_abapgit_syntax_highlighter DEFINITION !iv_class TYPE string RETURNING VALUE(rv_line) TYPE string . + PRIVATE SECTION. ENDCLASS. diff --git a/src/ui/zcl_abapgit_gui_page_diff.clas.abap b/src/ui/zcl_abapgit_gui_page_diff.clas.abap index 16c30a557..b1892ae0d 100644 --- a/src/ui/zcl_abapgit_gui_page_diff.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_diff.clas.abap @@ -87,7 +87,7 @@ CLASS zcl_abapgit_gui_page_diff DEFINITION IMPORTING is_diff_line TYPE zif_abapgit_definitions=>ty_diff iv_filename TYPE string iv_fstate TYPE char1 - iv_index TYPE sytabix + iv_index TYPE sy-tabix RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html. METHODS render_line_unified IMPORTING is_diff_line TYPE zif_abapgit_definitions=>ty_diff OPTIONAL @@ -112,7 +112,7 @@ CLASS zcl_abapgit_gui_page_diff DEFINITION iv_patch_line_possible TYPE abap_bool iv_filename TYPE string is_diff_line TYPE zif_abapgit_definitions=>ty_diff - iv_index TYPE sytabix. + iv_index TYPE sy-tabix. METHODS start_staging IMPORTING it_postdata TYPE cnht_post_data_tab @@ -162,7 +162,7 @@ ENDCLASS. -CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION. +CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. METHOD add_to_stage. @@ -497,7 +497,7 @@ CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION. METHOD get_diff_line. DATA: lt_diff TYPE zif_abapgit_definitions=>ty_diffs_tt, - lv_line_index TYPE sytabix. + lv_line_index TYPE sy-tabix. lv_line_index = iv_line_index. @@ -1015,18 +1015,6 @@ CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions. - - DATA: ls_hotkey_action LIKE LINE OF rt_hotkey_actions. - - ls_hotkey_action-name = |Stage changes|. - ls_hotkey_action-action = |stagePatch|. - ls_hotkey_action-hotkey = |s|. - INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. - - ENDMETHOD. - - METHOD zif_abapgit_gui_event_handler~on_event. DATA: lo_repo TYPE REF TO zcl_abapgit_repo_online. @@ -1051,4 +1039,16 @@ CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION. ENDCASE. ENDMETHOD. + + + METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions. + + DATA: ls_hotkey_action LIKE LINE OF rt_hotkey_actions. + + ls_hotkey_action-name = |Stage changes|. + ls_hotkey_action-action = |stagePatch|. + ls_hotkey_action-hotkey = |s|. + INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. + + ENDMETHOD. ENDCLASS. diff --git a/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap b/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap index 364291b3f..d75fad374 100644 --- a/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap @@ -51,7 +51,7 @@ CLASS zcl_abapgit_gui_page_merge_res DEFINITION DATA mo_merge_page TYPE REF TO zcl_abapgit_gui_page_merge . DATA mo_repo TYPE REF TO zcl_abapgit_repo_online . DATA ms_diff_file TYPE ty_file_diff . - DATA mv_current_conflict_index TYPE sytabix . + DATA mv_current_conflict_index TYPE sy-tabix . DATA mv_merge_mode TYPE string . DATA mt_conflicts TYPE zif_abapgit_definitions=>tt_merge_conflict . @@ -531,11 +531,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions. - - ENDMETHOD. - - METHOD zif_abapgit_gui_event_handler~on_event. FIELD-SYMBOLS: TYPE zif_abapgit_definitions=>ty_merge_conflict. @@ -583,4 +578,9 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION. ENDCASE. ENDMETHOD. + + + METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions. + + ENDMETHOD. ENDCLASS. diff --git a/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap b/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap index a69df90a5..98f8df7ed 100644 --- a/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap @@ -102,11 +102,11 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_SETT IMPLEMENTATION. CONSTANTS: lc_requirement_edit_count TYPE i VALUE 5. DATA: ls_dot TYPE zif_abapgit_dot_abapgit=>ty_dot_abapgit, lv_selected TYPE string, - lt_folder_logic TYPE stringtab, + lt_folder_logic TYPE string_table, lv_req_index TYPE i, lv_requirement_count TYPE i. - FIELD-SYMBOLS: TYPE LINE OF stringtab, + FIELD-SYMBOLS: TYPE LINE OF string_table, TYPE zif_abapgit_dot_abapgit=>ty_requirement. ls_dot = mo_repo->get_dot_abapgit( )->get_data( ). diff --git a/src/ui/zcl_abapgit_gui_page_tag.clas.abap b/src/ui/zcl_abapgit_gui_page_tag.clas.abap index d7be36672..72e275f59 100644 --- a/src/ui/zcl_abapgit_gui_page_tag.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_tag.clas.abap @@ -61,7 +61,7 @@ ENDCLASS. -CLASS zcl_abapgit_gui_page_tag IMPLEMENTATION. +CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION. METHOD constructor. @@ -208,7 +208,7 @@ CLASS zcl_abapgit_gui_page_tag IMPLEMENTATION. lv_s_param TYPE string, lo_settings TYPE REF TO zcl_abapgit_settings, lv_body_size TYPE i, - lt_type TYPE stringtab, + lt_type TYPE string_table, lv_selected TYPE string. FIELD-SYMBOLS: LIKE LINE OF lt_type. @@ -390,8 +390,8 @@ CLASS zcl_abapgit_gui_page_tag IMPLEMENTATION. ENDMETHOD. + METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions. ENDMETHOD. - ENDCLASS. diff --git a/src/ui/zcl_abapgit_popups.clas.abap b/src/ui/zcl_abapgit_popups.clas.abap index fbbd28b7a..25f42b4e5 100644 --- a/src/ui/zcl_abapgit_popups.clas.abap +++ b/src/ui/zcl_abapgit_popups.clas.abap @@ -283,7 +283,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION. METHOD on_select_list_link_click. - DATA: lv_line TYPE sytabix. + DATA: lv_line TYPE sy-tabix. FIELD-SYMBOLS: TYPE STANDARD TABLE, TYPE any, @@ -294,8 +294,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION. lv_line = row. - READ TABLE ASSIGNING - INDEX lv_line. + READ TABLE ASSIGNING INDEX lv_line. IF sy-subrc = 0. ASSIGN COMPONENT c_fieldname_selected diff --git a/src/ui/zcl_abapgit_services_git.clas.abap b/src/ui/zcl_abapgit_services_git.clas.abap index 1baec5264..427031b85 100644 --- a/src/ui/zcl_abapgit_services_git.clas.abap +++ b/src/ui/zcl_abapgit_services_git.clas.abap @@ -262,7 +262,7 @@ CLASS ZCL_ABAPGIT_SERVICES_GIT IMPLEMENTATION. lv_answer TYPE c LENGTH 1, lt_unnecessary_local_objs TYPE zif_abapgit_definitions=>ty_tadir_tt, lt_selected LIKE lt_unnecessary_local_objs, - lt_columns TYPE stringtab, + lt_columns TYPE string_table, ls_checks TYPE zif_abapgit_definitions=>ty_delete_checks, li_popups TYPE REF TO zif_abapgit_popups. diff --git a/src/ui/zcl_abapgit_services_repo.clas.abap b/src/ui/zcl_abapgit_services_repo.clas.abap index 7767b0014..ea1087cb1 100644 --- a/src/ui/zcl_abapgit_services_repo.clas.abap +++ b/src/ui/zcl_abapgit_services_repo.clas.abap @@ -192,7 +192,7 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION. METHOD popup_overwrite. - DATA: lt_columns TYPE stringtab, + DATA: lt_columns TYPE string_table, lt_selected LIKE ct_overwrite, lv_column LIKE LINE OF lt_columns, li_popups TYPE REF TO zif_abapgit_popups. @@ -237,7 +237,7 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION. METHOD popup_package_overwrite. - DATA: lt_colums_to_display TYPE stringtab, + DATA: lt_colums_to_display TYPE string_table, lv_column LIKE LINE OF lt_colums_to_display, lt_selected LIKE ct_overwrite, li_popups TYPE REF TO zif_abapgit_popups. diff --git a/src/ui/zif_abapgit_popups.intf.abap b/src/ui/zif_abapgit_popups.intf.abap index a41f6b8ac..33f46101c 100644 --- a/src/ui/zif_abapgit_popups.intf.abap +++ b/src/ui/zif_abapgit_popups.intf.abap @@ -113,7 +113,7 @@ INTERFACE zif_abapgit_popups !it_list TYPE STANDARD TABLE !iv_header_text TYPE csequence !iv_select_column_text TYPE csequence - !it_columns_to_display TYPE stringtab + !it_columns_to_display TYPE string_table EXPORTING VALUE(et_list) TYPE STANDARD TABLE RAISING diff --git a/src/zabapgit_forms.prog.abap b/src/zabapgit_forms.prog.abap index ddc865295..64213bf58 100644 --- a/src/zabapgit_forms.prog.abap +++ b/src/zabapgit_forms.prog.abap @@ -142,7 +142,7 @@ FORM password_popup ENDFORM. -FORM remove_toolbar USING pv_dynnr TYPE char4. +FORM remove_toolbar USING pv_dynnr TYPE sy-dynnr. DATA: ls_header TYPE rpy_dyhead, lt_containers TYPE dycatt_tab, diff --git a/src/zabapgit_password_dialog.prog.abap b/src/zabapgit_password_dialog.prog.abap index ea78323bf..c6b1a8487 100644 --- a/src/zabapgit_password_dialog.prog.abap +++ b/src/zabapgit_password_dialog.prog.abap @@ -41,7 +41,7 @@ CLASS lcl_password_dialog DEFINITION FINAL. CLASS-METHODS on_screen_output. CLASS-METHODS on_screen_event IMPORTING - iv_ucomm TYPE syucomm. + iv_ucomm TYPE sy-ucomm. PRIVATE SECTION. CLASS-DATA gv_confirm TYPE abap_bool. diff --git a/src/zcl_abapgit_settings.clas.abap b/src/zcl_abapgit_settings.clas.abap index 28a8822db..7b94eb175 100644 --- a/src/zcl_abapgit_settings.clas.abap +++ b/src/zcl_abapgit_settings.clas.abap @@ -106,10 +106,10 @@ CLASS zcl_abapgit_settings DEFINITION PUBLIC CREATE PUBLIC. zcx_abapgit_exception, set_link_hint_key IMPORTING - iv_link_hint_key TYPE char01, + iv_link_hint_key TYPE string, get_link_hint_key RETURNING - VALUE(rv_link_hint_key) TYPE char01, + VALUE(rv_link_hint_key) TYPE string, get_link_hint_background_color RETURNING VALUE(rv_background_color) TYPE string, diff --git a/src/zif_abapgit_definitions.intf.abap b/src/zif_abapgit_definitions.intf.abap index 5298ece77..bf12aaf5d 100644 --- a/src/zif_abapgit_definitions.intf.abap +++ b/src/zif_abapgit_definitions.intf.abap @@ -244,7 +244,7 @@ INTERFACE zif_abapgit_definitions email TYPE string, time TYPE string, message TYPE string, - body TYPE stringtab, + body TYPE string_table, branch TYPE string, merge TYPE string, tags TYPE stringtab, @@ -335,7 +335,7 @@ INTERFACE zif_abapgit_definitions adt_jump_enabled TYPE abap_bool, show_default_repo TYPE abap_bool, link_hints_enabled TYPE abap_bool, - link_hint_key TYPE char01, + link_hint_key TYPE c LENGTH 1, link_hint_background_color TYPE string, hotkeys TYPE tty_hotkey, parallel_proc_disabled TYPE abap_bool,