SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactoring types (#2785)

Browse Source 
* align use less different types

* refactor

* updates
This commit is contained in:
Lars Hvam 2019-07-15 09:33:37 -07:00 committed by GitHub
parent 2db46137fc
commit 1dbd4d1912
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
19 changed files with 55 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/git/zcl_abapgit_git_add_patch.clas.abap
View File

@ -12,7 +12,7 @@ CLASS zcl_abapgit_git_add_patch DEFINITION
get_patch get_patch
RETURNING RETURNING
VALUE(rt_patch) TYPE stringtab VALUE(rt_patch) TYPE string_table
RAISING RAISING
zcx_abapgit_exception, zcx_abapgit_exception,
@ -21,20 +21,18 @@ CLASS zcl_abapgit_git_add_patch DEFINITION
VALUE(rv_patch_binary) TYPE xstring VALUE(rv_patch_binary) TYPE xstring
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
PROTECTED SECTION. PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
DATA: DATA:
mt_diff TYPE zif_abapgit_definitions=>ty_diffs_tt, mt_diff TYPE zif_abapgit_definitions=>ty_diffs_tt,
mt_patch TYPE stringtab. mt_patch TYPE string_table.
METHODS: METHODS:
calculate_patch calculate_patch
RETURNING RETURNING
VALUE(rt_patch) TYPE stringtab VALUE(rt_patch) TYPE string_table
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
ENDCLASS. ENDCLASS.

2
src/git/zcl_abapgit_git_add_patch.clas.testclasses.abap
View File

@ -46,7 +46,7 @@ CLASS ltcl_calculate_patch DEFINITION FINAL FOR TESTING
DATA: DATA:
mt_diff TYPE zif_abapgit_definitions=>ty_diffs_tt, mt_diff TYPE zif_abapgit_definitions=>ty_diffs_tt,
mt_patch TYPE stringtab, mt_patch TYPE string_table,
mx_error TYPE REF TO zcx_abapgit_exception. mx_error TYPE REF TO zcx_abapgit_exception.
ENDCLASS. ENDCLASS.

6
src/git/zcl_abapgit_git_branch_list.clas.abap
View File

@ -37,8 +37,8 @@ CLASS zcl_abapgit_git_branch_list DEFINITION
CLASS-METHODS get_type CLASS-METHODS get_type
IMPORTING IMPORTING
!iv_branch_name TYPE clike !iv_branch_name TYPE clike
!it_result TYPE stringtab OPTIONAL !it_result TYPE string_table OPTIONAL
!iv_current_row_index TYPE sytabix OPTIONAL !iv_current_row_index TYPE sy-tabix OPTIONAL
RETURNING RETURNING
VALUE(rv_type) TYPE zif_abapgit_definitions=>ty_git_branch_type . VALUE(rv_type) TYPE zif_abapgit_definitions=>ty_git_branch_type .
CLASS-METHODS complete_heads_branch_name CLASS-METHODS complete_heads_branch_name
@ -197,7 +197,7 @@ CLASS ZCL_ABAPGIT_GIT_BRANCH_LIST IMPLEMENTATION.
DATA: lv_annotated_tag_with_suffix TYPE string. DATA: lv_annotated_tag_with_suffix TYPE string.
FIELD-SYMBOLS: <lv_result> TYPE LINE OF stringtab. FIELD-SYMBOLS: <lv_result> TYPE LINE OF string_table.
rv_type = zif_abapgit_definitions=>c_git_branch_type-other. rv_type = zif_abapgit_definitions=>c_git_branch_type-other.

5
src/http/zcl_abapgit_2fa_github_auth.clas.abap
View File

@ -41,7 +41,7 @@ CLASS zcl_abapgit_2fa_github_auth DEFINITION
IMPORTING IMPORTING
!ii_response TYPE REF TO if_http_response !ii_response TYPE REF TO if_http_response
RETURNING RETURNING
VALUE(rt_ids) TYPE stringtab . VALUE(rt_ids) TYPE string_table .
CLASS-METHODS set_del_token_request CLASS-METHODS set_del_token_request
IMPORTING IMPORTING
!ii_request TYPE REF TO if_http_request !ii_request TYPE REF TO if_http_request
@ -249,7 +249,8 @@ CLASS ZCL_ABAPGIT_2FA_GITHUB_AUTH IMPLEMENTATION.
DATA: li_http_client TYPE REF TO if_http_client, DATA: li_http_client TYPE REF TO if_http_client,
lv_http_code TYPE i, lv_http_code TYPE i,
lv_http_code_description TYPE string, lv_http_code_description TYPE string,
lt_tobedeleted_tokens TYPE stringtab. lt_tobedeleted_tokens TYPE string_table.
FIELD-SYMBOLS: <lv_id> TYPE string. FIELD-SYMBOLS: <lv_id> TYPE string.
li_http_client = get_authenticated_client( iv_username = iv_username li_http_client = get_authenticated_client( iv_username = iv_username

2
src/objects/zcl_abapgit_object_tabl_compar.clas.abap
View File

@ -64,7 +64,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL_COMPAR IMPLEMENTATION.
METHOD get_where_used_recursive. METHOD get_where_used_recursive.
DATA: lt_findstrings TYPE stringtab, DATA: lt_findstrings TYPE string_table,
lt_founds TYPE STANDARD TABLE OF rsfindlst, lt_founds TYPE STANDARD TABLE OF rsfindlst,
lt_scope TYPE tty_seu_obj, lt_scope TYPE tty_seu_obj,
lv_findstring LIKE LINE OF lt_findstrings. lv_findstring LIKE LINE OF lt_findstrings.

4
src/objects/zcl_abapgit_objects_generic.clas.abap
View File

@ -32,8 +32,8 @@ CLASS zcl_abapgit_objects_generic DEFINITION
TYPES: TYPES:
BEGIN OF ty_s_objkey, BEGIN OF ty_s_objkey,
num TYPE numc3, num TYPE n LENGTH 3,
value TYPE char128, value TYPE c LENGTH 128,
END OF ty_s_objkey . END OF ty_s_objkey .
TYPES: TYPES:
ty_t_objkey TYPE SORTED TABLE OF ty_s_objkey WITH UNIQUE KEY num . ty_t_objkey TYPE SORTED TABLE OF ty_s_objkey WITH UNIQUE KEY num .

5
src/syntax/zcl_abapgit_syntax_highlighter.clas.abap
View File

@ -19,7 +19,7 @@ CLASS zcl_abapgit_syntax_highlighter DEFINITION
TYPES: TYPES:
BEGIN OF ty_match, BEGIN OF ty_match,
token TYPE char1, " Type of matches token TYPE c LENGTH 1, " Type of matches
offset TYPE i, " Beginning position of the string that should be formatted offset TYPE i, " Beginning position of the string that should be formatted
length TYPE i, " Length of the string that should be formatted length TYPE i, " Length of the string that should be formatted
text_tag TYPE string, " Type of text tag text_tag TYPE string, " Type of text tag
@ -29,7 +29,7 @@ CLASS zcl_abapgit_syntax_highlighter DEFINITION
TYPES: TYPES:
BEGIN OF ty_rule, BEGIN OF ty_rule,
regex TYPE REF TO cl_abap_regex, regex TYPE REF TO cl_abap_regex,
token TYPE char1, token TYPE c LENGTH 1,
style TYPE string, style TYPE string,
relevant_submatch TYPE i, relevant_submatch TYPE i,
END OF ty_rule . END OF ty_rule .
@ -72,6 +72,7 @@ CLASS zcl_abapgit_syntax_highlighter DEFINITION
!iv_class TYPE string !iv_class TYPE string
RETURNING RETURNING
VALUE(rv_line) TYPE string . VALUE(rv_line) TYPE string .
PRIVATE SECTION.
ENDCLASS. ENDCLASS.

32
src/ui/zcl_abapgit_gui_page_diff.clas.abap
View File

@ -87,7 +87,7 @@ CLASS zcl_abapgit_gui_page_diff DEFINITION
IMPORTING is_diff_line TYPE zif_abapgit_definitions=>ty_diff IMPORTING is_diff_line TYPE zif_abapgit_definitions=>ty_diff
iv_filename TYPE string iv_filename TYPE string
iv_fstate TYPE char1 iv_fstate TYPE char1
iv_index TYPE sytabix iv_index TYPE sy-tabix
RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html. RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html.
METHODS render_line_unified METHODS render_line_unified
IMPORTING is_diff_line TYPE zif_abapgit_definitions=>ty_diff OPTIONAL IMPORTING is_diff_line TYPE zif_abapgit_definitions=>ty_diff OPTIONAL
@ -112,7 +112,7 @@ CLASS zcl_abapgit_gui_page_diff DEFINITION
iv_patch_line_possible TYPE abap_bool iv_patch_line_possible TYPE abap_bool
iv_filename TYPE string iv_filename TYPE string
is_diff_line TYPE zif_abapgit_definitions=>ty_diff is_diff_line TYPE zif_abapgit_definitions=>ty_diff
iv_index TYPE sytabix. iv_index TYPE sy-tabix.
METHODS start_staging METHODS start_staging
IMPORTING IMPORTING
it_postdata TYPE cnht_post_data_tab it_postdata TYPE cnht_post_data_tab
@ -162,7 +162,7 @@ ENDCLASS.
CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION. CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION.
METHOD add_to_stage. METHOD add_to_stage.
@ -497,7 +497,7 @@ CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION.
METHOD get_diff_line. METHOD get_diff_line.
DATA: lt_diff TYPE zif_abapgit_definitions=>ty_diffs_tt, DATA: lt_diff TYPE zif_abapgit_definitions=>ty_diffs_tt,
lv_line_index TYPE sytabix. lv_line_index TYPE sy-tabix.
lv_line_index = iv_line_index. lv_line_index = iv_line_index.
@ -1015,18 +1015,6 @@ CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions.
DATA: ls_hotkey_action LIKE LINE OF rt_hotkey_actions.
ls_hotkey_action-name = |Stage changes|.
ls_hotkey_action-action = |stagePatch|.
ls_hotkey_action-hotkey = |s|.
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
ENDMETHOD.
METHOD zif_abapgit_gui_event_handler~on_event. METHOD zif_abapgit_gui_event_handler~on_event.
DATA: lo_repo TYPE REF TO zcl_abapgit_repo_online. DATA: lo_repo TYPE REF TO zcl_abapgit_repo_online.
@ -1051,4 +1039,16 @@ CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION.
ENDCASE. ENDCASE.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions.
DATA: ls_hotkey_action LIKE LINE OF rt_hotkey_actions.
ls_hotkey_action-name = |Stage changes|.
ls_hotkey_action-action = |stagePatch|.
ls_hotkey_action-hotkey = |s|.
INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions.
ENDMETHOD.
ENDCLASS. ENDCLASS.

12
src/ui/zcl_abapgit_gui_page_merge_res.clas.abap
View File

@ -51,7 +51,7 @@ CLASS zcl_abapgit_gui_page_merge_res DEFINITION
DATA mo_merge_page TYPE REF TO zcl_abapgit_gui_page_merge . DATA mo_merge_page TYPE REF TO zcl_abapgit_gui_page_merge .
DATA mo_repo TYPE REF TO zcl_abapgit_repo_online . DATA mo_repo TYPE REF TO zcl_abapgit_repo_online .
DATA ms_diff_file TYPE ty_file_diff . DATA ms_diff_file TYPE ty_file_diff .
DATA mv_current_conflict_index TYPE sytabix . DATA mv_current_conflict_index TYPE sy-tabix .
DATA mv_merge_mode TYPE string . DATA mv_merge_mode TYPE string .
DATA mt_conflicts TYPE zif_abapgit_definitions=>tt_merge_conflict . DATA mt_conflicts TYPE zif_abapgit_definitions=>tt_merge_conflict .
@ -531,11 +531,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions.
ENDMETHOD.
METHOD zif_abapgit_gui_event_handler~on_event. METHOD zif_abapgit_gui_event_handler~on_event.
FIELD-SYMBOLS: <ls_conflict> TYPE zif_abapgit_definitions=>ty_merge_conflict. FIELD-SYMBOLS: <ls_conflict> TYPE zif_abapgit_definitions=>ty_merge_conflict.
@ -583,4 +578,9 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION.
ENDCASE. ENDCASE.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions.
ENDMETHOD.
ENDCLASS. ENDCLASS.

4
src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap
View File

@ -102,11 +102,11 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_SETT IMPLEMENTATION.
CONSTANTS: lc_requirement_edit_count TYPE i VALUE 5. CONSTANTS: lc_requirement_edit_count TYPE i VALUE 5.
DATA: ls_dot TYPE zif_abapgit_dot_abapgit=>ty_dot_abapgit, DATA: ls_dot TYPE zif_abapgit_dot_abapgit=>ty_dot_abapgit,
lv_selected TYPE string, lv_selected TYPE string,
lt_folder_logic TYPE stringtab, lt_folder_logic TYPE string_table,
lv_req_index TYPE i, lv_req_index TYPE i,
lv_requirement_count TYPE i. lv_requirement_count TYPE i.
FIELD-SYMBOLS: <lv_folder_logic> TYPE LINE OF stringtab, FIELD-SYMBOLS: <lv_folder_logic> TYPE LINE OF string_table,
<ls_requirement> TYPE zif_abapgit_dot_abapgit=>ty_requirement. <ls_requirement> TYPE zif_abapgit_dot_abapgit=>ty_requirement.
ls_dot = mo_repo->get_dot_abapgit( )->get_data( ). ls_dot = mo_repo->get_dot_abapgit( )->get_data( ).

6
src/ui/zcl_abapgit_gui_page_tag.clas.abap
View File

@ -61,7 +61,7 @@ ENDCLASS.
CLASS zcl_abapgit_gui_page_tag IMPLEMENTATION. CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION.
METHOD constructor. METHOD constructor.
@ -208,7 +208,7 @@ CLASS zcl_abapgit_gui_page_tag IMPLEMENTATION.
lv_s_param TYPE string, lv_s_param TYPE string,
lo_settings TYPE REF TO zcl_abapgit_settings, lo_settings TYPE REF TO zcl_abapgit_settings,
lv_body_size TYPE i, lv_body_size TYPE i,
lt_type TYPE stringtab, lt_type TYPE string_table,
lv_selected TYPE string. lv_selected TYPE string.
FIELD-SYMBOLS: <lv_type> LIKE LINE OF lt_type. FIELD-SYMBOLS: <lv_type> LIKE LINE OF lt_type.
@ -390,8 +390,8 @@ CLASS zcl_abapgit_gui_page_tag IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions. METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

5
src/ui/zcl_abapgit_popups.clas.abap
View File

@ -283,7 +283,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
METHOD on_select_list_link_click. METHOD on_select_list_link_click.
DATA: lv_line TYPE sytabix. DATA: lv_line TYPE sy-tabix.
FIELD-SYMBOLS: <lt_table> TYPE STANDARD TABLE, FIELD-SYMBOLS: <lt_table> TYPE STANDARD TABLE,
<lg_line> TYPE any, <lg_line> TYPE any,
@ -294,8 +294,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
lv_line = row. lv_line = row.
READ TABLE <lt_table> ASSIGNING <lg_line> READ TABLE <lt_table> ASSIGNING <lg_line> INDEX lv_line.
INDEX lv_line.
IF sy-subrc = 0. IF sy-subrc = 0.
ASSIGN COMPONENT c_fieldname_selected ASSIGN COMPONENT c_fieldname_selected

2
src/ui/zcl_abapgit_services_git.clas.abap
View File

@ -262,7 +262,7 @@ CLASS ZCL_ABAPGIT_SERVICES_GIT IMPLEMENTATION.
lv_answer TYPE c LENGTH 1, lv_answer TYPE c LENGTH 1,
lt_unnecessary_local_objs TYPE zif_abapgit_definitions=>ty_tadir_tt, lt_unnecessary_local_objs TYPE zif_abapgit_definitions=>ty_tadir_tt,
lt_selected LIKE lt_unnecessary_local_objs, lt_selected LIKE lt_unnecessary_local_objs,
lt_columns TYPE stringtab, lt_columns TYPE string_table,
ls_checks TYPE zif_abapgit_definitions=>ty_delete_checks, ls_checks TYPE zif_abapgit_definitions=>ty_delete_checks,
li_popups TYPE REF TO zif_abapgit_popups. li_popups TYPE REF TO zif_abapgit_popups.

4
src/ui/zcl_abapgit_services_repo.clas.abap
View File

@ -192,7 +192,7 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION.
METHOD popup_overwrite. METHOD popup_overwrite.
DATA: lt_columns TYPE stringtab, DATA: lt_columns TYPE string_table,
lt_selected LIKE ct_overwrite, lt_selected LIKE ct_overwrite,
lv_column LIKE LINE OF lt_columns, lv_column LIKE LINE OF lt_columns,
li_popups TYPE REF TO zif_abapgit_popups. li_popups TYPE REF TO zif_abapgit_popups.
@ -237,7 +237,7 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION.
METHOD popup_package_overwrite. METHOD popup_package_overwrite.
DATA: lt_colums_to_display TYPE stringtab, DATA: lt_colums_to_display TYPE string_table,
lv_column LIKE LINE OF lt_colums_to_display, lv_column LIKE LINE OF lt_colums_to_display,
lt_selected LIKE ct_overwrite, lt_selected LIKE ct_overwrite,
li_popups TYPE REF TO zif_abapgit_popups. li_popups TYPE REF TO zif_abapgit_popups.

2
src/ui/zif_abapgit_popups.intf.abap
View File

@ -113,7 +113,7 @@ INTERFACE zif_abapgit_popups
!it_list TYPE STANDARD TABLE !it_list TYPE STANDARD TABLE
!iv_header_text TYPE csequence !iv_header_text TYPE csequence
!iv_select_column_text TYPE csequence !iv_select_column_text TYPE csequence
!it_columns_to_display TYPE stringtab !it_columns_to_display TYPE string_table
EXPORTING EXPORTING
VALUE(et_list) TYPE STANDARD TABLE VALUE(et_list) TYPE STANDARD TABLE
RAISING RAISING

2
src/zabapgit_forms.prog.abap
View File

@ -142,7 +142,7 @@ FORM password_popup
ENDFORM. ENDFORM.
FORM remove_toolbar USING pv_dynnr TYPE char4. FORM remove_toolbar USING pv_dynnr TYPE sy-dynnr.
DATA: ls_header TYPE rpy_dyhead, DATA: ls_header TYPE rpy_dyhead,
lt_containers TYPE dycatt_tab, lt_containers TYPE dycatt_tab,

2
src/zabapgit_password_dialog.prog.abap
View File

@ -41,7 +41,7 @@ CLASS lcl_password_dialog DEFINITION FINAL.
CLASS-METHODS on_screen_output. CLASS-METHODS on_screen_output.
CLASS-METHODS on_screen_event CLASS-METHODS on_screen_event
IMPORTING IMPORTING
iv_ucomm TYPE syucomm. iv_ucomm TYPE sy-ucomm.
PRIVATE SECTION. PRIVATE SECTION.
CLASS-DATA gv_confirm TYPE abap_bool. CLASS-DATA gv_confirm TYPE abap_bool.

4
src/zcl_abapgit_settings.clas.abap
View File

@ -106,10 +106,10 @@ CLASS zcl_abapgit_settings DEFINITION PUBLIC CREATE PUBLIC.
zcx_abapgit_exception, zcx_abapgit_exception,
set_link_hint_key set_link_hint_key
IMPORTING IMPORTING
iv_link_hint_key TYPE char01, iv_link_hint_key TYPE string,
get_link_hint_key get_link_hint_key
RETURNING RETURNING
VALUE(rv_link_hint_key) TYPE char01, VALUE(rv_link_hint_key) TYPE string,
get_link_hint_background_color get_link_hint_background_color
RETURNING RETURNING
VALUE(rv_background_color) TYPE string, VALUE(rv_background_color) TYPE string,

4
src/zif_abapgit_definitions.intf.abap
View File

@ -244,7 +244,7 @@ INTERFACE zif_abapgit_definitions
email TYPE string, email TYPE string,
time TYPE string, time TYPE string,
message TYPE string, message TYPE string,
body TYPE stringtab, body TYPE string_table,
branch TYPE string, branch TYPE string,
merge TYPE string, merge TYPE string,
tags TYPE stringtab, tags TYPE stringtab,
@ -335,7 +335,7 @@ INTERFACE zif_abapgit_definitions
adt_jump_enabled TYPE abap_bool, adt_jump_enabled TYPE abap_bool,
show_default_repo TYPE abap_bool, show_default_repo TYPE abap_bool,
link_hints_enabled TYPE abap_bool, link_hints_enabled TYPE abap_bool,
link_hint_key TYPE char01, link_hint_key TYPE c LENGTH 1,
link_hint_background_color TYPE string, link_hint_background_color TYPE string,
hotkeys TYPE tty_hotkey, hotkeys TYPE tty_hotkey,
parallel_proc_disabled TYPE abap_bool, parallel_proc_disabled TYPE abap_bool,