OO factory, fix type (#7163)

This commit is contained in:
Lars Hvam 2025-03-24 17:37:35 +01:00 committed by GitHub
parent 18cf90740d
commit 1ef41d3f77
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 17 additions and 11 deletions

View File

@ -81,7 +81,7 @@ CLASS ltcl_abap_language_version DEFINITION FOR TESTING RISK LEVEL HARMLESS
PRIVATE SECTION.
" Cloud package hardcoded in cl_abap_language_version
CONSTANTS c_cloud_package TYPE devclass VALUE 'TEST_LANGUAGE_VERSION_SCP'.
CONSTANTS c_language_cfg TYPE seoclskey VALUE 'CL_ABAP_LANGUAGE_VERSION_CFG'.
CONSTANTS c_language_cfg TYPE seoclsname VALUE 'CL_ABAP_LANGUAGE_VERSION_CFG'.
DATA:
mt_versions TYPE string_table,

View File

@ -796,9 +796,11 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION.
METHOD zif_abapgit_oo_object_fnc~exists.
DATA ls_object_name TYPE seoclskey.
ls_object_name = iv_object_name.
CALL FUNCTION 'SEO_CLASS_EXISTENCE_CHECK'
EXPORTING
clskey = is_object_name
clskey = ls_object_name
EXCEPTIONS
not_specified = 1
not_existing = 2

View File

@ -16,11 +16,14 @@ CLASS zcl_abapgit_oo_factory DEFINITION PUBLIC.
RAISING
zcx_abapgit_exception.
PROTECTED SECTION.
PRIVATE SECTION.
ENDCLASS.
CLASS zcl_abapgit_oo_factory IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OO_FACTORY IMPLEMENTATION.
METHOD get_by_type.
IF iv_object_type = 'CLAS'.
@ -41,13 +44,13 @@ CLASS zcl_abapgit_oo_factory IMPLEMENTATION.
ls_object_name-clsname = to_upper( iv_object_name ).
CREATE OBJECT li_class TYPE zcl_abapgit_oo_class.
IF li_class->exists( ls_object_name ) = abap_true.
IF li_class->exists( ls_object_name-clsname ) = abap_true.
ri_object_oriented_object = li_class.
RETURN.
ENDIF.
CREATE OBJECT li_interface TYPE zcl_abapgit_oo_interface.
IF li_interface->exists( ls_object_name ) = abap_true.
IF li_interface->exists( ls_object_name-clsname ) = abap_true.
ri_object_oriented_object = li_interface.
RETURN.
ENDIF.
@ -55,5 +58,4 @@ CLASS zcl_abapgit_oo_factory IMPLEMENTATION.
zcx_abapgit_exception=>raise( |{ iv_object_name } is neither a class nor an interface| ).
ENDMETHOD.
ENDCLASS.

View File

@ -291,9 +291,11 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION.
METHOD zif_abapgit_oo_object_fnc~exists.
DATA ls_object_name TYPE seoclskey.
ls_object_name = iv_object_name.
CALL FUNCTION 'SEO_INTERFACE_EXISTENCE_CHECK'
EXPORTING
intkey = is_object_name
intkey = ls_object_name
EXCEPTIONS
not_specified = 1
not_existing = 2

View File

@ -119,7 +119,7 @@ INTERFACE zif_abapgit_oo_object_fnc PUBLIC.
zcx_abapgit_exception,
exists
IMPORTING
is_object_name TYPE seoclskey
iv_object_name TYPE seoclsname
RETURNING
VALUE(rv_exists) TYPE abap_bool,
serialize_abap

View File

@ -971,7 +971,7 @@ CLASS zcl_abapgit_object_clas IMPLEMENTATION.
ls_class_key-clsname = ms_item-obj_name.
rv_bool = mi_object_oriented_object_fct->exists( ls_class_key ).
rv_bool = mi_object_oriented_object_fct->exists( ls_class_key-clsname ).
" Skip classes generated by DDLS (SADL)
IF rv_bool = abap_true AND

View File

@ -673,7 +673,7 @@ CLASS zcl_abapgit_object_intf IMPLEMENTATION.
ls_class_key-clsname = ms_item-obj_name.
rv_bool = mi_object_oriented_object_fct->exists( ls_class_key ).
rv_bool = mi_object_oriented_object_fct->exists( ls_class_key-clsname ).
IF rv_bool = abap_true.
SELECT SINGLE category FROM seoclassdf INTO lv_category
@ -778,6 +778,7 @@ CLASS zcl_abapgit_object_intf IMPLEMENTATION.
ENDMETHOD.
METHOD extract_languages_for_transl.
DATA: lv_desc TYPE seocompotx,
lv_desc_int TYPE seoclasstx,
@ -811,5 +812,4 @@ CLASS zcl_abapgit_object_intf IMPLEMENTATION.
ENDLOOP.
ENDMETHOD.
ENDCLASS.