From 1f49f7a76ded8c9612b7e42c4c2f973ff113cfb1 Mon Sep 17 00:00:00 2001
From: mariusraht2 <45243391+mariusraht2@users.noreply.github.com>
Date: Wed, 8 Jan 2020 07:14:21 +0100
Subject: [PATCH] Issue 3130: TYPE: Type Group/Pool isn't being recognized
 (#3131)

* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Remove select for exists check

Due to the language flag-specific select a type group/pool couldn't be found. Removed the select at all because the following FM also recognizes unexistent type groups/pools and sets sy-subrc to something <> 0.

* Fill description if available in login language

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
---
 src/objects/zcl_abapgit_object_type.clas.abap | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/objects/zcl_abapgit_object_type.clas.abap b/src/objects/zcl_abapgit_object_type.clas.abap
index b6e86f84b..d3b33b212 100644
--- a/src/objects/zcl_abapgit_object_type.clas.abap
+++ b/src/objects/zcl_abapgit_object_type.clas.abap
@@ -11,8 +11,7 @@ CLASS zcl_abapgit_object_type DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
     METHODS read
       EXPORTING ev_ddtext TYPE ddtypet-ddtext
                 et_source TYPE abaptxt255_tab
-      RAISING   zcx_abapgit_exception
-                zcx_abapgit_not_found.
+      RAISING   zcx_abapgit_not_found.
 
     METHODS create
       IMPORTING iv_ddtext   TYPE ddtypet-ddtext
@@ -24,7 +23,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
+CLASS zcl_abapgit_object_type IMPLEMENTATION.
 
 
   METHOD create.
@@ -74,11 +73,8 @@ CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
 
     SELECT SINGLE ddtext FROM ddtypet
       INTO ev_ddtext
-      WHERE typegroup = ms_item-obj_name
-      AND ddlanguage = mv_language.
-    IF sy-subrc <> 0.
-      RAISE EXCEPTION TYPE zcx_abapgit_not_found.
-    ENDIF.
+      WHERE typegroup  = ms_item-obj_name
+        AND ddlanguage = mv_language.
 
     lv_typdname = ms_item-obj_name.
     CALL FUNCTION 'TYPD_GET_OBJECT'
@@ -94,7 +90,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
         reps_not_exist    = 2
         OTHERS            = 3.
     IF sy-subrc <> 0.
-      zcx_abapgit_exception=>raise( 'error from TYPD_GET_OBJECT' ).
+      RAISE EXCEPTION TYPE zcx_abapgit_not_found.
     ENDIF.
 
   ENDMETHOD.
@@ -166,7 +162,8 @@ CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
     TRY.
         read( ).
         rv_bool = abap_true.
-      CATCH zcx_abapgit_not_found zcx_abapgit_exception.
+      CATCH zcx_abapgit_not_found
+            zcx_abapgit_exception.
         rv_bool = abap_false.
     ENDTRY.