SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Issue 3130: TYPE: Type Group/Pool isn't being recognized (#3131)

Browse Source 
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Remove select for exists check

Due to the language flag-specific select a type group/pool couldn't be found. Removed the select at all because the following FM also recognizes unexistent type groups/pools and sets sy-subrc to something <> 0.

* Fill description if available in login language

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
mariusraht2 2020-01-08 07:14:21 +01:00 committed by Lars Hvam
parent baac63ce87
commit 1f49f7a76d
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/objects/zcl_abapgit_object_type.clas.abap
View File

@ -11,8 +11,7 @@ CLASS zcl_abapgit_object_type DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
METHODS read METHODS read
EXPORTING ev_ddtext TYPE ddtypet-ddtext EXPORTING ev_ddtext TYPE ddtypet-ddtext
et_source TYPE abaptxt255_tab et_source TYPE abaptxt255_tab
RAISING zcx_abapgit_exception RAISING zcx_abapgit_not_found.
zcx_abapgit_not_found.
METHODS create METHODS create
IMPORTING iv_ddtext TYPE ddtypet-ddtext IMPORTING iv_ddtext TYPE ddtypet-ddtext
@ -24,7 +23,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION. CLASS zcl_abapgit_object_type IMPLEMENTATION.
METHOD create. METHOD create.
@ -76,9 +75,6 @@ CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
INTO ev_ddtext INTO ev_ddtext
WHERE typegroup = ms_item-obj_name WHERE typegroup = ms_item-obj_name
AND ddlanguage = mv_language. AND ddlanguage = mv_language.
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE zcx_abapgit_not_found.
ENDIF.
lv_typdname = ms_item-obj_name. lv_typdname = ms_item-obj_name.
CALL FUNCTION 'TYPD_GET_OBJECT' CALL FUNCTION 'TYPD_GET_OBJECT'
@ -94,7 +90,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
reps_not_exist = 2 reps_not_exist = 2
OTHERS = 3. OTHERS = 3.
IF sy-subrc <> 0. IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from TYPD_GET_OBJECT' ). RAISE EXCEPTION TYPE zcx_abapgit_not_found.
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
@ -166,7 +162,8 @@ CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
TRY. TRY.
read( ). read( ).
rv_bool = abap_true. rv_bool = abap_true.
CATCH zcx_abapgit_not_found zcx_abapgit_exception. CATCH zcx_abapgit_not_found
zcx_abapgit_exception.
rv_bool = abap_false. rv_bool = abap_false.
ENDTRY. ENDTRY.