From 20ec92d224a44e30ebd3976e47e1b2f05db5459d Mon Sep 17 00:00:00 2001
From: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Date: Sat, 4 Nov 2023 04:58:26 -0400
Subject: [PATCH] Sort pull request popup (#6623)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
---
 .../zcl_abapgit_popup_pull_request.clas.abap  | 35 ++++++++++---------
 1 file changed, 19 insertions(+), 16 deletions(-)

diff --git a/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap b/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap
index 05cf2a7a4..e6ed9f72b 100644
--- a/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap
+++ b/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap
@@ -18,6 +18,7 @@ CLASS zcl_abapgit_popup_pull_request DEFINITION
       IMPORTING
         iv_url TYPE string.
 
+  PROTECTED SECTION.
   PRIVATE SECTION.
 
     DATA mv_repo_url TYPE string.
@@ -34,6 +35,11 @@ ENDCLASS.
 CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
 
 
+  METHOD constructor.
+    mv_repo_url = iv_url.
+  ENDMETHOD.
+
+
   METHOD create.
 
     CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_pull_request
@@ -43,26 +49,12 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
   ENDMETHOD.
 
 
-  METHOD constructor.
-    mv_repo_url = iv_url.
-  ENDMETHOD.
-
-
-  METHOD zif_abapgit_html_popup~create_picklist.
-
-    CREATE OBJECT ro_picklist
-      EXPORTING
-        iv_title         = 'Choose Pull Request'
-        it_list          = fetch_pull_request_list( )
-        ii_item_renderer = me.
-
-  ENDMETHOD.
-
-
   METHOD fetch_pull_request_list.
 
     rt_pulls = zcl_abapgit_pr_enumerator=>new( mv_repo_url )->get_pulls( ).
 
+    SORT rt_pulls DESCENDING BY number.
+
     IF lines( rt_pulls ) = 0.
       zcx_abapgit_exception=>raise( 'No pull requests found' ).
     ENDIF.
@@ -80,4 +72,15 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
     ri_html = zcl_abapgit_html=>create( |<b>{ <ls_pr>-number }</b> - { <ls_pr>-title } @{ <ls_pr>-user }| ).
 
   ENDMETHOD.
+
+
+  METHOD zif_abapgit_html_popup~create_picklist.
+
+    CREATE OBJECT ro_picklist
+      EXPORTING
+        iv_title         = 'Choose Pull Request'
+        it_list          = fetch_pull_request_list( )
+        ii_item_renderer = me.
+
+  ENDMETHOD.
 ENDCLASS.