Sort pull request popup (#6623)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2023-11-04 04:58:26 -04:00 committed by GitHub
parent 6d4fefa513
commit 20ec92d224
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -18,6 +18,7 @@ CLASS zcl_abapgit_popup_pull_request DEFINITION
IMPORTING IMPORTING
iv_url TYPE string. iv_url TYPE string.
PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
DATA mv_repo_url TYPE string. DATA mv_repo_url TYPE string.
@ -34,6 +35,11 @@ ENDCLASS.
CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION. CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
METHOD constructor.
mv_repo_url = iv_url.
ENDMETHOD.
METHOD create. METHOD create.
CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_pull_request CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_pull_request
@ -43,26 +49,12 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD constructor.
mv_repo_url = iv_url.
ENDMETHOD.
METHOD zif_abapgit_html_popup~create_picklist.
CREATE OBJECT ro_picklist
EXPORTING
iv_title = 'Choose Pull Request'
it_list = fetch_pull_request_list( )
ii_item_renderer = me.
ENDMETHOD.
METHOD fetch_pull_request_list. METHOD fetch_pull_request_list.
rt_pulls = zcl_abapgit_pr_enumerator=>new( mv_repo_url )->get_pulls( ). rt_pulls = zcl_abapgit_pr_enumerator=>new( mv_repo_url )->get_pulls( ).
SORT rt_pulls DESCENDING BY number.
IF lines( rt_pulls ) = 0. IF lines( rt_pulls ) = 0.
zcx_abapgit_exception=>raise( 'No pull requests found' ). zcx_abapgit_exception=>raise( 'No pull requests found' ).
ENDIF. ENDIF.
@ -80,4 +72,15 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
ri_html = zcl_abapgit_html=>create( |<b>{ <ls_pr>-number }</b> - { <ls_pr>-title } @{ <ls_pr>-user }| ). ri_html = zcl_abapgit_html=>create( |<b>{ <ls_pr>-number }</b> - { <ls_pr>-title } @{ <ls_pr>-user }| ).
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_html_popup~create_picklist.
CREATE OBJECT ro_picklist
EXPORTING
iv_title = 'Choose Pull Request'
it_list = fetch_pull_request_list( )
ii_item_renderer = me.
ENDMETHOD.
ENDCLASS. ENDCLASS.