From 25bbbf89cd5a4056c1641fa7a510b17f43720a51 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Fri, 6 Jan 2023 15:56:12 +0100 Subject: [PATCH] Refactor: Remove `delete_tadir` flag (#5949) Co-authored-by: Lars Hvam --- src/objects/zcl_abapgit_object_amsd.clas.abap | 1 - src/objects/zcl_abapgit_object_asfc.clas.abap | 3 -- src/objects/zcl_abapgit_object_auth.clas.abap | 1 - src/objects/zcl_abapgit_object_avar.clas.abap | 3 +- src/objects/zcl_abapgit_object_bdef.clas.abap | 1 - src/objects/zcl_abapgit_object_cmpt.clas.abap | 5 +-- src/objects/zcl_abapgit_object_cus0.clas.abap | 1 - src/objects/zcl_abapgit_object_cus1.clas.abap | 1 - src/objects/zcl_abapgit_object_dcls.clas.abap | 1 - src/objects/zcl_abapgit_object_ddls.clas.abap | 1 - src/objects/zcl_abapgit_object_ddlx.clas.abap | 1 - src/objects/zcl_abapgit_object_docv.clas.abap | 1 - src/objects/zcl_abapgit_object_drul.clas.abap | 1 - src/objects/zcl_abapgit_object_dsys.clas.abap | 1 - src/objects/zcl_abapgit_object_dtdc.clas.abap | 1 - src/objects/zcl_abapgit_object_fdt0.clas.abap | 1 - src/objects/zcl_abapgit_object_form.clas.abap | 3 -- src/objects/zcl_abapgit_object_ftgl.clas.abap | 1 - src/objects/zcl_abapgit_object_g4ba.clas.abap | 3 -- src/objects/zcl_abapgit_object_g4bs.clas.abap | 3 -- src/objects/zcl_abapgit_object_iobj.clas.abap | 34 ++------------ src/objects/zcl_abapgit_object_iwmo.clas.abap | 3 -- src/objects/zcl_abapgit_object_iwom.clas.abap | 45 +++++++++---------- src/objects/zcl_abapgit_object_iwpr.clas.abap | 45 +++++++++---------- src/objects/zcl_abapgit_object_iwsg.clas.abap | 5 +-- src/objects/zcl_abapgit_object_iwsv.clas.abap | 3 -- src/objects/zcl_abapgit_object_iwvb.clas.abap | 3 -- src/objects/zcl_abapgit_object_jobd.clas.abap | 3 -- src/objects/zcl_abapgit_object_oa2p.clas.abap | 40 +---------------- src/objects/zcl_abapgit_object_pers.clas.abap | 1 - src/objects/zcl_abapgit_object_prag.clas.abap | 3 -- .../zcl_abapgit_object_saxx_super.clas.abap | 1 - src/objects/zcl_abapgit_object_sfbf.clas.abap | 3 +- src/objects/zcl_abapgit_object_sfbs.clas.abap | 3 +- src/objects/zcl_abapgit_object_smtg.clas.abap | 1 - src/objects/zcl_abapgit_object_sobj.clas.abap | 5 +-- src/objects/zcl_abapgit_object_splo.clas.abap | 1 - src/objects/zcl_abapgit_object_sppf.clas.abap | 3 -- src/objects/zcl_abapgit_object_sqsc.clas.abap | 2 - src/objects/zcl_abapgit_object_srfc.clas.abap | 1 - src/objects/zcl_abapgit_object_srvb.clas.abap | 1 - src/objects/zcl_abapgit_object_srvd.clas.abap | 12 +---- src/objects/zcl_abapgit_object_ssfo.clas.abap | 1 - src/objects/zcl_abapgit_object_ssst.clas.abap | 1 - src/objects/zcl_abapgit_object_styl.clas.abap | 1 - src/objects/zcl_abapgit_object_sucu.clas.abap | 3 -- src/objects/zcl_abapgit_object_susc.clas.abap | 1 - src/objects/zcl_abapgit_object_sush.clas.abap | 1 - src/objects/zcl_abapgit_object_tobj.clas.abap | 3 +- src/objects/zcl_abapgit_object_ucsa.clas.abap | 5 +-- src/objects/zcl_abapgit_object_vcls.clas.abap | 1 - .../zcl_abapgit_object_w3xx_super.clas.abap | 6 +-- src/objects/zcl_abapgit_object_wdcc.clas.abap | 9 +--- src/objects/zcl_abapgit_objects.clas.abap | 21 --------- .../zcl_abapgit_objects_bridge.clas.abap | 3 +- .../zcl_abapgit_objects_generic.clas.abap | 32 ++++++------- .../zcl_abapgit_objects_super.clas.abap | 45 +++++++++++++++++++ .../zcl_abapgit_gui_page_debuginfo.clas.abap | 1 - src/zif_abapgit_definitions.intf.abap | 5 +-- 59 files changed, 130 insertions(+), 261 deletions(-) diff --git a/src/objects/zcl_abapgit_object_amsd.clas.abap b/src/objects/zcl_abapgit_object_amsd.clas.abap index 06ef0aaed..5c5d76433 100644 --- a/src/objects/zcl_abapgit_object_amsd.clas.abap +++ b/src/objects/zcl_abapgit_object_amsd.clas.abap @@ -321,7 +321,6 @@ CLASS zcl_abapgit_object_amsd IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_asfc.clas.abap b/src/objects/zcl_abapgit_object_asfc.clas.abap index eeb7bc1e9..1a4449a30 100644 --- a/src/objects/zcl_abapgit_object_asfc.clas.abap +++ b/src/objects/zcl_abapgit_object_asfc.clas.abap @@ -74,10 +74,7 @@ CLASS zcl_abapgit_object_asfc IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_auth.clas.abap b/src/objects/zcl_abapgit_object_auth.clas.abap index 54b8946cf..6fb099dae 100644 --- a/src/objects/zcl_abapgit_object_auth.clas.abap +++ b/src/objects/zcl_abapgit_object_auth.clas.abap @@ -128,7 +128,6 @@ CLASS zcl_abapgit_object_auth IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_avar.clas.abap b/src/objects/zcl_abapgit_object_avar.clas.abap index 66fee3e75..b8c8df913 100644 --- a/src/objects/zcl_abapgit_object_avar.clas.abap +++ b/src/objects/zcl_abapgit_object_avar.clas.abap @@ -17,7 +17,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_OBJECT_AVAR IMPLEMENTATION. +CLASS zcl_abapgit_object_avar IMPLEMENTATION. METHOD create_object. @@ -170,7 +170,6 @@ CLASS ZCL_ABAPGIT_OBJECT_AVAR IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_bdef.clas.abap b/src/objects/zcl_abapgit_object_bdef.clas.abap index 27d989789..d311141bc 100644 --- a/src/objects/zcl_abapgit_object_bdef.clas.abap +++ b/src/objects/zcl_abapgit_object_bdef.clas.abap @@ -522,7 +522,6 @@ CLASS zcl_abapgit_object_bdef IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_cmpt.clas.abap b/src/objects/zcl_abapgit_object_cmpt.clas.abap index 49c8dde4c..bd75ed696 100644 --- a/src/objects/zcl_abapgit_object_cmpt.clas.abap +++ b/src/objects/zcl_abapgit_object_cmpt.clas.abap @@ -84,6 +84,8 @@ CLASS zcl_abapgit_object_cmpt IMPLEMENTATION. zcx_abapgit_exception=>raise( |Error deleting CMPT { ms_item-obj_name }| ). ENDIF. + tadir_delete( ). + ENDMETHOD. @@ -169,10 +171,7 @@ CLASS zcl_abapgit_object_cmpt IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_cus0.clas.abap b/src/objects/zcl_abapgit_object_cus0.clas.abap index 64d765b45..46439655e 100644 --- a/src/objects/zcl_abapgit_object_cus0.clas.abap +++ b/src/objects/zcl_abapgit_object_cus0.clas.abap @@ -127,7 +127,6 @@ CLASS zcl_abapgit_object_cus0 IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_cus1.clas.abap b/src/objects/zcl_abapgit_object_cus1.clas.abap index 0058987f6..8025e7053 100644 --- a/src/objects/zcl_abapgit_object_cus1.clas.abap +++ b/src/objects/zcl_abapgit_object_cus1.clas.abap @@ -144,7 +144,6 @@ CLASS zcl_abapgit_object_cus1 IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_dcls.clas.abap b/src/objects/zcl_abapgit_object_dcls.clas.abap index da925fd60..a0b23e61c 100644 --- a/src/objects/zcl_abapgit_object_dcls.clas.abap +++ b/src/objects/zcl_abapgit_object_dcls.clas.abap @@ -150,7 +150,6 @@ CLASS zcl_abapgit_object_dcls IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ddls.clas.abap b/src/objects/zcl_abapgit_object_ddls.clas.abap index e28e3fc0b..386297d5b 100644 --- a/src/objects/zcl_abapgit_object_ddls.clas.abap +++ b/src/objects/zcl_abapgit_object_ddls.clas.abap @@ -374,7 +374,6 @@ CLASS zcl_abapgit_object_ddls IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ddlx.clas.abap b/src/objects/zcl_abapgit_object_ddlx.clas.abap index a7a527f14..8cfc6a255 100644 --- a/src/objects/zcl_abapgit_object_ddlx.clas.abap +++ b/src/objects/zcl_abapgit_object_ddlx.clas.abap @@ -268,7 +268,6 @@ CLASS zcl_abapgit_object_ddlx IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_docv.clas.abap b/src/objects/zcl_abapgit_object_docv.clas.abap index f5dd48aec..9d38d7067 100644 --- a/src/objects/zcl_abapgit_object_docv.clas.abap +++ b/src/objects/zcl_abapgit_object_docv.clas.abap @@ -166,7 +166,6 @@ CLASS zcl_abapgit_object_docv IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_drul.clas.abap b/src/objects/zcl_abapgit_object_drul.clas.abap index f214d7745..12f6c3e25 100644 --- a/src/objects/zcl_abapgit_object_drul.clas.abap +++ b/src/objects/zcl_abapgit_object_drul.clas.abap @@ -352,7 +352,6 @@ CLASS zcl_abapgit_object_drul IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_dsys.clas.abap b/src/objects/zcl_abapgit_object_dsys.clas.abap index 486aeba93..f17b534d6 100644 --- a/src/objects/zcl_abapgit_object_dsys.clas.abap +++ b/src/objects/zcl_abapgit_object_dsys.clas.abap @@ -184,7 +184,6 @@ CLASS zcl_abapgit_object_dsys IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. rs_metadata-version = 'v2.0.0'. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_dtdc.clas.abap b/src/objects/zcl_abapgit_object_dtdc.clas.abap index a308dd561..10d736b9b 100644 --- a/src/objects/zcl_abapgit_object_dtdc.clas.abap +++ b/src/objects/zcl_abapgit_object_dtdc.clas.abap @@ -397,7 +397,6 @@ CLASS zcl_abapgit_object_dtdc IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_fdt0.clas.abap b/src/objects/zcl_abapgit_object_fdt0.clas.abap index 1cfa227bd..6c6707144 100644 --- a/src/objects/zcl_abapgit_object_fdt0.clas.abap +++ b/src/objects/zcl_abapgit_object_fdt0.clas.abap @@ -618,7 +618,6 @@ CLASS zcl_abapgit_object_fdt0 IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_form.clas.abap b/src/objects/zcl_abapgit_object_form.clas.abap index 1d9e6374c..d2c1dd002 100644 --- a/src/objects/zcl_abapgit_object_form.clas.abap +++ b/src/objects/zcl_abapgit_object_form.clas.abap @@ -334,10 +334,7 @@ CLASS zcl_abapgit_object_form IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ftgl.clas.abap b/src/objects/zcl_abapgit_object_ftgl.clas.abap index 72d93439d..01c62e063 100644 --- a/src/objects/zcl_abapgit_object_ftgl.clas.abap +++ b/src/objects/zcl_abapgit_object_ftgl.clas.abap @@ -147,7 +147,6 @@ CLASS zcl_abapgit_object_ftgl IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_g4ba.clas.abap b/src/objects/zcl_abapgit_object_g4ba.clas.abap index ccf6bb0ee..824237013 100644 --- a/src/objects/zcl_abapgit_object_g4ba.clas.abap +++ b/src/objects/zcl_abapgit_object_g4ba.clas.abap @@ -122,10 +122,7 @@ CLASS zcl_abapgit_object_g4ba IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_g4bs.clas.abap b/src/objects/zcl_abapgit_object_g4bs.clas.abap index 376c5aa2d..231f4b8bf 100644 --- a/src/objects/zcl_abapgit_object_g4bs.clas.abap +++ b/src/objects/zcl_abapgit_object_g4bs.clas.abap @@ -125,10 +125,7 @@ CLASS zcl_abapgit_object_g4bs IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iobj.clas.abap b/src/objects/zcl_abapgit_object_iobj.clas.abap index 313f4f5ca..14ee0a2f8 100644 --- a/src/objects/zcl_abapgit_object_iobj.clas.abap +++ b/src/objects/zcl_abapgit_object_iobj.clas.abap @@ -77,13 +77,8 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION. objnm TYPE c LENGTH 30. TYPES END OF ty_iobj. - DATA: lt_iobjname TYPE STANDARD TABLE OF ty_iobj, - lv_subrc TYPE sy-subrc, - lv_object TYPE string, - lv_object_class TYPE string, - lv_transp_pkg TYPE abap_bool. - - lv_transp_pkg = zcl_abapgit_factory=>get_sap_package( iv_package )->are_changes_recorded_in_tr_req( ). + DATA: lt_iobjname TYPE STANDARD TABLE OF ty_iobj, + lv_subrc TYPE sy-subrc. APPEND ms_item-obj_name TO lt_iobjname. @@ -97,29 +92,7 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION. zcx_abapgit_exception=>raise( |Error when deleting InfoObject { ms_item-obj_name }| ). ENDIF. - IF lv_transp_pkg = abap_true. - - lv_object_class = ms_item-obj_type. - lv_object = ms_item-obj_name. - - CALL FUNCTION 'RS_CORR_INSERT' - EXPORTING - object = lv_object - object_class = lv_object_class - master_language = mv_language - global_lock = abap_true - mode = 'D' - suppress_dialog = abap_true - EXCEPTIONS - cancelled = 1 - permission_failure = 2 - unknown_objectclass = 3 - OTHERS = 4. - IF sy-subrc <> 0. - zcx_abapgit_exception=>raise_t100( ). - ENDIF. - - ENDIF. + corr_insert( iv_package ). ENDMETHOD. @@ -304,7 +277,6 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwmo.clas.abap b/src/objects/zcl_abapgit_object_iwmo.clas.abap index ec5e80a81..370a38dba 100644 --- a/src/objects/zcl_abapgit_object_iwmo.clas.abap +++ b/src/objects/zcl_abapgit_object_iwmo.clas.abap @@ -107,10 +107,7 @@ CLASS zcl_abapgit_object_iwmo IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwom.clas.abap b/src/objects/zcl_abapgit_object_iwom.clas.abap index 9e6075d99..92dc0b7b7 100644 --- a/src/objects/zcl_abapgit_object_iwom.clas.abap +++ b/src/objects/zcl_abapgit_object_iwom.clas.abap @@ -24,6 +24,27 @@ ENDCLASS. CLASS zcl_abapgit_object_iwom IMPLEMENTATION. + METHOD get_field_rules. + ro_result = zcl_abapgit_field_rules=>create( ). + ro_result->add( + iv_table = '/IWFND/I_MED_OHD' + iv_field = 'CREATED_BY' + iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user + )->add( + iv_table = '/IWFND/I_MED_OHD' + iv_field = 'CREATED_TIMESTMP' + iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp + )->add( + iv_table = '/IWFND/I_MED_OHD' + iv_field = 'CHANGED_BY' + iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user + )->add( + iv_table = '/IWFND/I_MED_OHD' + iv_field = 'CHANGED_TIMESTMP' + iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp ). + ENDMETHOD. + + METHOD get_generic. CREATE OBJECT ro_generic @@ -74,10 +95,7 @@ CLASS zcl_abapgit_object_iwom IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. @@ -102,25 +120,4 @@ CLASS zcl_abapgit_object_iwom IMPLEMENTATION. get_generic( )->serialize( io_xml ). ENDMETHOD. - - METHOD get_field_rules. - ro_result = zcl_abapgit_field_rules=>create( ). - ro_result->add( - iv_table = '/IWFND/I_MED_OHD' - iv_field = 'CREATED_BY' - iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user - )->add( - iv_table = '/IWFND/I_MED_OHD' - iv_field = 'CREATED_TIMESTMP' - iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp - )->add( - iv_table = '/IWFND/I_MED_OHD' - iv_field = 'CHANGED_BY' - iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user - )->add( - iv_table = '/IWFND/I_MED_OHD' - iv_field = 'CHANGED_TIMESTMP' - iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp ). - ENDMETHOD. - ENDCLASS. diff --git a/src/objects/zcl_abapgit_object_iwpr.clas.abap b/src/objects/zcl_abapgit_object_iwpr.clas.abap index 4caf220ee..150ff089e 100644 --- a/src/objects/zcl_abapgit_object_iwpr.clas.abap +++ b/src/objects/zcl_abapgit_object_iwpr.clas.abap @@ -24,6 +24,27 @@ ENDCLASS. CLASS zcl_abapgit_object_iwpr IMPLEMENTATION. + METHOD get_field_rules. + ro_result = zcl_abapgit_field_rules=>create( ). + ro_result->add( + iv_table = '/IWBEP/I_SBD_GA' + iv_field = 'CREATION_USER_ID' + iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user + )->add( + iv_table = '/IWBEP/I_SBD_GA' + iv_field = 'CREATION_TIME' + iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp + )->add( + iv_table = '/IWBEP/I_SBD_GA' + iv_field = 'LAST_CHG_USER_ID' + iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user + )->add( + iv_table = '/IWBEP/I_SBD_GA' + iv_field = 'LAST_CHG_TIME' + iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp ). + ENDMETHOD. + + METHOD get_generic. CREATE OBJECT ro_generic @@ -74,10 +95,7 @@ CLASS zcl_abapgit_object_iwpr IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. @@ -109,25 +127,4 @@ CLASS zcl_abapgit_object_iwpr IMPLEMENTATION. get_generic( )->serialize( io_xml ). ENDMETHOD. - - METHOD get_field_rules. - ro_result = zcl_abapgit_field_rules=>create( ). - ro_result->add( - iv_table = '/IWBEP/I_SBD_GA' - iv_field = 'CREATION_USER_ID' - iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user - )->add( - iv_table = '/IWBEP/I_SBD_GA' - iv_field = 'CREATION_TIME' - iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp - )->add( - iv_table = '/IWBEP/I_SBD_GA' - iv_field = 'LAST_CHG_USER_ID' - iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user - )->add( - iv_table = '/IWBEP/I_SBD_GA' - iv_field = 'LAST_CHG_TIME' - iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp ). - ENDMETHOD. - ENDCLASS. diff --git a/src/objects/zcl_abapgit_object_iwsg.clas.abap b/src/objects/zcl_abapgit_object_iwsg.clas.abap index 18bb844e8..2b7085a82 100644 --- a/src/objects/zcl_abapgit_object_iwsg.clas.abap +++ b/src/objects/zcl_abapgit_object_iwsg.clas.abap @@ -21,7 +21,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_OBJECT_IWSG IMPLEMENTATION. +CLASS zcl_abapgit_object_iwsg IMPLEMENTATION. METHOD get_field_rules. @@ -103,10 +103,7 @@ CLASS ZCL_ABAPGIT_OBJECT_IWSG IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwsv.clas.abap b/src/objects/zcl_abapgit_object_iwsv.clas.abap index 153fa053c..c3d36cfd9 100644 --- a/src/objects/zcl_abapgit_object_iwsv.clas.abap +++ b/src/objects/zcl_abapgit_object_iwsv.clas.abap @@ -107,10 +107,7 @@ CLASS zcl_abapgit_object_iwsv IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwvb.clas.abap b/src/objects/zcl_abapgit_object_iwvb.clas.abap index 1c7071951..9dca5d451 100644 --- a/src/objects/zcl_abapgit_object_iwvb.clas.abap +++ b/src/objects/zcl_abapgit_object_iwvb.clas.abap @@ -107,10 +107,7 @@ CLASS zcl_abapgit_object_iwvb IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_jobd.clas.abap b/src/objects/zcl_abapgit_object_jobd.clas.abap index 3653f496f..63d2578db 100644 --- a/src/objects/zcl_abapgit_object_jobd.clas.abap +++ b/src/objects/zcl_abapgit_object_jobd.clas.abap @@ -117,10 +117,7 @@ CLASS zcl_abapgit_object_jobd IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_oa2p.clas.abap b/src/objects/zcl_abapgit_object_oa2p.clas.abap index b1af9e7fd..4f266ae64 100644 --- a/src/objects/zcl_abapgit_object_oa2p.clas.abap +++ b/src/objects/zcl_abapgit_object_oa2p.clas.abap @@ -75,11 +75,7 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION. METHOD zif_abapgit_object~delete. - DATA: - lv_object TYPE string, - lv_object_class TYPE string, - lv_transp_pkg TYPE abap_bool, - lv_dummy TYPE string. + DATA lv_dummy TYPE string. CONSTANTS: lc_actvt TYPE c LENGTH 2 VALUE `06`. @@ -108,38 +104,7 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION. zcx_abapgit_exception=>raise( |Error when deleting OAuth2 Profile { lv_profile_key }.| ). ENDTRY. - - "collect change in transport - lv_transp_pkg = zcl_abapgit_factory=>get_sap_package( iv_package )->are_changes_recorded_in_tr_req( ). - IF lv_transp_pkg = abap_true. - - lv_object_class = ms_item-obj_type. - lv_object = ms_item-obj_name. - - CALL FUNCTION 'RS_CORR_INSERT' - EXPORTING - object = lv_object - object_class = lv_object_class - master_language = mv_language - global_lock = abap_true - mode = 'D' - suppress_dialog = abap_true - EXCEPTIONS - cancelled = 1 - permission_failure = 2 - unknown_objectclass = 3 - OTHERS = 4. - IF sy-subrc <> 0. - zcx_abapgit_exception=>raise_t100( - iv_msgid = sy-msgid - iv_msgno = sy-msgno - iv_msgv1 = sy-msgv1 - iv_msgv2 = sy-msgv2 - iv_msgv3 = sy-msgv3 - iv_msgv4 = sy-msgv4 ). - ENDIF. - ENDIF. - + corr_insert( iv_package ). ENDMETHOD. @@ -209,7 +174,6 @@ CLASS zcl_abapgit_object_oa2p IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_pers.clas.abap b/src/objects/zcl_abapgit_object_pers.clas.abap index 4a20de0a1..38d4f3b05 100644 --- a/src/objects/zcl_abapgit_object_pers.clas.abap +++ b/src/objects/zcl_abapgit_object_pers.clas.abap @@ -156,7 +156,6 @@ CLASS zcl_abapgit_object_pers IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_prag.clas.abap b/src/objects/zcl_abapgit_object_prag.clas.abap index 40bd5a605..3b4272294 100644 --- a/src/objects/zcl_abapgit_object_prag.clas.abap +++ b/src/objects/zcl_abapgit_object_prag.clas.abap @@ -109,10 +109,7 @@ CLASS zcl_abapgit_object_prag IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_saxx_super.clas.abap b/src/objects/zcl_abapgit_object_saxx_super.clas.abap index d71da2b14..7070b97c4 100644 --- a/src/objects/zcl_abapgit_object_saxx_super.clas.abap +++ b/src/objects/zcl_abapgit_object_saxx_super.clas.abap @@ -314,7 +314,6 @@ CLASS zcl_abapgit_object_saxx_super IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sfbf.clas.abap b/src/objects/zcl_abapgit_object_sfbf.clas.abap index 252734302..b48563e3b 100644 --- a/src/objects/zcl_abapgit_object_sfbf.clas.abap +++ b/src/objects/zcl_abapgit_object_sfbf.clas.abap @@ -71,6 +71,8 @@ CLASS zcl_abapgit_object_sfbf IMPLEMENTATION. zcx_abapgit_exception=>raise( 'Error deleting SFBF' ). ENDIF. + tadir_delete( ). + ENDMETHOD. @@ -178,7 +180,6 @@ CLASS zcl_abapgit_object_sfbf IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sfbs.clas.abap b/src/objects/zcl_abapgit_object_sfbs.clas.abap index 8e046e507..ec5e602e0 100644 --- a/src/objects/zcl_abapgit_object_sfbs.clas.abap +++ b/src/objects/zcl_abapgit_object_sfbs.clas.abap @@ -70,6 +70,8 @@ CLASS zcl_abapgit_object_sfbs IMPLEMENTATION. zcx_abapgit_exception=>raise( 'Error deleting SFBS' ). ENDIF. + tadir_delete( ). + ENDMETHOD. @@ -166,7 +168,6 @@ CLASS zcl_abapgit_object_sfbs IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_smtg.clas.abap b/src/objects/zcl_abapgit_object_smtg.clas.abap index 175ae5902..18026dd45 100644 --- a/src/objects/zcl_abapgit_object_smtg.clas.abap +++ b/src/objects/zcl_abapgit_object_smtg.clas.abap @@ -369,7 +369,6 @@ CLASS zcl_abapgit_object_smtg IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sobj.clas.abap b/src/objects/zcl_abapgit_object_sobj.clas.abap index 162f1b54b..dba345db0 100644 --- a/src/objects/zcl_abapgit_object_sobj.clas.abap +++ b/src/objects/zcl_abapgit_object_sobj.clas.abap @@ -25,7 +25,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_OBJECT_SOBJ IMPLEMENTATION. +CLASS zcl_abapgit_object_sobj IMPLEMENTATION. METHOD get_field_rules. @@ -211,10 +211,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SOBJ IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_splo.clas.abap b/src/objects/zcl_abapgit_object_splo.clas.abap index 1f1df59b5..1a37e264d 100644 --- a/src/objects/zcl_abapgit_object_splo.clas.abap +++ b/src/objects/zcl_abapgit_object_splo.clas.abap @@ -86,7 +86,6 @@ CLASS zcl_abapgit_object_splo IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sppf.clas.abap b/src/objects/zcl_abapgit_object_sppf.clas.abap index f3314cb2e..62cdb926b 100644 --- a/src/objects/zcl_abapgit_object_sppf.clas.abap +++ b/src/objects/zcl_abapgit_object_sppf.clas.abap @@ -74,10 +74,7 @@ CLASS zcl_abapgit_object_sppf IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sqsc.clas.abap b/src/objects/zcl_abapgit_object_sqsc.clas.abap index e23ee2f3d..41ccd38ac 100644 --- a/src/objects/zcl_abapgit_object_sqsc.clas.abap +++ b/src/objects/zcl_abapgit_object_sqsc.clas.abap @@ -258,8 +258,6 @@ CLASS zcl_abapgit_object_sqsc IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_srfc.clas.abap b/src/objects/zcl_abapgit_object_srfc.clas.abap index 8dd81ed4e..710807648 100644 --- a/src/objects/zcl_abapgit_object_srfc.clas.abap +++ b/src/objects/zcl_abapgit_object_srfc.clas.abap @@ -191,7 +191,6 @@ CLASS zcl_abapgit_object_srfc IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_srvb.clas.abap b/src/objects/zcl_abapgit_object_srvb.clas.abap index 13a8bdf17..8caa6d269 100644 --- a/src/objects/zcl_abapgit_object_srvb.clas.abap +++ b/src/objects/zcl_abapgit_object_srvb.clas.abap @@ -433,7 +433,6 @@ CLASS zcl_abapgit_object_srvb IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_srvd.clas.abap b/src/objects/zcl_abapgit_object_srvd.clas.abap index 40a0eddd2..f69de5c8b 100644 --- a/src/objects/zcl_abapgit_object_srvd.clas.abap +++ b/src/objects/zcl_abapgit_object_srvd.clas.abap @@ -47,9 +47,6 @@ CLASS zcl_abapgit_object_srvd DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje VALUE(ro_object_data_merged) TYPE REF TO if_wb_object_data_model RAISING zcx_abapgit_exception . - METHODS is_delete_tadir - RETURNING - VALUE(rv_delete_tadir) TYPE abap_bool . ENDCLASS. @@ -236,11 +233,6 @@ CLASS zcl_abapgit_object_srvd IMPLEMENTATION. ENDMETHOD. - METHOD is_delete_tadir. - rv_delete_tadir = abap_true. - ENDMETHOD. - - METHOD merge_object_data. DATA: @@ -344,6 +336,7 @@ CLASS zcl_abapgit_object_srvd IMPLEMENTATION. CATCH cx_root INTO lx_error. zcx_abapgit_exception=>raise_with_text( lx_error ). ENDTRY. + ENDMETHOD. @@ -487,8 +480,7 @@ CLASS zcl_abapgit_object_srvd IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = is_delete_tadir( ). + rs_metadata = get_metadata( ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ssfo.clas.abap b/src/objects/zcl_abapgit_object_ssfo.clas.abap index eb0280f07..cbeeb4ddf 100644 --- a/src/objects/zcl_abapgit_object_ssfo.clas.abap +++ b/src/objects/zcl_abapgit_object_ssfo.clas.abap @@ -309,7 +309,6 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ssst.clas.abap b/src/objects/zcl_abapgit_object_ssst.clas.abap index 74c5bdb71..686c5601d 100644 --- a/src/objects/zcl_abapgit_object_ssst.clas.abap +++ b/src/objects/zcl_abapgit_object_ssst.clas.abap @@ -165,7 +165,6 @@ CLASS zcl_abapgit_object_ssst IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_styl.clas.abap b/src/objects/zcl_abapgit_object_styl.clas.abap index 0403c84aa..2f0175af8 100644 --- a/src/objects/zcl_abapgit_object_styl.clas.abap +++ b/src/objects/zcl_abapgit_object_styl.clas.abap @@ -117,7 +117,6 @@ CLASS zcl_abapgit_object_styl IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sucu.clas.abap b/src/objects/zcl_abapgit_object_sucu.clas.abap index 889653fd9..1e294a439 100644 --- a/src/objects/zcl_abapgit_object_sucu.clas.abap +++ b/src/objects/zcl_abapgit_object_sucu.clas.abap @@ -70,10 +70,7 @@ CLASS zcl_abapgit_object_sucu IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_susc.clas.abap b/src/objects/zcl_abapgit_object_susc.clas.abap index f15701c71..2be53feb1 100644 --- a/src/objects/zcl_abapgit_object_susc.clas.abap +++ b/src/objects/zcl_abapgit_object_susc.clas.abap @@ -208,7 +208,6 @@ CLASS zcl_abapgit_object_susc IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sush.clas.abap b/src/objects/zcl_abapgit_object_sush.clas.abap index 99d653df5..8dcad2b09 100644 --- a/src/objects/zcl_abapgit_object_sush.clas.abap +++ b/src/objects/zcl_abapgit_object_sush.clas.abap @@ -256,7 +256,6 @@ CLASS zcl_abapgit_object_sush IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_tobj.clas.abap b/src/objects/zcl_abapgit_object_tobj.clas.abap index 5a33d8e00..cb5951f23 100644 --- a/src/objects/zcl_abapgit_object_tobj.clas.abap +++ b/src/objects/zcl_abapgit_object_tobj.clas.abap @@ -104,6 +104,7 @@ CLASS zcl_abapgit_object_tobj IMPLEMENTATION. CALL FUNCTION 'OBJ_GENERATE' EXPORTING + iv_korrnum = iv_transport iv_objectname = ls_objh-objectname iv_objecttype = ls_objh-objecttype iv_maint_mode = 'D' @@ -146,6 +147,7 @@ CLASS zcl_abapgit_object_tobj IMPLEMENTATION. CALL FUNCTION 'OBJ_GENERATE' EXPORTING + iv_korrnum = iv_transport iv_objectname = ls_objh-objectname iv_objecttype = ls_objh-objecttype iv_maint_mode = 'I' @@ -229,7 +231,6 @@ CLASS zcl_abapgit_object_tobj IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ucsa.clas.abap b/src/objects/zcl_abapgit_object_ucsa.clas.abap index 249b10773..81d238cdd 100644 --- a/src/objects/zcl_abapgit_object_ucsa.clas.abap +++ b/src/objects/zcl_abapgit_object_ucsa.clas.abap @@ -125,6 +125,8 @@ CLASS zcl_abapgit_object_ucsa IMPLEMENTATION. zcx_abapgit_exception=>raise( lv_text ). ENDTRY. + tadir_delete( ). + ENDMETHOD. @@ -210,10 +212,7 @@ CLASS zcl_abapgit_object_ucsa IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_vcls.clas.abap b/src/objects/zcl_abapgit_object_vcls.clas.abap index 9aa7d3876..a183571c5 100644 --- a/src/objects/zcl_abapgit_object_vcls.clas.abap +++ b/src/objects/zcl_abapgit_object_vcls.clas.abap @@ -167,7 +167,6 @@ CLASS zcl_abapgit_object_vcls IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_w3xx_super.clas.abap b/src/objects/zcl_abapgit_object_w3xx_super.clas.abap index cf71b7b39..0de6f90cd 100644 --- a/src/objects/zcl_abapgit_object_w3xx_super.clas.abap +++ b/src/objects/zcl_abapgit_object_w3xx_super.clas.abap @@ -98,9 +98,8 @@ CLASS zcl_abapgit_object_w3xx_super IMPLEMENTATION. METHOD get_metadata. - rs_metadata = super->get_metadata( ). - rs_metadata-version = 'v2.0.0'. " Serialization v2, separate data file - rs_metadata-delete_tadir = abap_true. + rs_metadata = super->get_metadata( ). + rs_metadata-version = 'v2.0.0'. " Serialization v2, separate data file ENDMETHOD. @@ -329,7 +328,6 @@ CLASS zcl_abapgit_object_w3xx_super IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. rs_metadata = get_metadata( ). - rs_metadata-delete_tadir = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_wdcc.clas.abap b/src/objects/zcl_abapgit_object_wdcc.clas.abap index 2b68f1225..fbf54a16f 100644 --- a/src/objects/zcl_abapgit_object_wdcc.clas.abap +++ b/src/objects/zcl_abapgit_object_wdcc.clas.abap @@ -271,14 +271,7 @@ CLASS zcl_abapgit_object_wdcc IMPLEMENTATION. METHOD zif_abapgit_object~get_metadata. - - DATA ls_meta_data TYPE zif_abapgit_definitions=>ty_metadata. - - ls_meta_data = get_metadata( ). - ls_meta_data-delete_tadir = abap_true. - - rs_metadata = ls_meta_data. - + rs_metadata = get_metadata( ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_objects.clas.abap b/src/objects/zcl_abapgit_objects.clas.abap index 84f3107e1..0a48451c7 100644 --- a/src/objects/zcl_abapgit_objects.clas.abap +++ b/src/objects/zcl_abapgit_objects.clas.abap @@ -558,27 +558,6 @@ CLASS zcl_abapgit_objects IMPLEMENTATION. li_obj->delete( iv_package = iv_package iv_transport = iv_transport ). - IF li_obj->get_metadata( )-delete_tadir = abap_true. - - CALL FUNCTION 'TR_TADIR_INTERFACE' - EXPORTING - wi_delete_tadir_entry = abap_true - wi_tadir_pgmid = 'R3TR' - wi_tadir_object = is_item-obj_type - wi_tadir_obj_name = is_item-obj_name - wi_test_modus = abap_false - EXCEPTIONS - OTHERS = 1 ##FM_SUBRC_OK. - - " We deliberately ignore the subrc, because throwing an exception would - " break the deletion of lots of object types. On the other hand we have - " to catch the exceptions because otherwise messages would directly be issued - " by the function module and change the control flow. Thus breaking the - " deletion of TOBJ and other object types. - " TODO: This is not very clean and has to be improved in the future. See PR 2741. - - ENDIF. - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_objects_bridge.clas.abap b/src/objects/zcl_abapgit_objects_bridge.clas.abap index 0fb25a2c1..d7668ec58 100644 --- a/src/objects/zcl_abapgit_objects_bridge.clas.abap +++ b/src/objects/zcl_abapgit_objects_bridge.clas.abap @@ -13,7 +13,8 @@ CLASS zcl_abapgit_objects_bridge DEFINITION PUBLIC FINAL CREATE PUBLIC INHERITIN PRIVATE SECTION. DATA: mo_plugin TYPE REF TO object. - " Metadata with late_deser to stay compatible with old bridge + " Metadata flags (late_deser, delete_tadir, and ddic) are not required by abapGit anymore + " We keep them to stay compatible with old bridge implementation TYPES: BEGIN OF ty_metadata, class TYPE string, diff --git a/src/objects/zcl_abapgit_objects_generic.clas.abap b/src/objects/zcl_abapgit_objects_generic.clas.abap index 5cb892d42..9f0b8dff0 100644 --- a/src/objects/zcl_abapgit_objects_generic.clas.abap +++ b/src/objects/zcl_abapgit_objects_generic.clas.abap @@ -159,6 +159,22 @@ CLASS zcl_abapgit_objects_generic IMPLEMENTATION. ENDMETHOD. + METHOD apply_clear_logic. + IF mo_field_rules IS BOUND. + mo_field_rules->apply_clear_logic( EXPORTING iv_table = |{ iv_table }| + CHANGING ct_data = ct_data ). + ENDIF. + ENDMETHOD. + + + METHOD apply_fill_logic. + IF mo_field_rules IS BOUND. + mo_field_rules->apply_fill_logic( EXPORTING iv_table = |{ iv_table }| + CHANGING ct_data = ct_data ). + ENDIF. + ENDMETHOD. + + METHOD before_export. DATA: lt_cts_object_entry TYPE STANDARD TABLE OF e071 WITH DEFAULT KEY, @@ -710,20 +726,4 @@ CLASS zcl_abapgit_objects_generic IMPLEMENTATION. ENDIF. ENDMETHOD. - - METHOD apply_clear_logic. - IF mo_field_rules IS BOUND. - mo_field_rules->apply_clear_logic( EXPORTING iv_table = |{ iv_table }| - CHANGING ct_data = ct_data ). - ENDIF. - ENDMETHOD. - - - METHOD apply_fill_logic. - IF mo_field_rules IS BOUND. - mo_field_rules->apply_fill_logic( EXPORTING iv_table = |{ iv_table }| - CHANGING ct_data = ct_data ). - ENDIF. - ENDMETHOD. - ENDCLASS. diff --git a/src/objects/zcl_abapgit_objects_super.clas.abap b/src/objects/zcl_abapgit_objects_super.clas.abap index 54b3a5fed..4617410b5 100644 --- a/src/objects/zcl_abapgit_objects_super.clas.abap +++ b/src/objects/zcl_abapgit_objects_super.clas.abap @@ -30,6 +30,9 @@ CLASS zcl_abapgit_objects_super DEFINITION !iv_package TYPE devclass RAISING zcx_abapgit_exception . + METHODS tadir_delete + RAISING + zcx_abapgit_exception . METHODS exists_a_lock_entry_for IMPORTING !iv_lock_object TYPE string @@ -341,6 +344,48 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION. ENDMETHOD. + METHOD tadir_delete. + + CALL FUNCTION 'TR_TADIR_INTERFACE' + EXPORTING + wi_delete_tadir_entry = abap_true + wi_tadir_pgmid = 'R3TR' + wi_tadir_object = ms_item-obj_type + wi_tadir_obj_name = ms_item-obj_name + wi_test_modus = abap_false + EXCEPTIONS + tadir_entry_not_existing = 1 + tadir_entry_ill_type = 2 + no_systemname = 3 + no_systemtype = 4 + original_system_conflict = 5 + object_reserved_for_devclass = 6 + object_exists_global = 7 + object_exists_local = 8 + object_is_distributed = 9 + obj_specification_not_unique = 10 + no_authorization_to_delete = 11 + devclass_not_existing = 12 + simultanious_set_remove_repair = 13 + order_missing = 14 + no_modification_of_head_syst = 15 + pgmid_object_not_allowed = 16 + masterlanguage_not_specified = 17 + devclass_not_specified = 18 + specify_owner_unique = 19 + loc_priv_objs_no_repair = 20 + gtadir_not_reached = 21 + object_locked_for_order = 22 + change_of_class_not_allowed = 23 + no_change_from_sap_to_tmp = 24 + OTHERS = 25. + IF sy-subrc <> 0. + zcx_abapgit_exception=>raise_t100( ). + ENDIF. + + ENDMETHOD. + + METHOD tadir_insert. CALL FUNCTION 'TR_TADIR_INTERFACE' diff --git a/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap index 17038804f..bacdd0c04 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap @@ -367,7 +367,6 @@ CLASS zcl_abapgit_gui_page_debuginfo IMPLEMENTATION. ls_metadata = li_object->get_metadata( ). rv_html = rv_html && |{ ls_metadata-version }|. - rv_html = rv_html && |{ ls_metadata-delete_tadir }|. lt_steps = li_object->get_deserialize_steps( ). diff --git a/src/zif_abapgit_definitions.intf.abap b/src/zif_abapgit_definitions.intf.abap index 4dfd2e4d9..f23a72af7 100644 --- a/src/zif_abapgit_definitions.intf.abap +++ b/src/zif_abapgit_definitions.intf.abap @@ -147,9 +147,8 @@ INTERFACE zif_abapgit_definitions END OF ty_delete_checks . TYPES: BEGIN OF ty_metadata, - class TYPE string, - version TYPE string, - delete_tadir TYPE abap_bool, + class TYPE string, + version TYPE string, END OF ty_metadata . TYPES: BEGIN OF ty_repo_file,