From 274bd529d95c983303cc756f672aea0b1a1eee13 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Tue, 15 Apr 2025 12:47:18 +0200 Subject: [PATCH] fix --- src/background/zcl_abapgit_background_push_au.clas.abap | 6 +++--- src/env/zcl_abapgit_user_record.clas.abap | 2 +- src/env/zcl_abapgit_user_record.clas.testclasses.abap | 2 +- src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap | 2 +- src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap | 2 +- src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap | 2 +- src/ui/pages/zcl_abapgit_gui_page_commit.clas.abap | 4 ++-- src/ui/pages/zcl_abapgit_gui_page_tags.clas.abap | 4 ++-- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/background/zcl_abapgit_background_push_au.clas.abap b/src/background/zcl_abapgit_background_push_au.clas.abap index 756fd871c..946aa62bf 100644 --- a/src/background/zcl_abapgit_background_push_au.clas.abap +++ b/src/background/zcl_abapgit_background_push_au.clas.abap @@ -72,9 +72,9 @@ CLASS zcl_abapgit_background_push_au IMPLEMENTATION. DATA: lo_user_record TYPE REF TO zcl_abapgit_user_record. - lo_user_record = zcl_abapgit_user_record=>get_instance( iv_changed_by ). - rs_user-name = lo_user_record->get_name( ). - rs_user-email = lo_user_record->get_email( ). + lo_user_record = zcl_abapgit_user_record=>get_instance( ). + rs_user-name = lo_user_record->get_name( iv_changed_by ). + rs_user-email = lo_user_record->get_email( iv_changed_by ). * If no email, fall back to localhost/default email IF rs_user-email IS INITIAL. diff --git a/src/env/zcl_abapgit_user_record.clas.abap b/src/env/zcl_abapgit_user_record.clas.abap index 740c65c22..63e779566 100644 --- a/src/env/zcl_abapgit_user_record.clas.abap +++ b/src/env/zcl_abapgit_user_record.clas.abap @@ -67,7 +67,7 @@ ENDCLASS. CLASS zcl_abapgit_user_record IMPLEMENTATION. METHOD get_instance. - RETURN. " todo, implement method + CREATE OBJECT ro_user. ENDMETHOD. diff --git a/src/env/zcl_abapgit_user_record.clas.testclasses.abap b/src/env/zcl_abapgit_user_record.clas.testclasses.abap index 02ce85af2..72ab1eb1f 100644 --- a/src/env/zcl_abapgit_user_record.clas.testclasses.abap +++ b/src/env/zcl_abapgit_user_record.clas.testclasses.abap @@ -19,7 +19,7 @@ CLASS ltcl_user_record IMPLEMENTATION. DATA: lo_user_record TYPE REF TO zcl_abapgit_user_record. zcl_abapgit_user_record=>reset( ). - lo_user_record = zcl_abapgit_user_record=>get_instance( c_wrong_user ). + lo_user_record = zcl_abapgit_user_record=>get_instance( ). cl_abap_unit_assert=>assert_equals( exp = 0 diff --git a/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap index 2c3603836..68fcd1ae4 100644 --- a/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap @@ -1323,7 +1323,7 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. ENDIF. IF iv_username <> zcl_abapgit_objects_super=>c_user_unknown AND iv_suppress_title = abap_false. - lv_title = zcl_abapgit_user_record=>get_title( iv_username ). + lv_title = zcl_abapgit_user_record=>get_instance( )->get_title( iv_username ). ENDIF. lv_jump = |{ zif_abapgit_definitions=>c_action-jump_user }?user={ iv_username }|. diff --git a/src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap b/src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap index e6e435979..dcca8eef3 100644 --- a/src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap +++ b/src/ui/pages/db/zcl_abapgit_gui_page_db.clas.abap @@ -367,7 +367,7 @@ CLASS zcl_abapgit_gui_page_db IMPLEMENTATION. WHEN zcl_abapgit_persistence_db=>c_type_user. lv_descr = 'Personal Settings'. - ls_explanation-value = zcl_abapgit_user_record=>get_instance( is_data-value )->get_name( ). + ls_explanation-value = zcl_abapgit_user_record=>get_instance( )->get_name( is_data-value ). WHEN zcl_abapgit_persistence_db=>c_type_settings. lv_descr = 'Global Settings'. diff --git a/src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap b/src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap index b723d2b8d..f256a63c6 100644 --- a/src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap +++ b/src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap @@ -194,7 +194,7 @@ CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION. ENDIF. IF iv_username <> zcl_abapgit_objects_super=>c_user_unknown. - lv_title = zcl_abapgit_user_record=>get_title( iv_username ). + lv_title = zcl_abapgit_user_record=>get_instance( )->get_title( iv_username ). ENDIF. rv_user = iv_username. diff --git a/src/ui/pages/zcl_abapgit_gui_page_commit.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_commit.clas.abap index 2949faa54..5ca2e2cf7 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_commit.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_commit.clas.abap @@ -241,7 +241,7 @@ CLASS zcl_abapgit_gui_page_commit IMPLEMENTATION. ENDIF. IF rv_email IS INITIAL. " get default from user record - rv_email = zcl_abapgit_user_record=>get_instance( sy-uname )->get_email( ). + rv_email = zcl_abapgit_user_record=>get_instance( )->get_email( sy-uname ). ENDIF. ENDMETHOD. @@ -259,7 +259,7 @@ CLASS zcl_abapgit_gui_page_commit IMPLEMENTATION. ENDIF. IF rv_user IS INITIAL. " get default from user record - rv_user = zcl_abapgit_user_record=>get_instance( sy-uname )->get_name( ). + rv_user = zcl_abapgit_user_record=>get_instance( )->get_name( sy-uname ). ENDIF. ENDMETHOD. diff --git a/src/ui/pages/zcl_abapgit_gui_page_tags.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_tags.clas.abap index 9e589bd70..8071ebc42 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_tags.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_tags.clas.abap @@ -237,7 +237,7 @@ CLASS zcl_abapgit_gui_page_tags IMPLEMENTATION. ENDIF. IF rv_email IS INITIAL. " get default from user record - rv_email = zcl_abapgit_user_record=>get_instance( sy-uname )->get_email( ). + rv_email = zcl_abapgit_user_record=>get_instance( )->get_email( sy-uname ). ENDIF. ENDMETHOD. @@ -255,7 +255,7 @@ CLASS zcl_abapgit_gui_page_tags IMPLEMENTATION. ENDIF. IF rv_user IS INITIAL. " get default from user record - rv_user = zcl_abapgit_user_record=>get_instance( sy-uname )->get_name( ). + rv_user = zcl_abapgit_user_record=>get_instance( )->get_name( sy-uname ). ENDIF. ENDMETHOD.