SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

linting (#2861)

Browse Source 
* rewrite

* Update abaplint.json

* Update abaplint.json

* move to include where its used

* Update .gitignore

* Update abaplint.json

* Update package.json

* Update package.json
This commit is contained in:
Lars Hvam 2019-08-11 23:16:10 -07:00 committed by GitHub
parent 971efbfaac
commit 27f712a47b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 24 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gitignore vendored
View File

@ -3,3 +3,4 @@ node_modules/
package-lock.json package-lock.json
zabapgit.abap zabapgit.abap
.vscode .vscode
deps

21
abaplint.json
View File

@ -6,7 +6,13 @@
"skipGeneratedFunctionGroups": true, "skipGeneratedFunctionGroups": true,
"applyUnspecifiedRules": false "applyUnspecifiedRules": false
}, },
"dependencies": [], "dependencies": [
{
"url": "https://github.com/abaplint/deps",
"folder": "/deps",
"files": "/src/**/*.*"
}
],
"syntax": { "syntax": {
"errorNamespace": "^(Z|Y)", "errorNamespace": "^(Z|Y)",
"globalConstants": [ "globalConstants": [
@ -23,6 +29,7 @@
"seoc_version_inactive", "seoc_version_inactive",
"seok_access_free", "seok_access_free",
"seok_access_modify", "seok_access_modify",
"seok_pgmid_r3tr",
"seop_ext_class_locals_def", "seop_ext_class_locals_def",
"seop_ext_class_locals_imp", "seop_ext_class_locals_imp",
"seop_ext_class_macros", "seop_ext_class_macros",
@ -52,6 +59,10 @@
"enabled": true, "enabled": true,
"exclude": [] "exclude": []
}, },
"ambiguous_statement": {
"enabled": true,
"exclude": []
},
"avoid_use": { "avoid_use": {
"enabled": true, "enabled": true,
"exclude": [], "exclude": [],
@ -67,8 +78,8 @@
"exclude": [] "exclude": []
}, },
"check_variables": { "check_variables": {
"enabled": false, "enabled": true,
"exclude": ["zcl_abapgit_ecatt"] "exclude": []
}, },
"class_attribute_names": { "class_attribute_names": {
"enabled": true, "enabled": true,
@ -330,8 +341,8 @@
"exclude": [] "exclude": []
}, },
"superclass_final": { "superclass_final": {
"enabled": false, "enabled": true,
"exclude": ["zcl_abapgit_ecatt"] "exclude": []
}, },
"tabl_enhancement_category": { "tabl_enhancement_category": {
"enabled": true, "enabled": true,

2
package.json
View File

@ -13,7 +13,7 @@
"url": "git+https://github.com/larshp/abapGit.git" "url": "git+https://github.com/larshp/abapGit.git"
}, },
"devDependencies": { "devDependencies": {
"abaplint": "^1.7.13", "abaplint": "^1.7.21",
"abapmerge": "^0.11.5", "abapmerge": "^0.11.5",
"eslint": "^5.11.1" "eslint": "^5.11.1"
} }

4
src/objects/zcl_abapgit_object_tobj.clas.abap
View File

@ -63,7 +63,9 @@ CLASS ZCL_ABAPGIT_OBJECT_TOBJ IMPLEMENTATION.
event = <ls_tvimf>-event event = <ls_tvimf>-event
TRANSPORTING NO FIELDS. TRANSPORTING NO FIELDS.
IF sy-subrc <> 0. IF sy-subrc <> 0.
DELETE tvimf FROM <ls_tvimf>. DELETE FROM tvimf
WHERE tabname = <ls_tvimf>-tabname
AND event = <ls_tvimf>-event.
ENDIF. ENDIF.
ENDLOOP. ENDLOOP.

2
src/zabapgit.prog.abap
View File

@ -30,6 +30,8 @@ SELECTION-SCREEN BEGIN OF SCREEN 1001.
* dummy for triggering screen on Java SAP GUI * dummy for triggering screen on Java SAP GUI
SELECTION-SCREEN END OF SCREEN 1001. SELECTION-SCREEN END OF SCREEN 1001.
TABLES sscrfields.
INCLUDE zabapgit_password_dialog. " !!! Contains SELECTION SCREEN INCLUDE zabapgit_password_dialog. " !!! Contains SELECTION SCREEN
* create class ZCL_ABAPGIT_AUTH_EXIT implementing ZIF_ABAPGIT_AUTH in following include, * create class ZCL_ABAPGIT_AUTH_EXIT implementing ZIF_ABAPGIT_AUTH in following include,

3
src/zabapgit_password_dialog.prog.abap
View File

@ -1,12 +1,11 @@
*&---------------------------------------------------------------------* *&---------------------------------------------------------------------*
*& Include ZABAPGIT_PASSWORD_DIALOG *& Include ZABAPGIT_PASSWORD_DIALOG
*&---------------------------------------------------------------------* *&---------------------------------------------------------------------*
TABLES sscrfields.
SELECTION-SCREEN BEGIN OF SCREEN 1002 TITLE s_title. SELECTION-SCREEN BEGIN OF SCREEN 1002 TITLE s_title.
SELECTION-SCREEN BEGIN OF LINE. SELECTION-SCREEN BEGIN OF LINE.
SELECTION-SCREEN COMMENT 1(10) s_url FOR FIELD p_url. SELECTION-SCREEN COMMENT 1(10) s_url FOR FIELD p_url.
PARAMETERS: p_url TYPE string LOWER CASE VISIBLE LENGTH 40 ##SEL_WRONG. PARAMETERS: p_url TYPE string LOWER CASE VISIBLE LENGTH 40 ##SEL_WRONG.
SELECTION-SCREEN END OF LINE. SELECTION-SCREEN END OF LINE.
SELECTION-SCREEN BEGIN OF LINE. SELECTION-SCREEN BEGIN OF LINE.
SELECTION-SCREEN COMMENT 1(10) s_user FOR FIELD p_user. SELECTION-SCREEN COMMENT 1(10) s_user FOR FIELD p_user.