SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

remove obsolete NO_HANDLER pragmas (#3085)

Browse Source 
* remove obsolete NO_HANDLER pragmas

* update lint to latest
This commit is contained in:
Lars Hvam 2019-11-25 07:35:41 +01:00 committed by GitHub
parent 038fa05d6d
commit 29cb891d23
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 64 additions and 64 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
abaplint.json
View File

@ -56,6 +56,8 @@
"globalMacros": []
},
"rules": {
"check_no_handler_pragma": true,
"newline_between_methods": false,
"chain_mainly_declarations": true,
"check_abstract": true,
"check_text_elements": true,

3
src/objects/zcl_abapgit_object_tabl.clas.abap
View File

@ -189,8 +189,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION.
io_xml->read( EXPORTING iv_name = c_s_dataname-segment_definition
CHANGING cg_data = lt_segment_definitions ).
CATCH zcx_abapgit_exception ##no_handler.
CATCH zcx_abapgit_exception.
RETURN. "previous XML version or no IDoc segment
ENDTRY.

123
src/ui/zcl_abapgit_log_viewer.clas.abap
View File

@ -19,6 +19,7 @@ CLASS zcl_abapgit_log_viewer DEFINITION
IMPORTING
ii_log TYPE REF TO zif_abapgit_log.
PROTECTED SECTION.
PRIVATE SECTION.
TYPES:
BEGIN OF ty_log_out,
@ -93,7 +94,43 @@ ENDCLASS.
CLASS zcl_abapgit_log_viewer IMPLEMENTATION.
CLASS ZCL_ABAPGIT_LOG_VIEWER IMPLEMENTATION.
METHOD calculate_cell_type.
FIELD-SYMBOLS: <ls_log> LIKE LINE OF gt_log.
DATA: ls_cell_type LIKE LINE OF <ls_log>-cell_type.
LOOP AT gt_log ASSIGNING <ls_log>.
IF <ls_log>-longtext IS NOT INITIAL.
ls_cell_type-columnname = `LONGTEXT`.
ls_cell_type-value = if_salv_c_cell_type=>hotspot.
INSERT ls_cell_type INTO TABLE <ls_log>-cell_type.
ENDIF.
IF <ls_log>-t100 IS NOT INITIAL.
ls_cell_type-columnname = `T100`.
ls_cell_type-value = if_salv_c_cell_type=>hotspot.
INSERT ls_cell_type INTO TABLE <ls_log>-cell_type.
ENDIF.
IF <ls_log>-source IS NOT INITIAL.
ls_cell_type-columnname = `SOURCE`.
ls_cell_type-value = if_salv_c_cell_type=>hotspot.
INSERT ls_cell_type INTO TABLE <ls_log>-cell_type.
ENDIF.
IF <ls_log>-callstack IS NOT INITIAL.
ls_cell_type-columnname = `CALLSTACK`.
ls_cell_type-value = if_salv_c_cell_type=>hotspot.
INSERT ls_cell_type INTO TABLE <ls_log>-cell_type.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD dispatch.
@ -120,6 +157,21 @@ CLASS zcl_abapgit_log_viewer IMPLEMENTATION.
ENDMETHOD.
METHOD get_exception_viewer.
DATA:
lx_abapgit TYPE REF TO zcx_abapgit_exception.
ASSERT is_log-exception IS BOUND.
lx_abapgit ?= is_log-exception.
CREATE OBJECT ro_exception_viewer
EXPORTING
ix_error = lx_abapgit.
ENDMETHOD.
METHOD goto_callstack.
get_exception_viewer( is_log )->show_callstack( ).
@ -134,6 +186,13 @@ CLASS zcl_abapgit_log_viewer IMPLEMENTATION.
ENDMETHOD.
METHOD goto_t100_message.
get_exception_viewer( is_log )->goto_message( ).
ENDMETHOD.
METHOD on_link_click.
DATA: lx_error TYPE REF TO zcx_abapgit_exception.
@ -338,8 +397,7 @@ CLASS zcl_abapgit_log_viewer IMPLEMENTATION.
TRY.
lx_abapgit ?= is_log-exception.
CATCH cx_sy_move_cast_error ##NO_HANDLER.
CATCH cx_sy_move_cast_error.
RETURN.
ENDTRY.
@ -375,13 +433,6 @@ CLASS zcl_abapgit_log_viewer IMPLEMENTATION.
ENDMETHOD.
METHOD goto_t100_message.
get_exception_viewer( is_log )->goto_message( ).
ENDMETHOD.
METHOD to_html.
DATA: lt_message TYPE zif_abapgit_log=>tty_log_out,
@ -437,56 +488,4 @@ CLASS zcl_abapgit_log_viewer IMPLEMENTATION.
ENDLOOP.
ENDMETHOD.
METHOD calculate_cell_type.
FIELD-SYMBOLS: <ls_log> LIKE LINE OF gt_log.
DATA: ls_cell_type LIKE LINE OF <ls_log>-cell_type.
LOOP AT gt_log ASSIGNING <ls_log>.
IF <ls_log>-longtext IS NOT INITIAL.
ls_cell_type-columnname = `LONGTEXT`.
ls_cell_type-value = if_salv_c_cell_type=>hotspot.
INSERT ls_cell_type INTO TABLE <ls_log>-cell_type.
ENDIF.
IF <ls_log>-t100 IS NOT INITIAL.
ls_cell_type-columnname = `T100`.
ls_cell_type-value = if_salv_c_cell_type=>hotspot.
INSERT ls_cell_type INTO TABLE <ls_log>-cell_type.
ENDIF.
IF <ls_log>-source IS NOT INITIAL.
ls_cell_type-columnname = `SOURCE`.
ls_cell_type-value = if_salv_c_cell_type=>hotspot.
INSERT ls_cell_type INTO TABLE <ls_log>-cell_type.
ENDIF.
IF <ls_log>-callstack IS NOT INITIAL.
ls_cell_type-columnname = `CALLSTACK`.
ls_cell_type-value = if_salv_c_cell_type=>hotspot.
INSERT ls_cell_type INTO TABLE <ls_log>-cell_type.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD get_exception_viewer.
DATA:
lx_abapgit TYPE REF TO zcx_abapgit_exception.
ASSERT is_log-exception IS BOUND.
lx_abapgit ?= is_log-exception.
CREATE OBJECT ro_exception_viewer
EXPORTING
ix_error = lx_abapgit.
ENDMETHOD.
ENDCLASS.