From 2b676a54b484789072ebdb223b2e1163368fad33 Mon Sep 17 00:00:00 2001
From: larshp <larshp@hotmail.com>
Date: Thu, 8 Nov 2018 14:51:22 +0000
Subject: [PATCH] ZCL_ABAPGIT_HTTP allow subclasses

---
 src/http/zcl_abapgit_http.clas.abap | 68 +++++++++++++++++------------
 src/http/zcl_abapgit_http.clas.xml  |  1 -
 2 files changed, 40 insertions(+), 29 deletions(-)

diff --git a/src/http/zcl_abapgit_http.clas.abap b/src/http/zcl_abapgit_http.clas.abap
index dae643ae2..f46a333a0 100644
--- a/src/http/zcl_abapgit_http.clas.abap
+++ b/src/http/zcl_abapgit_http.clas.abap
@@ -1,42 +1,54 @@
 CLASS zcl_abapgit_http DEFINITION
   PUBLIC
-  FINAL
   CREATE PUBLIC .
 
   PUBLIC SECTION.
-    CONSTANTS: BEGIN OF c_scheme,
-                 digest TYPE string VALUE 'Digest',
-               END OF c_scheme.
 
-    CLASS-METHODS:
-      get_agent
-        RETURNING VALUE(rv_agent) TYPE string,
-      create_by_url
-        IMPORTING iv_url           TYPE string
-                  iv_service       TYPE string
-        RETURNING VALUE(ro_client) TYPE REF TO zcl_abapgit_http_client
-        RAISING   zcx_abapgit_exception.
+    CONSTANTS:
+      BEGIN OF c_scheme,
+        digest TYPE string VALUE 'Digest',
+      END OF c_scheme .
+
+    CLASS-METHODS get_agent
+      RETURNING
+        VALUE(rv_agent) TYPE string .
+    CLASS-METHODS create_by_url
+      IMPORTING
+        !iv_url          TYPE string
+        !iv_service      TYPE string
+      RETURNING
+        VALUE(ro_client) TYPE REF TO zcl_abapgit_http_client
+      RAISING
+        zcx_abapgit_exception .
+  PROTECTED SECTION.
+
+    CLASS-METHODS check_auth_requested
+      IMPORTING
+        !ii_client               TYPE REF TO if_http_client
+      RETURNING
+        VALUE(rv_auth_requested) TYPE abap_bool
+      RAISING
+        zcx_abapgit_exception .
+    CLASS-METHODS is_local_system
+      IMPORTING
+        !iv_url        TYPE string
+      RETURNING
+        VALUE(rv_bool) TYPE abap_bool .
+    CLASS-METHODS acquire_login_details
+      IMPORTING
+        !ii_client       TYPE REF TO if_http_client
+        !io_client       TYPE REF TO zcl_abapgit_http_client
+        !iv_url          TYPE string
+      RETURNING
+        VALUE(rv_scheme) TYPE string
+      RAISING
+        zcx_abapgit_exception .
   PRIVATE SECTION.
-    CLASS-METHODS:
-      check_auth_requested
-        IMPORTING ii_client                TYPE REF TO if_http_client
-        RETURNING VALUE(rv_auth_requested) TYPE abap_bool
-        RAISING   zcx_abapgit_exception,
-      is_local_system
-        IMPORTING iv_url         TYPE string
-        RETURNING VALUE(rv_bool) TYPE abap_bool,
-      acquire_login_details
-        IMPORTING ii_client        TYPE REF TO if_http_client
-                  io_client        TYPE REF TO zcl_abapgit_http_client
-                  iv_url           TYPE string
-        RETURNING VALUE(rv_scheme) TYPE string
-        RAISING   zcx_abapgit_exception.
-
 ENDCLASS.
 
 
 
-CLASS zcl_abapgit_http IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_HTTP IMPLEMENTATION.
 
 
   METHOD acquire_login_details.
diff --git a/src/http/zcl_abapgit_http.clas.xml b/src/http/zcl_abapgit_http.clas.xml
index c61cc67f9..693a5de37 100644
--- a/src/http/zcl_abapgit_http.clas.xml
+++ b/src/http/zcl_abapgit_http.clas.xml
@@ -9,7 +9,6 @@
     <DESCRIPT>HTTP</DESCRIPT>
     <EXPOSURE>2</EXPOSURE>
     <STATE>1</STATE>
-    <CLSFINAL>X</CLSFINAL>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>
     <UNICODE>X</UNICODE>