From 2ba615135528bada0bc49b87d8e7e96ab28a44bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=BCnter?= Date: Fri, 18 Feb 2022 05:48:36 +0100 Subject: [PATCH] JUMP: Switch execution order - first specific then generic (#5357) * Switch jump order * fix DDLS * fix SHI3 --- src/objects/zcl_abapgit_object_aifc.clas.abap | 3 +++ src/objects/zcl_abapgit_object_area.clas.abap | 1 - src/objects/zcl_abapgit_object_asfc.clas.abap | 3 --- src/objects/zcl_abapgit_object_auth.clas.abap | 1 + src/objects/zcl_abapgit_object_avar.clas.abap | 1 - src/objects/zcl_abapgit_object_avas.clas.abap | 3 --- src/objects/zcl_abapgit_object_chdo.clas.abap | 2 ++ src/objects/zcl_abapgit_object_cmod.clas.abap | 1 - src/objects/zcl_abapgit_object_cus0.clas.abap | 2 ++ src/objects/zcl_abapgit_object_cus2.clas.abap | 3 --- src/objects/zcl_abapgit_object_ddls.clas.abap | 10 ++++----- src/objects/zcl_abapgit_object_dial.clas.abap | 4 +--- src/objects/zcl_abapgit_object_doct.clas.abap | 2 ++ src/objects/zcl_abapgit_object_docv.clas.abap | 3 --- src/objects/zcl_abapgit_object_dsys.clas.abap | 4 +--- src/objects/zcl_abapgit_object_fdt0.clas.abap | 2 ++ src/objects/zcl_abapgit_object_form.clas.abap | 2 ++ src/objects/zcl_abapgit_object_g4ba.clas.abap | 3 --- src/objects/zcl_abapgit_object_g4bs.clas.abap | 3 --- src/objects/zcl_abapgit_object_idoc.clas.abap | 2 ++ src/objects/zcl_abapgit_object_iext.clas.abap | 2 ++ src/objects/zcl_abapgit_object_iobj.clas.abap | 1 - src/objects/zcl_abapgit_object_iwmo.clas.abap | 2 ++ src/objects/zcl_abapgit_object_iwom.clas.abap | 3 --- src/objects/zcl_abapgit_object_iwpr.clas.abap | 2 ++ src/objects/zcl_abapgit_object_iwsg.clas.abap | 3 --- src/objects/zcl_abapgit_object_iwsv.clas.abap | 2 ++ src/objects/zcl_abapgit_object_iwvb.clas.abap | 2 ++ src/objects/zcl_abapgit_object_jobd.clas.abap | 2 ++ src/objects/zcl_abapgit_object_nrob.clas.abap | 2 ++ src/objects/zcl_abapgit_object_nspc.clas.abap | 6 ++--- src/objects/zcl_abapgit_object_pers.clas.abap | 2 ++ src/objects/zcl_abapgit_object_scp1.clas.abap | 2 ++ src/objects/zcl_abapgit_object_scvi.clas.abap | 3 --- src/objects/zcl_abapgit_object_shi3.clas.abap | 4 ++-- src/objects/zcl_abapgit_object_shi5.clas.abap | 3 +++ src/objects/zcl_abapgit_object_shi8.clas.abap | 1 - src/objects/zcl_abapgit_object_shma.clas.abap | 2 ++ src/objects/zcl_abapgit_object_sicf.clas.abap | 2 ++ src/objects/zcl_abapgit_object_splo.clas.abap | 1 - src/objects/zcl_abapgit_object_sppf.clas.abap | 3 --- src/objects/zcl_abapgit_object_ssfo.clas.abap | 2 ++ src/objects/zcl_abapgit_object_ssst.clas.abap | 2 ++ src/objects/zcl_abapgit_object_stvi.clas.abap | 3 --- src/objects/zcl_abapgit_object_styl.clas.abap | 2 ++ src/objects/zcl_abapgit_object_sucu.clas.abap | 3 --- src/objects/zcl_abapgit_object_susc.clas.abap | 2 ++ src/objects/zcl_abapgit_object_suso.clas.abap | 2 ++ src/objects/zcl_abapgit_object_tobj.clas.abap | 4 +--- src/objects/zcl_abapgit_object_tran.clas.abap | 2 ++ src/objects/zcl_abapgit_object_udmo.clas.abap | 2 ++ src/objects/zcl_abapgit_object_ueno.clas.abap | 2 ++ src/objects/zcl_abapgit_object_vcls.clas.abap | 2 ++ .../zcl_abapgit_object_w3xx_super.clas.abap | 2 ++ src/objects/zcl_abapgit_objects.clas.abap | 22 +++++++++++-------- .../zcl_abapgit_objects_bridge.clas.abap | 1 + src/objects/zif_abapgit_object.intf.abap | 2 ++ 57 files changed, 89 insertions(+), 71 deletions(-) diff --git a/src/objects/zcl_abapgit_object_aifc.clas.abap b/src/objects/zcl_abapgit_object_aifc.clas.abap index d898ff59e..47e4ca210 100644 --- a/src/objects/zcl_abapgit_object_aifc.clas.abap +++ b/src/objects/zcl_abapgit_object_aifc.clas.abap @@ -447,6 +447,9 @@ CLASS ZCL_ABAPGIT_OBJECT_AIFC IMPLEMENTATION. APPEND ls_param TO lt_params. SUBMIT (lv_report) WITH SELECTION-TABLE lt_params AND RETURN. + + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_area.clas.abap b/src/objects/zcl_abapgit_object_area.clas.abap index 316df0275..8cb690934 100644 --- a/src/objects/zcl_abapgit_object_area.clas.abap +++ b/src/objects/zcl_abapgit_object_area.clas.abap @@ -224,7 +224,6 @@ CLASS zcl_abapgit_object_area IMPLEMENTATION. METHOD zif_abapgit_object~jump. - zcx_abapgit_exception=>raise( |Jump to AREA is not yet supported| ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_asfc.clas.abap b/src/objects/zcl_abapgit_object_asfc.clas.abap index 1d3b9c8b2..ba10034a3 100644 --- a/src/objects/zcl_abapgit_object_asfc.clas.abap +++ b/src/objects/zcl_abapgit_object_asfc.clas.abap @@ -90,9 +90,6 @@ CLASS zcl_abapgit_object_asfc IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_auth.clas.abap b/src/objects/zcl_abapgit_object_auth.clas.abap index 59ea2dc83..d2b68c104 100644 --- a/src/objects/zcl_abapgit_object_auth.clas.abap +++ b/src/objects/zcl_abapgit_object_auth.clas.abap @@ -155,6 +155,7 @@ CLASS ZCL_ABAPGIT_OBJECT_AUTH IMPLEMENTATION. EXPORTING id_field = mv_fieldname id_wbo_mode = abap_false. + rv_exit = abap_true. ENDIF. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_avar.clas.abap b/src/objects/zcl_abapgit_object_avar.clas.abap index 8a3b5c7a1..66fee3e75 100644 --- a/src/objects/zcl_abapgit_object_avar.clas.abap +++ b/src/objects/zcl_abapgit_object_avar.clas.abap @@ -187,7 +187,6 @@ CLASS ZCL_ABAPGIT_OBJECT_AVAR IMPLEMENTATION. METHOD zif_abapgit_object~jump. - zcx_abapgit_exception=>raise( |Jump to AVAR is not supported| ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_avas.clas.abap b/src/objects/zcl_abapgit_object_avas.clas.abap index 549def9e2..f40dabc9d 100644 --- a/src/objects/zcl_abapgit_object_avas.clas.abap +++ b/src/objects/zcl_abapgit_object_avas.clas.abap @@ -201,9 +201,6 @@ CLASS ZCL_ABAPGIT_OBJECT_AVAS IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |Todo, AVAS jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_chdo.clas.abap b/src/objects/zcl_abapgit_object_chdo.clas.abap index f1ec92234..3ae1920f4 100644 --- a/src/objects/zcl_abapgit_object_chdo.clas.abap +++ b/src/objects/zcl_abapgit_object_chdo.clas.abap @@ -343,6 +343,8 @@ CLASS zcl_abapgit_object_chdo IMPLEMENTATION. iv_tcode = 'SCDO' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_cmod.clas.abap b/src/objects/zcl_abapgit_object_cmod.clas.abap index 366c0cd57..28f30b56e 100644 --- a/src/objects/zcl_abapgit_object_cmod.clas.abap +++ b/src/objects/zcl_abapgit_object_cmod.clas.abap @@ -156,7 +156,6 @@ CLASS ZCL_ABAPGIT_OBJECT_CMOD IMPLEMENTATION. METHOD zif_abapgit_object~jump. - zcx_abapgit_exception=>raise( |Jump to CMOD is not supported| ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_cus0.clas.abap b/src/objects/zcl_abapgit_object_cus0.clas.abap index 305213c67..ecd29cff0 100644 --- a/src/objects/zcl_abapgit_object_cus0.clas.abap +++ b/src/objects/zcl_abapgit_object_cus0.clas.abap @@ -155,6 +155,8 @@ CLASS zcl_abapgit_object_cus0 IMPLEMENTATION. i_display = abap_true CHANGING img_activity = lv_img_activity. + + rv_exit = abap_true. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_cus2.clas.abap b/src/objects/zcl_abapgit_object_cus2.clas.abap index ab5e09487..b34b69ba4 100644 --- a/src/objects/zcl_abapgit_object_cus2.clas.abap +++ b/src/objects/zcl_abapgit_object_cus2.clas.abap @@ -137,9 +137,6 @@ CLASS zcl_abapgit_object_cus2 IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ddls.clas.abap b/src/objects/zcl_abapgit_object_ddls.clas.abap index 2b6deae11..b5c99aded 100644 --- a/src/objects/zcl_abapgit_object_ddls.clas.abap +++ b/src/objects/zcl_abapgit_object_ddls.clas.abap @@ -399,12 +399,10 @@ CLASS zcl_abapgit_object_ddls IMPLEMENTATION. IMPORTING typekind = lv_ddtypekind. - CASE lv_ddtypekind. - WHEN 'STOB'. - open_adt_stob( ms_item-obj_name ). - WHEN OTHERS. - zcx_abapgit_exception=>raise( 'DDLS Jump Error' ). - ENDCASE. + IF lv_ddtypekind = 'STOB'. + open_adt_stob( ms_item-obj_name ). + rv_exit = abap_true. + ENDIF. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_dial.clas.abap b/src/objects/zcl_abapgit_object_dial.clas.abap index 9658e4f0c..7736f7ff0 100644 --- a/src/objects/zcl_abapgit_object_dial.clas.abap +++ b/src/objects/zcl_abapgit_object_dial.clas.abap @@ -171,9 +171,7 @@ CLASS zcl_abapgit_object_dial IMPLEMENTATION. object_not_found = 1 OTHERS = 2. - IF sy-subrc <> 0. - zcx_abapgit_exception=>raise_t100( ). - ENDIF. + rv_exit = boolc( sy-subrc = 0 ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_doct.clas.abap b/src/objects/zcl_abapgit_object_doct.clas.abap index a5b040051..9d2865101 100644 --- a/src/objects/zcl_abapgit_object_doct.clas.abap +++ b/src/objects/zcl_abapgit_object_doct.clas.abap @@ -144,6 +144,8 @@ CLASS zcl_abapgit_object_doct IMPLEMENTATION. iv_tcode = 'SE61' it_bdcdata = lt_bcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_docv.clas.abap b/src/objects/zcl_abapgit_object_docv.clas.abap index f3cb99385..37e288d12 100644 --- a/src/objects/zcl_abapgit_object_docv.clas.abap +++ b/src/objects/zcl_abapgit_object_docv.clas.abap @@ -149,9 +149,6 @@ CLASS zcl_abapgit_object_docv IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( 'todo, jump DOCV' ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_dsys.clas.abap b/src/objects/zcl_abapgit_object_dsys.clas.abap index 8f4fdd634..f7952c3cc 100644 --- a/src/objects/zcl_abapgit_object_dsys.clas.abap +++ b/src/objects/zcl_abapgit_object_dsys.clas.abap @@ -213,9 +213,7 @@ CLASS zcl_abapgit_object_dsys IMPLEMENTATION. object_not_found = 2 OTHERS = 3. - IF sy-subrc <> 0. - zcx_abapgit_exception=>raise_t100( ). - ENDIF. + rv_exit = boolc( sy-subrc = 0 ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_fdt0.clas.abap b/src/objects/zcl_abapgit_object_fdt0.clas.abap index 08577d2ef..6b4fc2baa 100644 --- a/src/objects/zcl_abapgit_object_fdt0.clas.abap +++ b/src/objects/zcl_abapgit_object_fdt0.clas.abap @@ -669,6 +669,8 @@ CLASS zcl_abapgit_object_fdt0 IMPLEMENTATION. zcx_abapgit_exception=>raise( 'Could not open BRF+ Workbench' ). ENDIF. + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_form.clas.abap b/src/objects/zcl_abapgit_object_form.clas.abap index f0b610085..95405fdb5 100644 --- a/src/objects/zcl_abapgit_object_form.clas.abap +++ b/src/objects/zcl_abapgit_object_form.clas.abap @@ -387,6 +387,8 @@ CLASS zcl_abapgit_object_form IMPLEMENTATION. iv_tcode = 'SE71' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_g4ba.clas.abap b/src/objects/zcl_abapgit_object_g4ba.clas.abap index ccb32b1e8..dd0fab274 100644 --- a/src/objects/zcl_abapgit_object_g4ba.clas.abap +++ b/src/objects/zcl_abapgit_object_g4ba.clas.abap @@ -90,9 +90,6 @@ CLASS zcl_abapgit_object_g4ba IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_g4bs.clas.abap b/src/objects/zcl_abapgit_object_g4bs.clas.abap index 59b0463ed..a1a5c82a5 100644 --- a/src/objects/zcl_abapgit_object_g4bs.clas.abap +++ b/src/objects/zcl_abapgit_object_g4bs.clas.abap @@ -90,9 +90,6 @@ CLASS zcl_abapgit_object_g4bs IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_idoc.clas.abap b/src/objects/zcl_abapgit_object_idoc.clas.abap index c71db2c10..8856c242e 100644 --- a/src/objects/zcl_abapgit_object_idoc.clas.abap +++ b/src/objects/zcl_abapgit_object_idoc.clas.abap @@ -217,6 +217,8 @@ CLASS zcl_abapgit_object_idoc IMPLEMENTATION. iv_tcode = 'WE30' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iext.clas.abap b/src/objects/zcl_abapgit_object_iext.clas.abap index 435c6213b..44b058b83 100644 --- a/src/objects/zcl_abapgit_object_iext.clas.abap +++ b/src/objects/zcl_abapgit_object_iext.clas.abap @@ -172,6 +172,8 @@ CLASS zcl_abapgit_object_iext IMPLEMENTATION. iv_tcode = 'WE30' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iobj.clas.abap b/src/objects/zcl_abapgit_object_iobj.clas.abap index b492f0ee6..1e833676a 100644 --- a/src/objects/zcl_abapgit_object_iobj.clas.abap +++ b/src/objects/zcl_abapgit_object_iobj.clas.abap @@ -336,7 +336,6 @@ CLASS ZCL_ABAPGIT_OBJECT_IOBJ IMPLEMENTATION. METHOD zif_abapgit_object~jump. - zcx_abapgit_exception=>raise( |Jump to InfoObjects is not yet supported| ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwmo.clas.abap b/src/objects/zcl_abapgit_object_iwmo.clas.abap index 1d00ad408..0323d08d5 100644 --- a/src/objects/zcl_abapgit_object_iwmo.clas.abap +++ b/src/objects/zcl_abapgit_object_iwmo.clas.abap @@ -115,6 +115,8 @@ CLASS zcl_abapgit_object_iwmo IMPLEMENTATION. iv_tcode = '/IWBEP/REG_MODEL' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwom.clas.abap b/src/objects/zcl_abapgit_object_iwom.clas.abap index 84ab84cd8..fbfc1a126 100644 --- a/src/objects/zcl_abapgit_object_iwom.clas.abap +++ b/src/objects/zcl_abapgit_object_iwom.clas.abap @@ -90,9 +90,6 @@ CLASS zcl_abapgit_object_iwom IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwpr.clas.abap b/src/objects/zcl_abapgit_object_iwpr.clas.abap index 5579d17ff..d9f9f7695 100644 --- a/src/objects/zcl_abapgit_object_iwpr.clas.abap +++ b/src/objects/zcl_abapgit_object_iwpr.clas.abap @@ -95,6 +95,8 @@ CLASS zcl_abapgit_object_iwpr IMPLEMENTATION. WITH i_prname = ms_item-obj_name AND RETURN. + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwsg.clas.abap b/src/objects/zcl_abapgit_object_iwsg.clas.abap index 887d65443..bf1edfd0c 100644 --- a/src/objects/zcl_abapgit_object_iwsg.clas.abap +++ b/src/objects/zcl_abapgit_object_iwsg.clas.abap @@ -90,9 +90,6 @@ CLASS zcl_abapgit_object_iwsg IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwsv.clas.abap b/src/objects/zcl_abapgit_object_iwsv.clas.abap index 3f08bbf04..a797397f1 100644 --- a/src/objects/zcl_abapgit_object_iwsv.clas.abap +++ b/src/objects/zcl_abapgit_object_iwsv.clas.abap @@ -115,6 +115,8 @@ CLASS zcl_abapgit_object_iwsv IMPLEMENTATION. iv_tcode = '/IWBEP/REG_SERVICE' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iwvb.clas.abap b/src/objects/zcl_abapgit_object_iwvb.clas.abap index e17e414f3..c22f644d4 100644 --- a/src/objects/zcl_abapgit_object_iwvb.clas.abap +++ b/src/objects/zcl_abapgit_object_iwvb.clas.abap @@ -96,6 +96,8 @@ CLASS zcl_abapgit_object_iwvb IMPLEMENTATION. WITH ip_avers = ms_item-obj_name+32(4) AND RETURN. + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_jobd.clas.abap b/src/objects/zcl_abapgit_object_jobd.clas.abap index 2e3218ae5..3653f496f 100644 --- a/src/objects/zcl_abapgit_object_jobd.clas.abap +++ b/src/objects/zcl_abapgit_object_jobd.clas.abap @@ -155,6 +155,8 @@ CLASS zcl_abapgit_object_jobd IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). ENDIF. + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_nrob.clas.abap b/src/objects/zcl_abapgit_object_nrob.clas.abap index 397ca5509..b8db39098 100644 --- a/src/objects/zcl_abapgit_object_nrob.clas.abap +++ b/src/objects/zcl_abapgit_object_nrob.clas.abap @@ -252,6 +252,8 @@ CLASS zcl_abapgit_object_nrob IMPLEMENTATION. iv_tcode = 'SNRO' it_bdcdata = lt_bcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_nspc.clas.abap b/src/objects/zcl_abapgit_object_nspc.clas.abap index cbc6fd403..7d79283c0 100644 --- a/src/objects/zcl_abapgit_object_nspc.clas.abap +++ b/src/objects/zcl_abapgit_object_nspc.clas.abap @@ -303,9 +303,9 @@ CLASS ZCL_ABAPGIT_OBJECT_NSPC IMPLEMENTATION. unknown_field_in_dba_sellist = 12 view_not_found = 13 OTHERS = 14. - IF sy-subrc <> 0. - zcx_abapgit_exception=>raise_t100( ). - ENDIF. + + rv_exit = boolc( sy-subrc = 0 ). + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_pers.clas.abap b/src/objects/zcl_abapgit_object_pers.clas.abap index eb6638956..0e4a0d1a3 100644 --- a/src/objects/zcl_abapgit_object_pers.clas.abap +++ b/src/objects/zcl_abapgit_object_pers.clas.abap @@ -198,6 +198,8 @@ CLASS zcl_abapgit_object_pers IMPLEMENTATION. iv_tcode = 'PERSREG' it_bdcdata = lt_bcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_scp1.clas.abap b/src/objects/zcl_abapgit_object_scp1.clas.abap index 8f24a6046..8050c33bc 100644 --- a/src/objects/zcl_abapgit_object_scp1.clas.abap +++ b/src/objects/zcl_abapgit_object_scp1.clas.abap @@ -435,6 +435,8 @@ CLASS zcl_abapgit_object_scp1 IMPLEMENTATION. SUBMIT scpr3 AND RETURN. + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_scvi.clas.abap b/src/objects/zcl_abapgit_object_scvi.clas.abap index 512184854..c83a6d79a 100644 --- a/src/objects/zcl_abapgit_object_scvi.clas.abap +++ b/src/objects/zcl_abapgit_object_scvi.clas.abap @@ -156,9 +156,6 @@ CLASS zcl_abapgit_object_scvi IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_shi3.clas.abap b/src/objects/zcl_abapgit_object_shi3.clas.abap index 0fa086fd3..b3eba97ba 100644 --- a/src/objects/zcl_abapgit_object_shi3.clas.abap +++ b/src/objects/zcl_abapgit_object_shi3.clas.abap @@ -321,10 +321,10 @@ CLASS zcl_abapgit_object_shi3 IMPLEMENTATION. CASE ls_head-type. WHEN 'BMENU'. jump_se43( ). + rv_exit = abap_true. WHEN 'GHIER'. jump_sbach04( ). - WHEN OTHERS. - zcx_abapgit_exception=>raise( |Jump for type { ls_head-type } not implemented| ). + rv_exit = abap_true. ENDCASE. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_shi5.clas.abap b/src/objects/zcl_abapgit_object_shi5.clas.abap index 851246c2f..0dd91a153 100644 --- a/src/objects/zcl_abapgit_object_shi5.clas.abap +++ b/src/objects/zcl_abapgit_object_shi5.clas.abap @@ -147,6 +147,9 @@ CLASS zcl_abapgit_object_shi5 IMPLEMENTATION. originals_only = abap_true TABLES show_only_extensions = lt_extension. + + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_shi8.clas.abap b/src/objects/zcl_abapgit_object_shi8.clas.abap index 1fd901999..54c912136 100644 --- a/src/objects/zcl_abapgit_object_shi8.clas.abap +++ b/src/objects/zcl_abapgit_object_shi8.clas.abap @@ -124,7 +124,6 @@ CLASS ZCL_ABAPGIT_OBJECT_SHI8 IMPLEMENTATION. METHOD zif_abapgit_object~jump. - zcx_abapgit_exception=>raise( |TODO: Jump SHI8| ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_shma.clas.abap b/src/objects/zcl_abapgit_object_shma.clas.abap index 1f99019d7..dcce29e48 100644 --- a/src/objects/zcl_abapgit_object_shma.clas.abap +++ b/src/objects/zcl_abapgit_object_shma.clas.abap @@ -250,6 +250,8 @@ CLASS zcl_abapgit_object_shma IMPLEMENTATION. iv_tcode = 'SHMA' it_bdcdata = lt_bcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sicf.clas.abap b/src/objects/zcl_abapgit_object_sicf.clas.abap index 3f884590d..0f51fcaa8 100644 --- a/src/objects/zcl_abapgit_object_sicf.clas.abap +++ b/src/objects/zcl_abapgit_object_sicf.clas.abap @@ -556,6 +556,8 @@ CLASS zcl_abapgit_object_sicf IMPLEMENTATION. iv_tcode = 'SICF' it_bdcdata = lt_bcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_splo.clas.abap b/src/objects/zcl_abapgit_object_splo.clas.abap index 64c691284..9309db2ca 100644 --- a/src/objects/zcl_abapgit_object_splo.clas.abap +++ b/src/objects/zcl_abapgit_object_splo.clas.abap @@ -95,7 +95,6 @@ CLASS ZCL_ABAPGIT_OBJECT_SPLO IMPLEMENTATION. METHOD zif_abapgit_object~jump. - zcx_abapgit_exception=>raise( 'todo, jump, SPLO' ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sppf.clas.abap b/src/objects/zcl_abapgit_object_sppf.clas.abap index 57826589d..eeb0968d3 100644 --- a/src/objects/zcl_abapgit_object_sppf.clas.abap +++ b/src/objects/zcl_abapgit_object_sppf.clas.abap @@ -90,9 +90,6 @@ CLASS ZCL_ABAPGIT_OBJECT_SPPF IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ssfo.clas.abap b/src/objects/zcl_abapgit_object_ssfo.clas.abap index 0de530c87..fdec1a5f4 100644 --- a/src/objects/zcl_abapgit_object_ssfo.clas.abap +++ b/src/objects/zcl_abapgit_object_ssfo.clas.abap @@ -390,6 +390,8 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION. iv_tcode = 'SMARTFORMS' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ssst.clas.abap b/src/objects/zcl_abapgit_object_ssst.clas.abap index b67ac6ae5..ee493d561 100644 --- a/src/objects/zcl_abapgit_object_ssst.clas.abap +++ b/src/objects/zcl_abapgit_object_ssst.clas.abap @@ -204,6 +204,8 @@ CLASS zcl_abapgit_object_ssst IMPLEMENTATION. iv_tcode = 'SMARTSTYLES' it_bdcdata = lt_bcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_stvi.clas.abap b/src/objects/zcl_abapgit_object_stvi.clas.abap index 2ea437ffc..196bbf5be 100644 --- a/src/objects/zcl_abapgit_object_stvi.clas.abap +++ b/src/objects/zcl_abapgit_object_stvi.clas.abap @@ -159,9 +159,6 @@ CLASS ZCL_ABAPGIT_OBJECT_STVI IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_styl.clas.abap b/src/objects/zcl_abapgit_object_styl.clas.abap index 1f4dfa66e..750c6983a 100644 --- a/src/objects/zcl_abapgit_object_styl.clas.abap +++ b/src/objects/zcl_abapgit_object_styl.clas.abap @@ -163,6 +163,8 @@ CLASS zcl_abapgit_object_styl IMPLEMENTATION. iv_tcode = 'SE72' it_bdcdata = lt_bcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_sucu.clas.abap b/src/objects/zcl_abapgit_object_sucu.clas.abap index 1e305e014..c1b949255 100644 --- a/src/objects/zcl_abapgit_object_sucu.clas.abap +++ b/src/objects/zcl_abapgit_object_sucu.clas.abap @@ -90,9 +90,6 @@ CLASS zcl_abapgit_object_sucu IMPLEMENTATION. METHOD zif_abapgit_object~jump. - - zcx_abapgit_exception=>raise( |TODO: Jump| ). - ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_susc.clas.abap b/src/objects/zcl_abapgit_object_susc.clas.abap index 91b8c4dd3..51806ac23 100644 --- a/src/objects/zcl_abapgit_object_susc.clas.abap +++ b/src/objects/zcl_abapgit_object_susc.clas.abap @@ -232,6 +232,8 @@ CLASS zcl_abapgit_object_susc IMPLEMENTATION. EXPORTING objclass = lv_objclass. + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_suso.clas.abap b/src/objects/zcl_abapgit_object_suso.clas.abap index 035a6450a..4a73b40de 100644 --- a/src/objects/zcl_abapgit_object_suso.clas.abap +++ b/src/objects/zcl_abapgit_object_suso.clas.abap @@ -310,6 +310,8 @@ CLASS zcl_abapgit_object_suso IMPLEMENTATION. EXPORTING object = mv_objectname. + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_tobj.clas.abap b/src/objects/zcl_abapgit_object_tobj.clas.abap index 2caec4eb7..7f4957bc9 100644 --- a/src/objects/zcl_abapgit_object_tobj.clas.abap +++ b/src/objects/zcl_abapgit_object_tobj.clas.abap @@ -256,9 +256,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TOBJ IMPLEMENTATION. jump_not_possible = 1 OTHERS = 2. - IF sy-subrc <> 0. - zcx_abapgit_exception=>raise( |Jump not possible. Subrc={ sy-subrc } from TR_OBJECT_JUMP_TO_TOOL| ). - ENDIF. + rv_exit = boolc( sy-subrc = 0 ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_tran.clas.abap b/src/objects/zcl_abapgit_object_tran.clas.abap index f7409c204..ce0cff233 100644 --- a/src/objects/zcl_abapgit_object_tran.clas.abap +++ b/src/objects/zcl_abapgit_object_tran.clas.abap @@ -838,6 +838,8 @@ CLASS zcl_abapgit_object_tran IMPLEMENTATION. iv_tcode = 'SE93' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_udmo.clas.abap b/src/objects/zcl_abapgit_object_udmo.clas.abap index db1024201..acd8b605d 100644 --- a/src/objects/zcl_abapgit_object_udmo.clas.abap +++ b/src/objects/zcl_abapgit_object_udmo.clas.abap @@ -738,6 +738,8 @@ CLASS zcl_abapgit_object_udmo IMPLEMENTATION. iv_tcode = 'SD11' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ueno.clas.abap b/src/objects/zcl_abapgit_object_ueno.clas.abap index 1c37f98df..7c3344874 100644 --- a/src/objects/zcl_abapgit_object_ueno.clas.abap +++ b/src/objects/zcl_abapgit_object_ueno.clas.abap @@ -618,6 +618,8 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION. iv_tcode = 'SD11' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_vcls.clas.abap b/src/objects/zcl_abapgit_object_vcls.clas.abap index fc1895753..a54813301 100644 --- a/src/objects/zcl_abapgit_object_vcls.clas.abap +++ b/src/objects/zcl_abapgit_object_vcls.clas.abap @@ -250,6 +250,8 @@ CLASS zcl_abapgit_object_vcls IMPLEMENTATION. iv_tcode = 'SE54' it_bdcdata = lt_bcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_w3xx_super.clas.abap b/src/objects/zcl_abapgit_object_w3xx_super.clas.abap index 70cf12f37..427c4133e 100644 --- a/src/objects/zcl_abapgit_object_w3xx_super.clas.abap +++ b/src/objects/zcl_abapgit_object_w3xx_super.clas.abap @@ -421,6 +421,8 @@ CLASS zcl_abapgit_object_w3xx_super IMPLEMENTATION. iv_tcode = 'SMW0' it_bdcdata = lt_bdcdata ). + rv_exit = abap_true. + ENDMETHOD. diff --git a/src/objects/zcl_abapgit_objects.clas.abap b/src/objects/zcl_abapgit_objects.clas.abap index da43b00f9..40a551671 100644 --- a/src/objects/zcl_abapgit_objects.clas.abap +++ b/src/objects/zcl_abapgit_objects.clas.abap @@ -977,16 +977,20 @@ CLASS zcl_abapgit_objects IMPLEMENTATION. zcx_abapgit_exception=>raise( |Object { is_item-obj_type } { is_item-obj_name } doesn't exist| ). ENDIF. - " Open object in new window - lv_exit = zcl_abapgit_ui_factory=>get_gui_jumper( )->jump( - is_item = is_item - iv_sub_obj_name = iv_sub_obj_name - iv_sub_obj_type = iv_sub_obj_type - iv_line_number = iv_line_number ). + " First priority object-specific handler + lv_exit = li_obj->jump( ). - " If all fails, try object-specific handler - IF lv_exit IS INITIAL. - li_obj->jump( ). + IF lv_exit = abap_false. + " Open object in new window with generic jumper + lv_exit = zcl_abapgit_ui_factory=>get_gui_jumper( )->jump( + is_item = is_item + iv_sub_obj_name = iv_sub_obj_name + iv_sub_obj_type = iv_sub_obj_type + iv_line_number = iv_line_number ). + ENDIF. + + IF lv_exit = abap_false. + zcx_abapgit_exception=>raise( |Jump to { is_item-obj_type } { is_item-obj_name } not possible| ). ENDIF. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_objects_bridge.clas.abap b/src/objects/zcl_abapgit_objects_bridge.clas.abap index b52628e95..05b581099 100644 --- a/src/objects/zcl_abapgit_objects_bridge.clas.abap +++ b/src/objects/zcl_abapgit_objects_bridge.clas.abap @@ -220,6 +220,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_BRIDGE IMPLEMENTATION. METHOD zif_abapgit_object~jump. CALL METHOD mo_plugin->('ZIF_ABAPGITP_PLUGIN~JUMP'). + rv_exit = abap_true. ENDMETHOD. diff --git a/src/objects/zif_abapgit_object.intf.abap b/src/objects/zif_abapgit_object.intf.abap index 768f25788..4dd046d52 100644 --- a/src/objects/zif_abapgit_object.intf.abap +++ b/src/objects/zif_abapgit_object.intf.abap @@ -54,6 +54,8 @@ INTERFACE zif_abapgit_object RAISING zcx_abapgit_exception . METHODS jump + RETURNING + VALUE(rv_exit) TYPE abap_bool RAISING zcx_abapgit_exception . METHODS get_metadata