From 320a74f95d98fad4078bb67a64b702f1bdfbb388 Mon Sep 17 00:00:00 2001 From: Marc Bernard Date: Thu, 28 Nov 2024 00:09:11 +0000 Subject: [PATCH] Revert some --- src/objects/zcl_abapgit_object_iobj.clas.abap | 137 ++++++------------ src/objects/zcl_abapgit_object_iwpr.clas.abap | 6 +- src/objects/zcl_abapgit_object_iwvb.clas.abap | 6 +- src/objects/zcl_abapgit_object_msag.clas.abap | 18 +-- 4 files changed, 53 insertions(+), 114 deletions(-) diff --git a/src/objects/zcl_abapgit_object_iobj.clas.abap b/src/objects/zcl_abapgit_object_iobj.clas.abap index ed1d4f4da..ae70908a1 100644 --- a/src/objects/zcl_abapgit_object_iobj.clas.abap +++ b/src/objects/zcl_abapgit_object_iobj.clas.abap @@ -61,7 +61,7 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION. iobj_not_found = 1 illegal_input = 2 bct_comp_invalid = 3 -* not_authorized = 4 " not in lower releases + not_authorized = 4 OTHERS = 5. IF sy-subrc = 0. ASSIGN COMPONENT 'TSTPNM' OF STRUCTURE TO . @@ -200,67 +200,36 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION. ASSERT sy-subrc = 0. IF zif_abapgit_object~exists( ) = abap_false. - TRY. - CALL FUNCTION 'BAPI_IOBJ_CREATE' - EXPORTING - details = - IMPORTING - return = ls_return - TABLES - compounds = - attributes = - navigationattributes = - atrnavinfoprovider = - hierarchycharacteristics = - elimination = - hanafieldsmapping = - xxlattributes = ##ARG_OK. - CATCH cx_sy_dyn_call_param_not_found. - CALL FUNCTION 'BAPI_IOBJ_CREATE' - EXPORTING - details = - IMPORTING - return = ls_return - TABLES - compounds = - attributes = - navigationattributes = - atrnavinfoprovider = - hierarchycharacteristics = - elimination = . - ENDTRY. + CALL FUNCTION 'BAPI_IOBJ_CREATE' + EXPORTING + details = + IMPORTING + return = ls_return + TABLES + compounds = + attributes = + navigationattributes = + atrnavinfoprovider = + hierarchycharacteristics = + elimination = + hanafieldsmapping = + xxlattributes = . ELSE. - TRY. - CALL FUNCTION 'BAPI_IOBJ_CHANGE' - EXPORTING - infoobject = - details = - IMPORTING - return = ls_return - TABLES - compounds = - attributes = - navigationattributes = - atrnavinfoprovider = - hierarchycharacteristics = - elimination = - hanafieldsmapping = - xxlattributes = ##ARG_OK. - CATCH cx_sy_dyn_call_param_not_found. - CALL FUNCTION 'BAPI_IOBJ_CHANGE' - EXPORTING - infoobject = - details = - IMPORTING - return = ls_return - TABLES - compounds = - attributes = - navigationattributes = - atrnavinfoprovider = - hierarchycharacteristics = - elimination = . - ENDTRY. + CALL FUNCTION 'BAPI_IOBJ_CHANGE' + EXPORTING + infoobject = + details = + IMPORTING + return = ls_return + TABLES + compounds = + attributes = + navigationattributes = + atrnavinfoprovider = + hierarchycharacteristics = + elimination = + hanafieldsmapping = + xxlattributes = . ENDIF. IF ls_return-type = 'E'. @@ -440,37 +409,21 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION. lv_iobjnam = ms_item-obj_name. - TRY. - CALL FUNCTION 'BAPI_IOBJ_GETDETAIL' - EXPORTING - infoobject = lv_iobjnam - IMPORTING - details = - return = ls_return - TABLES - compounds = - attributes = - navigationattributes = - atrnavinfoprovider = - hierarchycharacteristics = - elimination = - hanafieldsmapping = - xxlattributes = ##ARG_OK. - CATCH cx_sy_dyn_call_param_not_found. - CALL FUNCTION 'BAPI_IOBJ_GETDETAIL' - EXPORTING - infoobject = lv_iobjnam - IMPORTING - details = - return = ls_return - TABLES - compounds = - attributes = - navigationattributes = - atrnavinfoprovider = - hierarchycharacteristics = - elimination = . - ENDTRY. + CALL FUNCTION 'BAPI_IOBJ_GETDETAIL' + EXPORTING + infoobject = lv_iobjnam + IMPORTING + details = + return = ls_return + TABLES + compounds = + attributes = + navigationattributes = + atrnavinfoprovider = + hierarchycharacteristics = + elimination = + hanafieldsmapping = + xxlattributes = . IF ls_return-type = 'E'. zcx_abapgit_exception=>raise( |Error getting details of InfoObject: { ls_return-message }| ). diff --git a/src/objects/zcl_abapgit_object_iwpr.clas.abap b/src/objects/zcl_abapgit_object_iwpr.clas.abap index a0251fce3..1701dc6ec 100644 --- a/src/objects/zcl_abapgit_object_iwpr.clas.abap +++ b/src/objects/zcl_abapgit_object_iwpr.clas.abap @@ -124,11 +124,7 @@ CLASS zcl_abapgit_object_iwpr IMPLEMENTATION. METHOD zif_abapgit_object~jump. - DATA lv_prog TYPE progname. - - lv_prog = '/IWBEP/R_SBUI_SERVICE_BUILDER'. - - SUBMIT (lv_prog) + SUBMIT /iwbep/r_sbui_service_builder WITH i_prname = ms_item-obj_name AND RETURN. diff --git a/src/objects/zcl_abapgit_object_iwvb.clas.abap b/src/objects/zcl_abapgit_object_iwvb.clas.abap index e2405e71a..78b21145d 100644 --- a/src/objects/zcl_abapgit_object_iwvb.clas.abap +++ b/src/objects/zcl_abapgit_object_iwvb.clas.abap @@ -131,11 +131,7 @@ CLASS zcl_abapgit_object_iwvb IMPLEMENTATION. METHOD zif_abapgit_object~jump. - DATA lv_prog TYPE progname. - - lv_prog = '/IWBEP/R_DST_VOCAN_REGISTER'. - - SUBMIT (lv_prog) + SUBMIT /iwbep/r_dst_vocan_register WITH ip_aname = ms_item-obj_name WITH ip_avers = ms_item-obj_name+32(4) AND RETURN. diff --git a/src/objects/zcl_abapgit_object_msag.clas.abap b/src/objects/zcl_abapgit_object_msag.clas.abap index fcd443fc8..995788751 100644 --- a/src/objects/zcl_abapgit_object_msag.clas.abap +++ b/src/objects/zcl_abapgit_object_msag.clas.abap @@ -37,17 +37,13 @@ CLASS zcl_abapgit_object_msag DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje zcx_abapgit_exception . METHODS delete_msgid IMPORTING - !iv_message_id TYPE arbgb - RAISING - zcx_abapgit_exception. + !iv_message_id TYPE arbgb . METHODS free_access_permission IMPORTING !iv_message_id TYPE arbgb . METHODS delete_documentation IMPORTING - !iv_message_id TYPE arbgb - RAISING - zcx_abapgit_exception. + !iv_message_id TYPE arbgb . ENDCLASS. @@ -65,7 +61,9 @@ CLASS zcl_abapgit_object_msag IMPLEMENTATION. element = iv_message_id addition = ' ' IMPORTING - object = lv_key_s. + object = lv_key_s + EXCEPTIONS + OTHERS = 0. CALL FUNCTION 'DOKU_DELETE_ALL' EXPORTING @@ -82,11 +80,7 @@ CLASS zcl_abapgit_object_msag IMPLEMENTATION. no_docu_found = 4 object_is_already_enqueued = 5 object_is_enqueued_by_corr = 6 - user_break = 7 - OTHERS = 8. - IF sy-subrc <> 0. - zcx_abapgit_exception=>raise( 'Error deleting messages' ). - ENDIF. + user_break = 7. ENDMETHOD.