From 338cf6a35801d8ecb0cd0aa90fdeaa47824e56d5 Mon Sep 17 00:00:00 2001
From: yellappam <yellappa5237@gmail.com>
Date: Sat, 20 Feb 2021 22:17:43 +1300
Subject: [PATCH] Background logic to log exception and continue (#4534)

When executing the background logic if a repo processing fails, then log the error and continue processing with next repository.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
---
 .../zcl_abapgit_background.clas.abap          | 31 +++++++++++--------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/src/background/zcl_abapgit_background.clas.abap b/src/background/zcl_abapgit_background.clas.abap
index 766e8334d..f84e5b347 100644
--- a/src/background/zcl_abapgit_background.clas.abap
+++ b/src/background/zcl_abapgit_background.clas.abap
@@ -76,6 +76,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND IMPLEMENTATION.
           lt_list       TYPE zcl_abapgit_persist_background=>ty_background_keys,
           li_background TYPE REF TO zif_abapgit_background,
           li_log        TYPE REF TO zif_abapgit_log,
+          lx_error      TYPE REF TO zcx_abapgit_exception,
           lv_repo_name  TYPE string.
 
     FIELD-SYMBOLS: <ls_list> LIKE LINE OF lt_list.
@@ -101,22 +102,26 @@ CLASS ZCL_ABAPGIT_BACKGROUND IMPLEMENTATION.
     WRITE: / 'Background mode'.
 
     LOOP AT lt_list ASSIGNING <ls_list>.
-      lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( <ls_list>-key ).
-      lv_repo_name = lo_repo->get_name( ).
-      WRITE: / <ls_list>-method, lv_repo_name.
+      TRY.
+          lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( <ls_list>-key ).
+          lv_repo_name = lo_repo->get_name( ).
+          WRITE: / <ls_list>-method, lv_repo_name.
 
-      zcl_abapgit_login_manager=>set(
-        iv_uri      = lo_repo->get_url( )
-        iv_username = <ls_list>-username
-        iv_password = <ls_list>-password ).
+          zcl_abapgit_login_manager=>set(
+            iv_uri      = lo_repo->get_url( )
+            iv_username = <ls_list>-username
+            iv_password = <ls_list>-password ).
 
-      CREATE OBJECT li_log TYPE zcl_abapgit_log.
-      CREATE OBJECT li_background TYPE (<ls_list>-method).
+          CREATE OBJECT li_log TYPE zcl_abapgit_log.
+          CREATE OBJECT li_background TYPE (<ls_list>-method).
 
-      li_background->run(
-        io_repo     = lo_repo
-        ii_log      = li_log
-        it_settings = <ls_list>-settings ).
+          li_background->run(
+            io_repo     = lo_repo
+            ii_log      = li_log
+            it_settings = <ls_list>-settings ).
+        CATCH zcx_abapgit_exception INTO lx_error.
+          li_log->add_exception( lx_error ).
+      ENDTRY.
 
       zcl_abapgit_log_viewer=>write_log( li_log ).
     ENDLOOP.