SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Performance: Remove double check during deserialize (#3875)

Browse Source 
* Performance: Remove double check during deserialize

Closes https://github.com/larshp/abapGit/issues/3757

* check_write_protected check_language

* Add calls to find methods

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2020-09-14 06:47:45 -04:00 committed by GitHub
parent 454c23acdc
commit 34955f98cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 44 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
src/zcl_abapgit_repo.clas.abap
View File

@ -171,8 +171,8 @@ CLASS zcl_abapgit_repo DEFINITION
METHODS reset_remote . METHODS reset_remote .
PRIVATE SECTION. PRIVATE SECTION.
DATA mi_listener TYPE REF TO zif_abapgit_repo_listener. DATA mi_listener TYPE REF TO zif_abapgit_repo_listener .
DATA mo_apack_reader TYPE REF TO zcl_abapgit_apack_reader. DATA mo_apack_reader TYPE REF TO zcl_abapgit_apack_reader .
METHODS get_local_checksums METHODS get_local_checksums
RETURNING RETURNING
@ -196,6 +196,12 @@ CLASS zcl_abapgit_repo DEFINITION
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS check_for_restart . METHODS check_for_restart .
METHODS check_write_protect
RAISING
zcx_abapgit_exception .
METHODS check_language
RAISING
zcx_abapgit_exception .
ENDCLASS. ENDCLASS.
@ -260,6 +266,33 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD check_language.
DATA lv_master_language TYPE spras.
" assumes find_remote_dot_abapgit has been called before
lv_master_language = get_dot_abapgit( )->get_master_language( ).
IF lv_master_language <> sy-langu.
zcx_abapgit_exception=>raise( |Current login language |
&& |'{ zcl_abapgit_convert=>conversion_exit_isola_output( sy-langu ) }'|
&& | does not match master language |
&& |'{ zcl_abapgit_convert=>conversion_exit_isola_output( lv_master_language ) }'.|
&& | Run 'Advanced' > 'Open in master language'| ).
ENDIF.
ENDMETHOD.
METHOD check_write_protect.
IF get_local_settings( )-write_protected = abap_true.
zcx_abapgit_exception=>raise( 'Cannot deserialize. Local code is write-protected by repo config' ).
ENDIF.
ENDMETHOD.
METHOD constructor. METHOD constructor.
ASSERT NOT is_data-key IS INITIAL. ASSERT NOT is_data-key IS INITIAL.
@ -295,7 +328,11 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
DATA: lt_updated_files TYPE zif_abapgit_definitions=>ty_file_signatures_tt, DATA: lt_updated_files TYPE zif_abapgit_definitions=>ty_file_signatures_tt,
lx_error TYPE REF TO zcx_abapgit_exception. lx_error TYPE REF TO zcx_abapgit_exception.
deserialize_checks( ). find_remote_dot_abapgit( ).
find_remote_dot_apack( ).
check_write_protect( ).
check_language( ).
IF is_checks-requirements-met = zif_abapgit_definitions=>gc_no AND is_checks-requirements-decision IS INITIAL. IF is_checks-requirements-met = zif_abapgit_definitions=>gc_no AND is_checks-requirements-decision IS INITIAL.
zcx_abapgit_exception=>raise( 'Requirements not met and undecided' ). zcx_abapgit_exception=>raise( 'Requirements not met and undecided' ).
@ -338,26 +375,13 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
METHOD deserialize_checks. METHOD deserialize_checks.
DATA: lt_requirements TYPE zif_abapgit_dot_abapgit=>ty_requirement_tt, DATA: lt_requirements TYPE zif_abapgit_dot_abapgit=>ty_requirement_tt,
lt_dependencies TYPE zif_abapgit_apack_definitions=>tt_dependencies, lt_dependencies TYPE zif_abapgit_apack_definitions=>tt_dependencies.
lv_master_language TYPE spras,
lv_logon_language TYPE spras.
find_remote_dot_abapgit( ). find_remote_dot_abapgit( ).
find_remote_dot_apack( ). find_remote_dot_apack( ).
lv_master_language = get_dot_abapgit( )->get_master_language( ). check_write_protect( ).
lv_logon_language = sy-langu. check_language( ).
IF get_local_settings( )-write_protected = abap_true.
zcx_abapgit_exception=>raise( 'Cannot deserialize. Local code is write-protected by repo config' ).
ELSEIF lv_master_language <> lv_logon_language.
zcx_abapgit_exception=>raise( |Current login language |
&& |'{ zcl_abapgit_convert=>conversion_exit_isola_output( lv_logon_language ) }'|
&& | does not match master language |
&& |'{ zcl_abapgit_convert=>conversion_exit_isola_output( lv_master_language ) }'.|
&& | Run 'Advanced' > 'Open in master language'| ).
ENDIF.
rs_checks = zcl_abapgit_objects=>deserialize_checks( me ). rs_checks = zcl_abapgit_objects=>deserialize_checks( me ).