SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix namespace check for AFF (#6146)

Browse Source 
Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2023-03-15 11:38:02 +01:00 committed by GitHub
parent b52e82da87
commit 36cc1f83b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/repo/zcl_abapgit_file_status.clas.locals_imp.abap
View File

@ -180,13 +180,18 @@ CLASS lcl_status_consistency_checks IMPLEMENTATION.
FIELD-SYMBOLS <ls_result> LIKE LINE OF it_results. FIELD-SYMBOLS <ls_result> LIKE LINE OF it_results.
" Collect all namespaces based on name of xml-files " Collect all namespaces based on name of xml- and json-files
LOOP AT it_results ASSIGNING <ls_result>. LOOP AT it_results ASSIGNING <ls_result>.
FIND REGEX '^#([a-zA-Z0-9]+)#.*\..*\.xml$' IN <ls_result>-filename SUBMATCHES lv_namespace. FIND REGEX '^#([a-zA-Z0-9]+)#.*\..*\.xml$' IN <ls_result>-filename SUBMATCHES lv_namespace.
IF sy-subrc = 0. IF sy-subrc = 0.
lv_namespace = '/' && to_upper( lv_namespace ) && '/'. lv_namespace = '/' && to_upper( lv_namespace ) && '/'.
COLLECT lv_namespace INTO lt_namespace. COLLECT lv_namespace INTO lt_namespace.
ENDIF. ENDIF.
FIND REGEX '^\(([a-zA-Z0-9]+)\).*\..*\.json$' IN <ls_result>-filename SUBMATCHES lv_namespace.
IF sy-subrc = 0.
lv_namespace = '/' && to_upper( lv_namespace ) && '/'.
COLLECT lv_namespace INTO lt_namespace.
ENDIF.
ENDLOOP. ENDLOOP.
li_namespace = zcl_abapgit_factory=>get_sap_namespace( ). li_namespace = zcl_abapgit_factory=>get_sap_namespace( ).

30
src/repo/zcl_abapgit_file_status.clas.testclasses.abap
View File

@ -61,6 +61,7 @@ CLASS ltcl_run_checks DEFINITION FOR TESTING RISK LEVEL HARMLESS
neg_empty_filenames FOR TESTING RAISING zcx_abapgit_exception, neg_empty_filenames FOR TESTING RAISING zcx_abapgit_exception,
package_move FOR TESTING RAISING zcx_abapgit_exception, package_move FOR TESTING RAISING zcx_abapgit_exception,
check_namespace FOR TESTING RAISING zcx_abapgit_exception, check_namespace FOR TESTING RAISING zcx_abapgit_exception,
check_namespace_aff FOR TESTING RAISING zcx_abapgit_exception,
check_sub_package FOR TESTING RAISING zcx_abapgit_exception. check_sub_package FOR TESTING RAISING zcx_abapgit_exception.
ENDCLASS. ENDCLASS.
@ -516,6 +517,35 @@ CLASS ltcl_run_checks IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD check_namespace_aff.
" 6 Missing namespace
append_result( iv_obj_type = 'CLAS'
iv_obj_name = '/NOTEXIST/ZCLASS1'
iv_match = ' '
iv_lstate = ' '
iv_rstate = 'A'
iv_package = '/NOTEXIST/Z'
iv_path = '/'
iv_filename = '(notexist)zclass1.clas.json' ).
CREATE OBJECT mo_instance
EXPORTING
iv_root_package = '/NOTEXIST/Z'
io_dot = mo_dot.
mi_log = mo_instance->run_checks( mt_results ).
cl_abap_unit_assert=>assert_equals(
act = mi_log->count( )
exp = 1 ).
ltcl_util=>check_contains(
ii_log = mi_log
iv_pattern = |Namespace *| ).
ENDMETHOD.
METHOD check_sub_package. METHOD check_sub_package.
append_result( iv_obj_type = 'DEVC' append_result( iv_obj_type = 'DEVC'