SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 04:08:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix typos and adjust comments within the codebase (#6779)

Browse Source
This commit is contained in:
francisco-milan 2024-01-28 22:53:30 -07:00 committed by GitHub
parent 7bff32b718
commit 374bc13a7b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
12 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/objects/core/zcl_abapgit_folder_logic.clas.abap
View File

@ -118,7 +118,7 @@ CLASS zcl_abapgit_folder_logic IMPLEMENTATION.
IF iv_package(lv_len) <> lv_parentcl. IF iv_package(lv_len) <> lv_parentcl.
" If abapGit project is installed in package ZZZ, all subpackages should be named " If abapGit project is installed in package ZZZ, all subpackages should be named
" ZZZ_something. This will define the folder name in the zip file to be "something", " ZZZ_something. This will define the folder name in the zip file to be "something",
" similarily with online projects. Alternatively change to FULL folder logic " similarly with online projects. Alternatively change to FULL folder logic
lv_message = |PREFIX: Unexpected package naming | lv_message = |PREFIX: Unexpected package naming |
&& |(top: { iv_top }, parent: { lv_parentcl }, child: { iv_package }). | && |(top: { iv_top }, parent: { lv_parentcl }, child: { iv_package }). |
&& |Try using the folder logic FULL|. && |Try using the folder logic FULL|.

4
src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap
View File

@ -351,7 +351,7 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
ASSIGN lt_svars TO <lt_tab>. ASSIGN lt_svars TO <lt_tab>.
ENDCASE. ENDCASE.
CALL FUNCTION 'SDIXML_DATA_TO_DOM' "Ast generieren lassen CALL FUNCTION 'SDIXML_DATA_TO_DOM' "Generate branch
EXPORTING EXPORTING
name = lv_name name = lv_name
dataobject = <lt_tab> dataobject = <lt_tab>
@ -367,7 +367,7 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
previous = ex_ecatt ). previous = ex_ecatt ).
ENDIF. ENDIF.
* Ast in Hauptbaum haengen * Hang a branch in the main tree
lv_rc = li_deep_tcd->append_child( li_element ). lv_rc = li_deep_tcd->append_child( li_element ).
IF lv_rc <> 0. IF lv_rc <> 0.

2
src/objects/tabl/zcl_abapgit_object_tabl.clas.abap
View File

@ -31,7 +31,7 @@ CLASS zcl_abapgit_object_tabl DEFINITION
"! Deserialize IDoc Segment type/definition if exits "! Deserialize IDoc Segment type/definition if exits
"! @parameter iv_package | Target package "! @parameter iv_package | Target package
"! @parameter rv_deserialized | It's a segment and was desserialized "! @parameter rv_deserialized | It's a segment and was deserialized
"! @raising zcx_abapgit_exception | Exceptions "! @raising zcx_abapgit_exception | Exceptions
METHODS deserialize_idoc_segment IMPORTING is_internal TYPE zif_abapgit_object_tabl=>ty_internal METHODS deserialize_idoc_segment IMPORTING is_internal TYPE zif_abapgit_object_tabl=>ty_internal
iv_transport TYPE trkorr iv_transport TYPE trkorr

4
src/objects/zcl_abapgit_object_tran.clas.abap
View File

@ -524,7 +524,7 @@ CLASS zcl_abapgit_object_tran IMPLEMENTATION.
CLEAR cs_rsstcd-s_vari. CLEAR cs_rsstcd-s_vari.
IF cs_tstcp-param(1) = '\'. " OO-Transaktion ohne FR IF cs_tstcp-param(1) = '\'. " OO-Transaction without FR
split_parameters_comp( EXPORTING ig_type = c_oo_program split_parameters_comp( EXPORTING ig_type = c_oo_program
ig_param = cs_tstcp-param ig_param = cs_tstcp-param
CHANGING cg_value = cs_tstc-pgmna ). CHANGING cg_value = cs_tstc-pgmna ).
@ -539,7 +539,7 @@ CLASS zcl_abapgit_object_tran IMPLEMENTATION.
cs_rsstcd-s_local = c_true. cs_rsstcd-s_local = c_true.
ENDIF. ENDIF.
RETURN. RETURN.
ELSEIF cs_tstcp-param(1) = '@'. " Transaktionsvariante ELSEIF cs_tstcp-param(1) = '@'. " Transaction variant
cs_rsstcd-s_vari = c_true. cs_rsstcd-s_vari = c_true.
IF cs_tstcp-param(2) = '@@'. IF cs_tstcp-param(2) = '@@'.
cs_rsstcd-s_ind_vari = c_true. cs_rsstcd-s_ind_vari = c_true.

2
src/repo/utils/zcl_abapgit_repo_requirements.clas.abap
View File

@ -130,7 +130,7 @@ CLASS zcl_abapgit_repo_requirements IMPLEMENTATION.
is_status-required_release TO lv_required_release, is_status-required_release TO lv_required_release,
is_status-required_patch TO lv_required_patch. is_status-required_patch TO lv_required_patch.
CATCH cx_sy_conversion_error. CATCH cx_sy_conversion_error.
" Cannot compare by number, assume requirement not fullfilled (user can force install " Cannot compare by number, assume requirement not fulfilled (user can force install
" anyways if this was an error) " anyways if this was an error)
rv_true = abap_false. rv_true = abap_false.
RETURN. RETURN.

2
src/ui/pages/zcl_abapgit_gui_page_sett_bckg.clas.abap
View File

@ -298,7 +298,7 @@ CLASS zcl_abapgit_gui_page_sett_bckg IMPLEMENTATION.
COMMIT WORK AND WAIT. COMMIT WORK AND WAIT.
MESSAGE 'Settings succesfully saved' TYPE 'S'. MESSAGE 'Settings successfully saved' TYPE 'S'.
mo_form_data = read_settings( ). mo_form_data = read_settings( ).

2
src/ui/pages/zcl_abapgit_gui_page_sett_glob.clas.abap
View File

@ -308,7 +308,7 @@ CLASS zcl_abapgit_gui_page_sett_glob IMPLEMENTATION.
COMMIT WORK AND WAIT. COMMIT WORK AND WAIT.
MESSAGE 'Settings succesfully saved' TYPE 'S'. MESSAGE 'Settings successfully saved' TYPE 'S'.
mo_form_data = read_settings( ). mo_form_data = read_settings( ).

6
src/ui/pages/zcl_abapgit_gui_page_sett_locl.clas.abap
View File

@ -307,7 +307,7 @@ CLASS zcl_abapgit_gui_page_sett_locl IMPLEMENTATION.
IF mo_popup_picklist IS BOUND AND IF mo_popup_picklist IS BOUND AND
( mo_popup_picklist->is_fulfilled( ) = abap_true OR mo_popup_picklist->is_in_page( ) = abap_false ). ( mo_popup_picklist->is_fulfilled( ) = abap_true OR mo_popup_picklist->is_in_page( ) = abap_false ).
" Picklist is either fullfilled OR " Picklist is either fulfilled OR
" it was on its own page and user went back from it via F3/ESC and the picklist had no "graceful back" handler " it was on its own page and user went back from it via F3/ESC and the picklist had no "graceful back" handler
CASE mo_popup_picklist->id( ). CASE mo_popup_picklist->id( ).
WHEN c_event-choose_check_variant. WHEN c_event-choose_check_variant.
@ -410,7 +410,7 @@ CLASS zcl_abapgit_gui_page_sett_locl IMPLEMENTATION.
COMMIT WORK AND WAIT. COMMIT WORK AND WAIT.
MESSAGE 'Settings succesfully saved' TYPE 'S'. MESSAGE 'Settings successfully saved' TYPE 'S'.
mo_form_data = read_settings( ). mo_form_data = read_settings( ).
@ -522,7 +522,7 @@ CLASS zcl_abapgit_gui_page_sett_locl IMPLEMENTATION.
IF mo_popup_picklist IS BOUND. " Uniform popup state handling IF mo_popup_picklist IS BOUND. " Uniform popup state handling
" This should happen only for a new popup because " This should happen only for a new popup because
" on the first re-render main component event handling is blocked " on the first re-render main component event handling is blocked
" and not called again until the popup distruction " and not called again until the popup destruction
IF mo_popup_picklist->is_in_page( ) = abap_true. IF mo_popup_picklist->is_in_page( ) = abap_true.
rs_handled-state = zcl_abapgit_gui=>c_event_state-re_render. rs_handled-state = zcl_abapgit_gui=>c_event_state-re_render.
ELSE. ELSE.

2
src/ui/pages/zcl_abapgit_gui_page_sett_pers.clas.abap
View File

@ -344,7 +344,7 @@ CLASS zcl_abapgit_gui_page_sett_pers IMPLEMENTATION.
COMMIT WORK AND WAIT. COMMIT WORK AND WAIT.
MESSAGE 'Settings succesfully saved' TYPE 'S'. MESSAGE 'Settings successfully saved' TYPE 'S'.
mo_form_data = read_settings( ). mo_form_data = read_settings( ).

6
src/ui/pages/zcl_abapgit_gui_page_sett_remo.clas.abap
View File

@ -583,7 +583,7 @@ CLASS zcl_abapgit_gui_page_sett_remo IMPLEMENTATION.
IF mo_popup_picklist IS BOUND AND IF mo_popup_picklist IS BOUND AND
( mo_popup_picklist->is_fulfilled( ) = abap_true OR mo_popup_picklist->is_in_page( ) = abap_false ). ( mo_popup_picklist->is_fulfilled( ) = abap_true OR mo_popup_picklist->is_in_page( ) = abap_false ).
" Picklist is either fullfilled OR " Picklist is either fulfilled OR
" it was on its own page and user went back from it via F3/ESC and the picklist had no "graceful back" handler " it was on its own page and user went back from it via F3/ESC and the picklist had no "graceful back" handler
CASE mo_popup_picklist->id( ). CASE mo_popup_picklist->id( ).
WHEN c_event-choose_pull_request. WHEN c_event-choose_pull_request.
@ -717,7 +717,7 @@ CLASS zcl_abapgit_gui_page_sett_remo IMPLEMENTATION.
COMMIT WORK AND WAIT. COMMIT WORK AND WAIT.
MESSAGE 'Settings succesfully saved' TYPE 'S'. MESSAGE 'Settings successfully saved' TYPE 'S'.
mv_refresh_on_back = abap_true. mv_refresh_on_back = abap_true.
ms_settings_snapshot = get_remote_settings_from_repo( mo_repo ). ms_settings_snapshot = get_remote_settings_from_repo( mo_repo ).
@ -989,7 +989,7 @@ CLASS zcl_abapgit_gui_page_sett_remo IMPLEMENTATION.
IF mo_popup_picklist IS BOUND. " Uniform popup state handling IF mo_popup_picklist IS BOUND. " Uniform popup state handling
" This should happen only for a new popup because " This should happen only for a new popup because
" on the first re-render main component event handling is blocked " on the first re-render main component event handling is blocked
" and not called again until the popup distruction " and not called again until the popup destruction
IF mo_popup_picklist->is_in_page( ) = abap_true. IF mo_popup_picklist->is_in_page( ) = abap_true.
rs_handled-state = zcl_abapgit_gui=>c_event_state-re_render. rs_handled-state = zcl_abapgit_gui=>c_event_state-re_render.
ELSE. ELSE.

4
src/ui/pages/zcl_abapgit_gui_page_sett_repo.clas.abap
View File

@ -415,7 +415,7 @@ CLASS zcl_abapgit_gui_page_sett_repo IMPLEMENTATION.
COMMIT WORK AND WAIT. COMMIT WORK AND WAIT.
MESSAGE 'Settings succesfully saved' TYPE 'S'. MESSAGE 'Settings successfully saved' TYPE 'S'.
mo_form_data = read_settings( ). mo_form_data = read_settings( ).
@ -467,7 +467,7 @@ CLASS zcl_abapgit_gui_page_sett_repo IMPLEMENTATION.
ELSEIF lv_component IS NOT INITIAL AND lv_min_release IS INITIAL. ELSEIF lv_component IS NOT INITIAL AND lv_min_release IS INITIAL.
ro_validation_log->set( ro_validation_log->set(
iv_key = c_id-requirements iv_key = c_id-requirements
iv_val = |If you enter a software component, you must also enter a minumum release| ). iv_val = |If you enter a software component, you must also enter a minimum release| ).
ENDIF. ENDIF.
ENDDO. ENDDO.

2
src/utils/zcl_abapgit_utils.clas.abap
View File

@ -29,7 +29,7 @@ CLASS zcl_abapgit_utils IMPLEMENTATION.
" Previously we did a simple char range test described here " Previously we did a simple char range test described here
" stackoverflow.com/questions/277521/how-to-identify-the-file-content-as-ascii-or-binary " stackoverflow.com/questions/277521/how-to-identify-the-file-content-as-ascii-or-binary
" but this is insufficient if the data contains german umlauts and other special characters. " but this is insufficient if the data contains german umlauts and other special characters.
" Therefore we adopted another algorithm, which is similarily used by AL11 " Therefore we adopted another algorithm, which is similarly used by AL11
" RSWATCH0 / GUESS_FILE_TYPE " RSWATCH0 / GUESS_FILE_TYPE
" We count non-printable characters if there are more than XX% it's binary. " We count non-printable characters if there are more than XX% it's binary.