mirror of
https://github.com/abapGit/abapGit.git
synced 2025-04-30 20:03:20 +08:00
Fix typos and adjust comments within the codebase (#6779)
This commit is contained in:
parent
7bff32b718
commit
374bc13a7b
|
@ -118,7 +118,7 @@ CLASS zcl_abapgit_folder_logic IMPLEMENTATION.
|
|||
IF iv_package(lv_len) <> lv_parentcl.
|
||||
" If abapGit project is installed in package ZZZ, all subpackages should be named
|
||||
" ZZZ_something. This will define the folder name in the zip file to be "something",
|
||||
" similarily with online projects. Alternatively change to FULL folder logic
|
||||
" similarly with online projects. Alternatively change to FULL folder logic
|
||||
lv_message = |PREFIX: Unexpected package naming |
|
||||
&& |(top: { iv_top }, parent: { lv_parentcl }, child: { iv_package }). |
|
||||
&& |Try using the folder logic FULL|.
|
||||
|
|
|
@ -351,7 +351,7 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
|
|||
ASSIGN lt_svars TO <lt_tab>.
|
||||
ENDCASE.
|
||||
|
||||
CALL FUNCTION 'SDIXML_DATA_TO_DOM' "Ast generieren lassen
|
||||
CALL FUNCTION 'SDIXML_DATA_TO_DOM' "Generate branch
|
||||
EXPORTING
|
||||
name = lv_name
|
||||
dataobject = <lt_tab>
|
||||
|
@ -367,7 +367,7 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION.
|
|||
previous = ex_ecatt ).
|
||||
ENDIF.
|
||||
|
||||
* Ast in Hauptbaum haengen
|
||||
* Hang a branch in the main tree
|
||||
lv_rc = li_deep_tcd->append_child( li_element ).
|
||||
|
||||
IF lv_rc <> 0.
|
||||
|
|
|
@ -31,7 +31,7 @@ CLASS zcl_abapgit_object_tabl DEFINITION
|
|||
|
||||
"! Deserialize IDoc Segment type/definition if exits
|
||||
"! @parameter iv_package | Target package
|
||||
"! @parameter rv_deserialized | It's a segment and was desserialized
|
||||
"! @parameter rv_deserialized | It's a segment and was deserialized
|
||||
"! @raising zcx_abapgit_exception | Exceptions
|
||||
METHODS deserialize_idoc_segment IMPORTING is_internal TYPE zif_abapgit_object_tabl=>ty_internal
|
||||
iv_transport TYPE trkorr
|
||||
|
|
|
@ -524,7 +524,7 @@ CLASS zcl_abapgit_object_tran IMPLEMENTATION.
|
|||
|
||||
CLEAR cs_rsstcd-s_vari.
|
||||
|
||||
IF cs_tstcp-param(1) = '\'. " OO-Transaktion ohne FR
|
||||
IF cs_tstcp-param(1) = '\'. " OO-Transaction without FR
|
||||
split_parameters_comp( EXPORTING ig_type = c_oo_program
|
||||
ig_param = cs_tstcp-param
|
||||
CHANGING cg_value = cs_tstc-pgmna ).
|
||||
|
@ -539,7 +539,7 @@ CLASS zcl_abapgit_object_tran IMPLEMENTATION.
|
|||
cs_rsstcd-s_local = c_true.
|
||||
ENDIF.
|
||||
RETURN.
|
||||
ELSEIF cs_tstcp-param(1) = '@'. " Transaktionsvariante
|
||||
ELSEIF cs_tstcp-param(1) = '@'. " Transaction variant
|
||||
cs_rsstcd-s_vari = c_true.
|
||||
IF cs_tstcp-param(2) = '@@'.
|
||||
cs_rsstcd-s_ind_vari = c_true.
|
||||
|
|
|
@ -130,7 +130,7 @@ CLASS zcl_abapgit_repo_requirements IMPLEMENTATION.
|
|||
is_status-required_release TO lv_required_release,
|
||||
is_status-required_patch TO lv_required_patch.
|
||||
CATCH cx_sy_conversion_error.
|
||||
" Cannot compare by number, assume requirement not fullfilled (user can force install
|
||||
" Cannot compare by number, assume requirement not fulfilled (user can force install
|
||||
" anyways if this was an error)
|
||||
rv_true = abap_false.
|
||||
RETURN.
|
||||
|
|
|
@ -298,7 +298,7 @@ CLASS zcl_abapgit_gui_page_sett_bckg IMPLEMENTATION.
|
|||
|
||||
COMMIT WORK AND WAIT.
|
||||
|
||||
MESSAGE 'Settings succesfully saved' TYPE 'S'.
|
||||
MESSAGE 'Settings successfully saved' TYPE 'S'.
|
||||
|
||||
mo_form_data = read_settings( ).
|
||||
|
||||
|
|
|
@ -308,7 +308,7 @@ CLASS zcl_abapgit_gui_page_sett_glob IMPLEMENTATION.
|
|||
|
||||
COMMIT WORK AND WAIT.
|
||||
|
||||
MESSAGE 'Settings succesfully saved' TYPE 'S'.
|
||||
MESSAGE 'Settings successfully saved' TYPE 'S'.
|
||||
|
||||
mo_form_data = read_settings( ).
|
||||
|
||||
|
|
|
@ -307,7 +307,7 @@ CLASS zcl_abapgit_gui_page_sett_locl IMPLEMENTATION.
|
|||
|
||||
IF mo_popup_picklist IS BOUND AND
|
||||
( mo_popup_picklist->is_fulfilled( ) = abap_true OR mo_popup_picklist->is_in_page( ) = abap_false ).
|
||||
" Picklist is either fullfilled OR
|
||||
" Picklist is either fulfilled OR
|
||||
" it was on its own page and user went back from it via F3/ESC and the picklist had no "graceful back" handler
|
||||
CASE mo_popup_picklist->id( ).
|
||||
WHEN c_event-choose_check_variant.
|
||||
|
@ -410,7 +410,7 @@ CLASS zcl_abapgit_gui_page_sett_locl IMPLEMENTATION.
|
|||
|
||||
COMMIT WORK AND WAIT.
|
||||
|
||||
MESSAGE 'Settings succesfully saved' TYPE 'S'.
|
||||
MESSAGE 'Settings successfully saved' TYPE 'S'.
|
||||
|
||||
mo_form_data = read_settings( ).
|
||||
|
||||
|
@ -522,7 +522,7 @@ CLASS zcl_abapgit_gui_page_sett_locl IMPLEMENTATION.
|
|||
IF mo_popup_picklist IS BOUND. " Uniform popup state handling
|
||||
" This should happen only for a new popup because
|
||||
" on the first re-render main component event handling is blocked
|
||||
" and not called again until the popup distruction
|
||||
" and not called again until the popup destruction
|
||||
IF mo_popup_picklist->is_in_page( ) = abap_true.
|
||||
rs_handled-state = zcl_abapgit_gui=>c_event_state-re_render.
|
||||
ELSE.
|
||||
|
|
|
@ -344,7 +344,7 @@ CLASS zcl_abapgit_gui_page_sett_pers IMPLEMENTATION.
|
|||
|
||||
COMMIT WORK AND WAIT.
|
||||
|
||||
MESSAGE 'Settings succesfully saved' TYPE 'S'.
|
||||
MESSAGE 'Settings successfully saved' TYPE 'S'.
|
||||
|
||||
mo_form_data = read_settings( ).
|
||||
|
||||
|
|
|
@ -583,7 +583,7 @@ CLASS zcl_abapgit_gui_page_sett_remo IMPLEMENTATION.
|
|||
|
||||
IF mo_popup_picklist IS BOUND AND
|
||||
( mo_popup_picklist->is_fulfilled( ) = abap_true OR mo_popup_picklist->is_in_page( ) = abap_false ).
|
||||
" Picklist is either fullfilled OR
|
||||
" Picklist is either fulfilled OR
|
||||
" it was on its own page and user went back from it via F3/ESC and the picklist had no "graceful back" handler
|
||||
CASE mo_popup_picklist->id( ).
|
||||
WHEN c_event-choose_pull_request.
|
||||
|
@ -717,7 +717,7 @@ CLASS zcl_abapgit_gui_page_sett_remo IMPLEMENTATION.
|
|||
|
||||
COMMIT WORK AND WAIT.
|
||||
|
||||
MESSAGE 'Settings succesfully saved' TYPE 'S'.
|
||||
MESSAGE 'Settings successfully saved' TYPE 'S'.
|
||||
|
||||
mv_refresh_on_back = abap_true.
|
||||
ms_settings_snapshot = get_remote_settings_from_repo( mo_repo ).
|
||||
|
@ -989,7 +989,7 @@ CLASS zcl_abapgit_gui_page_sett_remo IMPLEMENTATION.
|
|||
IF mo_popup_picklist IS BOUND. " Uniform popup state handling
|
||||
" This should happen only for a new popup because
|
||||
" on the first re-render main component event handling is blocked
|
||||
" and not called again until the popup distruction
|
||||
" and not called again until the popup destruction
|
||||
IF mo_popup_picklist->is_in_page( ) = abap_true.
|
||||
rs_handled-state = zcl_abapgit_gui=>c_event_state-re_render.
|
||||
ELSE.
|
||||
|
|
|
@ -415,7 +415,7 @@ CLASS zcl_abapgit_gui_page_sett_repo IMPLEMENTATION.
|
|||
|
||||
COMMIT WORK AND WAIT.
|
||||
|
||||
MESSAGE 'Settings succesfully saved' TYPE 'S'.
|
||||
MESSAGE 'Settings successfully saved' TYPE 'S'.
|
||||
|
||||
mo_form_data = read_settings( ).
|
||||
|
||||
|
@ -467,7 +467,7 @@ CLASS zcl_abapgit_gui_page_sett_repo IMPLEMENTATION.
|
|||
ELSEIF lv_component IS NOT INITIAL AND lv_min_release IS INITIAL.
|
||||
ro_validation_log->set(
|
||||
iv_key = c_id-requirements
|
||||
iv_val = |If you enter a software component, you must also enter a minumum release| ).
|
||||
iv_val = |If you enter a software component, you must also enter a minimum release| ).
|
||||
ENDIF.
|
||||
ENDDO.
|
||||
|
||||
|
|
|
@ -29,7 +29,7 @@ CLASS zcl_abapgit_utils IMPLEMENTATION.
|
|||
" Previously we did a simple char range test described here
|
||||
" stackoverflow.com/questions/277521/how-to-identify-the-file-content-as-ascii-or-binary
|
||||
" but this is insufficient if the data contains german umlauts and other special characters.
|
||||
" Therefore we adopted another algorithm, which is similarily used by AL11
|
||||
" Therefore we adopted another algorithm, which is similarly used by AL11
|
||||
" RSWATCH0 / GUESS_FILE_TYPE
|
||||
" We count non-printable characters if there are more than XX% it's binary.
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user