From 3a833bb97178b4803e2dc6ffc28dbb5bec0e0f93 Mon Sep 17 00:00:00 2001 From: larshp Date: Sat, 10 Jun 2017 13:39:38 +0000 Subject: [PATCH] cleanup --- src/zabapgit_news.prog.abap | 6 +++--- src/zabapgit_object_auth.prog.abap | 2 +- src/zabapgit_object_enho.prog.abap | 2 +- src/zabapgit_object_fugr.prog.abap | 1 - src/zabapgit_object_shi3.prog.abap | 11 +---------- src/zabapgit_object_tabl.prog.abap | 13 +++++++++---- src/zabapgit_object_ttyp.prog.abap | 3 +-- src/zabapgit_object_view.prog.abap | 8 ++++++-- src/zabapgit_objects.prog.abap | 17 ++++++++++++----- src/zabapgit_repo_impl.prog.abap | 2 +- src/zabapgit_syntax_highlighter.prog.abap | 4 ---- src/zabapgit_util.prog.abap | 8 ++++---- src/zabapgit_xml.prog.abap | 3 +-- 13 files changed, 40 insertions(+), 40 deletions(-) diff --git a/src/zabapgit_news.prog.abap b/src/zabapgit_news.prog.abap index 0c539520b..9e51a9c16 100644 --- a/src/zabapgit_news.prog.abap +++ b/src/zabapgit_news.prog.abap @@ -394,17 +394,17 @@ CLASS ltcl_news IMPLEMENTATION. ls_log = lcl_news=>parse_line( iv_line = '======' iv_current_version = '1.26.01' ). - cl_abap_unit_assert=>assert_initial( act = ls_log ). + cl_abap_unit_assert=>assert_initial( ls_log ). ls_log = lcl_news=>parse_line( iv_line = '' iv_current_version = '1.26.01' ). - cl_abap_unit_assert=>assert_initial( act = ls_log ). + cl_abap_unit_assert=>assert_initial( ls_log ). ls_log = lcl_news=>parse_line( iv_line = '------' iv_current_version = '1.26.01' ). - cl_abap_unit_assert=>assert_initial( act = ls_log ). + cl_abap_unit_assert=>assert_initial( ls_log ). CLEAR ls_log. ls_log = lcl_news=>parse_line( diff --git a/src/zabapgit_object_auth.prog.abap b/src/zabapgit_object_auth.prog.abap index fde332ce9..8cfe21e0b 100644 --- a/src/zabapgit_object_auth.prog.abap +++ b/src/zabapgit_object_auth.prog.abap @@ -115,7 +115,7 @@ CLASS lcl_object_auth IMPLEMENTATION. METHOD lif_object~jump. - DATA: field TYPE fieldname . + DATA: field TYPE fieldname. field = ms_item-obj_name. diff --git a/src/zabapgit_object_enho.prog.abap b/src/zabapgit_object_enho.prog.abap index 30debffb4..176963fd5 100644 --- a/src/zabapgit_object_enho.prog.abap +++ b/src/zabapgit_object_enho.prog.abap @@ -262,7 +262,7 @@ CLASS lcl_object_enho_clif IMPLEMENTATION. io_xml->read( EXPORTING iv_name = 'TAB_METHODS' CHANGING cg_data = lt_tab_methods ). - io_clif->set_enhattributes( tab_attributes = lt_tab_attributes ). + io_clif->set_enhattributes( lt_tab_attributes ). * todo: deserialize includes diff --git a/src/zabapgit_object_fugr.prog.abap b/src/zabapgit_object_fugr.prog.abap index 8d7f9b118..3fd94c39f 100644 --- a/src/zabapgit_object_fugr.prog.abap +++ b/src/zabapgit_object_fugr.prog.abap @@ -419,7 +419,6 @@ CLASS lcl_object_fugr IMPLEMENTATION. DATA: lt_reposrc TYPE STANDARD TABLE OF ty_reposrc WITH DEFAULT KEY, ls_reposrc LIKE LINE OF lt_reposrc, lv_program TYPE program, - lv_cnam TYPE reposrc-cnam, lv_tabix LIKE sy-tabix, lt_functab TYPE ty_rs38l_incl_tt. diff --git a/src/zabapgit_object_shi3.prog.abap b/src/zabapgit_object_shi3.prog.abap index 255bcdf89..7faadf630 100644 --- a/src/zabapgit_object_shi3.prog.abap +++ b/src/zabapgit_object_shi3.prog.abap @@ -18,16 +18,7 @@ CLASS lcl_object_shi3 DEFINITION INHERITING FROM lcl_objects_super FINAL. PRIVATE SECTION. - - TYPES: BEGIN OF ty_id_map, - old TYPE ttree-id, - new TYPE ttree-id, - END OF ty_id_map. - TYPES tt_id_map TYPE STANDARD TABLE OF ty_id_map. - TYPES ts_id_map TYPE SORTED TABLE OF ty_id_map WITH UNIQUE KEY old. - - DATA: mv_tree_id TYPE ttree-id, - mt_map TYPE ts_id_map. " SORTED ! + DATA: mv_tree_id TYPE ttree-id. METHODS jump_se43 RAISING lcx_exception. diff --git a/src/zabapgit_object_tabl.prog.abap b/src/zabapgit_object_tabl.prog.abap index 229167c76..a8d4a2ab5 100644 --- a/src/zabapgit_object_tabl.prog.abap +++ b/src/zabapgit_object_tabl.prog.abap @@ -27,7 +27,6 @@ CLASS lcl_object_tabl IMPLEMENTATION. DATA: lv_date TYPE dats, lv_time TYPE tims, - lv_ts TYPE timestamp, lt_indexes TYPE STANDARD TABLE OF dd09l. FIELD-SYMBOLS LIKE LINE OF lt_indexes. @@ -42,7 +41,9 @@ CLASS lcl_object_tabl IMPLEMENTATION. iv_timestamp = iv_timestamp iv_date = lv_date iv_time = lv_time ). - CHECK rv_changed = abap_false. + IF rv_changed = abap_true. + RETURN. + ENDIF. SELECT SINGLE as4date as4time FROM dd09l " Table tech settings INTO (lv_date, lv_time) @@ -54,7 +55,9 @@ CLASS lcl_object_tabl IMPLEMENTATION. iv_timestamp = iv_timestamp iv_date = lv_date iv_time = lv_time ). - CHECK rv_changed = abap_false. + IF rv_changed = abap_true. + RETURN. + ENDIF. SELECT as4date as4time FROM dd12l " Table tech settings INTO CORRESPONDING FIELDS OF TABLE lt_indexes @@ -67,7 +70,9 @@ CLASS lcl_object_tabl IMPLEMENTATION. iv_timestamp = iv_timestamp iv_date = -as4date iv_time = -as4time ). - CHECK rv_changed = abap_false. + IF rv_changed = abap_true. + RETURN. + ENDIF. ENDLOOP. ENDMETHOD. "lif_object~has_changed_since diff --git a/src/zabapgit_object_ttyp.prog.abap b/src/zabapgit_object_ttyp.prog.abap index a79f4a6aa..a8031cc0e 100644 --- a/src/zabapgit_object_ttyp.prog.abap +++ b/src/zabapgit_object_ttyp.prog.abap @@ -25,8 +25,7 @@ CLASS lcl_object_ttyp IMPLEMENTATION. METHOD lif_object~has_changed_since. DATA: lv_date TYPE dats, - lv_time TYPE tims, - lv_ts TYPE timestamp. + lv_time TYPE tims. SELECT SINGLE as4date as4time FROM dd40l INTO (lv_date, lv_time) diff --git a/src/zabapgit_object_view.prog.abap b/src/zabapgit_object_view.prog.abap index 1d89a367d..bee07aff5 100644 --- a/src/zabapgit_object_view.prog.abap +++ b/src/zabapgit_object_view.prog.abap @@ -37,7 +37,9 @@ CLASS lcl_object_view IMPLEMENTATION. iv_timestamp = iv_timestamp iv_date = lv_date iv_time = lv_time ). - CHECK rv_changed = abap_false. + IF rv_changed = abap_true. + RETURN. + ENDIF. SELECT SINGLE as4date as4time FROM dd09l INTO (lv_date, lv_time) @@ -49,7 +51,9 @@ CLASS lcl_object_view IMPLEMENTATION. iv_timestamp = iv_timestamp iv_date = lv_date iv_time = lv_time ). - CHECK rv_changed = abap_false. + IF rv_changed = abap_true. + RETURN. + ENDIF. ENDMETHOD. "lif_object~has_changed_since diff --git a/src/zabapgit_objects.prog.abap b/src/zabapgit_objects.prog.abap index 22f9f8e2d..8b2907a56 100644 --- a/src/zabapgit_objects.prog.abap +++ b/src/zabapgit_objects.prog.abap @@ -1534,7 +1534,6 @@ CLASS lcl_objects_program IMPLEMENTATION. DATA: lv_date TYPE dats, lv_time TYPE tims, - lv_ts TYPE timestamp, lt_screens TYPE STANDARD TABLE OF d020s, lt_eudb TYPE STANDARD TABLE OF eudb. @@ -1550,7 +1549,9 @@ CLASS lcl_objects_program IMPLEMENTATION. iv_timestamp = iv_timestamp iv_date = lv_date iv_time = lv_time ). - CHECK rv_changed = abap_false. + IF rv_changed = abap_true. + RETURN. + ENDIF. SELECT SINGLE udat utime FROM repotext " Program text pool INTO (lv_date, lv_time) @@ -1562,7 +1563,9 @@ CLASS lcl_objects_program IMPLEMENTATION. iv_timestamp = iv_timestamp iv_date = lv_date iv_time = lv_time ). - CHECK rv_changed = abap_false. + IF rv_changed = abap_true. + RETURN. + ENDIF. ENDIF. IF iv_skip_gui = abap_true. @@ -1578,7 +1581,9 @@ CLASS lcl_objects_program IMPLEMENTATION. iv_timestamp = iv_timestamp iv_date = -dgen iv_time = -tgen ). - CHECK rv_changed = abap_false. + IF rv_changed = abap_true. + RETURN. + ENDIF. ENDLOOP. SELECT vdatum vzeit FROM eudb " GUI @@ -1592,7 +1597,9 @@ CLASS lcl_objects_program IMPLEMENTATION. iv_timestamp = iv_timestamp iv_date = -vdatum iv_time = -vzeit ). - CHECK rv_changed = abap_false. + IF rv_changed = abap_true. + RETURN. + ENDIF. ENDLOOP. ENDMETHOD. "check_prog_changed_since diff --git a/src/zabapgit_repo_impl.prog.abap b/src/zabapgit_repo_impl.prog.abap index 85e26ac1e..ef402633c 100644 --- a/src/zabapgit_repo_impl.prog.abap +++ b/src/zabapgit_repo_impl.prog.abap @@ -558,7 +558,7 @@ CLASS lcl_repo IMPLEMENTATION. io_dot = get_dot_abapgit( ) ). lt_filter = it_filter. - lv_filter_exist = boolc( lines( lt_filter ) > 0 ) . + lv_filter_exist = boolc( lines( lt_filter ) > 0 ). LOOP AT lt_tadir ASSIGNING . IF lv_filter_exist = abap_true. diff --git a/src/zabapgit_syntax_highlighter.prog.abap b/src/zabapgit_syntax_highlighter.prog.abap index bc176e31a..27c883e37 100644 --- a/src/zabapgit_syntax_highlighter.prog.abap +++ b/src/zabapgit_syntax_highlighter.prog.abap @@ -345,8 +345,6 @@ CLASS lcl_syntax_abap IMPLEMENTATION. METHOD constructor. - DATA ls_rule LIKE LINE OF mt_rules. - super->constructor( ). " Initialize instances of regular expression @@ -575,8 +573,6 @@ CLASS lcl_syntax_xml IMPLEMENTATION. METHOD constructor. - DATA ls_rule LIKE LINE OF mt_rules. - super->constructor( ). " Initialize instances of regular expressions diff --git a/src/zabapgit_util.prog.abap b/src/zabapgit_util.prog.abap index 45db5048c..db0ee274a 100644 --- a/src/zabapgit_util.prog.abap +++ b/src/zabapgit_util.prog.abap @@ -110,8 +110,8 @@ CLASS lcl_convert DEFINITION FINAL. RETURNING VALUE(rv_xstring) TYPE xstring. CLASS-METHODS split_string - IMPORTING iv_string TYPE string - RETURNING value(rt_lines) TYPE string_table. + IMPORTING iv_string TYPE string + RETURNING VALUE(rt_lines) TYPE string_table. ENDCLASS. "lcl_convert DEFINITION @@ -423,8 +423,8 @@ CLASS lcl_path IMPLEMENTATION. METHOD change_dir. - DATA lv_last TYPE i. - DATA lv_temp TYPE string. + DATA: lv_last TYPE i, + lv_temp TYPE string. lv_last = strlen( iv_cur_dir ) - 1. diff --git a/src/zabapgit_xml.prog.abap b/src/zabapgit_xml.prog.abap index 109f62f55..ffe3c348d 100644 --- a/src/zabapgit_xml.prog.abap +++ b/src/zabapgit_xml.prog.abap @@ -293,8 +293,7 @@ CLASS lcl_xml_output IMPLEMENTATION. name = 'abap' prefix = 'asx' ). - li_attr = mi_xml_doc->create_attribute_ns( - name = 'version' ). + li_attr = mi_xml_doc->create_attribute_ns( 'version' ). li_attr->if_ixml_node~set_value( '1.0' ). ri_element->set_attribute_node_ns( li_attr ).