From 3ec07c64935bbb1e1fc83d5f61d4521635034826 Mon Sep 17 00:00:00 2001 From: mariusraht2 <45243391+mariusraht2@users.noreply.github.com> Date: Tue, 27 Oct 2020 16:14:16 +0100 Subject: [PATCH] ZCL_ABAPGIT_SERVICES_GIT: Change signature of method checkout_commit_build_popup (#4072) * Implementation * Remove unrelated pretty printer changes Co-authored-by: Lars Hvam --- src/ui/zcl_abapgit_services_git.clas.abap | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/ui/zcl_abapgit_services_git.clas.abap b/src/ui/zcl_abapgit_services_git.clas.abap index 883764491..061299af7 100644 --- a/src/ui/zcl_abapgit_services_git.clas.abap +++ b/src/ui/zcl_abapgit_services_git.clas.abap @@ -80,11 +80,10 @@ CLASS zcl_abapgit_services_git DEFINITION zcx_abapgit_exception . CLASS-METHODS checkout_commit_build_popup IMPORTING - !it_commits TYPE zif_abapgit_definitions=>ty_commit_tt - EXPORTING - !es_selected_commit TYPE zif_abapgit_definitions=>ty_commit - CHANGING - !ct_value_tab TYPE ty_commit_value_tab_tt + !it_commits TYPE zif_abapgit_definitions=>ty_commit_tt + !it_value_tab TYPE ty_commit_value_tab_tt + RETURNING + VALUE(rs_selected_commit) TYPE zif_abapgit_definitions=>ty_commit RAISING zcx_abapgit_exception . @@ -151,8 +150,6 @@ CLASS zcl_abapgit_services_git IMPLEMENTATION. FIELD-SYMBOLS: TYPE ty_commit_value_tab, TYPE zif_abapgit_definitions=>ty_alv_column. - CLEAR: es_selected_commit. - APPEND INITIAL LINE TO lt_columns ASSIGNING . -name = 'SHA1'. -text = 'Hash'. @@ -167,7 +164,7 @@ CLASS zcl_abapgit_services_git IMPLEMENTATION. li_popups = zcl_abapgit_ui_factory=>get_popups( ). li_popups->popup_to_select_from_list( EXPORTING - it_list = ct_value_tab + it_list = it_value_tab iv_title = |Checkout Commit| iv_end_column = 83 iv_striped_pattern = abap_true @@ -190,7 +187,7 @@ CLASS zcl_abapgit_services_git IMPLEMENTATION. ENDIF. READ TABLE it_commits - INTO es_selected_commit + INTO rs_selected_commit WITH KEY sha1 = -sha1. ENDMETHOD.