ZCL_ABAPGIT_SERVICES_GIT: Change signature of method checkout_commit_build_popup (#4072)

* Implementation

* Remove unrelated pretty printer changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
mariusraht2 2020-10-27 16:14:16 +01:00 committed by GitHub
parent 5aebc0c88e
commit 3ec07c6493
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -81,10 +81,9 @@ CLASS zcl_abapgit_services_git DEFINITION
CLASS-METHODS checkout_commit_build_popup CLASS-METHODS checkout_commit_build_popup
IMPORTING IMPORTING
!it_commits TYPE zif_abapgit_definitions=>ty_commit_tt !it_commits TYPE zif_abapgit_definitions=>ty_commit_tt
EXPORTING !it_value_tab TYPE ty_commit_value_tab_tt
!es_selected_commit TYPE zif_abapgit_definitions=>ty_commit RETURNING
CHANGING VALUE(rs_selected_commit) TYPE zif_abapgit_definitions=>ty_commit
!ct_value_tab TYPE ty_commit_value_tab_tt
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
@ -151,8 +150,6 @@ CLASS zcl_abapgit_services_git IMPLEMENTATION.
FIELD-SYMBOLS: <ls_value_tab> TYPE ty_commit_value_tab, FIELD-SYMBOLS: <ls_value_tab> TYPE ty_commit_value_tab,
<ls_column> TYPE zif_abapgit_definitions=>ty_alv_column. <ls_column> TYPE zif_abapgit_definitions=>ty_alv_column.
CLEAR: es_selected_commit.
APPEND INITIAL LINE TO lt_columns ASSIGNING <ls_column>. APPEND INITIAL LINE TO lt_columns ASSIGNING <ls_column>.
<ls_column>-name = 'SHA1'. <ls_column>-name = 'SHA1'.
<ls_column>-text = 'Hash'. <ls_column>-text = 'Hash'.
@ -167,7 +164,7 @@ CLASS zcl_abapgit_services_git IMPLEMENTATION.
li_popups = zcl_abapgit_ui_factory=>get_popups( ). li_popups = zcl_abapgit_ui_factory=>get_popups( ).
li_popups->popup_to_select_from_list( li_popups->popup_to_select_from_list(
EXPORTING EXPORTING
it_list = ct_value_tab it_list = it_value_tab
iv_title = |Checkout Commit| iv_title = |Checkout Commit|
iv_end_column = 83 iv_end_column = 83
iv_striped_pattern = abap_true iv_striped_pattern = abap_true
@ -190,7 +187,7 @@ CLASS zcl_abapgit_services_git IMPLEMENTATION.
ENDIF. ENDIF.
READ TABLE it_commits READ TABLE it_commits
INTO es_selected_commit INTO rs_selected_commit
WITH KEY sha1 = <ls_value_tab>-sha1. WITH KEY sha1 = <ls_value_tab>-sha1.
ENDMETHOD. ENDMETHOD.