Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER #1775 (#1776)

* Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER

* catch exception if interfaces doesn't exist

Catch exception if IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist
This commit is contained in:
Christian Günter 2018-08-06 15:11:40 +02:00 committed by Lars Hvam
parent 6ef0357795
commit 400846e036
6 changed files with 48 additions and 25 deletions

View File

@ -68,7 +68,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_OO_CLASS_NEW IMPLEMENTATION. CLASS zcl_abapgit_oo_class_new IMPLEMENTATION.
METHOD create_report. METHOD create_report.
@ -303,18 +303,27 @@ CLASS ZCL_ABAPGIT_OO_CLASS_NEW IMPLEMENTATION.
METHOD update_source_index. METHOD update_source_index.
DATA li_index_helper TYPE REF TO if_oo_source_pos_index_helper. " dynamic invocation, IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist in 702.
DATA li_index_helper TYPE REF TO object.
TRY.
CREATE OBJECT li_index_helper TYPE cl_oo_source_pos_index_helper. CREATE OBJECT li_index_helper TYPE cl_oo_source_pos_index_helper.
li_index_helper->create_index_with_scanner( CALL METHOD li_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~CREATE_INDEX_WITH_SCANNER')
EXPORTING
class_name = iv_clsname class_name = iv_clsname
version = if_oo_clif_source=>co_version_active version = if_oo_clif_source=>co_version_active
scanner = io_scanner ). scanner = io_scanner.
li_index_helper->delete_index( CALL METHOD li_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~DELETE_INDEX')
EXPORTING
class_name = iv_clsname class_name = iv_clsname
version = if_oo_clif_source=>co_version_inactive ). version = if_oo_clif_source=>co_version_inactive.
CATCH cx_root.
" it's probably okay to no update the index
RETURN.
ENDTRY.
ENDMETHOD. ENDMETHOD.

View File

@ -105,9 +105,11 @@ CLASS ZCL_ABAPGIT_GUI_ROUTER IMPLEMENTATION.
METHOD get_page_playground. METHOD get_page_playground.
DATA: lv_class_name TYPE string, DATA: lv_class_name TYPE string,
lv_cancel TYPE abap_bool. lv_cancel TYPE abap_bool,
li_popups TYPE REF TO zif_abapgit_popups.
zcl_abapgit_ui_factory=>get_popups( )->run_page_class_popup( li_popups = zcl_abapgit_ui_factory=>get_popups( ).
li_popups->run_page_class_popup(
IMPORTING IMPORTING
ev_name = lv_class_name ev_name = lv_class_name
ev_cancel = lv_cancel ). ev_cancel = lv_cancel ).

View File

@ -127,12 +127,14 @@ CLASS ZCL_ABAPGIT_SERVICES_GIT IMPLEMENTATION.
DATA: lv_name TYPE string, DATA: lv_name TYPE string,
lv_cancel TYPE abap_bool, lv_cancel TYPE abap_bool,
lo_repo TYPE REF TO zcl_abapgit_repo_online. lo_repo TYPE REF TO zcl_abapgit_repo_online,
li_popups TYPE REF TO zif_abapgit_popups.
lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ). lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
zcl_abapgit_ui_factory=>get_popups( )->create_branch_popup( li_popups = zcl_abapgit_ui_factory=>get_popups( ).
li_popups->create_branch_popup(
IMPORTING IMPORTING
ev_name = lv_name ev_name = lv_name
ev_cancel = lv_cancel ). ev_cancel = lv_cancel ).
@ -221,7 +223,8 @@ CLASS ZCL_ABAPGIT_SERVICES_GIT IMPLEMENTATION.
lt_unnecessary_local_objs TYPE zif_abapgit_definitions=>ty_tadir_tt, lt_unnecessary_local_objs TYPE zif_abapgit_definitions=>ty_tadir_tt,
lt_selected LIKE lt_unnecessary_local_objs, lt_selected LIKE lt_unnecessary_local_objs,
lt_columns TYPE stringtab, lt_columns TYPE stringtab,
ls_checks TYPE zif_abapgit_definitions=>ty_delete_checks. ls_checks TYPE zif_abapgit_definitions=>ty_delete_checks,
li_popups TYPE REF TO zif_abapgit_popups.
lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ). lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
@ -251,7 +254,8 @@ CLASS ZCL_ABAPGIT_SERVICES_GIT IMPLEMENTATION.
INSERT `OBJECT` INTO TABLE lt_columns. INSERT `OBJECT` INTO TABLE lt_columns.
INSERT `OBJ_NAME` INTO TABLE lt_columns. INSERT `OBJ_NAME` INTO TABLE lt_columns.
zcl_abapgit_ui_factory=>get_popups( )->popup_to_select_from_list( li_popups = zcl_abapgit_ui_factory=>get_popups( ).
li_popups->popup_to_select_from_list(
EXPORTING EXPORTING
it_list = lt_unnecessary_local_objs it_list = lt_unnecessary_local_objs
i_header_text = |Which unnecessary objects should be deleted?| i_header_text = |Which unnecessary objects should be deleted?|

View File

@ -198,7 +198,8 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION.
DATA: lt_columns TYPE stringtab, DATA: lt_columns TYPE stringtab,
lt_selected LIKE ct_overwrite, lt_selected LIKE ct_overwrite,
lv_column LIKE LINE OF lt_columns. lv_column LIKE LINE OF lt_columns,
li_popups TYPE REF TO zif_abapgit_popups.
FIELD-SYMBOLS: <ls_overwrite> LIKE LINE OF ct_overwrite. FIELD-SYMBOLS: <ls_overwrite> LIKE LINE OF ct_overwrite.
@ -212,7 +213,8 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION.
lv_column = 'OBJ_NAME'. lv_column = 'OBJ_NAME'.
INSERT lv_column INTO TABLE lt_columns. INSERT lv_column INTO TABLE lt_columns.
zcl_abapgit_ui_factory=>get_popups( )->popup_to_select_from_list( li_popups = zcl_abapgit_ui_factory=>get_popups( ).
li_popups->popup_to_select_from_list(
EXPORTING EXPORTING
it_list = ct_overwrite it_list = ct_overwrite
i_header_text = |The following Objects have been modified locally.| i_header_text = |The following Objects have been modified locally.|

View File

@ -67,10 +67,12 @@ FORM branch_popup TABLES tt_fields TYPE zif_abapgit_definitions=>ty_sval_tt
RAISING zcx_abapgit_exception ##called ##needed. RAISING zcx_abapgit_exception ##called ##needed.
* called dynamically from function module POPUP_GET_VALUES_USER_BUTTONS * called dynamically from function module POPUP_GET_VALUES_USER_BUTTONS
DATA: lx_error TYPE REF TO zcx_abapgit_exception. DATA: lx_error TYPE REF TO zcx_abapgit_exception,
li_popups TYPE REF TO zif_abapgit_popups.
TRY. TRY.
zcl_abapgit_ui_factory=>get_popups( )->branch_popup_callback( li_popups = zcl_abapgit_ui_factory=>get_popups( ).
li_popups->branch_popup_callback(
EXPORTING EXPORTING
iv_code = pv_code iv_code = pv_code
CHANGING CHANGING
@ -91,10 +93,12 @@ FORM package_popup TABLES tt_fields TYPE zif_abapgit_definitions=>ty_sval_tt
RAISING zcx_abapgit_exception ##called ##needed. RAISING zcx_abapgit_exception ##called ##needed.
* called dynamically from function module POPUP_GET_VALUES_USER_BUTTONS * called dynamically from function module POPUP_GET_VALUES_USER_BUTTONS
DATA: lx_error TYPE REF TO zcx_abapgit_exception. DATA: lx_error TYPE REF TO zcx_abapgit_exception,
li_popups TYPE REF TO zif_abapgit_popups.
TRY. TRY.
zcl_abapgit_ui_factory=>get_popups( )->package_popup_callback( li_popups = zcl_abapgit_ui_factory=>get_popups( ).
li_popups->package_popup_callback(
EXPORTING EXPORTING
iv_code = pv_code iv_code = pv_code
CHANGING CHANGING

View File

@ -199,13 +199,15 @@ CLASS zcl_abapgit_zip IMPLEMENTATION.
METHOD export_package. METHOD export_package.
DATA: lo_repo TYPE REF TO zcl_abapgit_repo_offline, DATA: lo_repo TYPE REF TO zcl_abapgit_repo_offline,
ls_data TYPE zif_abapgit_persistence=>ty_repo. ls_data TYPE zif_abapgit_persistence=>ty_repo,
li_popups TYPE REF TO zif_abapgit_popups.
ls_data-key = 'DUMMY'. ls_data-key = 'DUMMY'.
ls_data-dot_abapgit = zcl_abapgit_dot_abapgit=>build_default( )->get_data( ). ls_data-dot_abapgit = zcl_abapgit_dot_abapgit=>build_default( )->get_data( ).
zcl_abapgit_ui_factory=>get_popups( )->popup_package_export( li_popups = zcl_abapgit_ui_factory=>get_popups( ).
li_popups->popup_package_export(
IMPORTING IMPORTING
ev_package = ls_data-package ev_package = ls_data-package
ev_folder_logic = ls_data-dot_abapgit-folder_logic ). ev_folder_logic = ls_data-dot_abapgit-folder_logic ).