LOG: add basic unit tests, change types (#4352)

closes #4259

src/utils/zcl_abapgit_log.clas.abap

@@ -5,18 +5,17 @@ CLASS zcl_abapgit_log DEFINITION
   PUBLIC SECTION.
 
     INTERFACES zif_abapgit_log .
-
   PROTECTED SECTION.
 
     TYPES:
       BEGIN OF ty_msg,
         text TYPE string,
-        type TYPE symsgty,
+        type TYPE sy-msgty,
       END OF ty_msg .
     TYPES:
       BEGIN OF ty_log, "in order of occurrence
         msg       TYPE ty_msg,
-        rc        TYPE balsort,
+        rc        TYPE sy-subrc,
         item      TYPE zif_abapgit_definitions=>ty_item,
         exception TYPE REF TO cx_root,
       END OF ty_log .
@@ -29,7 +28,7 @@ CLASS zcl_abapgit_log DEFINITION
       IMPORTING
         !it_msg          TYPE zif_abapgit_log=>ty_msgs
       RETURNING
-        VALUE(rv_status) TYPE symsgty .
+        VALUE(rv_status) TYPE sy-msgty .
   PRIVATE SECTION.
 ENDCLASS.
 

src/utils/zcl_abapgit_log.clas.testclasses.abap

@@ -0,0 +1,61 @@
+
+CLASS ltcl_test DEFINITION FOR TESTING DURATION SHORT RISK LEVEL HARMLESS FINAL.
+
+  PRIVATE SECTION.
+    DATA:
+      mi_cut TYPE REF TO zif_abapgit_log.
+
+    METHODS:
+      setup,
+      empty FOR TESTING,
+      add FOR TESTING.
+ENDCLASS.
+
+
+CLASS ltcl_test IMPLEMENTATION.
+
+  METHOD setup.
+    CREATE OBJECT mi_cut TYPE zcl_abapgit_log.
+  ENDMETHOD.
+
+  METHOD empty.
+
+    cl_abap_unit_assert=>assert_equals(
+      act = mi_cut->count( )
+      exp = 0 ).
+
+    cl_abap_unit_assert=>assert_equals(
+      act = mi_cut->get_title( )
+      exp = 'Log' ).
+
+  ENDMETHOD.
+
+  METHOD add.
+
+    DATA lv_message TYPE string.
+    DATA lt_messages TYPE zif_abapgit_log=>ty_log_outs.
+    DATA ls_message LIKE LINE OF lt_messages.
+
+    lv_message = 'hello'.
+
+    mi_cut->add( lv_message ).
+
+    cl_abap_unit_assert=>assert_equals(
+      act = mi_cut->count( )
+      exp = 1 ).
+
+    cl_abap_unit_assert=>assert_equals(
+      act = mi_cut->get_status( )
+      exp = 'E' ).
+
+    lt_messages = mi_cut->get_messages( ).
+    READ TABLE lt_messages INDEX 1 INTO ls_message.
+    cl_abap_unit_assert=>assert_subrc( ).
+
+    cl_abap_unit_assert=>assert_equals(
+      act = ls_message-text
+      exp = lv_message ).
+
+  ENDMETHOD.
+
+ENDCLASS.

src/utils/zcl_abapgit_log.clas.xml

@@ -10,6 +10,7 @@
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>
     <UNICODE>X</UNICODE>
+    <WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>
    </VSEOCLASS>
   </asx:values>
  </asx:abap>

src/utils/zif_abapgit_log.intf.abap

@@ -4,10 +4,10 @@ INTERFACE zif_abapgit_log
 
   TYPES:
     BEGIN OF ty_log_out,
-      type      TYPE symsgty,
+      type      TYPE sy-msgty,
       text      TYPE string,
-      obj_type  TYPE trobjtype,
-      obj_name  TYPE sobj_name,
+      obj_type  TYPE tadir-object,
+      obj_name  TYPE tadir-obj_name,
       exception TYPE REF TO cx_root,
     END OF ty_log_out .
   TYPES:
@@ -16,7 +16,7 @@ INTERFACE zif_abapgit_log
   TYPES:
     BEGIN OF ty_msg,
       text TYPE string,
-      type TYPE symsgty,
+      type TYPE sy-msgty,
     END OF ty_msg .
   TYPES:
     ty_msgs TYPE STANDARD TABLE OF ty_msg
@@ -24,7 +24,7 @@ INTERFACE zif_abapgit_log
   TYPES:
     BEGIN OF ty_item_status_out,
       item     TYPE zif_abapgit_definitions=>ty_item,
-      status   TYPE symsgty,
+      status   TYPE sy-msgty,
       messages TYPE ty_msgs,
     END OF ty_item_status_out .
   TYPES:
@@ -34,8 +34,8 @@ INTERFACE zif_abapgit_log
   METHODS add
     IMPORTING
       !iv_msg  TYPE csequence
-      !iv_type TYPE symsgty DEFAULT 'E'
-      !iv_rc   TYPE balsort OPTIONAL
+      !iv_type TYPE sy-msgty DEFAULT 'E'
+      !iv_rc   TYPE sy-subrc OPTIONAL
       !is_item TYPE zif_abapgit_definitions=>ty_item OPTIONAL
       !ix_exc  TYPE REF TO cx_root OPTIONAL .
   METHODS add_error
@@ -64,7 +64,7 @@ INTERFACE zif_abapgit_log
       VALUE(rv_count) TYPE i .
   METHODS has_rc
     IMPORTING
-      !iv_rc        TYPE balsort
+      !iv_rc        TYPE sy-subrc
     RETURNING
       VALUE(rv_yes) TYPE abap_bool .
   METHODS get_messages
@@ -75,7 +75,7 @@ INTERFACE zif_abapgit_log
       VALUE(rt_item_status) TYPE ty_item_status_outs .
   METHODS get_status
     RETURNING
-      VALUE(rv_status) TYPE symsgty .
+      VALUE(rv_status) TYPE sy-msgty .
   METHODS get_title
     RETURNING
       VALUE(rv_title) TYPE string .