SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-02 04:36:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

overview page, dont display "https://" (#4539)

Browse Source 
* overview page, dont display "https://"

dont display "https://" or "http://" in overview page

delete unused method HAS_FAVORITES

* add title
This commit is contained in:
Lars Hvam 2021-02-20 10:28:02 +01:00 committed by GitHub
parent 338cf6a358
commit 40cd29297d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/ui/zcl_abapgit_gui_page_repo_over.clas.abap
View File

@ -22,9 +22,6 @@ CLASS zcl_abapgit_gui_page_repo_over DEFINITION
METHODS set_filter METHODS set_filter
IMPORTING IMPORTING
!it_postdata TYPE zif_abapgit_html_viewer=>ty_post_data . !it_postdata TYPE zif_abapgit_html_viewer=>ty_post_data .
METHODS has_favorites
RETURNING
VALUE(rv_has_favorites) TYPE abap_bool .
PROTECTED SECTION. PROTECTED SECTION.
@ -120,7 +117,7 @@ ENDCLASS.
CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION. CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_OVER IMPLEMENTATION.
METHOD apply_filter. METHOD apply_filter.
@ -183,14 +180,6 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD has_favorites.
READ TABLE mt_overview WITH KEY favorite = abap_true TRANSPORTING NO FIELDS.
IF sy-subrc = 0.
rv_has_favorites = abap_true.
ENDIF.
ENDMETHOD.
METHOD map_repo_list_to_overview. METHOD map_repo_list_to_overview.
DATA: ls_overview LIKE LINE OF rt_overview, DATA: ls_overview LIKE LINE OF rt_overview,
@ -304,15 +293,16 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
CONSTANTS: lc_separator TYPE string VALUE `<span class="separator">|</span>`. CONSTANTS: lc_separator TYPE string VALUE `<span class="separator">|</span>`.
DATA: DATA:
lv_type_icon TYPE string, lv_type_icon TYPE string,
lv_favorite_icon TYPE string, lv_favorite_icon TYPE string,
lv_favorite_class TYPE string, lv_favorite_class TYPE string,
lv_stage_link TYPE string, lv_stage_link TYPE string,
lv_patch_link TYPE string, lv_patch_link TYPE string,
lv_zip_import_link TYPE string, lv_zip_import_link TYPE string,
lv_zip_export_link TYPE string, lv_zip_export_link TYPE string,
lv_check_link TYPE string, lv_check_link TYPE string,
lv_settings_link TYPE string. lv_text TYPE string,
lv_settings_link TYPE string.
FIELD-SYMBOLS: <ls_overview> LIKE LINE OF it_overview. FIELD-SYMBOLS: <ls_overview> LIKE LINE OF it_overview.
@ -347,9 +337,13 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
iv_act = |{ c_action-select }?key={ <ls_overview>-key }| ) }</td>| ). iv_act = |{ c_action-select }?key={ <ls_overview>-key }| ) }</td>| ).
IF <ls_overview>-type = abap_false. IF <ls_overview>-type = abap_false.
ii_html->add( |<td>{ ii_html->a( iv_txt = <ls_overview>-url lv_text = <ls_overview>-url.
iv_act = |{ zif_abapgit_definitions=>c_action-url }?url=| REPLACE FIRST OCCURRENCE OF 'https://' IN lv_text WITH ''.
&& |{ <ls_overview>-url }| ) }</td>| ). REPLACE FIRST OCCURRENCE OF 'http://' IN lv_text WITH ''.
ii_html->add( |<td>{ ii_html->a(
iv_txt = lv_text
iv_title = <ls_overview>-url
iv_act = |{ zif_abapgit_definitions=>c_action-url }?url={ <ls_overview>-url }| ) }</td>| ).
ELSE. ELSE.
ii_html->add( |<td></td>| ). ii_html->add( |<td></td>| ).
ENDIF. ENDIF.