From 4301d3e8c8e359f734007b4a118b493d3b464663 Mon Sep 17 00:00:00 2001
From: Lars Hvam <larshp@hotmail.com>
Date: Fri, 19 Nov 2021 16:19:27 +0100
Subject: [PATCH] no chained assignment (#5140)

* no chained assignment

* bugfix
---
 abaplint.json                                       | 1 +
 src/objects/core/zcl_abapgit_folder_logic.clas.abap | 3 ++-
 src/objects/zcl_abapgit_object_devc.clas.abap       | 5 ++++-
 src/objects/zcl_abapgit_object_tabl.clas.abap       | 6 +++---
 src/utils/zcl_abapgit_diff.clas.abap                | 8 +++++---
 src/zcl_abapgit_sap_package.clas.abap               | 3 ++-
 6 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/abaplint.json b/abaplint.json
index 01f6ed641..ab7440158 100644
--- a/abaplint.json
+++ b/abaplint.json
@@ -69,6 +69,7 @@
     "identical_descriptions": false,
     "modify_only_own_db_tables": false,
     "no_yoda_conditions": false,
+    "no_chained_assignment": true,
     "select_add_order_by": false,
     "dangerous_statement": false,
     "db_operation_in_loop": false,
diff --git a/src/objects/core/zcl_abapgit_folder_logic.clas.abap b/src/objects/core/zcl_abapgit_folder_logic.clas.abap
index b4c9f560b..8b4f3010f 100644
--- a/src/objects/core/zcl_abapgit_folder_logic.clas.abap
+++ b/src/objects/core/zcl_abapgit_folder_logic.clas.abap
@@ -167,7 +167,8 @@ CLASS zcl_abapgit_folder_logic IMPLEMENTATION.
       IF iv_top(1) = '$'.
         zcl_abapgit_factory=>get_sap_package( iv_top )->create_local( ).
       ELSE.
-        ls_package-devclass = ls_package-ctext = iv_top.
+        ls_package-devclass = iv_top.
+        ls_package-ctext = iv_top.
         ls_package-as4user = cl_abap_syst=>get_user_name( ).
         zcl_abapgit_factory=>get_sap_package( iv_top )->create( ls_package ).
       ENDIF.
diff --git a/src/objects/zcl_abapgit_object_devc.clas.abap b/src/objects/zcl_abapgit_object_devc.clas.abap
index c555687d9..940bdb6c9 100644
--- a/src/objects/zcl_abapgit_object_devc.clas.abap
+++ b/src/objects/zcl_abapgit_object_devc.clas.abap
@@ -620,7 +620,10 @@ CLASS zcl_abapgit_object_devc IMPLEMENTATION.
     update_pinf_usages( ii_package    = li_package
                         it_usage_data = lt_usage_data ).
 
-    ls_save_sign-pack = ls_save_sign-permis = ls_save_sign-elems = ls_save_sign-interf = abap_true.
+    ls_save_sign-pack = abap_true.
+    ls_save_sign-permis = abap_true.
+    ls_save_sign-elems = abap_true.
+    ls_save_sign-interf = abap_true.
     li_package->save_generic(
       EXPORTING
         i_save_sign           = ls_save_sign
diff --git a/src/objects/zcl_abapgit_object_tabl.clas.abap b/src/objects/zcl_abapgit_object_tabl.clas.abap
index 382a59b0f..455a95924 100644
--- a/src/objects/zcl_abapgit_object_tabl.clas.abap
+++ b/src/objects/zcl_abapgit_object_tabl.clas.abap
@@ -115,7 +115,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION.
+CLASS zcl_abapgit_object_tabl IMPLEMENTATION.
 
 
   METHOD clear_dd03p_fields.
@@ -269,8 +269,8 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION.
     lv_package = iv_package.
 
     LOOP AT lt_segment_definitions ASSIGNING <ls_segment_definition>.
-      <ls_segment_definition>-segmentheader-presp =
-        <ls_segment_definition>-segmentheader-pwork = cl_abap_syst=>get_user_name( ).
+      <ls_segment_definition>-segmentheader-presp = cl_abap_syst=>get_user_name( ).
+      <ls_segment_definition>-segmentheader-pwork = cl_abap_syst=>get_user_name( ).
 
       CALL FUNCTION 'SEGMENT_READ'
         EXPORTING
diff --git a/src/utils/zcl_abapgit_diff.clas.abap b/src/utils/zcl_abapgit_diff.clas.abap
index 9e49fe514..d31e4519e 100644
--- a/src/utils/zcl_abapgit_diff.clas.abap
+++ b/src/utils/zcl_abapgit_diff.clas.abap
@@ -82,7 +82,7 @@ ENDCLASS.
 
 
 
-CLASS zcl_abapgit_diff IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_DIFF IMPLEMENTATION.
 
 
   METHOD calculate_stats.
@@ -133,11 +133,13 @@ CLASS zcl_abapgit_diff IMPLEMENTATION.
       LOOP AT lt_delta ASSIGNING <ls_delta>.
         CLEAR ls_diff.
         IF <ls_delta>-line1 > 0.
-          ls_diff-old_num = lv_i = <ls_delta>-line1.
+          lv_i = <ls_delta>-line1.
+          ls_diff-old_num = lv_i.
           ls_diff-old     = <ls_delta>-text1.
         ENDIF.
         IF <ls_delta>-line2 > 0.
-          ls_diff-new_num = lv_i = <ls_delta>-line2.
+          lv_i = <ls_delta>-line2.
+          ls_diff-new_num = lv_i.
           ls_diff-new     = <ls_delta>-text2.
         ENDIF.
         IF <ls_delta>-flag1 = 'D'.
diff --git a/src/zcl_abapgit_sap_package.clas.abap b/src/zcl_abapgit_sap_package.clas.abap
index ae5e8de77..692cd36e6 100644
--- a/src/zcl_abapgit_sap_package.clas.abap
+++ b/src/zcl_abapgit_sap_package.clas.abap
@@ -258,7 +258,8 @@ CLASS zcl_abapgit_sap_package IMPLEMENTATION.
       lv_obj_name TYPE tadir-obj_name,
       lv_role     TYPE trnrole.
 
-    lv_pkg_name = lv_obj_name = mv_package.
+    lv_pkg_name = mv_package.
+    lv_obj_name = mv_package.
 
     CALL FUNCTION 'TR_GET_REQUEST_TYPE'
       EXPORTING