no chained assignment (#5140)

* no chained assignment

* bugfix
This commit is contained in:
Lars Hvam 2021-11-19 16:19:27 +01:00 committed by GitHub
parent b6b0aef3b6
commit 4301d3e8c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 17 additions and 9 deletions

View File

@ -69,6 +69,7 @@
"identical_descriptions": false, "identical_descriptions": false,
"modify_only_own_db_tables": false, "modify_only_own_db_tables": false,
"no_yoda_conditions": false, "no_yoda_conditions": false,
"no_chained_assignment": true,
"select_add_order_by": false, "select_add_order_by": false,
"dangerous_statement": false, "dangerous_statement": false,
"db_operation_in_loop": false, "db_operation_in_loop": false,

View File

@ -167,7 +167,8 @@ CLASS zcl_abapgit_folder_logic IMPLEMENTATION.
IF iv_top(1) = '$'. IF iv_top(1) = '$'.
zcl_abapgit_factory=>get_sap_package( iv_top )->create_local( ). zcl_abapgit_factory=>get_sap_package( iv_top )->create_local( ).
ELSE. ELSE.
ls_package-devclass = ls_package-ctext = iv_top. ls_package-devclass = iv_top.
ls_package-ctext = iv_top.
ls_package-as4user = cl_abap_syst=>get_user_name( ). ls_package-as4user = cl_abap_syst=>get_user_name( ).
zcl_abapgit_factory=>get_sap_package( iv_top )->create( ls_package ). zcl_abapgit_factory=>get_sap_package( iv_top )->create( ls_package ).
ENDIF. ENDIF.

View File

@ -620,7 +620,10 @@ CLASS zcl_abapgit_object_devc IMPLEMENTATION.
update_pinf_usages( ii_package = li_package update_pinf_usages( ii_package = li_package
it_usage_data = lt_usage_data ). it_usage_data = lt_usage_data ).
ls_save_sign-pack = ls_save_sign-permis = ls_save_sign-elems = ls_save_sign-interf = abap_true. ls_save_sign-pack = abap_true.
ls_save_sign-permis = abap_true.
ls_save_sign-elems = abap_true.
ls_save_sign-interf = abap_true.
li_package->save_generic( li_package->save_generic(
EXPORTING EXPORTING
i_save_sign = ls_save_sign i_save_sign = ls_save_sign

View File

@ -115,7 +115,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION. CLASS zcl_abapgit_object_tabl IMPLEMENTATION.
METHOD clear_dd03p_fields. METHOD clear_dd03p_fields.
@ -269,7 +269,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION.
lv_package = iv_package. lv_package = iv_package.
LOOP AT lt_segment_definitions ASSIGNING <ls_segment_definition>. LOOP AT lt_segment_definitions ASSIGNING <ls_segment_definition>.
<ls_segment_definition>-segmentheader-presp = <ls_segment_definition>-segmentheader-presp = cl_abap_syst=>get_user_name( ).
<ls_segment_definition>-segmentheader-pwork = cl_abap_syst=>get_user_name( ). <ls_segment_definition>-segmentheader-pwork = cl_abap_syst=>get_user_name( ).
CALL FUNCTION 'SEGMENT_READ' CALL FUNCTION 'SEGMENT_READ'

View File

@ -82,7 +82,7 @@ ENDCLASS.
CLASS zcl_abapgit_diff IMPLEMENTATION. CLASS ZCL_ABAPGIT_DIFF IMPLEMENTATION.
METHOD calculate_stats. METHOD calculate_stats.
@ -133,11 +133,13 @@ CLASS zcl_abapgit_diff IMPLEMENTATION.
LOOP AT lt_delta ASSIGNING <ls_delta>. LOOP AT lt_delta ASSIGNING <ls_delta>.
CLEAR ls_diff. CLEAR ls_diff.
IF <ls_delta>-line1 > 0. IF <ls_delta>-line1 > 0.
ls_diff-old_num = lv_i = <ls_delta>-line1. lv_i = <ls_delta>-line1.
ls_diff-old_num = lv_i.
ls_diff-old = <ls_delta>-text1. ls_diff-old = <ls_delta>-text1.
ENDIF. ENDIF.
IF <ls_delta>-line2 > 0. IF <ls_delta>-line2 > 0.
ls_diff-new_num = lv_i = <ls_delta>-line2. lv_i = <ls_delta>-line2.
ls_diff-new_num = lv_i.
ls_diff-new = <ls_delta>-text2. ls_diff-new = <ls_delta>-text2.
ENDIF. ENDIF.
IF <ls_delta>-flag1 = 'D'. IF <ls_delta>-flag1 = 'D'.

View File

@ -258,7 +258,8 @@ CLASS zcl_abapgit_sap_package IMPLEMENTATION.
lv_obj_name TYPE tadir-obj_name, lv_obj_name TYPE tadir-obj_name,
lv_role TYPE trnrole. lv_role TYPE trnrole.
lv_pkg_name = lv_obj_name = mv_package. lv_pkg_name = mv_package.
lv_obj_name = mv_package.
CALL FUNCTION 'TR_GET_REQUEST_TYPE' CALL FUNCTION 'TR_GET_REQUEST_TYPE'
EXPORTING EXPORTING