From 4421cdc209897753d3b3286338e6c5a05686118d Mon Sep 17 00:00:00 2001 From: mariusraht2 <45243391+mariusraht2@users.noreply.github.com> Date: Sun, 24 May 2020 11:23:50 +0200 Subject: [PATCH] Issue 3399: Use c or char instead of sychar (#3410) * Create pull.yml * Update zcl_abapgit_git_transport.clas.abap * Update zcl_abapgit_git_transport.clas.abap * Update pull.yml * Update pull.yml * Update zcl_abapgit_git_transport.clas.abap * Delete pull.yml * Update zcl_abapgit_git_transport.clas.abap * Use char or c instead of sychar * Replaced char with type of c Co-authored-by: mariusraht1 --- src/objects/zcl_abapgit_oo_class.clas.abap | 13 ++++++++----- src/zcl_abapgit_code_inspector.clas.abap | 4 ++-- src/zcl_abapgit_serialize.clas.abap | 3 ++- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/objects/zcl_abapgit_oo_class.clas.abap b/src/objects/zcl_abapgit_oo_class.clas.abap index bee406a8e..08307c287 100644 --- a/src/objects/zcl_abapgit_oo_class.clas.abap +++ b/src/objects/zcl_abapgit_oo_class.clas.abap @@ -26,6 +26,9 @@ CLASS zcl_abapgit_oo_class DEFINITION METHODS zif_abapgit_oo_object_fnc~deserialize_source REDEFINITION . PROTECTED SECTION. + TYPES: ty_char1 TYPE c LENGTH 1, + ty_char2 TYPE c LENGTH 2. + PRIVATE SECTION. CLASS-METHODS update_source_index @@ -77,8 +80,8 @@ CLASS zcl_abapgit_oo_class DEFINITION IMPORTING !iv_program TYPE programm !it_source TYPE string_table - !iv_extension TYPE sychar02 - !iv_program_type TYPE sychar01 + !iv_extension TYPE ty_char2 + !iv_program_type TYPE ty_char1 !iv_version TYPE r3state . CLASS-METHODS update_cs_number_of_methods IMPORTING @@ -88,7 +91,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_OO_CLASS IMPLEMENTATION. +CLASS zcl_abapgit_oo_class IMPLEMENTATION. METHOD create_report. @@ -236,8 +239,8 @@ CLASS ZCL_ABAPGIT_OO_CLASS IMPLEMENTATION. METHOD update_full_class_include. - CONSTANTS: lc_class_source_extension TYPE sychar02 VALUE 'CS', - lc_include_program_type TYPE sychar01 VALUE 'I', + CONSTANTS: lc_class_source_extension TYPE c LENGTH 2 VALUE 'CS', + lc_include_program_type TYPE c LENGTH 1 VALUE 'I', lc_active_version TYPE r3state VALUE 'A'. diff --git a/src/zcl_abapgit_code_inspector.clas.abap b/src/zcl_abapgit_code_inspector.clas.abap index f19d44163..4d9fee0cd 100644 --- a/src/zcl_abapgit_code_inspector.clas.abap +++ b/src/zcl_abapgit_code_inspector.clas.abap @@ -41,7 +41,7 @@ CLASS zcl_abapgit_code_inspector DEFINITION DATA mv_success TYPE abap_bool . - TYPES: t_run_mode TYPE sychar01. + TYPES: t_run_mode TYPE c LENGTH 1. CONSTANTS: BEGIN OF co_run_mode, run_with_popup TYPE t_run_mode VALUE 'P', @@ -53,7 +53,7 @@ CLASS zcl_abapgit_code_inspector DEFINITION END OF co_run_mode . DATA mo_inspection TYPE REF TO cl_ci_inspection . DATA mv_name TYPE sci_objs . - DATA mv_run_mode TYPE sychar01 . + DATA mv_run_mode TYPE c LENGTH 1 . METHODS create_objectset diff --git a/src/zcl_abapgit_serialize.clas.abap b/src/zcl_abapgit_serialize.clas.abap index 61bd13ad3..22f7f277f 100644 --- a/src/zcl_abapgit_serialize.clas.abap +++ b/src/zcl_abapgit_serialize.clas.abap @@ -22,6 +22,7 @@ CLASS zcl_abapgit_serialize DEFINITION zcx_abapgit_exception . PROTECTED SECTION. + TYPES: ty_char32 TYPE c LENGTH 32. CLASS-DATA gv_max_threads TYPE i . DATA mt_files TYPE zif_abapgit_definitions=>ty_files_item_tt . @@ -38,7 +39,7 @@ CLASS zcl_abapgit_serialize DEFINITION IMPORTING !is_tadir TYPE zif_abapgit_definitions=>ty_tadir !iv_language TYPE langu - !iv_task TYPE sychar32 + !iv_task TYPE ty_char32 RAISING zcx_abapgit_exception . METHODS run_sequential