From 46f504a0e8672ec1aa854e187d9bfc6545433079 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Wed, 28 Oct 2020 01:42:40 -0400 Subject: [PATCH] UI: Adjustments to Hotkeys (#4083) - Add hotkey "f" for "new offline" - Add hotkey "c" for "syntax check" - Fix #3927 --- src/ui/zcl_abapgit_gui_page_main.clas.abap | 9 +++++++-- src/ui/zcl_abapgit_gui_page_repo_view.clas.abap | 14 ++++++++++++-- src/ui/zcl_abapgit_hotkeys.clas.abap | 4 ++-- 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/src/ui/zcl_abapgit_gui_page_main.clas.abap b/src/ui/zcl_abapgit_gui_page_main.clas.abap index 245a695ab..45e42e0b7 100644 --- a/src/ui/zcl_abapgit_gui_page_main.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_main.clas.abap @@ -35,7 +35,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_main IMPLEMENTATION. METHOD build_main_menu. @@ -160,10 +160,15 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. ls_hotkey_action-hotkey = |x|. INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. - ls_hotkey_action-description = |Add online repository|. + ls_hotkey_action-description = |New online repository|. ls_hotkey_action-action = zif_abapgit_definitions=>c_action-repo_newonline. ls_hotkey_action-hotkey = |n|. INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. + ls_hotkey_action-description = |New offline repository|. + ls_hotkey_action-action = zif_abapgit_definitions=>c_action-repo_newoffline. + ls_hotkey_action-hotkey = |f|. + INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. + ENDMETHOD. ENDCLASS. diff --git a/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap b/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap index 3f2cc779f..b257f970b 100644 --- a/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap @@ -184,7 +184,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_VIEW IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION. METHOD apply_order_by. @@ -1256,7 +1256,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_VIEW IMPLEMENTATION. ls_hotkey_action-hotkey = |b|. INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. - ls_hotkey_action-description = |Installed repo list|. + ls_hotkey_action-description = |Repository list|. ls_hotkey_action-action = zif_abapgit_definitions=>c_action-abapgit_home. ls_hotkey_action-hotkey = |o|. INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. @@ -1281,6 +1281,11 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_VIEW IMPLEMENTATION. ls_hotkey_action-hotkey = |u|. INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. + ls_hotkey_action-description = |Run syntax check|. + ls_hotkey_action-action = zif_abapgit_definitions=>c_action-repo_syntax_check. + ls_hotkey_action-hotkey = |c|. + INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. + ls_hotkey_action-description = |Run code inspector|. ls_hotkey_action-action = zif_abapgit_definitions=>c_action-repo_code_inspector. ls_hotkey_action-hotkey = |i|. @@ -1291,5 +1296,10 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_VIEW IMPLEMENTATION. ls_hotkey_action-hotkey = |l|. INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. + ls_hotkey_action-description = |abapGit settings|. + ls_hotkey_action-action = zif_abapgit_definitions=>c_action-go_settings. + ls_hotkey_action-hotkey = |x|. + INSERT ls_hotkey_action INTO TABLE rt_hotkey_actions. + ENDMETHOD. ENDCLASS. diff --git a/src/ui/zcl_abapgit_hotkeys.clas.abap b/src/ui/zcl_abapgit_hotkeys.clas.abap index 20ad2903e..5b7f193c6 100644 --- a/src/ui/zcl_abapgit_hotkeys.clas.abap +++ b/src/ui/zcl_abapgit_hotkeys.clas.abap @@ -84,7 +84,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_HOTKEYS IMPLEMENTATION. +CLASS zcl_abapgit_hotkeys IMPLEMENTATION. METHOD filter_relevant_classes. @@ -372,7 +372,7 @@ CLASS ZCL_ABAPGIT_HOTKEYS IMPLEMENTATION. lv_hint = |Close window with upper right corner 'X'|. IF lv_hotkey IS NOT INITIAL. - lv_hint = lv_hint && | or '{ -hotkey }'|. + lv_hint = lv_hint && | or press '{ -hotkey }' again|. ENDIF. ri_html = zcl_abapgit_gui_chunk_lib=>render_infopanel(