From 48222ca05027770735574f2f44aec8017d07c8b2 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Wed, 31 Jul 2019 00:49:10 -0700 Subject: [PATCH] indentation fixes (#2820) * indentation fixes * fixes --- src/objects/zcl_abapgit_object_para.clas.abap | 9 +++--- src/objects/zcl_abapgit_object_tabl.clas.abap | 2 +- .../zcl_abapgit_object_tabl_compar.clas.abap | 4 +-- src/objects/zcl_abapgit_object_wapa.clas.abap | 3 +- .../zcl_abapgit_objects_program.clas.abap | 14 +++++----- src/zcl_abapgit_message_helper.clas.abap | 28 ++++++++++--------- src/zcl_abapgit_objects.clas.abap | 6 ++-- src/zcl_abapgit_transport_objects.clas.abap | 2 +- 8 files changed, 33 insertions(+), 35 deletions(-) diff --git a/src/objects/zcl_abapgit_object_para.clas.abap b/src/objects/zcl_abapgit_object_para.clas.abap index 6a8f1750c..6d11145e6 100644 --- a/src/objects/zcl_abapgit_object_para.clas.abap +++ b/src/objects/zcl_abapgit_object_para.clas.abap @@ -51,15 +51,14 @@ CLASS ZCL_ABAPGIT_OBJECT_PARA IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). ENDIF. - SELECT COUNT(*) FROM cross WHERE ( type = 'P' OR - type = 'Q' ) - AND name = lv_paramid. + SELECT COUNT(*) FROM cross + WHERE ( type = 'P' OR type = 'Q' ) AND name = lv_paramid. IF sy-subrc = 0. zcx_abapgit_exception=>raise( 'PARA: Parameter is still used' ). ELSE. SELECT COUNT(*) FROM dd04l BYPASSING BUFFER - WHERE memoryid = lv_paramid - AND as4local = 'A'. + WHERE memoryid = lv_paramid + AND as4local = 'A'. IF sy-subrc = 0. zcx_abapgit_exception=>raise( 'PARA: Parameter is still used' ). ENDIF. diff --git a/src/objects/zcl_abapgit_object_tabl.clas.abap b/src/objects/zcl_abapgit_object_tabl.clas.abap index bb85456af..55daad81a 100644 --- a/src/objects/zcl_abapgit_object_tabl.clas.abap +++ b/src/objects/zcl_abapgit_object_tabl.clas.abap @@ -204,7 +204,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION. LOOP AT lt_segment_definitions ASSIGNING . -segmentheader-presp = - -segmentheader-pwork = cl_abap_syst=>get_user_name( ). + -segmentheader-pwork = cl_abap_syst=>get_user_name( ). CALL FUNCTION 'SEGMENT_READ' EXPORTING diff --git a/src/objects/zcl_abapgit_object_tabl_compar.clas.abap b/src/objects/zcl_abapgit_object_tabl_compar.clas.abap index 70f87ab5a..7835fa6c8 100644 --- a/src/objects/zcl_abapgit_object_tabl_compar.clas.abap +++ b/src/objects/zcl_abapgit_object_tabl_compar.clas.abap @@ -99,9 +99,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL_COMPAR IMPLEMENTATION. object_not_exist = 8 OTHERS = 9. - IF sy-subrc = 1 - OR sy-subrc = 2 - OR lines( lt_founds ) = 0. + IF sy-subrc = 1 OR sy-subrc = 2 OR lines( lt_founds ) = 0. EXIT. ELSEIF sy-subrc > 2. zcx_abapgit_exception=>raise_t100( ). diff --git a/src/objects/zcl_abapgit_object_wapa.clas.abap b/src/objects/zcl_abapgit_object_wapa.clas.abap index 56c4b4019..81b29f2e7 100644 --- a/src/objects/zcl_abapgit_object_wapa.clas.abap +++ b/src/objects/zcl_abapgit_object_wapa.clas.abap @@ -494,8 +494,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WAPA IMPLEMENTATION. iv_ext = lv_ext ) ). lt_local_content = to_page_content( get_page_content( lo_page ) ). - IF ls_local_page = - AND lt_local_content = lt_remote_content. + IF ls_local_page = AND lt_local_content = lt_remote_content. " no changes -> nothing to do CONTINUE. ENDIF. diff --git a/src/objects/zcl_abapgit_objects_program.clas.abap b/src/objects/zcl_abapgit_objects_program.clas.abap index 0acca00ee..de0d7a44f 100644 --- a/src/objects/zcl_abapgit_objects_program.clas.abap +++ b/src/objects/zcl_abapgit_objects_program.clas.abap @@ -202,9 +202,9 @@ CLASS ZCL_ABAPGIT_OBJECTS_PROGRAM IMPLEMENTATION. TYPE rsmpe_men. IF cs_adm IS NOT INITIAL - AND ( cs_adm-actcode CO lc_num_n_space - AND cs_adm-mencode CO lc_num_n_space - AND cs_adm-pfkcode CO lc_num_n_space ). "Check performed in form check_adm of include LSMPIF03 + AND ( cs_adm-actcode CO lc_num_n_space + AND cs_adm-mencode CO lc_num_n_space + AND cs_adm-pfkcode CO lc_num_n_space ). "Check performed in form check_adm of include LSMPIF03 RETURN. ENDIF. @@ -347,7 +347,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_PROGRAM IMPLEMENTATION. * if the DDIC element has a PARAMETER_ID and the flag "from_dict" is active * the import will enable the SET-/GET_PARAM flag. In this case: "force off" IF -param_id IS NOT INITIAL - AND -from_dict = abap_true. + AND -from_dict = abap_true. IF -set_param IS INITIAL. -set_param = lc_rpyty_force_off. ENDIF. @@ -498,9 +498,9 @@ CLASS ZCL_ABAPGIT_OBJECTS_PROGRAM IMPLEMENTATION. " http://help.sap.com/abapdocu_751/en/abapinsert_report_internal.htm#!ABAP_ADDITION_1@1@ " This e.g. occurs in case of transportable Code Inspector variants (ending with ===VC) INSERT REPORT is_progdir-name - FROM it_source - STATE 'I' - EXTENSION TYPE is_progdir-name+30. + FROM it_source + STATE 'I' + EXTENSION TYPE is_progdir-name+30. IF sy-subrc <> 0. zcx_abapgit_exception=>raise( 'error from INSERT REPORT .. EXTENSION TYPE' ). ENDIF. diff --git a/src/zcl_abapgit_message_helper.clas.abap b/src/zcl_abapgit_message_helper.clas.abap index b8541b640..d969c2d0a 100644 --- a/src/zcl_abapgit_message_helper.clas.abap +++ b/src/zcl_abapgit_message_helper.clas.abap @@ -32,6 +32,7 @@ CLASS zcl_abapgit_message_helper DEFINITION RETURNING VALUE(rv_longtext) TYPE string. + PROTECTED SECTION. PRIVATE SECTION. DATA: mi_t100_message TYPE REF TO if_t100_message. @@ -86,7 +87,8 @@ ENDCLASS. -CLASS zcl_abapgit_message_helper IMPLEMENTATION. +CLASS ZCL_ABAPGIT_MESSAGE_HELPER IMPLEMENTATION. + METHOD constructor. @@ -131,28 +133,28 @@ CLASS zcl_abapgit_message_helper IMPLEMENTATION. WITH sy-msgv1. set_single_msg_var( - EXPORTING - iv_arg = mi_t100_message->t100key-attr2 - IMPORTING - ev_target = sy-msgv2 ). + EXPORTING + iv_arg = mi_t100_message->t100key-attr2 + IMPORTING + ev_target = sy-msgv2 ). REPLACE '&V2&' IN TABLE rt_itf WITH sy-msgv2. set_single_msg_var( - EXPORTING - iv_arg = mi_t100_message->t100key-attr3 - IMPORTING - ev_target = sy-msgv3 ). + EXPORTING + iv_arg = mi_t100_message->t100key-attr3 + IMPORTING + ev_target = sy-msgv3 ). REPLACE '&V3&' IN TABLE rt_itf WITH sy-msgv3. set_single_msg_var( - EXPORTING - iv_arg = mi_t100_message->t100key-attr4 - IMPORTING - ev_target = sy-msgv4 ). + EXPORTING + iv_arg = mi_t100_message->t100key-attr4 + IMPORTING + ev_target = sy-msgv4 ). REPLACE '&V4&' IN TABLE rt_itf WITH sy-msgv4. diff --git a/src/zcl_abapgit_objects.clas.abap b/src/zcl_abapgit_objects.clas.abap index 9c36f96a8..cc40129fa 100644 --- a/src/zcl_abapgit_objects.clas.abap +++ b/src/zcl_abapgit_objects.clas.abap @@ -243,7 +243,7 @@ ENDCLASS. -CLASS zcl_abapgit_objects IMPLEMENTATION. +CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. METHOD adjust_namespaces. @@ -959,8 +959,8 @@ CLASS zcl_abapgit_objects IMPLEMENTATION. ENDTRY. ELSEIF iv_line_number IS NOT INITIAL - AND iv_sub_obj_type IS NOT INITIAL - AND iv_sub_obj_name IS NOT INITIAL. + AND iv_sub_obj_type IS NOT INITIAL + AND iv_sub_obj_name IS NOT INITIAL. " For the line navigation we have to supply the sub object type (i_sub_obj_type). " If we use is_item-obj_type it navigates only to the object. diff --git a/src/zcl_abapgit_transport_objects.clas.abap b/src/zcl_abapgit_transport_objects.clas.abap index 939592421..cd00316fc 100644 --- a/src/zcl_abapgit_transport_objects.clas.abap +++ b/src/zcl_abapgit_transport_objects.clas.abap @@ -67,7 +67,7 @@ CLASS ZCL_ABAPGIT_TRANSPORT_OBJECTS IMPLEMENTATION. * SUSC, see https://github.com/larshp/abapGit/issues/2772 IF ls_transport_object-delflag = abap_false AND ls_transport_object-object <> 'SUSC'. zcx_abapgit_exception=>raise( |Object { ls_transport_object-obj_name - } should be removed, but has NO deletion flag in transport| ). + } should be removed, but has NO deletion flag in transport| ). ENDIF. io_stage->rm( iv_path = ls_object_status-path