SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 03:36:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Online: method INITIALIZE + RESET_STATUS to privat

Browse Source 
Change methods INITIALIZE + RESET_STATUS to private in ZCL_ABAPGIT_REPO_ONLINE

One external call of INITIALIZE changed to use REFRESH instead

Part of refactoring for issue #1757
This commit is contained in:
larshp 2018-08-05 09:08:51 +00:00 committed by Lars Hvam
parent c72d04ea80
commit 48e5a247f2
2 changed files with 29 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/zcl_abapgit_repo_online.clas.abap
View File

@ -53,15 +53,11 @@ CLASS zcl_abapgit_repo_online DEFINITION
VALUE(rt_results) TYPE zif_abapgit_definitions=>ty_results_tt
RAISING
zcx_abapgit_exception .
METHODS reset_status .
METHODS set_objects
IMPORTING
!it_objects TYPE zif_abapgit_definitions=>ty_objects_tt
RAISING
zcx_abapgit_exception .
METHODS initialize
RAISING
zcx_abapgit_exception .
METHODS push
IMPORTING
!is_comment TYPE zif_abapgit_definitions=>ty_comment
@ -89,6 +85,10 @@ CLASS zcl_abapgit_repo_online DEFINITION
DATA mv_initialized TYPE abap_bool .
DATA mt_status TYPE zif_abapgit_definitions=>ty_results_tt .
METHODS reset_status .
METHODS initialize
RAISING
zcx_abapgit_exception .
METHODS handle_stage_ignore
IMPORTING
!io_stage TYPE REF TO zcl_abapgit_stage
@ -96,7 +96,7 @@ CLASS zcl_abapgit_repo_online DEFINITION
zcx_abapgit_exception .
METHODS actualize_head_branch
IMPORTING
io_branch_list TYPE REF TO zcl_abapgit_git_branch_list
!io_branch_list TYPE REF TO zcl_abapgit_git_branch_list
RAISING
zcx_abapgit_exception .
ENDCLASS.

48
src/zcl_abapgit_repo_srv.clas.abap
View File

@ -49,7 +49,7 @@ ENDCLASS.
CLASS zcl_abapgit_repo_srv IMPLEMENTATION.
CLASS ZCL_ABAPGIT_REPO_SRV IMPLEMENTATION.
METHOD add.
@ -127,6 +127,28 @@ CLASS zcl_abapgit_repo_srv IMPLEMENTATION.
ENDMETHOD. "refresh
METHOD validate_sub_super_packages.
DATA:
ls_repo LIKE LINE OF it_repos,
lo_package TYPE REF TO zif_abapgit_sap_package,
lt_packages TYPE zif_abapgit_sap_package=>ty_devclass_tt,
lo_repo TYPE REF TO zcl_abapgit_repo.
LOOP AT it_repos INTO ls_repo.
lo_repo = get( ls_repo-key ).
lo_package = zcl_abapgit_factory=>get_sap_package( ls_repo-package ).
APPEND LINES OF lo_package->list_subpackages( ) TO lt_packages.
APPEND LINES OF lo_package->list_superpackages( ) TO lt_packages.
READ TABLE lt_packages TRANSPORTING NO FIELDS
WITH KEY table_line = iv_package.
IF sy-subrc = 0.
zcx_abapgit_exception=>raise( |Repository { lo_repo->get_name( ) } already contains { iv_package } | ).
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_repo_srv~delete.
io_repo->delete( ).
@ -264,7 +286,7 @@ CLASS zcl_abapgit_repo_srv IMPLEMENTATION.
add( ro_repo ).
ro_repo->initialize( ).
ro_repo->refresh( ).
ro_repo->find_remote_dot_abapgit( ).
ENDMETHOD.
@ -360,26 +382,4 @@ CLASS zcl_abapgit_repo_srv IMPLEMENTATION.
iv_package = iv_package
it_repos = lt_repos ).
ENDMETHOD.
METHOD validate_sub_super_packages.
DATA:
ls_repo LIKE LINE OF it_repos,
lo_package TYPE REF TO zif_abapgit_sap_package,
lt_packages TYPE zif_abapgit_sap_package=>ty_devclass_tt,
lo_repo TYPE REF TO zcl_abapgit_repo.
LOOP AT it_repos INTO ls_repo.
lo_repo = get( ls_repo-key ).
lo_package = zcl_abapgit_factory=>get_sap_package( ls_repo-package ).
APPEND LINES OF lo_package->list_subpackages( ) TO lt_packages.
APPEND LINES OF lo_package->list_superpackages( ) TO lt_packages.
READ TABLE lt_packages TRANSPORTING NO FIELDS
WITH KEY table_line = iv_package.
IF sy-subrc = 0.
zcx_abapgit_exception=>raise( |Repository { lo_repo->get_name( ) } already contains { iv_package } | ).
ENDIF.
ENDLOOP.
ENDMETHOD.
ENDCLASS.